any_good 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0af378cd27783fc6b6514e85e398f5eb19ba057a
-  data.tar.gz: 7b4fc488154e59cbb5230e5b58e8ebddb553ee9b
+SHA256:
+  metadata.gz: a7fb208f16bb2d4c212c9cea27ec91ba93bd8024b617be1e3b2767c692e57ffc
+  data.tar.gz: e1d259e50a27ce665049ef9bb3c757be63fe132b8daf812d9442f220cdfaeeb3
 SHA512:
-  metadata.gz: 3c24701236f05ed7d4fe3a2cc9165b5d13cbb8e98264000763c2611740b3906687476dea67bf73ec65958ff790a31b45e33d4e1b4c3ca7ffe34fd232b37c75a4
-  data.tar.gz: 1005d5619cc4e6fd2997cda250adf5686af74a2d917d43f4dadd0f50e413d418232fbae382c2c1fa523899bde705303ce820771b795e72dac7ed09dc5b26bc21
+  metadata.gz: 161a798f1b91ff1d60e2be248e52cbd23cd482d97f49063b24a6ad23109f9f86467eddaa5fca262aa5aa3058d975987bba8fa8572d6f004dad60ff72d014d646
+  data.tar.gz: 12393bd4beb5dd863a44cca7009fa17eadc4c3cfbee0b69c894928a9bd490aaac4e3f743da8c929cc3d019c5ce5f65fab77d846c43d7e2904bf05d98545f31a5

data/lib/any_good.rb

@@ -21,26 +21,11 @@ class AnyGood
   GITHUB_URI_PATTERN = %r{^https?://(www\.)?github\.com/}
 
   def fetch
-    data = {
-      gem: Gems.info(name),
-      gem_versions: Gems.versions(name),
-      gem_rev_deps: Gems.reverse_dependencies(name)
-    }
+    gem_info = fetch_gem
+    repo_id = detect_repo_id(*gem_info[:gem_info].values_at('source_code_uri', 'homepage_uri'))
+    github_info = fetch_github(repo_id)
 
-    repo_id = detect_repo_id(data[:gem]['source_code_uri'], data[:gem]['homepage_uri'])
-
-    if repo_id
-      data.merge!(
-        repo: @github_client.repository(repo_id).to_h,
-        open_issues: @github_client.issues(repo_id, state: 'open', per_page: 50).map(&:to_h),
-        closed_issues: @github_client.issues(repo_id, state: 'closed', per_page: 50).map(&:to_h),
-        last_commit: @github_client.commits(repo_id, per_page: 1).first.to_h
-        # open_prs: @github_client.issues(repo_id, state: 'open').map(&:to_h)
-        # closed_prs: @github_client.issues(repo_id, state: 'closed').map(&:to_h)
-      )
-    end
-
-    @data = OpenStruct.new(data)
+    @data = OpenStruct.new(gem_info.merge(github_info))
 
     self
   end
@@ -65,7 +50,7 @@ class AnyGood
   T = TimeMath
   now = Time.now
 
-  metric('Downloads', thresholds: [5_000, 10_000]) { data.gem['downloads'] }
+  metric('Downloads', thresholds: [5_000, 10_000]) { data.gem_info['downloads'] }
   metric('Latest version', thresholds: [T.year.decrease(now), T.month.decrease(now, 2)]) {
     Time.parse(data.gem_versions.first['created_at'])
   }
@@ -95,6 +80,30 @@ class AnyGood
 
   private
 
+  def fetch_gem
+    {
+      gem_info: Gems.info(name),
+      gem_versions: Gems.versions(name),
+      gem_rev_deps: Gems.reverse_dependencies(name)
+    }
+  rescue JSON::ParserError => e
+    # Gems have no cleaner way to indicate gem does not exist :shrug:
+    raise unless e.message.include?('This rubygem could not be found.')
+    abort("Gem #{name} does not exist.")
+  end
+
+  def fetch_github(repo_id)
+    return {} unless repo_id
+    {
+      repo: @github_client.repository(repo_id).to_h,
+      open_issues: @github_client.issues(repo_id, state: 'open', per_page: 50).map(&:to_h),
+      closed_issues: @github_client.issues(repo_id, state: 'closed', per_page: 50).map(&:to_h),
+      last_commit: @github_client.commits(repo_id, per_page: 1).first.to_h
+      # open_prs: @github_client.issues(repo_id, state: 'open').map(&:to_h)
+      # closed_prs: @github_client.issues(repo_id, state: 'closed').map(&:to_h)
+    }
+  end
+
   def detect_repo_id(*urls)
     repo_url = urls.grep(GITHUB_URI_PATTERN).first or return nil
     Octokit::Repository.from_url(repo_url).slug

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: any_good
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Victor Shepelev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-23 00:00:00.000000000 Z
+date: 2018-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pastel
@@ -126,7 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Is that gem any good?