anvil-core 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9ac08ce0101f9b591711a99ea58973b07ecb6df
-  data.tar.gz: 20d037d2a7845faa66b5b62e37c30e992dfe1083
+  metadata.gz: 71ffb03f67a3fed9d510791164f6688a87392fc4
+  data.tar.gz: c4dab2c85e2d625ffab883580fa2e2bb88382570
 SHA512:
-  metadata.gz: a7f030a95bf219418730dcd7ff69a6aa1c3ce7c2c98293e270413726c769c22e28dafbd87b9aa3f9888efd8f7fa59a1a3d4694d41268dafbf216733b0092438d
-  data.tar.gz: a84505d91dd37c7a7efadce8a68da11b1765d0084f64968a4cc1e229bbeb57c6129618c41971482745f8e9646b6b600b7f25594f45d9fb2ee23abe68fc664f7a
+  metadata.gz: 2a47af0b91a303163f21691c8d520925e7f9558617c8993b22e5d265740679c4bbca464f4b1b8874fa11831563cb14d24e259a52806f0b1485f491f148d5f7d8
+  data.tar.gz: a2555fcaedd1ee41e37e66aeb782b7b65bd2b4ed9b09939730649085638bd378b4114d00bce8e25937f9e0e9e39711e9fca3a51bdcbe2e19a2466fccf11f1126

data/VERSION

@@ -1 +1 @@
-0.3.2
+0.4.0

data/lib/anvil/bundler.rb

@@ -1,8 +1,11 @@
 module Anvil
   class Bundler
     def self.update_gem(gem_name)
-      line = Cocaine::CommandLine.new('bundle', 'update :gem')
-      line.run gem: gem_name
+      ::Bundler.with_clean_env do
+        Cocaine::CommandLine.runner = Cocaine::CommandLine::PopenRunner.new
+        line = Cocaine::CommandLine.new('bundle', "update #{gem_name}")
+        line.run
+      end
     end
   end
 end

data/lib/anvil/task.rb

@@ -3,6 +3,7 @@
 require 'anvil/task/class_methods'
 require 'anvil/task/naming'
 require 'anvil/task/options'
+require 'anvil/task/callback'
 
 module Anvil
   # Common class for all tasks
@@ -37,9 +38,7 @@ module Anvil
     protected
 
     def run_after_callbacks
-      self.class.afters.each do |after|
-        after[0].new(after[1]).run
-      end
+      self.class.afters.each { |callback| callback.run }
     end
 
     def run_assures
@@ -47,9 +46,7 @@ module Anvil
     end
 
     def run_before_callbacks
-      self.class.befores.each do |before|
-        before[0].new(before[1]).run
-      end
+      self.class.befores.each { |callback| callback.run }
     end
 
     def run_task

data/lib/anvil/task/callback.rb

@@ -0,0 +1,19 @@
+require 'anvil/task/naming'
+
+module Anvil
+  class Task
+    class Callback
+      include Anvil::Task::Naming
+
+      attr_reader :task, :options
+
+      def initialize(task_name, options)
+        @task, @options = from_name(task_name), options
+      end
+
+      def run
+        task.new(options).run
+      end
+    end
+  end
+end

data/lib/anvil/task/class_methods.rb

@@ -18,7 +18,7 @@ module Anvil
       end
 
       def after(task_name, options = {})
-        afters << [from_name(task_name), options]
+        afters << Callback.new(task_name, options)
       end
 
       def assure(assure_name)
@@ -26,7 +26,7 @@ module Anvil
       end
 
       def before(task_name, options = {})
-        befores << [from_name(task_name), options]
+        befores << Callback.new(task_name, options)
       end
 
       def run(*args)

data/lib/anvil/task/projects.rb

@@ -13,6 +13,11 @@ module Anvil
         log_project_does_not_exists project
       end
 
+      # Yields a block in which PWD is the folder of a project managed
+      # by anvil.
+      #
+      # @param [String] project the name of a project managed by anvil
+      # @return [Object] anything returned by the yielded block
       def on_project(project)
         Dir.chdir(project_path(project)) do
           yield(git)
@@ -21,8 +26,13 @@ module Anvil
         log_project_does_not_exists project
       end
 
+      # Runs on_project on an array of projects
+      #
+      # @param [Array] projects an array of projects managed by anvil
+      # @return [Array] an array with the values returned by each
+      #   on_project run
       def on_each_project(projects)
-        projects.each do |project|
+        projects.map do |project|
           on_project(project) { |project_git| yield project, project_git }
         end
       end

data/lib/tasks/help_task.rb

@@ -14,7 +14,12 @@ class HelpTask < Anvil::Task
   end
 
   def task
+    return default_message unless task_name.present?
     klazz = Anvil::Task.from_name(task_name)
     printf(klazz.help)
   end
+
+  def default_message
+    printf(self.class.help)
+  end
 end

data/spec/lib/anvil/task/callback_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+require 'anvil/task/naming'
+
+describe Anvil::Task::Callback do
+
+  subject(:callback) { Anvil::Task::Callback.new(:dummy, option: 'value') }
+
+  describe '#new' do
+    it 'sets the task by the name' do
+      expect(callback.task).to be DummyTask
+    end
+
+    it 'sets the options' do
+      expect(callback.options).to include(option: 'value')
+    end
+  end
+
+  describe '.run' do
+    let(:dummy_task) { DummyTask.new }
+
+    it 'runs the task' do
+      expect(DummyTask).to receive(:new)
+        .with(option: 'value')
+        .and_return(dummy_task)
+      expect(dummy_task).to receive(:run)
+      callback.run
+    end
+  end
+end

data/spec/lib/anvil/task/projects_spec.rb

@@ -44,6 +44,12 @@ describe Anvil::Task::Projects, fakefs: true do
     it 'yields a git project object' do
       expect { |b| subject.on_project(project, &b) }.to yield_with_args
     end
+
+    it 'returns the same thing returned by the yielded block' do
+      return_value = 'return-value'
+
+      expect(subject.on_project(project) { return_value }).to eq(return_value)
+    end
   end
 
   describe '#on_each_project' do
@@ -53,7 +59,8 @@ describe Anvil::Task::Projects, fakefs: true do
     end
 
     it 'works on each project' do
-      expect { |b| subject.on_each_project(projects, &b) }.to yield_control.twice
+      expect { |b| subject.on_each_project(projects, &b) }
+        .to yield_control.twice
     end
   end
 end

data/spec/lib/anvil/task_spec.rb

@@ -10,8 +10,10 @@ describe Anvil::Task do
   describe '.after' do
     before { dummy_task.class_eval { after :dummy_after, argument: 'value' } }
 
+    subject(:afters) { dummy_task.afters }
     it 'adds DummyBeforeTask to the after callbacks' do
-      dummy_task.afters.should include([after_task, arguments])
+      afters.first.should be_an_instance_of Anvil::Task::Callback
+      afters.first.task.should be DummyAfterTask
     end
   end
 
@@ -28,8 +30,10 @@ describe Anvil::Task do
       dummy_task.class_eval { before :dummy_before, argument: 'value' }
     end
 
+    subject(:befores) { dummy_task.befores }
     it 'adds DummyBeforeTask to the before callbacks' do
-      dummy_task.befores.should include([before_task, arguments])
+      befores.first.should be_an_instance_of Anvil::Task::Callback
+      befores.first.task.should be DummyBeforeTask
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: anvil-core
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Fran Casas
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-05 00:00:00.000000000 Z
+date: 2014-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: git
@@ -178,6 +178,7 @@ files:
 - lib/anvil/parser.rb
 - lib/anvil/rubygems.rb
 - lib/anvil/task.rb
+- lib/anvil/task/callback.rb
 - lib/anvil/task/class_methods.rb
 - lib/anvil/task/naming.rb
 - lib/anvil/task/options.rb
@@ -200,6 +201,7 @@ files:
 - spec/lib/anvil/config_spec.rb
 - spec/lib/anvil/extensions_manager_spec.rb
 - spec/lib/anvil/parser_spec.rb
+- spec/lib/anvil/task/callback_spec.rb
 - spec/lib/anvil/task/naming_spec.rb
 - spec/lib/anvil/task/options_spec.rb
 - spec/lib/anvil/task/projects_spec.rb
@@ -253,6 +255,7 @@ test_files:
 - spec/lib/anvil/config_spec.rb
 - spec/lib/anvil/extensions_manager_spec.rb
 - spec/lib/anvil/parser_spec.rb
+- spec/lib/anvil/task/callback_spec.rb
 - spec/lib/anvil/task/naming_spec.rb
 - spec/lib/anvil/task/options_spec.rb
 - spec/lib/anvil/task/projects_spec.rb