analytics_instrumentation 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a2153b9c13c4a12c4f9109c5693ff93d9eaa93a3
-  data.tar.gz: 1aba06ff204ae0a490ed954bf447bff1fe282dd3
+  metadata.gz: ff0321bb8effd93476013ff31e7aa07320119786
+  data.tar.gz: ca34cd660ff84ca6b73c6c4776869223a18dcd33
 SHA512:
-  metadata.gz: d9243c70c77838a29109126e239682a1266c683a7507134fc7baabac98c924d0cac050d43aa32000b93977cc276813ea858965c4a092da29cc00ee4b769cab89
-  data.tar.gz: 3a2cb4247846e20d47d06a2211af12f9387489f219e42113d94681cfa12bf261805851d37cfd11fa0c0c1497525b4eea89c76ccec2c226c3355902c9076e62f9
+  metadata.gz: fdf6916c194864a4b422be5844304c80cd7c67d7df8e464035f7e19370b175c65fa5a6402e9e2eb256aebabd94dbaac238f419f5bd602b46128c38de4c5165df
+  data.tar.gz: 5f3e519d10cb4eae86b5de47a9faec15ab51c28fc7af667024454f333963e49dc94cb8eb6f7382da8323712d47112d322ccc1187bd796ed45b6f12cd15923c59

data/lib/analytics_instrumentation.rb

@@ -40,7 +40,10 @@ module AnalyticsInstrumentation
         if !session[:last_seen] || session[:last_seen] < 30.minutes.ago
           analyticsTrackEvent("Session Start")
           if @@config.intercom? && Rails.env.production?
-            Intercom.post("https://api.intercom.io/users", {user_id:current_user.id, new_session:true})
+            begin
+              Intercom.post("https://api.intercom.io/users", {user_id:current_user.id, new_session:true})
+            rescue
+            end
           end
         end
         session[:last_seen] = Time.now
@@ -115,7 +118,11 @@ module AnalyticsInstrumentation
 
     properties = {
       user_id: user.id,
-      traits: (user_traits||{})
+      traits: (user_traits||{}),
+      integrations: {
+        # Don't send leads to C.io if they don't have an email
+        "Customer.io" => (!user.email.blank?)
+      }
     }
 
     logger.debug "Analytics.identify #{JSON.pretty_generate(properties)}"
@@ -125,16 +132,12 @@ module AnalyticsInstrumentation
   def analyticsSuperProperties
     superProperties = {
       "Raw Analytics ID" => raw_analytics_id,
-      "Ajax" => !request.xhr?.nil?
+      "Ajax" => !request.xhr?.nil?,
+      "Platform" => analyticsPlatform
     }
     if current_user
-      superProperties.merge!({
-        "User Created At" => current_user.created_at,
-        "Username" => current_user.try(:username),
-        "Full name" => current_user.try(:full_name),
-        "User ID" => current_user.id,
-        "Login Provider" => current_user.try(:provider) || "Email"
-      })
+      user_traits = instance_exec(user, &@@config.custom_user_traits)
+      superProperties.merge!({user:user_traits}) if user_traits
     end
     superProperties
   end
@@ -165,6 +168,10 @@ module AnalyticsInstrumentation
         'Google Analytics' => {
           clientId: googleAnalyticsID
         }
+      },
+      integrations: {
+        # Don't send leads to C.io if they don't have an email
+        "Customer.io" => !!current_user
       }
     }
 
@@ -183,6 +190,15 @@ module AnalyticsInstrumentation
   end
 
   private
+  def analyticsPlatform
+    case
+    when browser.mobile?            then "Mobile"
+    when browser.platform != :other then "Desktop"
+    else
+      "Other"
+    end
+  end
+
   def googleAnalyticsID
     ck = cookies[:_ga]
     return "1.1" if ck.nil?
@@ -194,7 +210,7 @@ module AnalyticsInstrumentation
     return true if Rails.env.test?
     return true if request.bot?
     return true if request.user_agent.nil?
-    bad_strings = ["http:", "https:", "twitterbot", "bingbot", "googlebot", "gediapartners-google"]
+    bad_strings = ["http:", "https:", "twitterbot", "bingbot", "googlebot", "mediapartners-google", "Webhook"]
     return true if bad_strings.any? { |s| !request.user_agent.downcase.index(s).nil? }
     false
   end

data/lib/analytics_instrumentation/version.rb

@@ -1,3 +1,3 @@
 module AnalyticsInstrumentation
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/lib/config/routes.rb

@@ -1,6 +1,4 @@
-# TODO: Not namespace this
-
-CanopyBackend::Application.routes.draw do
+Rails.application.routes.draw do
 
   post "api/analytics_event" => "analytics_implementation#analytics_event", as: :analytics_event
 

data/lib/test/integration/analytics_instrumentation_test.rb

@@ -0,0 +1,15 @@
+require 'test_helper'
+
+class AnalyticsInstrumentationTest < ActiveSupport::TestCase
+  test "All analytics routes are valid" do
+    mappings = AnalyticsMapping.createMappings
+    for method in mappings.keys
+      controller, action = method.to_s.split("__")
+      begin
+        Rails.application.routes.url_helpers.url_for(controller: controller, action: action, id: 1, slug: "a", page: 1, issue_number: 1, user_id: 1, username: 'a', user_collection_id: 1, followable_type: "User", followable_id: 1, host: "canopy.co")
+      rescue
+        throw "No route for route with analytics instrumentation: #{method}"
+      end
+    end
+  end
+end

data/test/analytics_instrumentation_test.rb

@@ -4,4 +4,10 @@ class AnalyticsInstrumentationTest < ActiveSupport::TestCase
   test "truth" do
     assert_kind_of Module, AnalyticsInstrumentation
   end
+
+  test "C.io wont see users without emails" do
+    assert false, "TODO"
+  end
+
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: analytics_instrumentation
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Jordan Feldstein
@@ -9,62 +9,76 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-31 00:00:00.000000000 Z
+date: 2015-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.2'
 - !ruby/object:Gem::Dependency
   name: analytics-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: voight_kampff
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: browser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 description: "Add analytics to any app, quickly, robustly, and accurately. \n\nDefine
@@ -89,7 +103,7 @@ files:
 - lib/config/routes.rb
 - lib/controllers/analytics_implementation_controller.rb
 - lib/controllers/application_controller.rb
-- lib/tasks/analytics_instrumentation_tasks.rake
+- lib/test/integration/analytics_instrumentation_test.rb
 - test/analytics_instrumentation_test.rb
 - test/dummy/README.rdoc
 - test/dummy/Rakefile
@@ -136,17 +150,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Best-practices analytics instrumentation for Rails.

data/lib/tasks/analytics_instrumentation_tasks.rake

@@ -1,4 +0,0 @@
-# desc "Explaining what the task does"
-# task :analytics_instrumentation do
-#   # Task goes here
-# end