analytics_instrumentation 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f74834b46e9fb5f60bd56989cf5d0afc529a2a9c
-  data.tar.gz: db452554d8957a30f7595051623fccf9042b2b3c
+  metadata.gz: a2153b9c13c4a12c4f9109c5693ff93d9eaa93a3
+  data.tar.gz: 1aba06ff204ae0a490ed954bf447bff1fe282dd3
 SHA512:
-  metadata.gz: 1f0e39f74651a8131f8ead84856a952a3873feed8356251cee9449a11e1f6ac4752f3ceba7d32fdb1ba2020bb13592d7b8fc29d024ad67b8cd3016179442aafc
-  data.tar.gz: 5903a8d3bb60482493251d0d057356d7ee8435b2b7b178b28216c266d0f58ba1d0dacc98db5b42f4fb590cfdf2906892c2f89ed50035a50a91c6e5b08480d80a
+  metadata.gz: d9243c70c77838a29109126e239682a1266c683a7507134fc7baabac98c924d0cac050d43aa32000b93977cc276813ea858965c4a092da29cc00ee4b769cab89
+  data.tar.gz: 3a2cb4247846e20d47d06a2211af12f9387489f219e42113d94681cfa12bf261805851d37cfd11fa0c0c1497525b4eea89c76ccec2c226c3355902c9076e62f9

data/lib/analytics_instrumentation.rb

@@ -51,11 +51,8 @@ module AnalyticsInstrumentation
         session[:last_seen_logged_out] = Time.now
       end
     rescue => e
-      puts "FOUND ERROR #{e.inspect}"
-      puts caller
-      puts @@config.inspect
-      puts @@config.error_handler.inspect
-      @@config.error_handler(e, "Analytics Check Session Crash: #{request.filtered_path}")
+      logger.debug "Errpr found in analyticsCheckSessionStart: #{e.inspect}"
+      @@config.error_handler.call(e, "Analytics Check Session Crash: #{request.filtered_path}")
     end
   end
 
@@ -81,7 +78,8 @@ module AnalyticsInstrumentation
       properties.merge! analyticsSuperProperties
       analyticsTrackEvent "Page View", properties
     rescue => e
-      @@config.error_handler(e, "Analytics Crash: #{request.filtered_path}")
+      logger.debug "Errpr found in analyticsLogPageView: #{e.inspect}"
+      @@config.error_handler.call(e, "Analytics Crash: #{request.filtered_path}")
     end
   end
 
@@ -113,9 +111,11 @@ module AnalyticsInstrumentation
   def analyticsSetPerson(user)
     return if skip_analytics?
 
+    user_traits = instance_exec(user, &@@config.custom_user_traits)
+
     properties = {
       user_id: user.id,
-      traits: @@config.custom_user_traits(user)
+      traits: (user_traits||{})
     }
 
     logger.debug "Analytics.identify #{JSON.pretty_generate(properties)}"
@@ -148,7 +148,10 @@ module AnalyticsInstrumentation
     properties["source"]    = params[:source] if params[:source]
 
     properties.merge! analyticsSuperProperties
-    properties.merge! @@config.extra_event_properties
+
+    # User defined extra props, called in context
+    extra_props = instance_exec(&@@config.extra_event_properties)
+    properties.merge! (extra_props || {})
 
     analyticsApplyOriginatingPage properties
 

data/lib/analytics_instrumentation/analytics_mapping.rb

@@ -20,7 +20,7 @@ class AnalyticsMapping
 
     replaceAllTokens(analysis, params, view_assigns)
 
-    analysis
+    HashWithIndifferentAccess.new(analysis)
   end
 
   def self.replaceAllTokens(obj, params, view_assigns)

data/lib/analytics_instrumentation/config.rb

@@ -31,14 +31,6 @@ module AnalyticsInstrumentation
       self.error_handler          = Proc.new { |e, msg=""| raise }
     end
 
-    def custom_user_traits(user)
-      self.custom_user_traits(user) || {}
-    end
-
-    def extra_event_properties
-      self.extra_event_properties() || {}
-    end
-
     def intercom?
       Intercom rescue false
     end

data/lib/analytics_instrumentation/version.rb

@@ -1,3 +1,3 @@
 module AnalyticsInstrumentation
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: analytics_instrumentation
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Jordan Feldstein
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-30 00:00:00.000000000 Z
+date: 2015-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails