analytics_instrumentation 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23edc0fcddb60777d22506a73d5644a823beed1d
-  data.tar.gz: 7229fb73b5606f178e55dbaba1df3be2c2b09e34
+  metadata.gz: 541748eba4bb7231b1f791d55aefadd26f8c7bb6
+  data.tar.gz: 71dd90eae86fd384c104f90bbd5ccda2c7c432dc
 SHA512:
-  metadata.gz: d092014e81ee505b97ca8b5d6f47d8671c492513e0f1367276073b672c21b1da74cbb8e07efe7d561b59946d73f12b8d0a0f9985f254ff8575a588143128402e
-  data.tar.gz: ab0dd4da0f9d16afb9944b75109a424696643736e84a74a4e55d424d5102bc431e139809b31bb215110fa53e8772fbc29a59df07293e28d8aa69f628bedb642c
+  metadata.gz: 4ca866ab4932e2c585fb74bf3351a7aeb1dc28be0d0f4d696188d49545a5c3b689e5856b240502d60ed83b335a21554201b64c30e67ab126d4f20d938d0521a3
+  data.tar.gz: 32b8f3dd99d9877309908d5844adb3da6ac241ef358a1ebafd61d08aa721bc396705d7872ef3b80e02226985824f06bab80fd623e1d9f6fa81166e92d92d3353

data/README.rdoc

@@ -13,7 +13,7 @@ or
 
 Once installed, write your initializer and yml mappings.
 
-== Initializer & Defaults
+== Initializer
 
 Most behaviors in AnalyticsInstrumentation are one-size-fits-all.
 
@@ -28,7 +28,7 @@ The behaviors exposed are:
       config.segment_write_key = ENV["SEGMENT_API_KEY"] || ""
 
       # Define a hash of traits to be passed to `#identify()` calls for each user.
-      config.custom_user_traits = (user) -> {
+      config.custom_user_traits = Proc.new { |user|
         {
           name: user.full_name,
           email: user.email,
@@ -47,7 +47,7 @@ The behaviors exposed are:
       # 1. Event-specific properties are configured via the YML files (see below)
       # 2. System-wide properties are included for you with all events (see below)
       # 3. To have your own system-wide properties included on all events, have them returned by a Proc set to `config.extra_event_properties`, like so:
-      config.extra_event_properties = -> {
+      config.extra_event_properties = Proc.new {
         {
           user_sees_experiment_a: current_user.experiment_a?
           user_sees_experiment_b: current_user.experiment_b?
@@ -56,16 +56,16 @@ The behaviors exposed are:
 
       # To capture and handle errors that happen within AnalyticsInstrumentation,
       # Define an error_handler, like so:
-      config.error_handler = (e, msg) -> {
+      config.error_handler = Proc.new { |e, msg|
         if Rails.env.production?
-          Rollbar.error(e, msg)
+          Rollbar.error(e, msg) # or Airbrake, etc
         else
           raise
         end
       }
     end
 
-== Configuring Events & Their Properties
+== YML Mappings: Named Events & Properties
 
 AnalyticsInstrumentation maps controller#action pairs to events using YML files in `./config/analytics/*.yml`.
 

data/lib/analytics_instrumentation.rb

@@ -1,14 +1,19 @@
+require 'active_model'
+require 'segment/analytics'
+require 'voight_kampff'
+
 require 'analytics_instrumentation/analytics_attribution'
 require 'analytics_instrumentation/analytics_mapping'
+require 'analytics_instrumentation/config'
 
 module AnalyticsInstrumentation
   include AnalyticsAttribution
 
   class << self
     def included(base)
-      @segment = Segment::Analytics.new({
-          write_key:  @config.segment_write_key,
-          on_error:   @config.error_handler
+      @@segment = Segment::Analytics.new({
+          write_key:  @@config.segment_write_key,
+          on_error:   @@config.error_handler
       })
 
       base.class_eval do
@@ -18,13 +23,13 @@ module AnalyticsInstrumentation
     end
 
     def configure(&proc)
-      @config ||= Config.new
-      yield @config
+      @@config ||= AnalyticsInstrumentation::Config.new
+      yield @@config
 
-      unless @config.valid?
-        errors = @config.errors.full_messages.join(', ')
-        raise Config::Invalid.new(errors)
-      end
+      # unless @config.valid?
+      #   errors = @config.errors.full_messages.join(', ')
+      #   raise AnalyticsInstrumentation::Config::Invalid.new(errors)
+      # end
     end
   end
 
@@ -34,7 +39,7 @@ module AnalyticsInstrumentation
       if current_user
         if !session[:last_seen] || session[:last_seen] < 30.minutes.ago
           analyticsTrackEvent("Session Start")
-          if @config.intercom? && Rails.env.production?
+          if @@config.intercom? && Rails.env.production?
             Intercom.post("https://api.intercom.io/users", {user_id:current_user.id, new_session:true})
           end
         end
@@ -46,7 +51,11 @@ module AnalyticsInstrumentation
         session[:last_seen_logged_out] = Time.now
       end
     rescue => e
-      @config.error_handler(e, "Analytics Check Session Crash: #{request.filtered_path}")
+      puts "FOUND ERROR #{e.inspect}"
+      puts caller
+      puts @@config.inspect
+      puts @@config.error_handler.inspect
+      @@config.error_handler(e, "Analytics Check Session Crash: #{request.filtered_path}")
     end
   end
 
@@ -72,7 +81,7 @@ module AnalyticsInstrumentation
       properties.merge! analyticsSuperProperties
       analyticsTrackEvent "Page View", properties
     rescue => e
-      @config.error_handler(e, "Analytics Crash: #{request.filtered_path}")
+      @@config.error_handler(e, "Analytics Crash: #{request.filtered_path}")
     end
   end
 
@@ -97,8 +106,8 @@ module AnalyticsInstrumentation
     }
 
     logger.debug "Analytics.alias #{aliasProperties}"
-    @segment.alias(aliasProperties)
-    @segment.flush
+    @@segment.alias(aliasProperties)
+    @@segment.flush
   end
 
   def analyticsSetPerson(user)
@@ -106,11 +115,11 @@ module AnalyticsInstrumentation
 
     properties = {
       user_id: user.id,
-      traits: @config.custom_user_traits(user)
+      traits: @@config.custom_user_traits(user)
     }
 
     logger.debug "Analytics.identify #{JSON.pretty_generate(properties)}"
-    @segment.identify(properties)
+    @@segment.identify(properties)
   end
 
   def analyticsSuperProperties
@@ -139,7 +148,7 @@ module AnalyticsInstrumentation
     properties["source"]    = params[:source] if params[:source]
 
     properties.merge! analyticsSuperProperties
-    properties.merge! @config.extra_event_properties
+    properties.merge! @@config.extra_event_properties
 
     analyticsApplyOriginatingPage properties
 
@@ -157,7 +166,7 @@ module AnalyticsInstrumentation
     }
 
     logger.debug "Analytics.track #{JSON.pretty_generate(analyticsProperties)}"
-    @segment.track(analyticsProperties)
+    @@segment.track(analyticsProperties)
   end
 
   def raw_analytics_id

data/lib/analytics_instrumentation/config.rb

@@ -16,18 +16,19 @@ module AnalyticsInstrumentation
       :custom_user_traits,
       :error_handler
     ]
+
     validate do
-      @@REQUIRED_CALLABLES.each |callable| do
-        unless self.send(callable).respond_to?(:call)
-          errors.add(callable, "must be a callable object (eg. Proc)")
+      @@REQUIRED_CALLABLES.each do |callable|
+        unless self.send(callable).is_a?(Proc)
+          errors.add(callable, "must be a Proc")
         end
       end
     end
 
     def initialize
-      self.extra_event_properties = -> {}
-      self.custom_user_traits     = -> {}
-      self.error_handler          = (msg) -> { raise }
+      self.extra_event_properties = Proc.new {}
+      self.custom_user_traits     = Proc.new {}
+      self.error_handler          = Proc.new { |e, msg=""| raise }
     end
 
     def custom_user_traits(user)

data/lib/analytics_instrumentation/version.rb

@@ -1,3 +1,3 @@
 module AnalyticsInstrumentation
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: analytics_instrumentation
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jordan Feldstein
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-29 00:00:00.000000000 Z
+date: 2015-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails