amtrak 3.0.1 → 3.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3eba83171c15751acc34cfca614a5fb542cb4137
-  data.tar.gz: b299e5b1d3c52f60066b5792ad9ac25547a3c4a3
+  metadata.gz: 5e6f2af5819b3bc8d69a509b5424ac1642ca3225
+  data.tar.gz: 9acdc2c34c1205a12ead90465939c796f4f0bc53
 SHA512:
-  metadata.gz: 690330fcc13bd7b00e67d76560b1349b9cebb73627794c4b0d1cf7c7d88aa86dda80a4f6553a7ab5916c0e3dc5e82b0ea02ab18742accdc20040d2567107b80b
-  data.tar.gz: b5bf6dd747477bcc3b55d5971a4c55c38c05a7f4cdc109111d2ce64401546d9926a61c8e5ac0d091a148746e8d87b569f1bedabdb9fcfe87aca7173c7e4d17c9
+  metadata.gz: 7eabdc4126fd285c7bf630de6f1678a5875a0cf5d7b7b22107f0f054176003138fa87d201393bf2d4e781ffce3ebe4bcc39a2b90e56c8216037ebcaaa2edb95b
+  data.tar.gz: 46551c2535e81286c55a9b04a868fa667409a65a3520a608c2f72a15b7e542714e6078da05a0e9ebfbedca0f9f11d0a4bfd7bf480906f7c31e8474c8ad0baeee

data/lib/amtrak/train_parser.rb

@@ -15,7 +15,7 @@ module Amtrak
     end
 
     def parse
-      json['journeys']
+      (json['journeys'] || [])
         .map(&method(:parse_journey))
         .compact
     end

data/lib/amtrak/version.rb

@@ -1,6 +1,6 @@
 module Amtrak
   # This module holds the Amtrak version
   module Version
-    VERSION = '3.0.1'.freeze
+    VERSION = '3.0.2'.freeze
   end
 end

data/spec/amtrak/train_parser_spec.rb

@@ -28,5 +28,25 @@ describe Amtrak::TrainParser do
     it 'returns a list of train times' do
       expect(output).to eq(expected)
     end
+
+    context 'when the train status is unavailable' do
+      let(:document) do
+        File.read(File.join('spec', 'fixtures', 'json', 'unavailable.json'))
+      end
+
+      it 'does not return any trains' do
+        expect(output).to eq([])
+      end
+    end
+
+    context 'when the train is not operated by amtrak' do
+      let(:document) do
+        File.read(File.join('spec', 'fixtures', 'json', 'not_operated_by_amtrak.json'))
+      end
+
+      it 'does not return any trains' do
+        expect(output).to eq([])
+      end
+    end
   end
 end

data/spec/fixtures/json/not_operated_by_amtrak.json

@@ -0,0 +1,16 @@
+{
+  "appVersion": "1.51",
+  "authenticationToken": null,
+  "buildNumber": "1.51_20170909.0300",
+  "errors": [
+    {
+      "ariesMessage": "011NO TRAIN SERVICE FOR THIS DATE",
+      "code": "3",
+      "text": "The train number provided is not operated by Amtrak. Please check the number or try a search using two stations.  [011A]",
+      "type": "3"
+    }
+  ],
+  "hostName": "ussbpri021amtra",
+  "infoNotification": null,
+  "responseCode": "ERROR"
+}

data/spec/fixtures/json/unavailable.json

@@ -0,0 +1,16 @@
+{
+  "appVersion": "1.51",
+  "authenticationToken": null,
+  "buildNumber": "1.51_20170909.0300",
+  "errors": [
+    {
+      "ariesMessage": "008INVALID DATE 09OCT",
+      "code": "15",
+      "text": "Train Status is currently unavailable. Please try again later [R412]",
+      "type": "3"
+    }
+  ],
+  "hostName": "ussbpri031amtra",
+  "infoNotification": null,
+  "responseCode": "ERROR"
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: amtrak
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.0.2
 platform: ruby
 authors:
 - Todd Lunter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-13 00:00:00.000000000 Z
+date: 2017-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon
@@ -146,7 +146,9 @@ files:
 - spec/amtrak_spec.rb
 - spec/fixtures/json/_get.json
 - spec/fixtures/json/_parse.json
+- spec/fixtures/json/not_operated_by_amtrak.json
 - spec/fixtures/json/pvd_to_bby.json
+- spec/fixtures/json/unavailable.json
 - spec/fixtures/vcr/Amtrak/_get/returns_a_list_of_train_times.yml
 - spec/fixtures/vcr/Amtrak_TrainFetcher/_get/does_the_same_as_get.yml
 - spec/fixtures/vcr/Amtrak_TrainFetcher/_get/given_a_valid_date_and_invalid_train_stations/does_not_include_various_keys_and_includes_an_error.yml
@@ -184,7 +186,9 @@ test_files:
 - spec/amtrak_spec.rb
 - spec/fixtures/json/_get.json
 - spec/fixtures/json/_parse.json
+- spec/fixtures/json/not_operated_by_amtrak.json
 - spec/fixtures/json/pvd_to_bby.json
+- spec/fixtures/json/unavailable.json
 - spec/fixtures/vcr/Amtrak/_get/returns_a_list_of_train_times.yml
 - spec/fixtures/vcr/Amtrak_TrainFetcher/_get/does_the_same_as_get.yml
 - spec/fixtures/vcr/Amtrak_TrainFetcher/_get/given_a_valid_date_and_invalid_train_stations/does_not_include_various_keys_and_includes_an_error.yml