amqp-subscribe-many 0.1.5 → 0.1.6

data/Rakefile

@@ -49,7 +49,7 @@ Jeweler::RubygemsDotOrgTasks.new
 
 Jeweler::Tasks.new do |gem|
   gem.name        = "amqp-subscribe-many"
-  gem.version     = "0.1.5"
+  gem.version     = "0.1.6"
   gem.homepage    = "http://github.com/brendanhay/amqp-subscribe-many"
   gem.license     = "MPL"
   gem.summary     = "An implementation of the publish one, subscribe many pattern"

data/amqp-subscribe-many.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{amqp-subscribe-many}
-  s.version = "0.1.5"
+  s.version = "0.1.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [%q{brendanhay}]
-  s.date = %q{2012-09-07}
+  s.date = %q{2012-09-19}
   s.description = %q{Codifies best practices and configuration when consuming from multiple AMQP brokers simultaneously}
   s.email = %q{brendan@soundcloud.com}
   s.extra_rdoc_files = [

data/lib/messaging/consumer.rb

@@ -58,6 +58,8 @@ module Messaging
 
     # Invoked when a message is received from any of the subscriptions.
     #
+    # @param meta [AMQP::Header] A wrapper around the AMQP headers, and ruby-amqp metadata
+    # @param payload [String] The message payload
     # @raise [NotImplementedError]
     # @api protected
     def on_message(meta, payload)
@@ -115,14 +117,27 @@ module Messaging
         ex = declare_exchange(channel, exchange, type, config.exchange_options)
         q  = declare_queue(channel, ex, queue, key, config.queue_options)
 
-        q.subscribe(:ack => true) do |meta, payload|
+        # Expliclity create an AMQP::Consumer rather than using
+        # AMQP::Queue.subscription, which is a global singleton
+        # and prevents the creation of multiple subscriptions
+        AMQP::Consumer.new(channel, q).consume.on_delivery do |meta, payload|
           log.debug("Receieved message on channel #{meta.channel.id} from queue #{queue.inspect}")
 
-          # If this raises an exception, the connection
-          # will be closed, and the message requeued by the broker.
-          on_message(meta, payload)
-
-          meta.ack
+          # If an exception is raised in on_message, the message will not be
+          # acknowledged and the exception will be logged and re-raised
+          begin
+            on_message(meta, payload)
+
+            meta.ack
+          rescue => ex
+            log.error("Exception: #{ex}, " \
+              "Payload: #{payload.inspect}, " \
+              "Headers: #{meta.headers.inspect}\n" \
+              "Backtrace:\n#{ex.backtrace.join('\n')}")
+
+            # Re-raise the exception
+            raise ex
+          end
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: amqp-subscribe-many
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-07 00:00:00.000000000 Z
+date: 2012-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: amqp
-  requirement: &70256241444900 !ruby/object:Gem::Requirement
+  requirement: &70235814586420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 0.9.6
   type: :runtime
   prerelease: false
-  version_requirements: *70256241444900
+  version_requirements: *70235814586420
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70256241482320 !ruby/object:Gem::Requirement
+  requirement: &70235814585520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256241482320
+  version_requirements: *70235814585520
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70256241481600 !ruby/object:Gem::Requirement
+  requirement: &70235814584860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '3.0'
   type: :development
   prerelease: false
-  version_requirements: *70256241481600
+  version_requirements: *70235814584860
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70256241480400 !ruby/object:Gem::Requirement
+  requirement: &70235814584100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256241480400
+  version_requirements: *70235814584100
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &70256241477160 !ruby/object:Gem::Requirement
+  requirement: &70235814583200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256241477160
+  version_requirements: *70235814583200
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &70256241476540 !ruby/object:Gem::Requirement
+  requirement: &70235814582520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256241476540
+  version_requirements: *70235814582520
 - !ruby/object:Gem::Dependency
   name: redcarpet
-  requirement: &70256241475320 !ruby/object:Gem::Requirement
+  requirement: &70235814581820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256241475320
+  version_requirements: *70235814581820
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &70256241490260 !ruby/object:Gem::Requirement
+  requirement: &70235814581200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,7 +98,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70256241490260
+  version_requirements: *70235814581200
 description: Codifies best practices and configuration when consuming from multiple
   AMQP brokers simultaneously
 email: brendan@soundcloud.com
@@ -145,7 +145,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2625083279973371652
+      hash: 1747811653672625853
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: