amqp-boilerplate 1.1.0 → 1.1.1

data/CHANGELOG

@@ -1,3 +1,8 @@
+= version 1.1.1
+
+  * [ENHANCEMENT] Pass additional parameters to on_unhandled_consumer_exception
+  handler
+
 = version 1.1.0
 
   * [FEATURE] Added on_unhandled_consumer_exception option to allow for more

data/README.rdoc

@@ -21,7 +21,9 @@ Add a initializer +amqp.rb+ to your config/initializer folder with the following
     config.logger = ::Rails.logger
     config.consumer_paths += %W( #{Rails.root}/app/consumers )
     config.connection_options = { :host => "localhost", :port => 5672, :vhost => Rails.env }
-    config.on_unhandled_exception = Proc.new { |exception| puts "Do something with exceptions: #{exception}" }
+    config.on_unhandled_exception = Proc.new { |exception, consumer, metadata, payload|
+      puts "Do something with exceptions: #{exception}"
+    }
   end
 
   # Require all files that are no longer auto-loaded when Rails is in thread-safe mode

data/lib/amqp/boilerplate.rb

@@ -61,7 +61,7 @@ module AMQP
     #     config.logger = ::Rails.logger
     #     config.consumer_paths += %W( #{Rails.root}/app/consumers )
     #     config.connection_options = { :host => "localhost", :port => 5672, :vhost => Rails.env }
-    #     config.on_unhandled_exception = Proc.new { |exception| puts "Do something with exceptions: #{exception}" }
+    #     config.on_unhandled_exception = Proc.new { |exception, consumer, metadata, payload| puts "Do something with exceptions: #{exception}" }
     #   end
     def self.configure
       yield self if block_given?

data/lib/amqp/boilerplate/consumer.rb

@@ -90,7 +90,7 @@ module AMQP
         handle_message(metadata, payload)
       rescue Exception => e
         if AMQP::Boilerplate.on_unhandled_consumer_exception.is_a?(Proc)
-          AMQP::Boilerplate.on_unhandled_consumer_exception.call(e)
+          AMQP::Boilerplate.on_unhandled_consumer_exception.call(e, self, metadata, payload)
         else
           raise e
         end

data/lib/amqp/boilerplate/version.rb

@@ -1,5 +1,5 @@
 module AMQP
   module Boilerplate
-    VERSION = "1.1.0"
+    VERSION = "1.1.1"
   end
 end

data/spec/amqp/boilerplate/consumer_spec.rb

@@ -132,6 +132,8 @@ describe AMQP::Boilerplate::Consumer do
   end
 
   describe "#handle_message_wrapper" do
+    subject { @consumer.handle_message_wrapper(@metadata, @payload) }
+
     before(:each) do
       @consumer = BarConsumer.new
 
@@ -141,25 +143,32 @@ describe AMQP::Boilerplate::Consumer do
 
     it "should let handle_message do the heavy lifting" do
       @consumer.should_receive(:handle_message).with(@metadata, @payload)
-      @consumer.handle_message_wrapper(@metadata, @payload)
+      subject
     end
 
     context "when on_unhandled_consumer_exception option set" do
-      before do
-        AMQP::Boilerplate.stub(:on_unhandled_consumer_exception).and_return(Proc.new { |e|
+      let(:handler) do
+        Proc.new { |e,c,m,p|
           AMQP::Boilerplate.logger.error("foo: #{e.message}")
-        })
+        }
+      end
+
+      before do
+        AMQP::Boilerplate.stub(:on_unhandled_consumer_exception).and_return(handler)
       end
 
       it "should not raise the exception" do
-        expect {
-          @consumer.handle_message_wrapper(@metadata, @payload)
-        }.to_not raise_error
+        expect { subject }.to_not raise_error
       end
 
-      it "should yield the on_unhandled_consumer_exception" do
+      it "should execute the on_unhandled_consumer_exception proc" do
         AMQP::Boilerplate.logger.should_receive(:error)
-        @consumer.handle_message_wrapper(@metadata, @payload)
+        subject
+      end
+
+      it "should call the on_unhandled_consumer_exception proc with parameters" do
+        handler.should_receive(:call).with(NoMethodError, subject, @metadata, @payload)
+        subject
       end
     end
 
@@ -169,9 +178,7 @@ describe AMQP::Boilerplate::Consumer do
       end
 
       it "should re-raise the exception" do
-        expect {
-          @consumer.handle_message_wrapper(@metadata, @payload)
-        }.to raise_error
+        expect { subject }.to raise_error
       end
     end
   end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: amqp-boilerplate
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: 
   segments: 
   - 1
   - 1
-  - 0
-  version: 1.1.0
+  - 1
+  version: 1.1.1
 platform: ruby
 authors: 
 - Patrick Baselier