amountable 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eaab8de5d539d970c93a407222cddfbdcb0b3cef
-  data.tar.gz: ef1f96155420b3adddbfab6ce97fbaffd7bafe8f
+  metadata.gz: 1f8f2e9a3b13fdf8694c20e935180962c1731864
+  data.tar.gz: d11442900e2e45e11992198e15ccbc38d3a9a911
 SHA512:
-  metadata.gz: 67aa3b1d6d456f2c3c3e2005ef6a009be518be79492cc2edbdfae92a2b011661e8ae51d7cd959d5794d5044e9ec80ad8132245acceb1832ce910f5607ff280d3
-  data.tar.gz: 38ffecf5763a50f826ca60c4304cdf721e91814a6bdb08aacddf5fdb2da21ddffb965243c07cd396d16a2d47c862d218fd06efecc0789a5b6467c756f5de34a4
+  metadata.gz: 2b51ce8c0058625f4792b603986fdcf44b1bd359b5a438332c7a190c185c9f0dbb8fe5492f1daa787500636d42295b9b22c786dbe51a7be8e5a16693cac007dd
+  data.tar.gz: ff6bf8d43f992ecde40508a84bd61e3f3cdc755ab1b735a8fb868f3d8a27d855d35cf7d8b9b8c69a8d60b173a3233b15b0218d741e8e37979e1efdca7569976e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    amountable (0.0.1)
+    amountable (0.0.2)
       activerecord-import (= 0.10.0)
       monetize
       money-rails

data/lib/amountable.rb

@@ -102,11 +102,18 @@ module Amountable
       end
 
       define_method "#{name}=" do |value|
-        return Money.zero if value.zero?
         amount = find_amount(name) || amounts.build(name: name)
         amount.value = value.to_money
-        all_amounts << amount if amount.new_record?
-        (@amounts_by_name ||= {})[name.to_sym] = amount
+        if value.zero?
+          amounts.delete(amount)
+          all_amounts.delete(amount)
+          @amounts_by_name.delete(name)
+          amount.destroy
+        else
+          all_amounts << amount if amount.new_record?
+          (@amounts_by_name ||= {})[name.to_sym] = amount
+        end
+        value.to_money
       end
 
       Array(options[:summable] || options[:summables] || options[:set] || options[:sets] || options[:amount_set] || options[:amount_sets]).each do |set|

data/lib/amountable/version.rb

@@ -1,5 +1,5 @@
 # Copyright 2015, Instacart
 
 module Amountable
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/amountable/amountable_spec.rb

@@ -6,11 +6,7 @@ describe Amountable do
 
   it 'should' do
     order = Order.new
-    expect {
-      order.save
-    }.not_to change {
-      Amount.count
-    }
+    expect { order.save }.not_to change { Amount.count }
     %i(sub_total taxes total).each do |name|
       expect(order.send(name)).to eq(Money.zero)
     end
@@ -22,24 +18,41 @@ describe Amountable do
       expect(amount.name).to eq('sub_total')
       expect(amount.value).to eq(Money.new(100))
       expect(amount.new_record?).to be true
-      expect {
-        order.save
-      }.to change {
-        Amount.count
-      }.by(1)
+      expect { order.save }.to change { Amount.count }.by(1)
       expect(amount.persisted?).to be true
     end
-    expect{
+    expect do
       expect(order.update_attributes(sub_total: Money.new(200)))
-    }.not_to change {
-      Amount.count
-    }
+    end.not_to change { Amount.count }
+  end
+
+  describe 'name=' do
+    let (:order) { Order.create }
+
+    it 'should not persist Money.zero' do
+      expect(order.sub_total = Money.zero).to eq(Money.zero)
+      expect { order.save }.not_to change { Amount.count }
+    end
+
+    it 'should not persist Money.zero if using ActiveRecord persistence' do
+      expect { order.update(sub_total: Money.zero) }.not_to change { Amount.count }
+    end
+
+    it 'should work with ActiveRecord#update' do
+      expect { order.update(sub_total: Money.new(1)) }.to change { Amount.count }.by(1)
+    end
+
+    it 'should destroy Amount if exist and assigning Money.zero' do
+      order.update(sub_total: Money.new(1))
+      expect { order.sub_total = Money.zero }.to change { Amount.count }.by(-1)
+      expect(order.amounts.empty?).to be true
+    end
   end
 
   it 'should insert amounts in bulk' do
     order = Order.create
-    expect {
+    expect do
       order.update(sub_total: Money.new(100), taxes: Money.new(200))
-    }.to make_database_queries(count: 1, manipulative: true)
+    end.to make_database_queries(count: 1, manipulative: true)
   end
 end

data/spec/support/database.rb

@@ -28,7 +28,7 @@ if File.exist?(database_yml)
     ActiveRecord::Base.establish_connection(config)
   end
 
-  load(File.dirname(__FILE__) + '/../internal/db/schema.rb')
+  #load(File.dirname(__FILE__) + '/../internal/db/schema.rb')
   load(File.dirname(__FILE__) + '/../internal/app/models/order.rb')
 
 else

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: amountable
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Emmanuel Turlay
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-17 00:00:00.000000000 Z
+date: 2016-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails