amount_field 1.4.1 → 1.4.2

data/History.txt

@@ -1,3 +1,7 @@
+== 1.4.1 2010-05-11
+
+* Don't set default dom Id for FormBuilder amount_field, use Rails default or use given one.
+
 == 1.4.1 2010-04-23
 
 * Method amount_field considers given option "name" and "id":

data/README.rdoc

@@ -14,7 +14,7 @@ As Gem:
 
 As plugin:
 
-  $ script/plugin install git://github.com/thomasbaustert/amount_field.git -r 2.3
+  $ script/plugin install git://github.com/thomasbaustert/amount_field.git
 
 == Example
 
@@ -170,6 +170,7 @@ See test_helper.rb for details.
 == Credits
 
 * Michael Schiller (for feedback and ideas)
+* Clements Teichmann (consider option 'name' and 'id')
  
 == Contact
 

data/Rakefile

@@ -2,7 +2,7 @@ require 'rubygems'
 require 'rake'
 require 'echoe'
 
-Echoe.new('amount_field', '1.4.1') do |p|
+Echoe.new('amount_field', '1.4.2') do |p|
   p.description   = "Rails gem/plugin that accepts (amount) values in german or us format like 1.234,56 or 1,234.56"
   p.url           = "http://github.com/thomasbaustert/amount_field"
   p.author        = "Thomas Baustert"

data/amount_field.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{amount_field}
-  s.version = "1.4.1"
+  s.version = "1.4.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Thomas Baustert"]
-  s.date = %q{2010-04-23}
+  s.date = %q{2010-05-11}
   s.description = %q{Rails gem/plugin that accepts (amount) values in german or us format like 1.234,56 or 1,234.56}
   s.email = %q{ business@thomasbaustert.de}
   s.extra_rdoc_files = ["README.rdoc", "lib/amount_field.rb", "lib/amount_field/configuration.rb", "lib/amount_field/form_helper.rb", "lib/amount_field/form_tag_helper.rb", "lib/amount_field/validations.rb"]

data/lib/amount_field/form_helper.rb

@@ -53,9 +53,10 @@ module AmountField #:nodoc:
           options[:value] ||= object.send("#{AmountField::Configuration.prefix}_#{method}") || object.send("#{method}_before_type_cast")
         end
 
+        # Note: we don't set options[:id] here, because caller or Rails knows best what to do.
+        # We accidentally set it to "foo[bar]_name" instead of "foo_bar_name".
         options[:name]  ||= "#{object_name}[#{AmountField::Configuration.prefix}_#{method}]"
         options[:class] = "#{options[:class]} #{AmountField::Configuration.css_class}"
-        options[:id]    ||= "#{object_name}_#{method}"
         
         text_field(method, options)
       end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 4
-  - 1
-  version: 1.4.1
+  - 2
+  version: 1.4.2
 platform: ruby
 authors: 
 - Thomas Baustert
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-04-23 00:00:00 +02:00
+date: 2010-05-11 00:00:00 +02:00
 default_executable: 
 dependencies: []