alula-ruby 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8e7c4adad8dc9335e13282c8c0ea43d962312e5e4e34113d52877099a072b56c
-  data.tar.gz: 800ed5ba6ddcb94d33742c3b0ecf46ac55d846b9d24d708ea080f55bc6013952
+  metadata.gz: f70aa0a4b0c40a14dd7cfdbb1faa3655525f06212409a61eb9c4af071deead07
+  data.tar.gz: a97bd6710997caa25a901cd3000c1edabdcbd31458460a17e61658093dc7cc5b
 SHA512:
-  metadata.gz: 3c5f72d61ad7f378b1eb412ec3d824d08e33a73f90dcc1a9ec91dec51e552b935af89f7fea74a553243938c3991bc5c3c1504d5a37e2740155d85a9f07f656da
-  data.tar.gz: 54d92e69be82bf5d9a2a2321f02631e2a73e0d26fc887e4541fe30872e0e507c14a2dabbd9224a8eda5fdeffc7cbcbe0bce2412b726c92d4c4c965cc45286b32
+  metadata.gz: 9ff58743a47fc9cc49a71c76e57302debc60acb28a13f37099385d7dbf7260f96b3381da9b6fd8423ee0877a786050a4c6cf9efc5060bf4339a6921d82fba8cb
+  data.tar.gz: f51670cb212984b3157ec25e64e07744205359e0d98c3d707ade79bded8a83fc30a0764a747b021cdd23867094c5be8e93a862ac47fa9a0c7b610ef87522a36d

data/VERSION.md

@@ -2,6 +2,7 @@
 
 | Version | Date      | Description                                                                 |
 | ------- | --------- | --------------------------------------------------------------------------- |
+| v1.4.0  | 2024-01-04  | Add more known errors that use a different format, bugfix for `NotImplementedError` raising         |
 | v1.3.0  | 2023-11-20  | Update NotImplemented error's message to include a JSONized hash, add more known errors that use a different format         |
 | v1.2.4  | 2023-09-15  | Update UI Settings to object         |
 | v1.2.3  | 2023-08-31  | Update typo device patchable field `uiSettings`         |

data/lib/alula/errors.rb

@@ -75,15 +75,19 @@ module Alula
         # Sometimes they are in the msg key, sometimes in the message key
         # Example: https://github.com/alula-net/alula-connect/pull/3417#issue-1985813211
         # Here we have some errors that are actually known but at least one of them is not properly formatted by the API
-        message = response.data.dig('error', 'data', 'msg') || response.data.dig('error', 'data', 'message')
+        message = response.data.dig('error', 'data', 'msg') ||
+                  response.data.dig('error', 'data', 'message') ||
+                  response.data.dig('error', 'description')
         case message
         when 'dealer does not exist'
           NotFoundError.new(message)
         when 'Insufficient User Scope'
           InsufficientScopeError.new(message)
+        when 'Not Found'
+          NotFoundError.new(message)
         else
           Alula.logger.error response
-          raise NotImplementedError.new('Unable to derive error for', response.data['error'].to_json)
+          raise NotImplementedError, "Unable to derive error for #{response.data['error'].to_json}"
         end
       end
     end
@@ -112,15 +116,17 @@ module Alula
         return ProcedureError.new(response) if response.data['jsonrpc']
 
         # See comment in the error_for_response method
-        message = error.dig('data', 'msg') || error.dig('data', 'message')
+        message = error.dig('data', 'msg') || error.dig('data', 'message') || error['description']
         case message
         when 'dealer does not exist'
           NotFoundError.new(message)
         when 'Insufficient User Scope'
           InsufficientScopeError.new(message)
+        when 'Not Found'
+          NotFoundError.new(message)
         else
           Alula.logger.error response
-          raise NotImplementedError.new('Unable to derive error for', response.data['errors'].to_json)
+          raise NotImplementedError, "Unable to derive error for #{response.data['errors'].to_json}"
         end
       end
     end

data/lib/alula/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Alula
-  VERSION = '1.3.0'
+  VERSION = '1.4.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alula-ruby
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Titus Johnson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-11-21 00:00:00.000000000 Z
+date: 2024-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty