alterity 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e235d55d20337f7ff9bf2b4eed178c3585c4ff682bda637a34339c507644438
-  data.tar.gz: b41b2d051afdbb66a42f5ce00e2daff2b8e9b4f8935fa3c9f01e64ab0148d9e4
+  metadata.gz: 6283968b3d028f736da1517832ee5ebf8410aa4281aea4a2fa7af9e868a7ef89
+  data.tar.gz: c4e6ae366bea0f1065aa303824c0f64f7dc684f7566e600ede7ece16c4e58b60
 SHA512:
-  metadata.gz: 749cd02d5f7b2b6feb3e5e3b63c52274f701946cc03fd067b51f5c4214d7a2c73fab365ca329323058d1fb7c09999d3c1c7a8608bcb9574faa406bc244ad08cd
-  data.tar.gz: a0234815613fe77cf4db1950b8ef72de5c0def70b6abe45394c4efa1d5c7b1154d99454f81d9babcd8f00f58cbdf63edcd2f9cb181c22102e08cbaf7aa15691e
+  metadata.gz: 1bf501f5c7f2ce204f995341c7ee2bf73a0c3d8fc16ed9b32ea710ff4b77251e464891df9866a6847b7740ae9472f1c639cae7b7ac31bb82381616b84d5ea66b
+  data.tar.gz: 58fb3f6708f0b610d4129c960f1765e5073d74e0170f46456d549cf3f65ecf8e34da7b139efee3afbb5575d0f0c01d5630170590d51ffba2b6de9ef8d52e4a1c

data/lib/alterity.rb

@@ -10,7 +10,18 @@ class Alterity
     def process_sql_query(sql, &block)
       case sql.tr("\n", " ").strip
       when /^alter\s+table\s+(?<table>.+?)\s+(?<updates>.+)/i
-        execute_alter($~[:table], $~[:updates])
+        table = $~[:table]
+        updates = $~[:updates]
+        if updates.split(",").all? { |s| s =~ /^\s*drop\s+foreign\s+key\s+\w+\s*$/i } ||
+           updates.split(",").all? { |s| s =~ /^\s*add\s+constraint\s+`?\w+`?\s+foreign\s+key\s+\(`?\w+`?\)\s+references\s+`?\w+`?\s+\(`?\w+`?\)\s*$/i }
+          block.call
+        elsif updates =~ /drop\s+foreign\s+key/i || updates =~ /add\s+constraint/i
+          # ADD CONSTRAINT / DROP FOREIGN KEY have to go to the original table,
+          # other alterations need to got to the new table.
+          raise "[Alterity] Can't change a FK and do something else in the same query. Split it."
+        else
+          execute_alter(table, updates)
+        end
       when /^create\s+index\s+(?<index>.+?)\s+on\s+(?<table>.+?)\s+(?<updates>.+)/i
         execute_alter($~[:table], "ADD INDEX #{$~[:index]} #{$~[:updates]}")
       when /^create\s+unique\s+index\s+(?<index>.+?)\s+on\s+(?<table>.+?)\s+(?<updates>.+)/i

data/lib/alterity/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Alterity
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/alterity_spec.rb

@@ -29,7 +29,10 @@ RSpec.describe Alterity do
         "SHOW CREATE TABLE `users`",
         "SHOW TABLE STATUS LIKE `users`",
         "SHOW KEYS FROM `users`",
-        "SHOW FULL FIELDS FROM `users`"
+        "SHOW FULL FIELDS FROM `users`",
+        "ALTER TABLE `installment_events` DROP FOREIGN KEY _fk_rails_0123456789",
+        "ALTER TABLE `installment_events` DROP FOREIGN KEY _fk_rails_0123456789, DROP FOREIGN KEY _fk_rails_9876543210",
+        "ALTER TABLE `installment_events` ADD CONSTRAINT `fk_rails_0cb5590091` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`)"
       ].each do |query|
         expected_block = proc {}
         expect(expected_block).to receive(:call)
@@ -37,5 +40,19 @@ RSpec.describe Alterity do
         Alterity.process_sql_query(query, &expected_block)
       end
     end
+
+    it "raises an error if mixing FK change and other things" do
+      expected_block = proc {}
+      expect(expected_block).not_to receive(:call)
+      expect(Alterity).not_to receive(:execute_alter)
+      query = "ALTER TABLE `installment_events` ADD `col` VARCHAR(255), DROP FOREIGN KEY _fk_rails_0123456789"
+      expect do
+        Alterity.process_sql_query(query, &expected_block)
+      end.to raise_error(/FK/)
+      query = "ALTER TABLE `installment_events` ADD `col` VARCHAR(255), ADD CONSTRAINT `fk_rails_0cb5590091` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`)"
+      expect do
+        Alterity.process_sql_query(query, &expected_block)
+      end.to raise_error(/FK/)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alterity
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Chris Maximin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-06 00:00:00.000000000 Z
+date: 2021-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mysql2