alphavantagerb 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2846dc690fd548267b1fd3657beae0c5be91451c
-  data.tar.gz: 5b6cdcb1492ba342f1cf8e02a5284fd89dd0290b
+  metadata.gz: 45b9bfaa0883fbcebabc5b26972fd66f736df2c4
+  data.tar.gz: 9407ed9a0c3761d8ba70bf79a19678bc7b614ac8
 SHA512:
-  metadata.gz: 6e62c435f993111a6c95e2b2522eea583f80c9dfb5b6b3efb9e74bddf5a7d45ca2d47c98b9ad7daf8d11003a84f6a9fbdf1447b6d297c228fc6dc3dcf759c08d
-  data.tar.gz: e0141b848e4b8512ebf1f2f7d618d109adbcec3a62217752d6a8ec6ac964ec0c50704161d074525514104e9407ac42aa05b2b6b1624f977df9824fbcf618a6b6
+  metadata.gz: d07776377781826d1778768bad668cf5125f3e8856b52828c27b0d3a45bfe18907023739cd0d4884af890ce9727f528c4775e02f502fac9970980e48dcdb0bf3
+  data.tar.gz: 60945c1de9ffc3d0c08dff5b65b87cf3cba61615f32d61107e17f3ffcf9db5afa8570f6abb978cc61069bcc31385ff4e46cc354418728ea0a455f768b31bda9f

data/AlphavantageRB.gemspec

@@ -4,7 +4,7 @@ require "rake"
 
 Gem::Specification.new do |s|
   s.name        = "alphavantagerb"
-  s.version	    = "1.1.0"
+  s.version	    = "1.2.0"
   s.authors     = ["Stefano Martin"]
   s.email       = ["stefano.martin87@gmail.com"]
   s.homepage    = "https://github.com/StefanoMartin/AlphaVantageRB"

data/README.md

@@ -665,8 +665,8 @@ To create a new Crypto_Timeseries class you can use a Crypto class or you can cr
 These two creation commands are equivalent:
 
 ``` ruby
-crypto_timeseries = crypto.timeseries
-crypto_timeseries = Alphavantage::Crypto_Timeseries.new symbol: "BTC", market: "DKK", key: "YOURKEY"
+crypto_timeseries = crypto.timeseries type: "daily"
+crypto_timeseries = Alphavantage::Crypto_Timeseries.new type: "daily", symbol: "BTC", market: "DKK", key: "YOURKEY"
 ```
 
 Note that the initialization owns different entries:
@@ -674,6 +674,7 @@ Note that the initialization owns different entries:
 * market: it is a string that denote the market you want to analyze. This value cannot be setup if you are initializing a timeseries from a stock
 * key: authentication key.  This value cannot be setup if you are initializing a timeseries from a crypto class
 * verbose: used to see the request to Alpha Vantage (default false). This value cannot be setup if you are initializing a timeseries from a stock
+* type: it can be "intraday", "daily", "weekly", "monthly" (default "daily")
 * datatype: it can be "json" or "csv" (default "json")
 * file: path where a csv file should be saved (default "nil")
 
@@ -700,17 +701,23 @@ These methods will return an array of couples where the first entry is a timesta
 These timeseries return always the corrispective timeseries in relation of the USD market.
 
 ``` ruby
-  crypto_timeseries.price
-  crypto_timeseries.price_usd
+  crypto_timeseries.open
+  crypto_timeseries.close
+  crypto_timeseries.high
+  crypto_timeseries.low
   crypto_timeseries.volume
+  crypto_timeseries.open_usd
+  crypto_timeseries.close_usd
+  crypto_timeseries.high_usd
+  crypto_timeseries.low_usd
   crypto_timeseries.market_cap_usd
 ```
 
 You can order the data in ascending or descending order.
 
 ``` ruby
-  crypto_timeseries.price("desc") # Default
-  crypto_timeseries.price("asc")
+  crypto_timeseries.open("desc") # Default
+  crypto_timeseries.open("asc")
 ```
 <a name="Exchange"></a>
 ## Alphavantage::Exchange

data/lib/Crypto.rb

@@ -18,8 +18,8 @@ module Alphavantage
       @datatype = datatype
     end
 
-    def timeseries market: @market, file: nil, datatype: @datatype
-      Alphavantage::Crypto_Timeseries.new market: market,
+    def timeseries type: "intraday", market: @market, file: nil, datatype: @datatype
+      Alphavantage::Crypto_Timeseries.new type: type, market: market,
         symbol: @symbol, datatype: datatype, file: file, key: @client
     end
   end

data/lib/Crypto_Timeseries.rb

@@ -2,7 +2,7 @@ module Alphavantage
   class Crypto_Timeseries
     include HelperFunctions
 
-    def initialize market:, symbol:, datatype: "json", file: nil,
+    def initialize type: "intraday", market:, symbol:, datatype: "json", file: nil,
       key:, verbose: false
       check_argument([true, false], verbose, "verbose")
       @client = return_client(key, verbose)
@@ -13,8 +13,8 @@ module Alphavantage
         raise Alphavantage::Error.new message: "Hash error: No file necessary"
       end
 
-      # @selected_time_series = which_series(type)
-      url = "function=DIGITAL_CURRENCY_INTRADAY&symbol=#{symbol}&market=#{market}"
+      @selected_time_series = which_series(type)
+      url = "function=#{@selected_time_series}&symbol=#{symbol}&market=#{market}"
       return @client.download(url, file) if datatype == "csv"
       @hash = @client.request(url)
       metadata = @hash.dig("Meta Data") || {}
@@ -57,11 +57,11 @@ module Alphavantage
 
     attr_reader :hash
 
-    # def which_series(type)
-    #   check_argument(["intraday", "daily", "weekly", "monthly"], type, "type")
-    #   series = "DIGITAL_CURRENCY_"
-    #   series += type.upcase
-    #   return series
-    # end
+    def which_series(type)
+      check_argument(["intraday", "daily", "weekly", "monthly"], type, "type")
+      series = "DIGITAL_CURRENCY_"
+      series += type.upcase
+      return series
+    end
   end
 end

data/spec/lib/1.0.0/crypto_timeseries.rb

@@ -3,17 +3,17 @@ require_relative './../../spec_helper'
 describe Alphavantage::Crypto_Timeseries do
   context "#new" do
     it "create a new timeseries without stock" do
-      sleep(1); stock = Alphavantage::Crypto_Timeseries.new symbol: "BTC", key: @config["key"], verbose: false, market: "DKK"
+      sleep(1); stock = Alphavantage::Crypto_Timeseries.new symbol: "BTC", key: @config["key"], verbose: false, market: "DKK", type: "daily"
       expect(stock.class).to eq Alphavantage::Crypto_Timeseries
     end
 
     it "create a new stock from stock" do
-      sleep(1); timeseries = @client.crypto(symbol: "BTC", market: "DKK").timeseries
+      sleep(1); timeseries = @client.crypto(symbol: "BTC", market: "DKK").timeseries(type: "monthly")
       expect(timeseries.class).to eq Alphavantage::Crypto_Timeseries
     end
 
     it "own multiple data" do
-      sleep(1); timeseries = @client.crypto(symbol: "BTC", market: "DKK").timeseries
+      sleep(1); timeseries = @client.crypto(symbol: "BTC", market: "DKK").timeseries(type: "monthly")
       bool = []
       bool << timeseries.information.is_a?(String)
       bool << (timeseries.digital_currency_code == "BTC")
@@ -23,9 +23,15 @@ describe Alphavantage::Crypto_Timeseries do
       bool << timeseries.last_refreshed.is_a?(String)
       bool << timeseries.time_zone.is_a?(String)
       bool << timeseries.hash.is_a?(Hash)
+      bool << timeseries.open.is_a?(Array)
+      bool << timeseries.high.is_a?(Array)
+      bool << timeseries.low.is_a?(Array)
+      bool << timeseries.close.is_a?(Array)
       bool << timeseries.volume("asc").is_a?(Array)
-      bool << timeseries.price.is_a?(Array)
-      bool << timeseries.price_usd.is_a?(Array)
+      bool << timeseries.open_usd.is_a?(Array)
+      bool << timeseries.high_usd.is_a?(Array)
+      bool << timeseries.low_usd.is_a?(Array)
+      bool << timeseries.close_usd.is_a?(Array)
       bool << timeseries.market_cap_usd.is_a?(Array)
       expect(bool.all?{|e| e}).to eq true
     end
@@ -43,7 +49,7 @@ describe Alphavantage::Crypto_Timeseries do
     it "cannot retrieve with wrong symbol" do
       error = false
       begin
-        sleep(1); stock = Alphavantage::Crypto_Timeseries.new symbol: "wrong_symbol", key: @config["key"], market: "DKK"
+        sleep(1); stock = Alphavantage::Crypto_Timeseries.new symbol: "wrong_symbol", key: @config["key"], market: "DKK", type: "daily"
       rescue Alphavantage::Error => e
         error = true
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alphavantagerb
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Stefano Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-07 00:00:00.000000000 Z
+date: 2018-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty