alpha_card 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d71d35569f21cf510852e3c35f8df41399983e8a
-  data.tar.gz: a2266edd9c1e5df53788121264173053615c0931
+  metadata.gz: 30d93b58f9dc44c84691c6666bcdc6b0f41a8f6a
+  data.tar.gz: 8b797a6054d6daa1f7314a1e3c23c6d7d3f23918
 SHA512:
-  metadata.gz: 417ac49bc0b7a982f56d7fbc16d684b616c807e88d1adf37a0d2ab7aba3920608f678aa7eb4d59f7fdb50a2b8a2c52a94ae8660443a50dc0ace98d1e8833ae14
-  data.tar.gz: cebcd84f04b491a4d0bb7ad199572d89a4efb74c0e075867037ed6d2a7c5539aa2d74dc5d5ea939fa13197ba5eaa0a45a05e34413d051db0ddef854a25bd6daa
+  metadata.gz: 1385c84b244958cd05e7915a384964d006c1a96c1c0b7fa05f58ff021cdf3454759b1926566dda4d5183f2e8b197b3789a88911bfd3cba078e07e2361344eb73
+  data.tar.gz: 09d4105be24baa504e86e9989ce927f5bc34bc3b74ae00705efa67638d96f1136f5d985fb56c1b44bdb90caeff21fb97b2ad90a7cccbf210e8454871d855335e

data/.gitignore

@@ -1 +0,0 @@
-Gemfile.lock

data/.travis.yml

@@ -9,6 +9,8 @@ rvm:
   - 2.1.1
   - 2.1.2
   - 2.1.5
+  - 2.2.4
+  - 2.3.0
   - jruby-19mode
   - ruby-head
 matrix:

data/Gemfile

@@ -3,6 +3,8 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'virtus'
-gem 'rest-client'
-gem 'coveralls', require: false
-gem 'rack-test', require: false
+
+group :test do
+  gem 'coveralls', require: false
+  gem 'rack-test', require: false
+end

data/Gemfile.lock

@@ -0,0 +1,86 @@
+PATH
+  remote: .
+  specs:
+    alpha_card (0.2.6)
+      virtus (~> 1.0, >= 1.0.5)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    axiom-types (0.1.1)
+      descendants_tracker (~> 0.0.4)
+      ice_nine (~> 0.11.0)
+      thread_safe (~> 0.3, >= 0.3.1)
+    coercible (1.0.0)
+      descendants_tracker (~> 0.0.1)
+    coveralls (0.8.10)
+      json (~> 1.8)
+      rest-client (>= 1.6.8, < 2)
+      simplecov (~> 0.11.0)
+      term-ansicolor (~> 1.3)
+      thor (~> 0.19.1)
+      tins (~> 1.6.0)
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.2.5)
+    docile (1.1.5)
+    domain_name (0.5.25)
+      unf (>= 0.0.5, < 1.0.0)
+    equalizer (0.0.11)
+    http-cookie (1.0.2)
+      domain_name (~> 0.5)
+    ice_nine (0.11.1)
+    json (1.8.3)
+    mime-types (2.99)
+    netrc (0.11.0)
+    rack (1.6.4)
+    rack-test (0.6.3)
+      rack (>= 1.0)
+    rest-client (1.8.0)
+      http-cookie (>= 1.0.2, < 2.0)
+      mime-types (>= 1.16, < 3.0)
+      netrc (~> 0.7)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.1)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+    simplecov (0.11.1)
+      docile (~> 1.1.0)
+      json (~> 1.8)
+      simplecov-html (~> 0.10.0)
+    simplecov-html (0.10.0)
+    term-ansicolor (1.3.2)
+      tins (~> 1.0)
+    thor (0.19.1)
+    thread_safe (0.3.5)
+    tins (1.6.0)
+    unf (0.1.4)
+      unf_ext
+    unf_ext (0.0.7.1)
+    virtus (1.0.5)
+      axiom-types (~> 0.1)
+      coercible (~> 1.0)
+      descendants_tracker (~> 0.0, >= 0.0.3)
+      equalizer (~> 0.0, >= 0.0.9)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  alpha_card!
+  coveralls
+  rack-test
+  rspec (~> 3)
+  virtus
+
+BUNDLED WITH
+   1.11.2

data/README.md

@@ -6,6 +6,7 @@
 [![Build Status](https://travis-ci.org/nbulaj/alpha_card.svg?branch=master)](https://travis-ci.org/nbulaj/alpha_card)
 [![Inline docs](http://inch-ci.org/github/nbulaj/alpha_card.png?branch=master)](http://inch-ci.org/github/nbulaj/alpha_card)
 [![License](http://img.shields.io/badge/license-MIT-brightgreen.svg)](#license)
+[![Gem](https://img.shields.io/gem/dt/alpha_card.svg)]()
 
 This gem can help your Ruby or Ruby on Rails application to integrate with Alpha Card Service, Inc.
 
@@ -86,7 +87,7 @@ _Unnecessary fields_:
 _Constructor_:
 
 ```ruby
-AlphaCard::Order.new({field_name: value, ...})
+AlphaCard::Order.new(field_name: value, ...)
 ```
 
 ### Billing
@@ -112,7 +113,7 @@ _Unnecessary fields_:
 _Constructor_:
 
 ```ruby
-AlphaCard::Billing.new({field_name: value, ...})
+AlphaCard::Billing.new(field_name: value, ...)
 ```
 
 ### Shipping
@@ -135,7 +136,7 @@ _Unnecessary fields_:
 _Constructor_:
 
 ```ruby
-AlphaCard::Shipping.new({field_name: value, ...})
+AlphaCard::Shipping.new(field_name: value, ...)
 ```
 
 ### Sale
@@ -154,14 +155,14 @@ _Unnecessary fields_:
 _Constructor_:
 
 ```ruby
-AlphaCard::Sale.new({field_name: value, ...})
+AlphaCard::Sale.new(field_name: value, ...)
 ```
 
 To create the payment you must call *create(_alpha_card_order_, _alpha_card_account_)* method:
 
 ```ruby
 ...
-sale = AlphaCard::Sale.new({})
+sale = AlphaCard::Sale.new(amount: 10)
 sale.create(order, account)
 ```
 
@@ -235,4 +236,5 @@ Thanks.
 ## License
 
 Alpha Card gem is released under the [MIT License](http://www.opensource.org/licenses/MIT).
-Copyright (c) 2014-2015 Nikita Bulaj (bulajnikita@gmail.com).
+
+Copyright (c) 2014-2016 Nikita Bulaj (bulajnikita@gmail.com).

data/alpha_card.gemspec

@@ -16,8 +16,7 @@ Gem::Specification.new do |gem|
   gem.license = 'MIT'
   gem.required_ruby_version = '>= 1.9.3'
 
-  gem.add_dependency 'virtus', '~> 1.0'
-  gem.add_dependency 'rest-client', '~> 1.8'
+  gem.add_runtime_dependency 'virtus', '~> 1.0', '>= 1.0.5'
 
   gem.add_development_dependency 'rspec', '~> 3'
 end

data/lib/alpha_card.rb

@@ -1,7 +1,8 @@
 # encoding:utf-8
 require 'yaml'
 require 'virtus'
-require 'rest-client'
+require 'net/http'
+require 'uri'
 require 'rack/utils'
 
 # Version
@@ -37,112 +38,134 @@ module AlphaCard
   class << self
     # @return [String] Alpha Card Gateway DirectPost API URL.
     attr_accessor :api_base
-  end
 
-  ##
-  # Send the POST request to the AlphaCard Gateway from the
-  # specified account. Request must contains params - Alpha Card
-  # transaction variables.
-  #
-  # @param [Hash] params
-  #   Alpha Card transaction variables.
-  # @param [AlphaCard::Account] account
-  #   An <code>AlphaCard::Account</code> credentials object.
-  #
-  # @return [AlphaCard::AlphaCardResponse]
-  #   Response from Alpha Card Gateway.
-  #
-  # @raise [AlphaCard::AlphaCardError]
-  #   AlphaCardError Exception if request failed.
-  #
-  # @example
-  #   account = AlphaCard::Account.new('demo', 'password')
-  #   response = AlphaCard.request(
-  #     {
-  #       cexp: '0720',
-  #       ccnumber: '4111111111111111',
-  #       amount: '10.00'
-  #     },
-  #     account
-  #   )
-  #
-  #   #=> #<AlphaCard::AlphaCardResponse:0x1a0fda8 @data={"response"=>"1",
-  #       "responsetext"=>"SUCCESS", "authcode"=>"123", "transactionid"=>"123",
-  #       "avsresponse"=>"", "cvvresponse"=>"N", "orderid"=>"", "type"=>"",
-  #       "response_code"=>"100"}>
-  #
-  #   account = AlphaCard::Account.new('demo', 'password')
-  #   response = AlphaCard.request(
-  #     {
-  #       cexp: '0720',
-  #       ccnumber: '123',
-  #       amount: '10.00'
-  #     },
-  #     account
-  #   )
-  #
-  #   #=> AlphaCard::AlphaCardError: AlphaCard::AlphaCardError
-  def self.request(params = {}, account)
-    fail AlphaCardError, 'You must set credentials to create the sale!' unless account.filled?
-
-    begin
-      response = RestClient.post(@api_base, params.merge(account.attributes))
-    rescue => e
-      handle_connection_errors(e)
+    ##
+    # Send the POST request to the AlphaCard Gateway from the
+    # specified account. Request must contains params - Alpha Card
+    # transaction variables.
+    #
+    # @param [Hash] params
+    #   Alpha Card transaction variables.
+    # @param [AlphaCard::Account] account
+    #   An <code>AlphaCard::Account</code> credentials object.
+    #
+    # @return [AlphaCard::AlphaCardResponse]
+    #   Response from Alpha Card Gateway.
+    #
+    # @raise [AlphaCard::AlphaCardError]
+    #   AlphaCardError Exception if request failed.
+    #
+    # @example
+    #   account = AlphaCard::Account.new('demo', 'password')
+    #   response = AlphaCard.request(
+    #     account,
+    #     {
+    #       cexp: '0720',
+    #       ccnumber: '4111111111111111',
+    #       amount: '10.00'
+    #     }
+    #   )
+    #
+    #   #=> #<AlphaCard::AlphaCardResponse:0x1a0fda8 @data={"response"=>"1",
+    #       "responsetext"=>"SUCCESS", "authcode"=>"123", "transactionid"=>"123",
+    #       "avsresponse"=>"", "cvvresponse"=>"N", "orderid"=>"", "type"=>"",
+    #       "response_code"=>"100"}>
+    #
+    #   account = AlphaCard::Account.new('demo', 'password')
+    #   response = AlphaCard.request(
+    #     account,
+    #     {
+    #       cexp: '0720',
+    #       ccnumber: '123',
+    #       amount: '10.00'
+    #     }
+    #   )
+    #
+    #   #=> AlphaCard::AlphaCardError: AlphaCard::AlphaCardError
+    def request(account, params = {})
+      fail AlphaCardError, 'You must set credentials to create the sale!' unless account.filled?
+
+      begin
+        response = http_request(@api_base, params.merge(account.attributes))
+      rescue => e
+        handle_connection_errors(e)
+      end
+
+      alpha_card_response = AlphaCardResponse.new(response.body)
+      handle_alpha_card_errors(alpha_card_response)
+
+      alpha_card_response
     end
 
-    alpha_card_response = AlphaCardResponse.new(response.to_str)
-    handle_alpha_card_errors(alpha_card_response)
-
-    alpha_card_response
-  end
-
-  private
-
-  ##
-  # Raises an exception if Alpha Card Gateway return an error or
-  # decline code for the request. Message is taken from the Global
-  # Payment Systems Credit Card Authorization Codes (codes.yml).
-  # If code wasn't found in <code>CREDIT_CARD_CODES</code>, then
-  # message = Alpha Card response text.
-  #
-  # @param [AlphaCard::AlphaCardResponse] response
-  #   Alpha Card Response object.
-  #
-  # @raise [AlphaCard::AlphaCardError]
-  #   AlphaCardError Exception if request failed.
-  #
-  # @return [String]
-  #   Alpha Card Services response text.
-  def self.handle_alpha_card_errors(response)
-    code = response.text
-    raise AlphaCardError.new(CREDIT_CARD_CODES[code] || code, response) unless response.success?
-  end
+    ##
+    # Raises an exception if Alpha Card Gateway return an error or
+    # decline code for the request. Message is taken from the Global
+    # Payment Systems Credit Card Authorization Codes (codes.yml).
+    # If code wasn't found in <code>CREDIT_CARD_CODES</code>, then
+    # message = Alpha Card response text.
+    #
+    # @param [AlphaCard::AlphaCardResponse] response
+    #   Alpha Card Response object.
+    #
+    # @raise [AlphaCard::AlphaCardError]
+    #   AlphaCardError Exception if request failed.
+    #
+    # @return [String]
+    #   Alpha Card Services response text.
+    def handle_alpha_card_errors(response)
+      code = response.text
+      raise AlphaCardError.new(CREDIT_CARD_CODES[code] || code, response) unless response.success?
+    end
 
-  ##
-  # Raises an exception if a network error occurs. It
-  # could be request timeout, socket error or anything else.
-  #
-  # @param [Exception] e
-  #   Exception object.
-  #
-  # @raise [AlphaCard::AlphaCardError]
-  #   AlphaCardError Exception.
-  def self.handle_connection_errors(error)
-    case error
-    when RestClient::ServerBrokeConnection, RestClient::RequestTimeout
-      message = "Could not connect to Alpha Card Gateway (#{@api_base}). " \
-          'Please check your internet connection and try again. ' \
-          'If this problem persists, you should check Alpha Card services status.'
-
-    when SocketError
-      message = 'Unexpected error communicating when trying to connect to Alpha Card Gateway. ' \
-          'You may be seeing this message because your DNS is not working.'
-
-    else
-      message = 'Unexpected error communicating with Alpha Card Gateway.'
+    ##
+    # Raises an exception if a network error occurs. It
+    # could be request timeout, socket error or anything else.
+    #
+    # @param [Exception]
+    #   Exception object.
+    #
+    # @raise [AlphaCard::AlphaCardError]
+    #   AlphaCardError Exception.
+    def handle_connection_errors(error)
+      case error
+      when Timeout::Error, Errno::EINVAL, Errno::ECONNRESET
+        message = "Could not connect to Alpha Card Gateway (#{@api_base}). " \
+            'Please check your internet connection and try again. ' \
+            'If this problem persists, you should check Alpha Card services status.'
+
+      when SocketError
+        message = 'Unexpected error communicating when trying to connect to Alpha Card Gateway. ' \
+            'You may be seeing this message because your DNS is not working.'
+
+      else
+        message = 'Unexpected error communicating with Alpha Card Gateway.'
+      end
+
+      fail APIConnectionError, "#{message}\n\n(Network error: #{error.message})"
     end
 
-    raise APIConnectionError, "#{message}\n\n(Network error: #{error.message})"
+    ##
+    # Send secure HTTP(S) request with params
+    # to requested URL.
+    #
+    # @param [String] url
+    #   URL
+    # @param [Hash] params
+    #   Hash of params for the request
+    #
+    # @return [HTTPResponse]
+    #   Response of the request as HTTPResponse object
+    def http_request(url, params)
+      uri = URI.parse(url)
+
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl = true
+      http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+
+      request = Net::HTTP::Post.new(uri.request_uri)
+      request.set_form_data(params)
+
+      http.request(request)
+    end
   end
 end

data/lib/alpha_card/alpha_card_response.rb

@@ -9,11 +9,11 @@ module AlphaCard
     attr_reader :data
 
     # Success response code
-    APPROVED = '1'
+    APPROVED = '1'.freeze
     # Decline response code
-    DECLINED = '2'
+    DECLINED = '2'.freeze
     # Error response code
-    ERROR    = '3'
+    ERROR    = '3'.freeze
 
     ##
     # AlphaCardResponse constructor.

data/lib/alpha_card/objects/sale.rb

@@ -41,15 +41,32 @@ module AlphaCard
     #   #=> true
     def create(order, account)
       [:ccexp, :ccnumber, :amount].each do |attr|
-        fail Exception, "No #{attr} information provided!" if self[attr].nil? || self[attr].empty?
+        fail ArgumentError, "No #{attr} information provided!" if self[attr].nil? || self[attr].empty?
       end
 
+      AlphaCard.request(account, params_with(order)).success?
+    end
+
+    private
+
+    ##
+    # Return params for Alpha Card merged with
+    # params of another object passed through arguments
+    #
+    # @param [AlphaCard::Order] order
+    #    An <code>AlphaCard::Order</code> object.
+    #
+    # @return [Hash]
+    #   Params of *self* object merged with params
+    #   of another object (<code>AlphaCard::Order</code>)
+    def params_with(order)
       params = filled_attributes || {}
+
       [order, order.billing, order.shipping].compact.each do |obj|
         params.merge!(obj ? obj.filled_attributes : {})
       end
 
-      AlphaCard.request(params, account).success?
+      params
     end
   end
 end

data/lib/alpha_card/version.rb

@@ -1,5 +1,5 @@
 module AlphaCard
   ##
   # Version information for AlphaCard gem.
-  VERSION = '0.2.5'
+  VERSION = '0.2.6'.freeze
 end

data/spec/alpha_card/alpha_card_spec.rb

@@ -8,8 +8,6 @@ describe AlphaCard do
   let!(:order) { AlphaCard::Order.new({orderid: '1', billing: billing, shipping: shipping}) }
   let!(:card_exp) { "#{'%02d' % Time.now.month}/#{Time.now.year.next}" }
 
-  #TODO: Create rest client mock to imitate requests, normal tests for error exceptions
-
   context 'With valid attributes' do
     let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: '4111111111111111', amount: '5.00'}) }
 
@@ -73,7 +71,7 @@ describe AlphaCard do
     let!(:sale) { AlphaCard::Sale.new({}) }
 
     it 'should raise an Exception' do
-      expect { sale.create(order, account) }.to raise_exception
+      expect { sale.create(order, account) }.to raise_error(ArgumentError)
     end
   end
 
@@ -89,12 +87,12 @@ describe AlphaCard do
   end
 
   context 'With connection errors' do
-    let!(:rest_client_error) { RestClient::RequestTimeout.new }
+    let!(:timeout_error) { Timeout::Error.new }
     let!(:socket_error) { SocketError.new }
     let!(:unclassified_error) { StandardError.new('Some error') }
 
-    it 'should raise an APIConnectionError if Rest Client Error' do
-      expect { AlphaCard.handle_connection_errors(rest_client_error) }.to raise_error(AlphaCard::APIConnectionError) do |e|
+    it 'should raise an APIConnectionError if Timeout Error' do
+      expect { AlphaCard.handle_connection_errors(timeout_error) }.to raise_error(AlphaCard::APIConnectionError) do |e|
         expect(e.message).to include('Could not connect to Alpha Card Gateway')
       end
     end
@@ -115,7 +113,7 @@ describe AlphaCard do
       let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: '4111111111111111', amount: '5.00'}) }
 
       it 'should handle an error' do
-        AlphaCard.api_base = 'https://google.com' # todo: some other service
+        AlphaCard.api_base = 'https://not-existing.com' # todo: some other service
         expect { sale.create(order, account) }.to raise_error(AlphaCard::APIConnectionError)
 
         AlphaCard.api_base = 'https://secure.alphacardgateway.com/api/transact.php'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alpha_card
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - Nikita Bulaj
@@ -17,6 +17,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -24,20 +27,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: rest-client
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: 1.0.5
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -62,6 +54,7 @@ files:
 - ".rspec"
 - ".travis.yml"
 - Gemfile
+- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -102,7 +95,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Alpha Card Services API for Ruby