alpha_card 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ceec62767933ce8b3848b21ec0ffbe6c9775f229
-  data.tar.gz: 82c414eea55aa6d675d0c1043cba408eb21af70a
+  metadata.gz: 4c5e5fb8c704ad1100003d8eb8023a7adf9c782d
+  data.tar.gz: 8207975985e90e9287e360eccda6ffdc649a0cba
 SHA512:
-  metadata.gz: dac21d71195b11f35c375c1ea0743cf033f33e81eaa61ce639fdc5aedecf6ac5450ad139527233e18484fdb0a1ebccb223d843ef296a6b416318f84f16d547e2
-  data.tar.gz: 3e713b2ccbd597e73a1f4c6bcc0faedab7e49e5fb9ec3319b3812d34c8fd74d1ecf3c3e78464df9c34bce9815f6daacc5c474caefca33a887cf7b8b4b613569e
+  metadata.gz: 6eb401a030e241fa9345168a1efe3dbcfdb26b1a3a4a8cb490bc6d94013cfdfc22ff029e753bdcc1e7e6854b57a6a0afd91c6263a4644a7c30da437c2f1ff5ab
+  data.tar.gz: 63c3e4f5fa8936433ad872e45e652357f4c773f8b3a003eb9dc75abcc2edf7f59e078fee5e0df6e62c5691d7651c212171d4638b4ca66f5db7c35fea11c6ed3c

data/Rakefile

@@ -3,4 +3,4 @@ require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/alpha_card.gemspec

@@ -1,17 +1,17 @@
-$:.unshift(File.join(File.dirname(__FILE__), 'lib'))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), 'lib'))
 
 require 'alpha_card/version'
 
 Gem::Specification.new do |gem|
   gem.name = 'alpha_card'
   gem.version = AlphaCard::VERSION
-  gem.date = '2014-07-11'
+  gem.date = '2014-07-24'
   gem.summary = 'Alpha Card Services DirectPost API for Ruby'
   gem.description = 'Gem for creating sales with Alpha Card Services DirectPost API'
   gem.authors = ['Nikita Bulaj']
   gem.email = 'bulajnikita@gmail.com'
-  gem.require_paths = ["lib"]
-  gem.files = `git ls-files`.split($/)
+  gem.require_paths = ['lib']
+  gem.files = `git ls-files`.split($RS)
   gem.homepage = 'http://github.com/budev/alpha_card'
   gem.license = 'MIT'
   gem.required_ruby_version = '>= 1.9.3'
@@ -19,5 +19,5 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'virtus', '~> 1.0'
   gem.add_dependency 'rest_client', '~> 1.7'
 
-  gem.add_development_dependency "rspec", '~> 3'
+  gem.add_development_dependency 'rspec', '~> 3'
 end

data/lib/alpha_card.rb

@@ -83,9 +83,7 @@ module AlphaCard
   #
   #   #=> AlphaCard::AlphaCardError: AlphaCard::AlphaCardError
   def self.request(params = {}, account)
-    unless account.filled?
-      raise AlphaCardError.new('You must set credentials to create the sale!')
-    end
+    fail AlphaCardError, 'You must set credentials to create the sale!' unless account.filled?
 
     begin
       response = RestClient.post(@api_base, params.merge(account.attributes))
@@ -130,22 +128,21 @@ module AlphaCard
   #
   # @raise [AlphaCard::AlphaCardError]
   #   AlphaCardError Exception.
-  def self.handle_connection_errors(e)
-    case e
-      when RestClient::ServerBrokeConnection, RestClient::RequestTimeout
-        message = "Could not connect to Alpha Card Gateway (#{@api_base}). " +
-            'Please check your internet connection and try again. ' +
-            'If this problem persists, you should check Alpha Card services status.'
-
-      when SocketError
-        message = 'Unexpected error communicating when trying to connect to Alpha Card Gateway. ' +
-            'You may be seeing this message because your DNS is not working.'
-
-      else
-        message = 'Unexpected error communicating with Alpha Card Gateway.'
+  def self.handle_connection_errors(error)
+    case error
+    when RestClient::ServerBrokeConnection, RestClient::RequestTimeout
+      message = "Could not connect to Alpha Card Gateway (#{@api_base}). " \
+          'Please check your internet connection and try again. ' \
+          'If this problem persists, you should check Alpha Card services status.'
+
+    when SocketError
+      message = 'Unexpected error communicating when trying to connect to Alpha Card Gateway. ' \
+          'You may be seeing this message because your DNS is not working.'
+
+    else
+      message = 'Unexpected error communicating with Alpha Card Gateway.'
     end
 
-    raise APIConnectionError.new(message + "\n\n(Network error: #{e.message})")
+    raise APIConnectionError, "#{message}\n\n(Network error: #{error.message})"
   end
 end
-

data/lib/alpha_card/account.rb

@@ -1,7 +1,7 @@
 module AlphaCard
   ##
   # Implementation of Alpha Card Services account object.
-  # Contains credentials (username and password) for 
+  # Contains credentials (username and password) for
   # the Alpha Card Gateway API access.
   class Account < AlphaCardObject
     attribute :username, String
@@ -42,7 +42,7 @@ module AlphaCard
     #   #=> false
     def filled?
       attrs = [username, password]
-      !attrs.empty? && attrs.all? {|attr| attr && !attr.strip.empty? }
+      !attrs.empty? && attrs.all? { |attr| attr && !attr.strip.empty? }
     end
   end
-end
+end

data/lib/alpha_card/alpha_card_object.rb

@@ -18,7 +18,7 @@ module AlphaCard
     #
     #   #=> {orderid: '1', ponumber: 'PO123'}
     def filled_attributes
-      self.attributes.select { |_, value| !value.nil? }
+      attributes.select { |_, value| !value.nil? }
     end
   end
-end
+end

data/lib/alpha_card/alpha_card_response.rb

@@ -128,4 +128,4 @@ module AlphaCard
       @data['response'] == ERROR
     end
   end
-end
+end

data/lib/alpha_card/billing.rb

@@ -17,4 +17,4 @@ module AlphaCard
     attribute :fax, String
     attribute :website, String
   end
-end
+end

data/lib/alpha_card/order.rb

@@ -12,4 +12,4 @@ module AlphaCard
     attribute :billing, AlphaCard::Billing
     attribute :shipping, AlphaCard::Shipping
   end
-end
+end

data/lib/alpha_card/sale.rb

@@ -41,13 +41,15 @@ module AlphaCard
     #   #=> true
     def create(order, account)
       [:ccexp, :ccnumber, :amount].each do |attr|
-        raise Exception.new("No #{attr} information provided") if self[attr].nil? || self[attr].empty?
+        fail Exception, "No #{attr} information provided" if self[attr].nil? || self[attr].empty?
       end
 
-      params = self.filled_attributes || {}
-      [order, order.billing, order.shipping].compact.each { |obj| params.merge!(obj ? obj.filled_attributes : {}) }
+      params = filled_attributes || {}
+      [order, order.billing, order.shipping].compact.each do |obj|
+        params.merge!(obj ? obj.filled_attributes : {})
+      end
 
       AlphaCard.request(params, account).success?
     end
   end
-end
+end

data/lib/alpha_card/shipping.rb

@@ -16,7 +16,7 @@ module AlphaCard
 
     ##
     # Overloaded <code>filled_attributes</code> method from
-    # <code>AlphaCard::AlphaCardObject</code>. All attributes of
+    # <code>AlphaCard::AlphaCardObject</code>. All attribute names of
     # the Alpha Card Shipping object must start with "shipping_"
     # prefix.
     #
@@ -29,7 +29,7 @@ module AlphaCard
     #
     #   #=> {shipping_firstname: 'John', shipping_state: 'NY'}
     def filled_attributes
-      Hash[super.map {|k, v| ["shipping_#{k}".to_sym, v] }]
+      Hash[super.map { |k, v| ["shipping_#{k}".to_sym, v] }]
     end
   end
-end
+end

data/lib/alpha_card/utils.rb

@@ -40,7 +40,7 @@ module AlphaCard
       # Parse query string to a <code>Hash</code> by breaking it up
       # at the '&' and ';' characters.
       #
-      # @param [String] qs
+      # @param [String] query
       #   query string
       # @param [String] d
       #   delimiter for the params
@@ -56,12 +56,12 @@ module AlphaCard
       #
       #   query = AlphaCard::Utils.parse_query("cars[]=Saab&cars[]=Audi")
       #   #=> {"cars[]"=>["Saab", "Audi"]}
-      def parse_query(qs, d = nil, &unescaper)
+      def parse_query(query, d = nil, &unescaper)
         unescaper ||= method(:unescape)
 
         params = {}
 
-        (qs || '').split(d ? /[#{d}] */n : DEFAULT_SEP).each do |p|
+        (query || '').split(d ? /[#{d}] */n : DEFAULT_SEP).each do |p|
           next if p.empty?
           k, v = p.split('=', 2).map(&unescaper)
 
@@ -80,4 +80,4 @@ module AlphaCard
       end
     end
   end
-end
+end

data/lib/alpha_card/version.rb

@@ -1,5 +1,5 @@
 module AlphaCard
   ##
   # Version information for AlphaCard gem.
-  VERSION = '0.2.2'
-end
+  VERSION = '0.2.3'
+end

data/spec/alpha_card/alpha_card_account_spec.rb

@@ -15,4 +15,4 @@ describe AlphaCard::Account do
       expect(invalid_account.filled?).to be_falsey
     end
   end
-end
+end

data/spec/alpha_card/alpha_card_response_spec.rb

@@ -60,4 +60,4 @@ describe AlphaCard::AlphaCardResponse do
       expect(response.transaction_id).to eq('2302620041')
     end
   end
-end
+end

data/spec/alpha_card/alpha_card_spec.rb

@@ -111,4 +111,4 @@ describe AlphaCard do
       end
     end
   end
-end
+end

data/spec/alpha_card/alpha_card_utils_spec.rb

@@ -22,4 +22,4 @@ describe AlphaCard::Utils do
     expect(AlphaCard::Utils.unescape("a%20space")).to eq("a space")
     expect(AlphaCard::Utils.unescape("q1%212%22%27w%245%267%2Fz8%29%3F%5C")).to eq("q1!2\"'w$5&7/z8)?\\")
   end
-end
+end

data/spec/spec_helper.rb

@@ -8,4 +8,4 @@ require 'alpha_card'
 
 RSpec.configure do |config|
   config.order = 'random'
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alpha_card
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Nikita Bulaj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-11 00:00:00.000000000 Z
+date: 2014-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus