alpha_card 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6af86a7de326ef53708c81f07ed025792c44841c
-  data.tar.gz: 5a670c2177f9b7ac326f34ea1c3e34decd5ea37c
+  metadata.gz: 706d4fb925ed92b75aeb824e9ac0cb1353b4cd5e
+  data.tar.gz: ddd2530759a1516a3008c10635105acdb19d7782
 SHA512:
-  metadata.gz: ca0333c53125849ca415b73a10d9a4c659d54cff80879bc0f2aadd3aa502ffecc3af758ed87709ce83ba7016d57679b7a6f023f672952d7e9f3788fda29f7ad1
-  data.tar.gz: 0bea0ef881a98bd593a99a20883de46f2b94f1d6cf384caa39dbeaed8f95f53a99afa8855a22becba76f0e0f6b5ac90017263dda9d2473a4564e7938c525d7a9
+  metadata.gz: 35b50540e1457d8f9774307dcb7443d084c24ede72a009dca98430a265bb5a0dea4162b3fe9f7785a66c62dbdb2094c280a6fb164d08afd6d628515c30bca624
+  data.tar.gz: ee1eb394decc0933f881f4f8e9931ae083cb215b4d1a0d622d15befa0d361cbdbfefb1cdd7d3bdd63e8651317c428c11ed11ec9d733e9bff4e7910f61ecb967a

data/README.md

@@ -4,6 +4,7 @@
 [![Code Climate](https://codeclimate.com/github/budev/alpha_card.png)](https://codeclimate.com/github/budev/alpha_card)
 [![Coverage Status](https://coveralls.io/repos/budev/alpha_card/badge.png?branch=master)](https://coveralls.io/r/budev/alpha_card?branch=master)
 [![Build Status](https://travis-ci.org/budev/alpha_card.svg?branch=master)](https://travis-ci.org/budev/alpha_card)
+[![Inline docs](http://inch-ci.org/github/budev/alpha_card.png?branch=master)](http://inch-ci.org/github/budev/alpha_card)
 
 This gem can help your Ruby or Ruby on Rails application to integrate with Alpha Card Service, Inc.
 
@@ -37,7 +38,6 @@ gem install alpha_card
 Dependencies required:
 
 *   ruby >= 1.9.3;
-*   rack;
 *   rest_client;
 *   virtus (for nice OOP objects of AlphaCard).
 

data/alpha_card.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |gem|
   gem.name = 'alpha_card'
-  gem.version = '0.1.7'
-  gem.date = '2014-06-27'
+  gem.version = '0.1.8'
+  gem.date = '2014-07-01'
   gem.summary = 'Alpha Card Services DirectPost API for Ruby'
   gem.description = 'Gem for creating sales with Alpha Card Services DirectPost API'
   gem.authors = ['Nikita Bulaj']

data/lib/alpha_card.rb

@@ -4,7 +4,6 @@ require 'virtus'
 require 'rest_client'
 
 require 'alpha_card/utils'
-require 'alpha_card/object'
 require 'alpha_card/alpha_card_object'
 require 'alpha_card/alpha_card_response'
 require 'alpha_card/alpha_card_error'

data/lib/alpha_card/account.rb

@@ -41,7 +41,8 @@ module AlphaCard
     #
     #   #=> false
     def filled?
-      [self.username, self.password].all?(&:present?)
+      attrs = [username, password]
+      !attrs.empty? && attrs.all? {|attr| attr && !attr.strip.empty? }
     end
   end
 end

data/lib/alpha_card/alpha_card_object.rb

@@ -18,7 +18,7 @@ module AlphaCard
     #
     #   #=> {orderid: '1', ponumber: 'PO123'}
     def filled_attributes
-      self.attributes.select { |key, value| value.present? }
+      self.attributes.select { |_, value| !value.nil? }
     end
   end
 end

data/lib/alpha_card/order.rb

@@ -3,7 +3,7 @@ module AlphaCard
   # Implementation of Alpha Card Services Order object.
   # Contains all the information about order (id, description, etc).
   class Order < AlphaCardObject
-    attribute :orderid, Integer
+    attribute :orderid, String
     attribute :orderdescription, String
     attribute :ponumber, String
     attribute :tax, String

data/lib/alpha_card/sale.rb

@@ -41,11 +41,11 @@ module AlphaCard
     #   #=> true
     def create(order, account)
       [:ccexp, :ccnumber, :amount].each do |attr|
-        raise Exception.new("No #{attr} information provided") if self[attr].blank?
+        raise Exception.new("No #{attr} information provided") if self[attr].nil? || self[attr].empty?
       end
 
       params = self.filled_attributes || {}
-      [order, order.billing, order.shipping].compact.each { |obj| params.merge!(obj.try(:filled_attributes)) }
+      [order, order.billing, order.shipping].compact.each { |obj| params.merge!(obj ? obj.filled_attributes : {}) }
 
       AlphaCard.request(params, account).success?
     end

data/lib/alpha_card/utils.rb

@@ -8,7 +8,7 @@ module AlphaCard
     # @see https://github.com/rack/rack rack gem GitHub
     class << self
       ##
-      # Default separators for query string.
+      # Default separators for the query string.
       DEFAULT_SEP = /[&;] */n
 
       # A part of the rack gem.
@@ -29,10 +29,15 @@ module AlphaCard
           @params[key] = value
         end
 
+        ##
+        # Returns <code>true</code> if the given key is present
+        # in <i>params</i>.
         def key?(key)
           @params.key?(key)
         end
 
+        ##
+        # Converts params to <code>Hash</code> object.
         def to_params_hash
           hash = @params
           hash.keys.each do |key|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alpha_card
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Nikita Bulaj
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-27 00:00:00.000000000 Z
+date: 2014-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -45,7 +45,6 @@ files:
 - lib/alpha_card/alpha_card_response.rb
 - lib/alpha_card/billing.rb
 - lib/alpha_card/data/codes.yml
-- lib/alpha_card/object.rb
 - lib/alpha_card/order.rb
 - lib/alpha_card/sale.rb
 - lib/alpha_card/shipping.rb

data/lib/alpha_card/object.rb

@@ -1,52 +0,0 @@
-##
-# Some stolen methods from the active_support gem.
-# For the clear dependencies.
-# @todo Remove this class, rewrite library code
-class Object
-  # An object is blank if it's false, empty, or a whitespace string.
-  # For example, '', '   ', +nil+, [], and {} are all blank.
-  #
-  # This simplifies
-  #
-  #   address.nil? || address.empty?
-  #
-  # to
-  #
-  #   address.blank?
-  #
-  # @return [true, false]
-  def blank?
-    respond_to?(:empty?) ? !!empty? : !self
-  end
-
-  # An object is present if it's not blank.
-  #
-  # @return [true, false]
-  def present?
-    !blank?
-  end
-
-  # Invokes the public method whose name goes as first argument just like
-  # +public_send+ does, except that if the receiver does not respond to it the
-  # call returns +nil+ rather than raising an exception.
-  #
-  # This method is defined to be able to write
-  #
-  #   @person.try(:name)
-  #
-  # instead of
-  #
-  #   @person ? @person.name : nil
-  #
-  # +try+ returns +nil+ when called on +nil+ regardless of whether it responds
-  # to the method:
-  #
-  #   nil.try(:to_i) # => nil, rather than 0
-  def try(*a, &b)
-    if a.empty? && block_given?
-      yield self
-    else
-      public_send(*a, &b) if respond_to?(a.first)
-    end
-  end
-end