alpha_card 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8d1b3608b60661b5688717b2f96768ac0e36a83c
-  data.tar.gz: 8d0a9f755a5faa7802d36feac0828bd1d3877cc1
+  metadata.gz: 294f83e708f2952a60d2ecf8480ae58af870e368
+  data.tar.gz: 1fa31126072357beaed859e4415c03245a937e13
 SHA512:
-  metadata.gz: c752b3a03ce5299126ae280a3456d7d7507803e63a8c0bd0cca7dd3cffaa2ec34764694da072d962658666d7b876231ba3b026a27d99554edbfb87d075729d9b
-  data.tar.gz: 531987ff7b2dcf6555e29816eccd92394bbf6d1577219064e321020a6a75713d8c37c7037e1a117a8d77ef5c7f184f6ab6a7834108676467419bf1970cdb92b0
+  metadata.gz: 6c715932f21918d1914c83df62fd8a96e963b5a322c20da13b7facc00efc60cb8353ca6be255f403d0b684cb5db91fb4b92f623026adb7bdafb2a415ea54bb56
+  data.tar.gz: 1e091ed0479b8d61741f7cd37fea94f2b58ef6f5c34403743d4bd846d8e985080628ecd82a04b22fa15ffff96e0a150cb88c1a4a9daca67c24cd5a34b7dab988

data/.gitignore

@@ -0,0 +1 @@
+Gemfile.lock

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--format documentation

data/Gemfile

@@ -3,4 +3,6 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'virtus'
-gem 'rest_client'
+gem 'rest_client'
+gem 'rack'
+#gem 'simplecov', :require => false

data/README.md

@@ -1,5 +1,5 @@
 # Ruby lib for creating payments with AlphaCard DirectPost API
-[![Gem Version](https://badge.fury.io/rb/alpha_card.png)](http://badge.fury.io/rb/alpha_card)
+[![Gem Version](https://badge.fury.io/rb/alpha_card.svg)](http://badge.fury.io/rb/alpha_card)
 [![Dependency Status](https://gemnasium.com/budev/alpha_card.png)](https://gemnasium.com/budev/alpha_card)
 
 This gem can help your ruby/rails application to integrate with AlphaCard service.
@@ -212,6 +212,23 @@ Example of exception:
 AlphaCard::AlphaCardError: Invalid Credit Card Number REFID:127145481
 ```
 
+## Contributing
+
+You are very welcome to help improve alpha_card if you have suggestions for features that other people can use.
+
+To contribute:
+
+1. Fork the project
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Make your changes
+4. Add tests
+5. Run `rake` to make sure all tests pass
+6. Commit your changes (`git commit -am 'Add new feature'`)
+7. Push to the branch (`git push origin my-new-feature`)
+8. Create new pull request
+
+Thanks.
+
 ## Copyright
 
 Copyright (c) 2014 Nikita Bulaj (bulajnikita@gmail.com).

data/Rakefile

@@ -0,0 +1,6 @@
+require 'bundler/gem_tasks'
+
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/alpha_card.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name = 'alpha_card'
-  gem.version = '0.1.4'
+  gem.version = '0.1.5'
   gem.date = '2014-06-25'
   gem.summary = 'Alpha Card Services DirectPost API for Ruby'
   gem.description = 'Gem for creating sales with Alpha Card Services DirectPost API'
@@ -11,4 +11,6 @@ Gem::Specification.new do |gem|
   gem.homepage = 'http://github.com/budev/alpha_card'
   gem.license = 'MIT'
   gem.required_ruby_version = '>= 1.9.3'
+
+  gem.add_development_dependency "rspec", '~> 3'
 end

data/lib/alpha_card.rb

@@ -19,7 +19,7 @@ module AlphaCard
   @api_base = 'https://secure.alphacardgateway.com/api/transact.php'
 
   # Global Payment Systems (NDC) Credit Card Authorization Codes
-  CREDIT_CARD_CODES = YAML.load_file(File.expand_path('../alpha_card/data/codes.yml',  __FILE__)) unless defined? CREDIT_CARD_CODES
+  CREDIT_CARD_CODES = YAML.load_file(File.expand_path('../alpha_card/data/codes.yml', __FILE__)) unless defined? CREDIT_CARD_CODES
 
   class << self
     attr_accessor :api_base
@@ -38,10 +38,14 @@ module AlphaCard
       raise AlphaCardError.new('You must set credentials to create the sale!')
     end
 
-    response = RestClient.post(@api_base, params.merge(account.attributes))
+    begin
+      response = RestClient.post(@api_base, params.merge(account.attributes))
+    rescue => e
+      handle_connection_errors(e)
+    end
 
     alpha_card_response = AlphaCardResponse.new(response.to_str)
-    handle_errors(alpha_card_response)
+    handle_alpha_card_errors(alpha_card_response)
 
     alpha_card_response
   end
@@ -56,9 +60,34 @@ module AlphaCard
   #
   #    response = AlphaCard.request(params, account)
   #    handle_errors(response) #=> nil or Exception
-  def self.handle_errors(response)
+  def self.handle_alpha_card_errors(response)
     code = response.text
     raise AlphaCardError.new(CREDIT_CARD_CODES[code] || code) unless response.success?
   end
+
+  # AlphaCard.handle_connection_errors(exception) -> Exception
+  #
+  # Raise an exception if AlphaCard Gateway return some exception
+  # due to connection problems or some other net errors.
+  #
+  #    response = RestClient.post(URL, {param: 'value'})
+  #    handle_connection_errors(response) #=> Exception
+  def self.handle_connection_errors(e)
+    case e
+      when RestClient::ServerBrokeConnection, RestClient::RequestTimeout
+        message = "Could not connect to Alpha Card Gateway (#{@api_base}). " +
+            'Please check your internet connection and try again. ' +
+            'If this problem persists, you should check Alpha Card services status.'
+
+      when SocketError
+        message = 'Unexpected error communicating when trying to connect to Alpha Card Gateway. ' +
+            'You may be seeing this message because your DNS is not working.'
+
+      else
+        message = 'Unexpected error communicating with Alpha Card Gateway.'
+    end
+
+    raise AlphaCardError.new(message + "\n\n(Network error: #{e.message})")
+  end
 end
 

data/spec/alpha_card/alpha_card_response_spec.rb

@@ -0,0 +1,63 @@
+require "spec_helper"
+
+describe AlphaCard::AlphaCardResponse do
+  let!(:successful_response_mock) {
+    "authcode=083319&avsresponse=&cvvresponse=M&orderid=1&response=1&response_code=100&responsetext=AP&transactionid=2303767426&type=sale"
+  }
+
+  let!(:declined_response_mock) {
+    "authcode=&avsresponse=&cvvresponse=&orderid=1&response=2&response_code=220&responsetext=INVLD+ACCT&transactionid=2302720045&type=sale"
+  }
+
+  let!(:error_response_mock) {
+    "authcode=&avsresponse=&cvvresponse=&orderid=1&response=3&response_code=220&responsetext=ERROR&transactionid=2302620041&type=sale"
+  }
+
+  context 'successful request' do
+    let!(:response) { AlphaCard::AlphaCardResponse.new(successful_response_mock) }
+
+    it 'should be success' do
+      expect(response.success?).to be_truthy
+    end
+
+    it 'should return responce code' do
+      expect(response.code).to eq('100')
+    end
+
+    it 'should return transaction id' do
+      expect(response.transaction_id).to eq('2303767426')
+    end
+  end
+
+  context 'declined request' do
+    let!(:response) { AlphaCard::AlphaCardResponse.new(declined_response_mock) }
+
+    it 'should be declined' do
+      expect(response.declined?).to be_truthy
+    end
+
+    it 'should return responce code' do
+      expect(response.code).to eq('220')
+    end
+
+    it 'should return transaction id' do
+      expect(response.transaction_id).to eq('2302720045')
+    end
+  end
+
+  context 'error request' do
+    let!(:response) { AlphaCard::AlphaCardResponse.new(error_response_mock) }
+
+    it 'should be error' do
+      expect(response.error?).to be_truthy
+    end
+
+    it 'should return responce code' do
+      expect(response.code).to eq('220')
+    end
+
+    it 'should return transaction id' do
+      expect(response.transaction_id).to eq('2302620041')
+    end
+  end
+end

data/spec/alpha_card/alpha_card_spec.rb

@@ -0,0 +1,106 @@
+require "spec_helper"
+
+describe AlphaCard do
+  # Shared objects
+  let!(:account) { AlphaCard::Account.new('demo', 'password') }
+  let!(:billing) { AlphaCard::Billing.new({email: 'test@example.com'}) }
+  let!(:shipping) { AlphaCard::Shipping.new({address_1: '22 N str.'}) }
+  let!(:order) { AlphaCard::Order.new({orderid: '1', billing: billing, shipping: shipping}) }
+  let!(:card_exp) { "#{'%02d' % Time.now.month}/#{Time.now.year.next}" }
+
+  #TODO: Create rest client mock to imitate requests, normal tests for error exceptions
+
+  context 'With valid attributes' do
+    let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: '4111111111111111', amount: '5.00'}) }
+
+    it 'should successfully create the sale' do
+      expect(sale.create(order, account)).to be_truthy
+    end
+  end
+
+  context 'With invalid Card number' do
+    let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: 'Invalid', amount: '5.00'}) }
+
+    it 'should raise an AlphaCardError' do
+      expect { sale.create(order, account) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('Card number must contain only digits')
+      end
+    end
+  end
+
+  context 'With invalid amount' do
+    let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: '4111111111111111', amount: '0.00'}) }
+
+    it 'should raise an AlphaCardError' do
+      expect { sale.create(order, account) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('Invalid amount')
+      end
+    end
+  end
+
+  context 'With invalid Card expiration date' do
+    let!(:sale) { AlphaCard::Sale.new({ccexp: 'Invalid', ccnumber: '4111111111111111', amount: '5.00'}) }
+
+    it 'should raise an AlphaCardError' do
+      expect { sale.create(order, account) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('Card expiration should be in the format')
+      end
+    end
+  end
+
+  context 'With invalid Card CVV' do
+    let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, cvv: 'Invalid', ccnumber: '4111111111111111', amount: '5.00'}) }
+
+    it 'should raise an AlphaCardError' do
+      expect { sale.create(order, account) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('CVV must be')
+      end
+    end
+  end
+
+  context 'With invalid account credentials' do
+    let!(:invalid_account) { AlphaCard::Account.new('demo', 'Invalid password') }
+    let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: '4111111111111111', amount: '5.00'}) }
+
+    it 'should raise an AlphaCardError' do
+      expect { sale.create(order, invalid_account) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('Authentication Failed')
+      end
+    end
+  end
+
+  context 'With blank account credentials' do
+    let!(:blank_account) { AlphaCard::Account.new(nil, '') }
+    let!(:sale) { AlphaCard::Sale.new({ccexp: card_exp, ccnumber: '4111111111111111', amount: '5.00'}) }
+
+    it 'should raise an AlphaCardError' do
+      expect { sale.create(order, blank_account) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('You must set credentials to create the sale')
+      end
+    end
+  end
+
+  context 'With connection errors' do
+    let!(:rest_client_error) { RestClient::RequestTimeout.new }
+    let!(:socket_error) { SocketError.new }
+    let!(:unclassified_error) { StandardError.new('Some error') }
+
+    it 'should raise an Exception if Rest Client Error' do
+      expect { AlphaCard.handle_connection_errors(rest_client_error) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('Could not connect to Alpha Card Gateway')
+      end
+    end
+
+    it 'should raise an Exception if Socket Error' do
+      expect { AlphaCard.handle_connection_errors(socket_error) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('Unexpected error communicating when trying to connect to Alpha Card Gateway')
+      end
+    end
+
+    it 'should raise an Exception if Unclassified Error' do
+      expect { AlphaCard.handle_connection_errors(unclassified_error) }.to raise_error(AlphaCard::AlphaCardError) do |e|
+        expect(e.message).to include('Unexpected error communicating with Alpha Card Gateway')
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,12 @@
+# Uncomment for coverage statistics
+# require 'simplecov'
+# SimpleCov.start
+
+require 'bundler/setup'
+Bundler.setup
+
+require 'alpha_card'
+
+RSpec.configure do |config|
+  config.order = 'random'
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alpha_card
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Nikita Bulaj
@@ -9,16 +9,33 @@ autorequire:
 bindir: bin
 cert_chain: []
 date: 2014-06-25 00:00:00.000000000 Z
-dependencies: []
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3'
 description: Gem for creating sales with Alpha Card Services DirectPost API
 email: bulajnikita@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE
 - README.md
+- Rakefile
 - alpha_card.gemspec
 - lib/alpha_card.rb
 - lib/alpha_card/account.rb
@@ -31,6 +48,9 @@ files:
 - lib/alpha_card/order.rb
 - lib/alpha_card/sale.rb
 - lib/alpha_card/shipping.rb
+- spec/alpha_card/alpha_card_response_spec.rb
+- spec/alpha_card/alpha_card_spec.rb
+- spec/spec_helper.rb
 homepage: http://github.com/budev/alpha_card
 licenses:
 - MIT