aloha_analyzer 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d289f940c1715018a7e9108125f9759b4ba59324
-  data.tar.gz: 30b91b3430356376349099aceafedfc5c8ae463a
+  metadata.gz: 677e72dae554f56e36e1746aa7fab53ab57937b6
+  data.tar.gz: 9d01dba6b8c5e08e1bd8c40e6684d3720421d0ab
 SHA512:
-  metadata.gz: 5bbb88cf518745ef0b3c8f84638444ca075806f730f6160f60dc6554edfb20db5a43a24d39e1bfd2222d4321838711953cbcc70552d7c9e62870e03930f4ca33
-  data.tar.gz: ae83dcf4cf74ab222ed8275c3e008d01102915e533899945cbe7aa19358b928988eb5ea0fa4b4220f4342422b71cf75a029078092fe15c24c01858772903a1ae
+  metadata.gz: bd40d6c868c4db0c3798124a5f5301513f4464ae16222fc73b1706cb5468eade1f5b363ca1bbafcd72102c9ef2561099e337447bf803c507b491b5da9ce76bdd
+  data.tar.gz: cb2beeefb013b4628a085d26703c2d941f38454635d47873fc0740249f195c9e5f32cc0df8967bd98864d3f9a154aebf85aa07de3605c155074509e79a9419cc

data/lib/aloha_analyzer/base.rb

@@ -75,10 +75,11 @@ module AlohaAnalyzer
     end
 
     def add_foreign_language_user(user)
-      prepare_foreign_language(user[language_key])
-      @analysis['foreign_languages'][user[language_key]]['count'] += 1
-      unless too_many_users?(@analysis['foreign_languages'][user[language_key]]['users'])
-        @analysis['foreign_languages'][user[language_key]]['users'].push(user)
+      abbreviation = Language.find_by_abbreviation(user[language_key], network_name)['abbreviation']
+      prepare_foreign_language(abbreviation)
+      @analysis['foreign_languages'][abbreviation]['count'] += 1
+      unless too_many_users?(@analysis['foreign_languages'][abbreviation]['users'])
+        @analysis['foreign_languages'][abbreviation]['users'].push(user)
       end
     end
 

data/lib/aloha_analyzer/version.rb

@@ -1,3 +1,3 @@
 module AlohaAnalyzer
-  VERSION = '0.6.1'
+  VERSION = '0.6.2'
 end

data/spec/aloha_analyzer/facebook_spec.rb

@@ -137,6 +137,38 @@ describe AlohaAnalyzer::Facebook do
           end
         end
 
+        context 'when unknown language' do
+          let(:users) do
+            [
+              {'id' => '1', 'locale' => 'unknown'},
+              {'id' => '2', 'locale' => 'something'},
+              {'id' => '3', 'locale' => 'en-GB'}
+            ]
+          end
+
+          it 'returns a hash' do
+            expect(subject).to be_a Hash
+          end
+
+          it 'includes the total count' do
+            expect(subject['count']).to eq 3
+          end
+
+          it 'includes the correct foreign_languages_count' do
+            expect(subject['foreign_languages_count']).to eq 2
+          end
+
+          it 'returns results results based on the non user language' do
+            expect(subject['foreign_languages']).to eq(
+                'other' => {
+                  'count'    => 2,
+                  'language' => {'abbreviation'=>'other', 'name'=>'Other', 'greeting'=>'', 'population'=>nil, 'countries' => '' },
+                  'users'=> [{'id'=>'1', 'locale'=>'unknown'}, {'id'=>'2', 'locale'=>'something'}]
+                }
+              )
+          end
+        end
+
         context 'when only user langugages users' do
           let(:users) {
             [

data/spec/aloha_analyzer/twitter_spec.rb

@@ -254,6 +254,38 @@ describe AlohaAnalyzer::Twitter do
             )
           end
         end
+
+        context 'when unknown language' do
+          let(:users) do
+            [
+              {'id' => '1', 'lang' => 'unknown'},
+              {'id' => '2', 'lang' => 'something'},
+              {'id' => '3', 'lang' => 'en-GB'}
+            ]
+          end
+
+          it 'returns a hash' do
+            expect(subject).to be_a Hash
+          end
+
+          it 'includes the total count' do
+            expect(subject['count']).to eq 3
+          end
+
+          it 'includes the correct foreign_languages_count' do
+            expect(subject['foreign_languages_count']).to eq 2
+          end
+
+          it 'returns results results based on the non user language' do
+            expect(subject['foreign_languages']).to eq(
+                'other' => {
+                  'count'    => 2,
+                  'language' => {'abbreviation'=>'other', 'name'=>'Other', 'greeting'=>'', 'population'=>nil, 'countries' => '' },
+                  'users'=> [{'id'=>'1', 'lang'=>'unknown'}, {'id'=>'2', 'lang'=>'something'}]
+                }
+              )
+          end
+        end
       end
 
       context 'when user limit per language' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aloha_analyzer
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Matthieu Aussaguel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-19 00:00:00.000000000 Z
+date: 2014-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: twitter_cldr