almodovar 1.5.3 → 1.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b0070e4a31dadf08f8c1c4419f1cf9adaae3cfb3
-  data.tar.gz: e7749dc727492f4362a89d9f7e8f374c336b4a28
+  metadata.gz: 85aa0a429ca1941cb1cdfb137f9f8955c69b8c9c
+  data.tar.gz: ea1145d5b1682a40c5a6371e275386bc3bb3a534
 SHA512:
-  metadata.gz: 2d368d1b28e8e011828ccaf01fa735facb74f012323b799c3b24c74baee7b6278606bc3689678b353c732b62d556a43ae1c8b2862eb517190c5019de61f1ed04
-  data.tar.gz: d8306c513cd1a59226374c935b2a34e4d0df44ca556082fe01963cb683ad7f7be6f257447d4678f3710b9d5d89846f42208e91ec802e5766e04cbdeff33694df
+  metadata.gz: ef21d0d38978ea475a591ea75ece12e6144c3fafe1ae2c200c56c34cd5ec0fa00c7dbf7c10797ca624c691eee486752e412dd9fc1cf7fc2a147d2e9d70428e1f
+  data.tar.gz: 65d3a7c15e6bb59b33ce3d1d6381d32af237898a6fcfa800fa02442dfb2ce9fb95c19cde5d114c942d8f38724778d7385d1c4a8403cd44e383212ae62e706ab3

data/README.rdoc

@@ -109,10 +109,23 @@ And exactly the same with the _delete_ method:
   => <job> ... </job>
   >> job.delete
 
+== Detailed error messages
+
+In case an incorrect _PUT/POST_ request fails with 422 response status, you can access list of errors using _error_messages_ method of Almodovar::UnprocessableEntityError:
+
+  >> collection_entry = Almodovar::Resource("http://sequence.example.com/api/collection_entries/12345", auth)
+  => <collection-entry> ... </collection-entry>
+  >> begin
+      collection_entry.update(:collection_entry => {:position => 3.2})
+     rescue Almodovar::UnprocessableEntityError => e
+       e.error_messages
+     end
+  => ["Position must be an integer"]
+
 ==To-do
 
 * Better error management
 * Write the conventions Almodovar expects in an API
 * Other authentication methods than digest
 
-Copyright (c) 2010 BeBanjo S.L., released under the MIT license
+Copyright (c) 2010 BeBanjo S.L., released under the MIT license

data/lib/almodovar/errors.rb

@@ -2,6 +2,7 @@ module Almodovar
   class HttpError < StandardError
     attr_reader :response_status, :response_body
 
+    # Children of this class must not override the initialize method
     def initialize(response, url)
       @response_status = response.status
       @response_body = response.body
@@ -20,4 +21,46 @@ module Almodovar
 
   class ConnectTimeoutError < TimeoutError
   end
+
+  class UnprocessableEntityError < HttpError
+    def errors?
+      error_messages.any?
+    end
+
+    # There are some different kind of errors in Almodovar servers
+    # "errors" => [{"error" => "wadus"}]
+    # "errors" => {"error" => ["wadus", "foo"]
+    # "error" => {"message" => "chaflan"}
+    #
+    # In case we cannot parse the response an empty array is returned
+    def error_messages
+      @error_messages ||= begin
+        if hash.key?('errors')
+          Array.wrap(hash['errors']).flat_map do |error|
+            error.is_a?(Hash) && error.key?('error') ? error['error'] : error.to_s
+          end
+        elsif hash.key?('error')
+          Array.wrap(hash['error'] && hash['error']['message'])
+        else
+          []
+        end
+      end
+    end
+
+    private
+
+    def hash
+      @hash ||= begin
+        Hash.from_xml(@response_body) || {}
+      rescue StandardError
+        # The expected errors depends on the ActiveSupport::XmlMini_parser used that it's REXML by default but there
+        # are other, so just rescue a generic error
+        {}
+      end
+    end
+  end
+
+  HTTP_ERRORS = {
+    422 => UnprocessableEntityError
+  }
 end

data/lib/almodovar/http_accessor.rb

@@ -31,7 +31,10 @@ module Almodovar
     end
 
     def check_errors(response, url)
-      raise(Almodovar::HttpError.new(response, url)) if response.status >= 400
+      if response.status >= 400
+        http_error_klass = Almodovar::HTTP_ERRORS[response.status] || Almodovar::HttpError
+        raise http_error_klass.new(response, url)
+      end
     end
   end
 end

data/lib/almodovar/version.rb

@@ -1,3 +1,3 @@
 module Almodovar
-  VERSION = '1.5.3'
+  VERSION = '1.5.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: almodovar
 version: !ruby/object:Gem::Version
-  version: 1.5.3
+  version: 1.5.4
 platform: ruby
 authors:
 - BeBanjo S.L.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-01 00:00:00.000000000 Z
+date: 2016-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -134,8 +134,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: BeBanjo API client
 test_files: []
+has_rdoc: