allscripts_unity_client 3.4.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58403ed28c5720a5561b2586e08f45a0b4e94674
-  data.tar.gz: 5f7839227467a6f441cd79033529d5edfb708318
+  metadata.gz: 37f39f6c94937da70a53192060bb913051b67197
+  data.tar.gz: ea1f2091395c1fde998e0eb599cddd9f37822c39
 SHA512:
-  metadata.gz: 12454a2b06e5e7003afa26d1ccb3a67d9dd39f2f348682b5194e8837548d4d3348d5b561f2dde184ee86bee12e9f7e38b2d8dafa71a0aa578943f35a478bb825
-  data.tar.gz: 6598b9d73b4c62d7ab736a52917678530f9a7a621c50c4cd386bc51f921dac50f9620ad60d1c299c28e35087afd1aad0bf801c408e57122ffef5948217312c5a
+  metadata.gz: d769e28f027e5bed0601ed9614c517a619966dfcb2b7c89fb93211d5819492fcde6811f1f6893e2c1c29ef6fa04da7a017a51c60a68d8404d37cf791ae392b53
+  data.tar.gz: 7a04ede9be73ddd21c15d441c3669969ca4474e595da7ded59d266ee2a07e3264c66b654d44073c3fcd4f0b8ef0bf045dce547dd5ef34d97c42a7cdbdc093214

data/.gitignore

@@ -18,3 +18,4 @@ test/version_tmp
 tmp
 .idea
 logs
+*.swp

data/.rubocop.yml

@@ -0,0 +1,340 @@
+AllCops:
+  DisabledByDefault: true
+  DisplayCopNames: true
+  Exclude:
+    - 'bin/**/*'
+
+
+Style/AndOr:
+  Description: 'Use &&/|| instead of and/or.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-and-or-or'
+  Enabled: true
+  Exclude:
+    - 'lib/healthfinch/service/controller_base.rb'
+
+Style/DefWithParentheses:
+  Description: 'Use def with parentheses when there are arguments.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#method-parens'
+  Enabled: true
+
+Style/PreferredHashMethods:
+  Description: 'Checks for use of deprecated Hash methods.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#hash-key'
+  Enabled: true
+
+Style/DoubleNegation:
+  Description: 'Checks for uses of double negation (!!).'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-bang-bang'
+  Enabled: true
+  Exclude:
+    - 'lib/healthfinch/service/rspec/process_service_acceptance.rb'
+
+Layout/ElseAlignment:
+  Description: 'Align elses and elsifs correctly.'
+  Enabled: true
+
+Style/EmptyElse:
+  Description: 'Avoid empty else-clauses.'
+  Enabled: true
+
+Layout/EmptyLineBetweenDefs:
+  Description: 'Use empty lines between defs.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#empty-lines-between-methods'
+  Enabled: true
+
+Layout/EmptyLines:
+  Description: "Don't use several empty lines in a row."
+  Enabled: true
+
+Layout/EndOfLine:
+  Description: 'Use Unix-style line endings.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#crlf'
+  Enabled: true
+
+Layout/ExtraSpacing:
+  Description: 'Do not use unnecessary spacing.'
+  Enabled: true
+
+Naming/FileName:
+  Description: 'Use snake_case for source file names.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#snake-case-files'
+  Enabled: true
+
+Layout/IndentationConsistency:
+  Description: 'Keep indentation straight.'
+  Enabled: true
+
+Layout/IndentationWidth:
+  Description: 'Use 2 spaces for indentation.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#spaces-indentation'
+  Enabled: true
+
+Style/MethodCallWithoutArgsParentheses:
+  Description: 'Do not use parentheses for method calls with no arguments.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-args-no-parens'
+  Enabled: true
+
+Style/MethodDefParentheses:
+  Description: >-
+                 Checks if the method definitions have or don't have
+                 parentheses.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#method-parens'
+  Enabled: true
+
+Naming/MethodName:
+  Description: 'Use the configured style when naming methods.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#snake-case-symbols-methods-vars'
+  Enabled: true
+
+Style/NestedTernaryOperator:
+  Description: 'Use one expression per branch in a ternary operator.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-nested-ternary'
+  Enabled: true
+
+Style/NilComparison:
+  Description: 'Prefer x.nil? to x == nil.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#predicate-methods'
+  Enabled: true
+
+Style/NonNilCheck:
+  Description: 'Checks for redundant nil checks.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-non-nil-checks'
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Description: 'Put a space before the modifier keyword.'
+  Enabled: true
+
+Layout/Tab:
+  Description: 'No hard tabs.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#spaces-indentation'
+  Enabled: true
+
+Layout/TrailingBlankLines:
+  Description: 'Checks trailing blank lines and final newline.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#newline-eof'
+  Enabled: true
+
+Layout/TrailingWhitespace:
+  Description: 'Avoid trailing whitespace.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-whitespace'
+  Enabled: true
+
+Style/UnlessElse:
+  Description: >-
+                 Do not use unless with else. Rewrite these with the positive
+                 case first.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-else-with-unless'
+  Enabled: true
+
+Naming/VariableName:
+  Description: 'Use the configured style when naming variables.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#snake-case-symbols-methods-vars'
+  Enabled: true
+
+#################### Lint ################################
+### Warnings
+
+Lint/AmbiguousOperator:
+  Description: >-
+                 Checks for ambiguous operators in the first argument of a
+                 method invocation without parentheses.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#parens-as-args'
+  Enabled: true
+
+Lint/AmbiguousRegexpLiteral:
+  Description: >-
+                 Checks for ambiguous regexp literals in the first argument of
+                 a method invocation without parenthesis.
+  Enabled: true
+
+Lint/AssignmentInCondition:
+  Description: "Don't use assignment in conditions."
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition'
+  Enabled: true
+
+Lint/BlockAlignment:
+  Description: 'Align block ends correctly.'
+  Enabled: true
+
+Lint/CircularArgumentReference:
+  Description: "Don't refer to the keyword argument in the default value."
+  Enabled: true
+
+Lint/ConditionPosition:
+  Description: >-
+                 Checks for condition placed in a confusing position relative to
+                 the keyword.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#same-line-condition'
+  Enabled: true
+
+Lint/Debugger:
+  Description: 'Check for debugger calls.'
+  Enabled: true
+
+Lint/DefEndAlignment:
+  Description: 'Align ends corresponding to defs correctly.'
+  Enabled: true
+
+Lint/DeprecatedClassMethods:
+  Description: 'Check for deprecated class method calls.'
+  Enabled: true
+
+Lint/DuplicateMethods:
+  Description: 'Check for duplicate methods calls.'
+  Enabled: true
+
+Lint/DuplicatedKey:
+  Description: 'Check for duplicate keys in hash literals.'
+  Enabled: true
+
+Lint/EachWithObjectArgument:
+  Description: 'Check for immutable argument given to each_with_object.'
+  Enabled: true
+
+Lint/ElseLayout:
+  Description: 'Check for odd code arrangement in an else block.'
+  Enabled: true
+
+Lint/EmptyEnsure:
+  Description: 'Checks for empty ensure block.'
+  Enabled: true
+
+Lint/EmptyInterpolation:
+  Description: 'Checks for empty string interpolation.'
+  Enabled: true
+
+Lint/EndAlignment:
+  Description: 'Align ends correctly.'
+  Enabled: true
+
+Lint/EndInMethod:
+  Description: 'END blocks should not be placed inside method definitions.'
+  Enabled: true
+
+Lint/EnsureReturn:
+  Description: 'Do not use return in an ensure block.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-return-ensure'
+  Enabled: true
+
+Security/Eval:
+  Description: 'The use of eval represents a serious security risk.'
+  Enabled: true
+
+Lint/FormatParameterMismatch:
+  Description: 'The number of parameters to format/sprint must match the fields.'
+  Enabled: true
+
+Lint/HandleExceptions:
+  Description: "Don't suppress exception."
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions'
+  Enabled: true
+
+Lint/LiteralInCondition:
+  Description: 'Checks of literals used in conditions.'
+  Enabled: true
+
+Lint/LiteralInInterpolation:
+  Description: 'Checks for literals used in interpolation.'
+  Enabled: true
+
+Lint/Loop:
+  Description: >-
+                 Use Kernel#loop with break rather than begin/end/until or
+                 begin/end/while for post-loop tests.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#loop-with-break'
+  Enabled: true
+
+Lint/NestedMethodDefinition:
+  Description: 'Do not use nested method definitions.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-nested-methods'
+  Enabled: true
+
+Lint/NonLocalExitFromIterator:
+  Description: 'Do not use return in iterator to cause non-local exit.'
+  Enabled: true
+
+Lint/ParenthesesAsGroupedExpression:
+  Description: >-
+                 Checks for method calls with a space before the opening
+                 parenthesis.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#parens-no-spaces'
+  Enabled: true
+
+Lint/RequireParentheses:
+  Description: >-
+                 Use parentheses in the method call to avoid confusion
+                 about precedence.
+  Enabled: true
+
+Lint/RescueException:
+  Description: 'Avoid rescuing the Exception class.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-blind-rescues'
+  Enabled: true
+
+Lint/ShadowingOuterLocalVariable:
+  Description: >-
+                 Do not use the same name as outer local variable
+                 for block arguments or block local variables.
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+  Description: >-
+                 Put a space between a method name and the first argument
+                 in a method call without parentheses.
+  Enabled: true
+
+Lint/StringConversionInInterpolation:
+  Description: 'Checks for Object#to_s usage in string interpolation.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-to-s'
+  Enabled: true
+
+Lint/UnderscorePrefixedVariableName:
+  Description: 'Do not use prefix `_` for a variable that is used.'
+  Enabled: true
+
+Lint/UnneededDisable:
+  Description: >-
+                 Checks for rubocop:disable comments that can be removed.
+                 Note: this cop is not disabled when disabling all cops.
+                 It must be explicitly disabled.
+  Enabled: true
+
+Lint/UnusedBlockArgument:
+  Description: 'Checks for unused block arguments.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars'
+  Enabled: true
+
+Lint/UnusedMethodArgument:
+  Description: 'Checks for unused method arguments.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars'
+  Enabled: true
+
+Lint/UnreachableCode:
+  Description: 'Unreachable code.'
+  Enabled: true
+
+Lint/UselessAccessModifier:
+  Description: 'Checks for useless access modifiers.'
+  Enabled: true
+
+Lint/UselessAssignment:
+  Description: 'Checks for useless assignment to a local variable.'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars'
+  Enabled: true
+
+Lint/UselessComparison:
+  Description: 'Checks for comparison of something with itself.'
+  Enabled: true
+
+Lint/UselessElseWithoutRescue:
+  Description: 'Checks for useless `else` in `begin..end` without `rescue`.'
+  Enabled: true
+
+Lint/UselessSetterCall:
+  Description: 'Checks for useless setter call to a local variable.'
+  Enabled: true
+
+Lint/Void:
+  Description: 'Possible use of operator/literal/variable in void context.'
+  Enabled: true

data/Gemfile

@@ -1,2 +1,2 @@
 source 'https://rubygems.org'
-gemspec
+gemspec

data/Rakefile

@@ -4,4 +4,4 @@ require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new
 
 task default: :spec
-task test: :spec
+task test: :spec

data/allscripts_unity_client.gemspec

@@ -22,18 +22,19 @@ Gem::Specification.new do |gem|
 
   gem.files = `git ls-files`.split("\n").delete_if { |file| /^\.ruby-version$/.match(file) }
 
-  gem.add_dependency 'httpclient', '~> 2.6'
-  gem.add_dependency 'activesupport', '>=3', '< 5'
+  gem.add_dependency 'httpclient', '~> 2.8'
+  gem.add_dependency 'activesupport', '>= 4', '< 5.0'
   gem.add_dependency 'nokogiri', '>= 1.4.0'
-  gem.add_dependency 'nori', '~> 2.4.0'
+  gem.add_dependency 'nori', '~> 2.6.0'
   gem.add_dependency 'american_date', '~> 1.1.0'
-  gem.add_dependency 'multi_json', '~> 1.0'
-  gem.add_dependency 'rubyntlm', '~> 0.4.0'
-
-  gem.add_development_dependency 'factory_girl', '~> 4.4.0'
-  gem.add_development_dependency 'rake', '~> 10.3.1'
-  gem.add_development_dependency 'faker', '~> 1.4.2'
-  gem.add_development_dependency 'rspec', '~> 3.0.0'
-  gem.add_development_dependency 'webmock', '~> 1.18.0'
-  gem.add_development_dependency 'simplecov', '~> 0.7.1'
+  gem.add_dependency 'multi_json', '~> 1.12'
+  gem.add_dependency 'rubyntlm', '~> 0.6.2'
+
+  gem.add_development_dependency 'factory_bot', '~> 4.8.0'
+  gem.add_development_dependency 'rake', '~> 12.2.1'
+  gem.add_development_dependency 'faker', '~> 1.8.4'
+  gem.add_development_dependency 'rspec', '~> 3.7.0'
+  gem.add_development_dependency 'webmock', '~> 3.1.0'
+  gem.add_development_dependency 'simplecov', '~> 0.15.1'
+  gem.add_development_dependency 'rubocop', '~> 0.51'
 end

data/lib/allscripts_unity_client/client_driver.rb

@@ -27,17 +27,17 @@ module AllscriptsUnityClient
     end
 
     # See Client#magic.
-    def magic(parameters = {})
+    def magic(_parameters = {})
       raise NotImplementedError, 'magic not implemented'
     end
 
     # See Client#get_security_token!.
-    def get_security_token!(parameters = {})
+    def get_security_token!(_parameters = {})
       raise NotImplementedError, 'get_security_token! not implemented'
     end
 
     # See Client#retire_security_token!.
-    def retire_security_token!(parameters = {})
+    def retire_security_token!(_parameters = {})
       raise NotImplementedError, 'retire_security_token! not implemented'
     end
 

data/lib/allscripts_unity_client/client_options.rb

@@ -38,10 +38,10 @@ module AllscriptsUnityClient
     #
     # See #initialize.
     def validate_options(options = {})
-      base_unity_url = options.has_key?(:base_unity_url) ? options[:base_unity_url] : @base_unity_url
-      username = options.has_key?(:username) ? options[:username] : @username
-      password = options.has_key?(:password) ? options[:password] : @password
-      appname = options.has_key?(:appname) ? options[:appname] : @appname
+      base_unity_url = options.fetch(:base_unity_url, @base_unity_url)
+      username = options.fetch(:username, @username)
+      password = options.fetch(:password, @password)
+      appname = options.fetch(:appname, @appname)
 
       raise ArgumentError, 'base_unity_url can not be nil' if base_unity_url.nil?
       raise ArgumentError, 'username can not be nil' if username.nil?
@@ -54,7 +54,7 @@ module AllscriptsUnityClient
     # Strips trailing slash for URL.
     def base_unity_url=(base_unity_url)
       validate_options(base_unity_url: base_unity_url)
-      @base_unity_url = base_unity_url.gsub /\/$/, ''
+      @base_unity_url = base_unity_url.gsub(/\/$/, '')
     end
 
     # Mutator for username.

data/lib/allscripts_unity_client/json_unity_request.rb

@@ -35,4 +35,4 @@ module AllscriptsUnityClient
       }
     end
   end
-end
+end

data/lib/allscripts_unity_client/json_unity_response.rb

@@ -26,4 +26,4 @@ module AllscriptsUnityClient
       Utilities::recursively_symbolize_keys(result)
     end
   end
-end
+end

data/lib/allscripts_unity_client/unity_request.rb

@@ -88,4 +88,4 @@ module AllscriptsUnityClient
       end
     end
   end
-end
+end

data/lib/allscripts_unity_client/unity_response.rb

@@ -115,4 +115,4 @@ module AllscriptsUnityClient
       response
     end
   end
-end
+end

data/lib/allscripts_unity_client/version.rb

@@ -1,3 +1,3 @@
 module AllscriptsUnityClient
-  VERSION = '3.4.1'.freeze
+  VERSION = '4.0.0'.freeze
 end

data/spec/client_spec.rb

@@ -51,18 +51,18 @@ describe AllscriptsUnityClient::Client do
 
   describe '#get_task_list' do
     it 'does stuff' do
-    subject.client_driver = double(magic: 'magic')
-    subject.get_task_list(123, Date.yesterday.strftime("%m/%d/%Y"),
-                          'Y', 'Something|okj', 'Ready|go')
-    magicified_parameters = {
-      action: 'GetTaskList',
-      userid: 123,
-      parameter1: Date.yesterday.strftime("%m/%d/%Y"),
-      parameter2: 'Something|okj',
-      parameter3: 'Ready|go',
-      parameter4: 'Y'
-    }
-    expect(subject.client_driver).to have_received(:magic).with(magicified_parameters)
+      subject.client_driver = double(magic: 'magic')
+      subject.get_task_list(123, Date.yesterday.strftime("%m/%d/%Y"),
+                            'Y', 'Something|okj', 'Ready|go')
+      magicified_parameters = {
+        action: 'GetTaskList',
+        userid: 123,
+        parameter1: Date.yesterday.strftime("%m/%d/%Y"),
+        parameter2: 'Something|okj',
+        parameter3: 'Ready|go',
+        parameter4: 'Y'
+      }
+      expect(subject.client_driver).to have_received(:magic).with(magicified_parameters)
     end
   end
 

data/spec/factories/allscripts_unity_client_parameters_factory.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :allscripts_unity_client_parameters, class: Hash do
     initialize_with { attributes }
 
@@ -12,5 +12,7 @@ FactoryGirl.define do
     ca_file nil
     ca_path nil
     timeout nil
+
+    skip_create
   end
-end
+end

data/spec/factories/client_driver_factory.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :client_driver, class: AllscriptsUnityClient::ClientDriver do
     initialize_with { new(attributes) }
 
@@ -14,5 +14,7 @@ FactoryGirl.define do
     timeout nil
 
     factory :json_client_driver, class: AllscriptsUnityClient::JSONClientDriver
+
+    skip_create
   end
 end

data/spec/factories/client_factory.rb

@@ -1,7 +1,9 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :client, class: AllscriptsUnityClient::Client do
     initialize_with { new(client_driver) }
 
     client_driver { build(:client_driver) }
+
+    skip_create
   end
-end
+end

data/spec/factories/client_options.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :client_options, class: AllscriptsUnityClient::ClientOptions do
     initialize_with { new(attributes) }
 
@@ -12,5 +12,7 @@ FactoryGirl.define do
     ca_file nil
     ca_path nil
     timeout nil
+
+    skip_create
   end
 end

data/spec/factories/magic_request_factory.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :magic_request, class: Hash do
     initialize_with { attributes }
 
@@ -14,6 +14,8 @@ FactoryGirl.define do
     parameter5 nil
     parameter6 nil
     data nil
+
+    skip_create
   end
 
   factory :populated_magic_request, parent: :magic_request do
@@ -29,5 +31,7 @@ FactoryGirl.define do
     parameter5 Faker::Internet.domain_word
     parameter6 Faker::Internet.domain_word
     data Faker::Internet.domain_word
+
+    skip_create
   end
-end
+end

data/spec/factories/unity_request_factory.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :unity_request, class: AllscriptsUnityClient::UnityRequest do
     initialize_with { new(parameters, timezone, appname, security_token) }
 
@@ -7,5 +7,7 @@ FactoryGirl.define do
     appname Faker::Name.name
     security_token SecureRandom.uuid
     factory :json_unity_request, class: AllscriptsUnityClient::JSONUnityRequest
+
+    skip_create
   end
-end
+end

data/spec/factories/unity_response_factory.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :unity_response, class: AllscriptsUnityClient::UnityResponse do
     initialize_with { new(response, timezone) }
 
@@ -6,5 +6,7 @@ FactoryGirl.define do
     timezone ActiveSupport::TimeZone['Etc/UTC']
 
     factory :json_unity_response, class: AllscriptsUnityClient::JSONUnityResponse
+
+    skip_create
   end
-end
+end

data/spec/json_unity_request_spec.rb

@@ -34,4 +34,4 @@ describe AllscriptsUnityClient::JSONUnityRequest do
       expect(subject.to_hash['Data']).to eq(['data'].pack('m'))
     end
   end
-end
+end

data/spec/json_unity_response_spec.rb

@@ -41,4 +41,4 @@ describe AllscriptsUnityClient::JSONUnityResponse do
       end
     end
   end
-end
+end

data/spec/spec_helper.rb

@@ -19,7 +19,7 @@ require 'rspec'
 require 'webmock/rspec'
 require 'securerandom'
 require 'faker'
-require 'factory_girl'
+require 'factory_bot'
 require 'json'
 
 # Include all support files

data/spec/support/factory_bot.rb

@@ -0,0 +1,10 @@
+# Include all factories
+FactoryBot.find_definitions
+
+RSpec.configure do |config|
+  config.include FactoryBot::Syntax::Methods
+
+  config.before(:suite) do
+    FactoryBot.lint
+  end
+end

data/spec/support/fixture_loader.rb

@@ -14,9 +14,7 @@ class FixtureLoader
     read(filename)
   end
 
-  private
-
   def self.read(filename)
     File.read(File.expand_path("../../fixtures/#{filename}", __FILE__))
   end
-end
+end

data/spec/support/shared_examples_for_unity_response.rb

@@ -23,4 +23,4 @@ shared_examples 'a unity response' do
       expect(subject.send(:convert_dates_to_utc, date_string_hash)).to eq(date_hash)
     end
   end
-end
+end

data/spec/unity_request_spec.rb

@@ -34,4 +34,4 @@ describe AllscriptsUnityClient::UnityRequest do
       expect(subject.to_hash['data']).to eq(['data'].pack('m'))
     end
   end
-end
+end

data/spec/unity_response_spec.rb

@@ -33,4 +33,4 @@ describe AllscriptsUnityClient::UnityResponse do
       end
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: allscripts_unity_client
 version: !ruby/object:Gem::Version
-  version: 3.4.1
+  version: 4.0.0
 platform: ruby
 authors:
 - healthfinch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-05 00:00:00.000000000 Z
+date: 2018-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -16,34 +16,34 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '2.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '2.8'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '4'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -64,14 +64,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.6.0
 - !ruby/object:Gem::Dependency
   name: american_date
   requirement: !ruby/object:Gem::Requirement
@@ -92,112 +92,126 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.12'
 - !ruby/object:Gem::Dependency
   name: rubyntlm
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.6.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.6.2
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.4.0
+        version: 4.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.4.0
+        version: 4.8.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.3.1
+        version: 12.2.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.3.1
+        version: 12.2.1
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.2
+        version: 1.8.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.2
+        version: 1.8.4
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: 3.7.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.18.0
+        version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.18.0
+        version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 0.15.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 0.15.1
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.51'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.51'
 description: Provides a simple interface to the Allscripts Unity API using JSON. Developed
   at healthfinch http://healthfinch.com
 email:
@@ -208,6 +222,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE
@@ -260,7 +275,7 @@ files:
 - spec/json_unity_request_spec.rb
 - spec/json_unity_response_spec.rb
 - spec/spec_helper.rb
-- spec/support/factory_girl.rb
+- spec/support/factory_bot.rb
 - spec/support/fixture_loader.rb
 - spec/support/shared_examples_for_client_driver.rb
 - spec/support/shared_examples_for_unity_request.rb
@@ -288,7 +303,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.2.1
 signing_key: 
 specification_version: 4
 summary: Allscripts Unity API client

data/spec/support/factory_girl.rb

@@ -1,10 +0,0 @@
-# Include all factories
-FactoryGirl.find_definitions
-
-RSpec.configure do |config|
-  config.include FactoryGirl::Syntax::Methods
-
-  config.before(:suite) do
-    FactoryGirl.lint
-  end
-end