allscripts_unity_client 3.4.0 → 3.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5b018d1ed24a0f4b028314d344ddda233cdae85e
-  data.tar.gz: a50e668f398d71abb9b9c2a634ece8009a97b929
+  metadata.gz: 58403ed28c5720a5561b2586e08f45a0b4e94674
+  data.tar.gz: 5f7839227467a6f441cd79033529d5edfb708318
 SHA512:
-  metadata.gz: f60b57a172e05271f9c68d9eeb4d9c04e10dbe17d16c9bba85e8e9a91f3435fd290b63d8d8d787a7f827489f0aa2caff61837c985f5e46dbf3451f622312bca4
-  data.tar.gz: c2e23be3758cce7f2568476132afafcc1140cea9b9453e225373fb0d4b61f9f383997405ab592a556412cbea4935cfa8816bd0faf137ece71fc51fa2a3652de2
+  metadata.gz: 12454a2b06e5e7003afa26d1ccb3a67d9dd39f2f348682b5194e8837548d4d3348d5b561f2dde184ee86bee12e9f7e38b2d8dafa71a0aa578943f35a478bb825
+  data.tar.gz: 6598b9d73b4c62d7ab736a52917678530f9a7a621c50c4cd386bc51f921dac50f9620ad60d1c299c28e35087afd1aad0bf801c408e57122ffef5948217312c5a

data/lib/allscripts_unity_client/client.rb

@@ -277,6 +277,17 @@ module AllscriptsUnityClient
       raise NotImplementedError, 'GetListOfDictionaries magic action not implemented'
     end
 
+    # @param [String] userid the Allscripts EHR username.
+    #
+    # @param [Numeric,String] patient_id the Allscripts internal patient ID.
+    #
+    # @param [Numeric,String] transaction_id the transaction ID of the
+    #   RX in question. M prefix=medication, H prefix=historic
+    #   medication.
+    #
+    # @return [Array] if {transaction_id} is either 0 or "0".
+    #
+    # @return [Hash] if {transaction_id} is not 0 or "0".
     def get_medication_by_trans_id(userid, patientid, transaction_id)
       magic_parameters = {
         action: 'GetMedicationByTransID',
@@ -299,6 +310,13 @@ module AllscriptsUnityClient
       result
     end
 
+    # @param [String] userid the Allscripts EHR username.
+    #
+    # @param [String] ddid the numeric drug identifier.
+    #
+    # @param [String] patientid the Allscripts internal patient ID.
+    #
+    # @return [Object]
     def get_medication_info(userid, ddid, patientid = nil)
       magic_parameters = {
         action: 'GetMedicationInfo',

data/lib/allscripts_unity_client/utilities.rb

@@ -18,18 +18,19 @@ module AllscriptsUnityClient
     #
     # Returns Date or ActiveSupport::TimeWithZone, or the string if it did not contain a date.
     def self.try_to_encode_as_date(timezone, possible_date)
-      if possible_date.nil?
-        return nil
-      end
-
-      if possible_date.is_a?(String) && possible_date =~ DATE_REGEX
-        return Date.parse(possible_date)
-      end
-
-      if possible_date.is_a?(String) && possible_date =~ DATETIME_REGEX
-        return timezone.parse(possible_date)
+      case possible_date
+      when DATE_REGEX
+        Date.parse(possible_date)
+      when DATETIME_REGEX
+        timezone.parse(possible_date)
+      else
+        possible_date
       end
-
+    # Since we know in either of the cases above we only attempt to
+    # parse a string this is either an "invalid date" from
+    # `Date.parse` or an "argument out of range" from
+    # `ActiveSupport::TimeZone#parse`.
+    rescue ArgumentError
       possible_date
     end
 

data/lib/allscripts_unity_client/version.rb

@@ -1,3 +1,3 @@
 module AllscriptsUnityClient
-  VERSION = '3.4.0'
+  VERSION = '3.4.1'.freeze
 end

data/spec/utilities_spec.rb

@@ -103,6 +103,15 @@ describe AllscriptsUnityClient::Utilities do
         expect(subject.try_to_encode_as_date(timezone, invalid_date_string_one)).to eq(invalid_date_string_one)
       end
     end
+
+    context 'when givn an valid date string that represents an invalid date' do
+      it 'it returns the string' do
+        date = "10/00/1999"
+        date_time = "10/00/1999 01:01:01"
+        expect(subject.try_to_encode_as_date(timezone, date)).to be(date)
+        expect(subject.try_to_encode_as_date(timezone, date_time)).to be(date_time)
+      end
+    end
   end
 
   describe '.encode_data' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: allscripts_unity_client
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.4.1
 platform: ruby
 authors:
 - healthfinch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-16 00:00:00.000000000 Z
+date: 2017-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient