allscripts_unity_client 2.0.2 → 2.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 78b65bf8597ab01389fb52af523a577324cf25af
-  data.tar.gz: 906619caa58558d76501a941e68d9f440e7bfeee
+  metadata.gz: 8a8ad6c24ee13b526a4712967fdcd5297da828de
+  data.tar.gz: 5aa6e846c1d5236c6f81c2c9f97d1566d6f2a4fc
 SHA512:
-  metadata.gz: 6d8287a426c5c4bed6e1aa8bb084d1d0e0e14e43c6983bbdbf92fc4eb27fca5528ff7ef02951a76289855cf9284cc2d97f8823d067f0c5dc7e9ebda1bc69cee2
-  data.tar.gz: 32e1e7798cbaf325d5cc2abd90fe70336216cf54e4d88444f7bc2ce285d8a9d0c836ac4ca8c561718f036cebf3b8d401095e1ffbd637dff2fb801177f40e49b4
+  metadata.gz: 47f75cbd115e5227ead22005ff18006b869b98815c25f9868d8c59ee0189f1dfdd3ab12c360e26c1a5e5453894811cf0dccbefead528f2dab0b6e6a3da7ea888
+  data.tar.gz: 96a3a111d967cc60fbfbabc62314d6334b64856979382dd8c451837aba12773998e20f03eaa9ad6973eef6937bf3441727a6f085510b308a3d9e1c03dffc32cd

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2013 healthfinch, Inc
+Copyright (c) 2014 healthfinch, Inc
 
 MIT License
 

data/README.md

@@ -317,11 +317,11 @@ The above example would output the following `Hash`:
 
 ## Additional Information
 
-Maintainer(s):  Ash Gupta (https://github.com/incomethax), Neil Goodman (https://github.com/posco2k8)
+Maintainer(s): Neil Goodman (https://github.com/posco2k8)
 
 ## License
 
-Copyright (c) 2013 healthfinch, Inc
+Copyright (c) 2014 healthfinch, Inc
 
 MIT License
 

data/lib/allscripts_unity_client/client_options.rb

@@ -1,20 +1,21 @@
 module AllscriptsUnityClient
   class ClientOptions
-    attr_accessor :proxy, :logger
-    attr_reader :base_unity_url, :username, :password, :appname, :timezone, :ca_file, :ca_path, :timeout
+    attr_accessor :proxy, :logger, :ca_file, :ca_path, :timeout
+    attr_reader :base_unity_url, :username, :password, :appname, :timezone
 
     def initialize(options = {})
-      @base_unity_url = options[:base_unity_url] ? options[:base_unity_url].gsub(/\/$/, '') : nil
       @username = options[:username]
       @password = options[:password]
       @appname = options[:appname]
       @proxy = options[:proxy]
-      self.timezone = options[:timezone]
       @logger = options[:logger]
       @ca_file = options[:ca_file]
       @ca_path = options[:ca_path]
       @timeout = options[:timeout]
 
+      self.timezone = options[:timezone]
+      self.base_unity_url = options[:base_unity_url]
+
       validate_options
     end
 
@@ -59,9 +60,7 @@ module AllscriptsUnityClient
     end
 
     def proxy?
-      return false if @proxy.nil?
-      return false if @proxy.empty?
-      true
+      !@proxy.to_s.strip.empty?
     end
 
     def logger?
@@ -69,21 +68,15 @@ module AllscriptsUnityClient
     end
 
     def ca_file?
-      return false if @ca_file.nil?
-      return false if @ca_file.empty?
-      true
+      !@ca_file.to_s.strip.empty?
     end
 
     def ca_path?
-      return false if @ca_path.nil?
-      return false if @ca_path.empty?
-      true
+      !@ca_path.to_s.strip.empty?
     end
 
     def timeout?
-      return false if @timeout.nil?
-      return false if @timeout.empty?
-      true
+      !@timeout.to_s.strip.empty?
     end
   end
 end

data/lib/allscripts_unity_client/version.rb

@@ -1,3 +1,3 @@
 module AllscriptsUnityClient
-  VERSION = '2.0.2'
+  VERSION = '2.0.3'
 end

data/spec/client_options_spec.rb

@@ -10,14 +10,6 @@ describe 'ClientOptions' do
   let(:america_los_angeles_timezone) { AllscriptsUnityClient::Timezone.new('America/Los_Angeles') }
   let(:client_options_hash) { { base_unity_url: 'http://www.example.com', username: 'username', password: 'password', appname: 'appname', proxy: 'proxy', timezone: 'UTC', logger: nil } }
 
-  describe '#initialize' do
-    context 'when given a base_unity_url that ends in a slash (/)' do
-      it 'strips the slash' do
-        expect(build(:client_options, base_unity_url: url_with_slash).base_unity_url).to eq(url_without_slash)
-      end
-    end
-  end
-
   describe '#validate_options' do
     context 'when not given base_unity_url' do
       it { expect { build(:client_options, base_unity_url: nil) }.to raise_error(ArgumentError) }
@@ -131,4 +123,63 @@ describe 'ClientOptions' do
       end
     end
   end
+
+  describe '#ca_file?' do
+    context 'when ca_file is nil' do
+      it 'returns false' do
+        expect(subject.ca_file?).to be_falsey
+      end
+    end
+
+    context 'when ca_file is not nil' do
+      it 'returns true' do
+        subject.ca_file = 'test_file'
+        expect(subject.ca_file?).to be_truthy
+      end
+    end
+
+    context 'when ca_file is empty string' do
+      it 'returns false' do
+        subject.ca_file = ''
+        expect(subject.ca_file?).to be_falsey
+      end
+    end
+  end
+
+  describe '#ca_path?' do
+    context 'when ca_path is nil' do
+      it 'returns false' do
+        expect(subject.ca_path?).to be_falsey
+      end
+    end
+
+    context 'when ca_path is not nil' do
+      it 'returns true' do
+        subject.ca_path = 'test_path'
+        expect(subject.ca_path?).to be_truthy
+      end
+    end
+
+    context 'when ca_path is empty string' do
+      it 'returns false' do
+        subject.ca_path = ''
+        expect(subject.ca_path?).to be_falsey
+      end
+    end
+  end
+
+  describe '#timeout?' do
+    context 'when timeout is nil' do
+      it 'returns false' do
+        expect(subject.timeout?).to be_falsey
+      end
+    end
+
+    context 'when timeout is not nil' do
+      it 'returns true' do
+        subject.timeout = 10
+        expect(subject.timeout?).to be_truthy
+      end
+    end
+  end
 end

data/spec/factories/allscripts_unity_client_parameters_factory.rb

@@ -6,8 +6,11 @@ FactoryGirl.define do
     username Faker::Name.name
     password Faker::Internet.password
     appname Faker::Name.name
-    mode [:json, :soap].sample
-    log false
+    proxy nil
+    timezone 'America/Phoenix'
     logger nil
+    ca_file nil
+    ca_path nil
+    timeout nil
   end
 end

data/spec/factories/client_driver_factory.rb

@@ -1,6 +1,6 @@
 FactoryGirl.define do
   factory :client_driver, class: AllscriptsUnityClient::ClientDriver do
-    initialize_with { new(base_unity_url: base_unity_url, username: username, password: password, appname: appname, proxy: proxy, timezone: timezone, logger: logger) }
+    initialize_with { new(attributes) }
 
     base_unity_url 'http://www.example.com'
     username Faker::Name.name
@@ -9,5 +9,8 @@ FactoryGirl.define do
     proxy nil
     timezone 'America/Phoenix'
     logger nil
+    ca_file nil
+    ca_path nil
+    timeout nil
   end
 end

data/spec/factories/client_options.rb

@@ -1,6 +1,6 @@
 FactoryGirl.define do
   factory :client_options, class: AllscriptsUnityClient::ClientOptions do
-    initialize_with { new(base_unity_url: base_unity_url, username: username, password: password, appname: appname, proxy: proxy, timezone: timezone, logger: logger) }
+    initialize_with { new(attributes) }
 
     base_unity_url 'http://www.example.com'
     username Faker::Name.name
@@ -9,5 +9,8 @@ FactoryGirl.define do
     proxy nil
     timezone 'America/Phoenix'
     logger nil
+    ca_file nil
+    ca_path nil
+    timeout nil
   end
 end

data/spec/factories/unity_response_factory.rb

@@ -2,7 +2,7 @@ FactoryGirl.define do
   factory :unity_response, class: AllscriptsUnityClient::UnityResponse do
     initialize_with { new(response, timezone) }
 
-    response {}
+    response Hash.new
     timezone { build(:timezone) }
   end
 end

data/spec/json_client_driver_spec.rb

@@ -138,4 +138,109 @@ describe 'JSONClientDriver' do
       it { expect { subject.send(:raise_if_response_error, error_string) }.to raise_error(AllscriptsUnityClient::APIError) }
     end
   end
+
+  describe '#build_faraday_options' do
+    context 'when given options with ca_file' do
+      it 'sets ca_file' do
+        client_driver = build(:json_client_driver, ca_file: 'test_file')
+        expect(client_driver.send(:build_faraday_options)[:ssl][:ca_file]).to eq('test_file')
+      end
+    end
+
+    context 'when given options with ca_path' do
+      it 'sets ca_path' do
+        client_driver = build(:json_client_driver, ca_path: 'test_path')
+        expect(client_driver.send(:build_faraday_options)[:ssl][:ca_path]).to eq('test_path')
+      end
+    end
+
+    context 'when given options with nil ca_file and ca_path' do
+      it 'calls JSONClientDriver.find_ca_file' do
+        allow(AllscriptsUnityClient::JSONClientDriver).to receive(:find_ca_file).and_return('/test/file')
+        expect(subject.send(:build_faraday_options)[:ssl][:ca_file]).to eq('/test/file')
+      end
+    end
+
+    context 'when given options with nil ca_file, ca_path, and JSONClientDriver.find_ca_file returns nil' do
+      it 'calls JSONClientDriver.find_ca_file' do
+        allow(AllscriptsUnityClient::JSONClientDriver).to receive(:find_ca_file).and_return(nil)
+        allow(AllscriptsUnityClient::JSONClientDriver).to receive(:find_ca_path).and_return('/test/path')
+        expect(subject.send(:build_faraday_options)[:ssl][:ca_path]).to eq('/test/path')
+      end
+    end
+  end
+
+  describe '.find_ca_path' do
+    context 'when Ubuntu certs path is found' do
+      it 'returns the Ubuntu certs path' do
+        allow(File).to receive(:directory?).with('/usr/lib/ssl/certs').and_return(true)
+        expect(AllscriptsUnityClient::JSONClientDriver.send(:find_ca_path)).to eq('/usr/lib/ssl/certs')
+      end
+    end
+
+    context 'when no certificate path is found' do
+      it 'returns nil' do
+        allow(File).to receive(:directory?).with('/usr/lib/ssl/certs').and_return(false)
+        expect(AllscriptsUnityClient::JSONClientDriver.send(:find_ca_path)).to be_nil
+      end
+    end
+  end
+
+  describe '.find_ca_file' do
+    context 'when OS X ca-bundle.crt found' do
+      it 'returns the ca-bundle.crt' do
+          allow(File).to receive(:exists?).with('/opt/boxen/homebrew/opt/curl-ca-bundle/share/ca-bundle.crt').and_return(true)
+          expect(AllscriptsUnityClient::JSONClientDriver.send(:find_ca_file)).to eq('/opt/boxen/homebrew/opt/curl-ca-bundle/share/ca-bundle.crt')
+      end
+    end
+
+    context 'when OS X curl-ca-bundle.crt found' do
+      it 'returns the curl-ca-bundle.crt' do
+        allow(File).to receive(:exists?).with('/opt/boxen/homebrew/opt/curl-ca-bundle/share/ca-bundle.crt').and_return(false)
+        allow(File).to receive(:exists?).with('/opt/local/share/curl/curl-ca-bundle.crt').and_return(true)
+        expect(AllscriptsUnityClient::JSONClientDriver.send(:find_ca_file)).to eq('/opt/local/share/curl/curl-ca-bundle.crt')
+      end
+    end
+
+    context 'when CentOS ca-certificates.crt found' do
+      it 'returns the curl-ca-bundle.crt' do
+        allow(File).to receive(:exists?).with('/opt/boxen/homebrew/opt/curl-ca-bundle/share/ca-bundle.crt').and_return(false)
+        allow(File).to receive(:exists?).with('/opt/local/share/curl/curl-ca-bundle.crt').and_return(false)
+        allow(File).to receive(:exists?).with('/usr/lib/ssl/certs/ca-certificates.crt').and_return(true)
+        expect(AllscriptsUnityClient::JSONClientDriver.send(:find_ca_file)).to eq('/usr/lib/ssl/certs/ca-certificates.crt')
+      end
+    end
+
+    context 'when no certificate file is found' do
+      it 'returns nil' do
+        allow(File).to receive(:exists?).with('/opt/boxen/homebrew/opt/curl-ca-bundle/share/ca-bundle.crt').and_return(false)
+        allow(File).to receive(:exists?).with('/opt/local/share/curl/curl-ca-bundle.crt').and_return(false)
+        allow(File).to receive(:exists?).with('/usr/lib/ssl/certs/ca-certificates.crt').and_return(false)
+        expect(AllscriptsUnityClient::JSONClientDriver.send(:find_ca_file)).to be_nil
+      end
+    end
+  end
+
+  describe '.set_request_timeout' do
+    context 'when given options with timeout set' do
+      it 'sets timeout and open_timeout on the request' do
+        client_driver = build(:json_client_driver, timeout: 10)
+        options = {}
+        request = double('request', options: options)
+        client_driver.send(:set_request_timeout, request)
+        expect(options[:timeout]).to eq(10)
+        expect(options[:open_timeout]).to eq(10)
+      end
+    end
+
+    context 'when given options without timeout set' do
+      it 'sets timeout and open_timeout to 90 on the request' do
+        options = {}
+        request = double('request', options: options)
+        subject.send(:set_request_timeout, request)
+        expect(options[:timeout]).to eq(90)
+        expect(options[:open_timeout]).to eq(90)
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,17 +1,21 @@
 require 'pathname'
 require 'simplecov'
-require 'coveralls'
+
+# Setup coveralls only if running inside Travis-CI
+if ENV['TRAVIS']
+  require 'coveralls'
+  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+    SimpleCov::Formatter::HTMLFormatter,
+    Coveralls::SimpleCov::Formatter
+  ]
+end
 
 # Configure coverage stats.
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
-  SimpleCov::Formatter::HTMLFormatter,
-  Coveralls::SimpleCov::Formatter
-]
 SimpleCov.start do
+  ignored_files = %w(version.rb allscripts_unity_client.gemspec Gemfile Rakefile)
+
   add_filter do |source_file|
     filename = Pathname.new(source_file.filename).basename
-    ignored_files = %w(version.rb allscripts_unity_client.gemspec Gemfile Rakefile)
-
     ignored_files.include?(filename) || source_file.filename.include?('spec/')
   end
 end
@@ -20,7 +24,6 @@ lib = File.expand_path('../lib/', __FILE__)
 $:.unshift lib unless $:.include?(lib)
 
 require 'allscripts_unity_client'
-
 require 'rspec'
 require 'webmock/rspec'
 require 'savon/mock/spec_helper'
@@ -32,9 +35,10 @@ require 'json'
 # Include all support files
 Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
 
-# Include all factories
-FactoryGirl.find_definitions
-
 RSpec.configure do |config|
-  config.include FactoryGirl::Syntax::Methods
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = "random"
 end

data/spec/support/factory_girl.rb

@@ -0,0 +1,10 @@
+# Include all factories
+FactoryGirl.find_definitions
+
+RSpec.configure do |config|
+  config.include FactoryGirl::Syntax::Methods
+
+  config.before(:suite) do
+    FactoryGirl.lint
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: allscripts_unity_client
 version: !ruby/object:Gem::Version
-  version: 2.0.2
+  version: 2.0.3
 platform: ruby
 authors:
 - Ash Gupta
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-01 00:00:00.000000000 Z
+date: 2014-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -283,6 +283,7 @@ files:
 - spec/json_unity_response_spec.rb
 - spec/soap_client_driver_spec.rb
 - spec/spec_helper.rb
+- spec/support/factory_girl.rb
 - spec/support/fixture_loader.rb
 - spec/support/shared_examples_for_client_driver.rb
 - spec/support/shared_examples_for_unity_request.rb