allscripts_unity_client 1.1.1 → 1.2.0

data/README.md

@@ -187,6 +187,11 @@ unity_client = AllscriptsUnityClient.create({
 })
 ```
 
+### Locale
+
+This gem uses the [american_date](http://rubygems.org/gems/american_date) gem to force `Date.parse` to
+accept USA locale dates by default. There are currently no plans to support other locales. Pull requests welcome.
+
 ## Examples
 
 ### GetServerInfo SOAP

data/allscripts_unity_client.gemspec

@@ -28,6 +28,7 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency "tzinfo", "~> 0.3.29"
   gem.add_runtime_dependency "nokogiri", "< 1.6", ">= 1.4.0"
   gem.add_runtime_dependency "nori", "~> 2.3.0"
+  gem.add_runtime_dependency "american_date", "~> 1.1.0"
 
   gem.add_development_dependency "factory_girl", "~> 4.2.0"
   gem.add_development_dependency "rake", "~> 10.1.0"

data/lib/allscripts_unity_client/utilities.rb

@@ -1,10 +1,11 @@
 require "nori"
 require "date"
+require "american_date"
 
 module AllscriptsUnityClient
   class Utilities
-    DATETIME_REGEX = /^((\d{1,2}[-\/]\d{1,2}[-\/]\d{4})|(\d{4}[-\/]\d{1,2}[-\/]\d{1,2})|([A-Za-z]{3,4} \d{1,2} \d{2,4}))(T| )\d{1,2}:\d{2}(:\d{2})?(\.\d+)? ?(PM|AM|pm|am)?((-|\+)\d{2}:?\d{2})?Z?$/
-    DATE_REGEX = /^((\d{1,2}[-\/]\d{1,2}[-\/]\d{4})|(\d{4}[-\/]\d{1,2}[-\/]\d{1,2})|(\d{1,2}-[A-Za-z]{3,4}-\d{4}))$/
+    DATETIME_REGEX = /^((\d{1,2}[-\/]\d{1,2}[-\/]\d{4})|(\d{4}[-\/]\d{1,2}[-\/]\d{1,2})|(\d{1,2}-[A-Za-z]{3,4}-\d{4})|([A-Za-z]{3,4} \d{1,2} \d{2,4}))(T| +)(\d{1,2}:\d{2}(:\d{2})?(\.\d+)? ?(PM|AM|pm|am)?((-|\+)\d{2}:?\d{2})?Z?)$/
+    DATE_REGEX = /^((\d{1,2}[-\/]\d{1,2}[-\/]\d{4})|(\d{4}[-\/]\d{1,2}[-\/]\d{1,2})|(\d{1,2}-[A-Za-z]{3,4}-\d{4})|([A-Za-z]{3,4} \d{1,2} \d{2,4}))$/
 
     def self.try_to_encode_as_date(possible_date)
       if possible_date.nil?

data/lib/allscripts_unity_client/version.rb

@@ -1,3 +1,3 @@
 module AllscriptsUnityClient
-  VERSION = "1.1.1"
+  VERSION = "1.2.0"
 end

data/spec/utilities_spec.rb

@@ -15,6 +15,17 @@ describe 'Utilities' do
   let(:string_keyed_hash) { FixtureLoader.load_yaml("string_keyed_hash.yml") }
   let(:symbol_keyed_hash) { FixtureLoader.load_yaml("symbol_keyed_hash.yml") }
 
+  let(:datetime_string_one) { 'Feb 27 2013 12:37PM' }
+  let(:datetime_string_two) { 'Feb 28 2013  1:34PM' }
+  let(:datetime_string_three) { '12/25/2013 12:37 PM' }
+  let(:datetime_one) { DateTime.parse(datetime_string_one) }
+  let(:datetime_two) { DateTime.parse(datetime_string_two) }
+  let(:datetime_three) { DateTime.parse(datetime_string_three) }
+  let(:date_string_one) { '20-Jul-2014' }
+  let(:date_string_two) { '12/25/2013' }
+  let(:date_one) { Date.parse(date_string_one) }
+  let(:date_two) { Date.parse(date_string_two) }
+
   describe '.try_to_encode_as_date' do
     context 'when given nil' do
       it { expect(subject.try_to_encode_as_date(nil)).to be_nil }
@@ -32,6 +43,36 @@ describe 'Utilities' do
       end
     end
 
+    context 'when given datetime_string_one' do
+      it 'returns the string as a DateTime' do
+        expect(subject.try_to_encode_as_date(datetime_string_one)).to eq(datetime_one)
+      end
+    end
+
+    context 'when given datetime_string_two' do
+      it 'returns the string as a DateTime' do
+        expect(subject.try_to_encode_as_date(datetime_string_two)).to eq(datetime_two)
+      end
+    end
+
+    context 'when given datetime_string_three' do
+      it 'returns the string as a DateTime' do
+        expect(subject.try_to_encode_as_date(datetime_string_three)).to eq(datetime_three)
+      end
+    end
+
+    context 'when given date_string_one' do
+      it 'returns the string as a Date' do
+        expect(subject.try_to_encode_as_date(date_string_one)).to eq(date_one)
+      end
+    end
+
+    context 'when given date_string_two' do
+      it 'returns the string as a Date' do
+        expect(subject.try_to_encode_as_date(date_string_two)).to eq(date_two)
+      end
+    end
+
     context 'when given a non-date string' do
       it 'returns that string' do
         expect(subject.try_to_encode_as_date(string)).to eq(string)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: allscripts_unity_client
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -114,6 +114,22 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.3.0
+- !ruby/object:Gem::Dependency
+  name: american_date
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: factory_girl
   requirement: !ruby/object:Gem::Requirement