allocation_tracer 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ec726b2a738166d01a261edd355fe34d8a727af
-  data.tar.gz: 4bcfe98dad9c2e41621992b780a60c419f710b70
+  metadata.gz: e1f129686d0942e7690ff66568f9af7f50f11148
+  data.tar.gz: fbc17e5b8358996aa55843c8632e15896d14f16d
 SHA512:
-  metadata.gz: 0c2195f1424ca3220e939519b79130a4baad68993643fd895d1c26433d313876738372232cdd12df1a673b6d248af736647d11c0d35ed2018996ee49dad6927d
-  data.tar.gz: 6a28c18f2c5a943c28cbde895f020dfe7cc8e4542c83bdf3d8b05058d7210d7ee6f3ff8fffcd055ed65e374bd9e5f88b82fb980747a02b2b9c873cef91997dec
+  metadata.gz: 886adb15a4f94f3fd9ed2815f9aee9fa524bf48aa853ceafb9bf2ff450a5dcd204ce8b8c483029ba78d1bc81f2124e7bb6662770d253e2aed58262c24a54e8ad
+  data.tar.gz: 69b0c17158f3f8af672296a4868c609a2f12c0c8b8d10d08b7d2309c6357b35b2b9f843986594c62bfad1549a62aeae12f90e9cfe3db3c299ee59f5001b07b00

data/README.md

@@ -26,7 +26,16 @@ Or install it yourself as:
 
 ### Allocation tracing
 
-You can trace allocation information and you can get aggregated information.
+You can trace allocation and aggregate information. Information includes:
+
+    count - how many objects are created.
+    total_age - total age of objects which created here
+    max_age - age of longest living object created here
+    min_age - age of shortest living object created here
+
+Age of Object can be calculated by this formula: [current GC count] - [birth time GC count]
+
+For example:
 
 ```ruby
 require 'allocation_tracer'

data/ext/allocation_tracer/allocation_tracer.c

@@ -15,7 +15,6 @@ struct allocation_info {
     int living;
     VALUE flags;
     VALUE klass;
-    const char *klass_path;
     size_t generation;
 
     /* allocation info */
@@ -188,7 +187,6 @@ static void
 free_allocation_info(struct traceobj_arg *arg, struct allocation_info *info)
 {
     delete_unique_str(arg->str_table, info->path);
-    delete_unique_str(arg->str_table, info->klass_path);
     ruby_xfree(info);
 }
 
@@ -199,12 +197,9 @@ newobj_i(VALUE tpval, void *data)
     struct allocation_info *info;
     rb_trace_arg_t *tparg = rb_tracearg_from_tracepoint(tpval);
     VALUE obj = rb_tracearg_object(tparg);
-    VALUE klass = RBASIC_CLASS(obj);
     VALUE path = rb_tracearg_path(tparg);
     VALUE line = rb_tracearg_lineno(tparg);
-    VALUE klass_path = (RTEST(klass) && !OBJ_FROZEN(klass)) ? rb_class_path_cached(klass) : Qnil;
     const char *path_cstr = RTEST(path) ? make_unique_str(arg->str_table, RSTRING_PTR(path), RSTRING_LEN(path)) : NULL;
-    const char *klass_path_cstr = RTEST(klass_path) ? make_unique_str(arg->str_table, RSTRING_PTR(klass_path), RSTRING_LEN(klass_path)) : NULL;
 
     if (st_lookup(arg->object_table, (st_data_t)obj, (st_data_t *)&info)) {
 	if (info->living) {
@@ -212,7 +207,6 @@ newobj_i(VALUE tpval, void *data)
 	}
 	/* reuse info */
 	delete_unique_str(arg->str_table, info->path);
-	delete_unique_str(arg->str_table, info->klass_path);
     }
     else {
 	info = create_allocation_info();
@@ -221,8 +215,7 @@ newobj_i(VALUE tpval, void *data)
     info->next = NULL;
     info->living = 1;
     info->flags = RBASIC(obj)->flags;
-    info->klass = klass;
-    info->klass_path = klass_path_cstr;
+    info->klass = rb_class_real(RBASIC_CLASS(obj));
     info->generation = rb_gc_count();
 
     info->path = path_cstr;
@@ -262,7 +255,7 @@ aggregator_i(void *data)
 	    key_data.data[i++] = (st_data_t)(info->flags & T_MASK);
 	}
 	if (arg->keys & KEY_CLASS) {
-	    key_data.data[i++] = (st_data_t)info->klass_path;
+	    key_data.data[i++] = info->klass;
 	}
 	key_data.n = i;
 	key = (st_data_t)&key_data;
@@ -282,7 +275,6 @@ aggregator_i(void *data)
 	    val_buff[2] = val_buff[3] = age;
 
 	    if (arg->keys & KEY_PATH) keep_unique_str(arg->str_table, info->path);
-	    if (arg->keys & KEY_CLASS) keep_unique_str(arg->str_table, info->klass_path);
 
 	    st_insert(arg->aggregate_table, (st_data_t)key_buff, (st_data_t)val_buff);
 	}
@@ -301,11 +293,10 @@ aggregator_i(void *data)
 }
 
 static void
-move_to_freed_list(struct traceobj_arg *arg, VALUE obj, struct allocation_info *info)
+move_to_freed_list(struct traceobj_arg *arg, struct allocation_info *info)
 {
     info->next = arg->freed_allocation_info;
     arg->freed_allocation_info = info;
-    st_delete(arg->object_table, (st_data_t *)&obj, (st_data_t *)&info);
 }
 
 static void
@@ -321,7 +312,8 @@ freeobj_i(VALUE tpval, void *data)
     }
 
     if (st_lookup(arg->object_table, (st_data_t)obj, (st_data_t *)&info)) {
-	move_to_freed_list(arg, obj, info);
+	move_to_freed_list(arg, info);
+	st_delete(arg->object_table, (st_data_t *)&obj, (st_data_t *)&info);
     }
 }
 
@@ -422,10 +414,12 @@ aggregate_result_i(st_data_t key, st_data_t val, void *data)
 	rb_ary_push(k, type_symbols[key_buff->data[i++]]);
     }
     if (arg->keys & KEY_CLASS) {
-	const char *klass_path = (const char *)key_buff->data[i++];
-	if (klass_path) {
-	    
-	    delete_unique_str(arg->str_table, klass_path);
+	VALUE klass = key_buff->data[i++];
+	if (BUILTIN_TYPE(klass) == T_CLASS) {
+	    klass = rb_class_real(klass);
+	    rb_ary_push(k, klass);
+	    /* TODO: actually, it is dangerous code because klass can be sweeped */
+	    /*       So that class specifier is hidden feature                   */
 	}
 	else {
 	    rb_ary_push(k, Qnil);
@@ -442,7 +436,7 @@ aggregate_rest_object_i(st_data_t key, st_data_t val, void *data)
 {
     struct traceobj_arg *arg = (struct traceobj_arg *)data;
     struct allocation_info *info = (struct allocation_info *)val;
-    move_to_freed_list(arg, (VALUE)key, info);
+    move_to_freed_list(arg, info);
     return ST_CONTINUE;
 }
 
@@ -454,6 +448,7 @@ aggregate_result(struct traceobj_arg *arg)
     aar.arg = arg;
 
     st_foreach(arg->object_table, aggregate_rest_object_i, (st_data_t)arg);
+    st_clear(arg->object_table);
     aggregator_i(arg);
     st_foreach(arg->aggregate_table, aggregate_result_i, (st_data_t)&aar);
     clear_traceobj_arg();
@@ -521,6 +516,8 @@ allocation_tracer_setup(int argc, VALUE *argv, VALUE self)
 	int i;
 	VALUE ary = rb_check_array_type(argv[0]);
 
+	arg->keys = 0;
+
 	for (i=0; i<(int)RARRAY_LEN(ary); i++) {
 	         if (RARRAY_AREF(ary, i) == ID2SYM(rb_intern("path"))) arg->keys |= KEY_PATH;
 	    else if (RARRAY_AREF(ary, i) == ID2SYM(rb_intern("line"))) arg->keys |= KEY_LINE;

data/lib/allocation_tracer/version.rb

@@ -1,3 +1,3 @@
 module ObjectSpace::AllocationTracer
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/allocation_tracer_spec.rb

@@ -23,5 +23,39 @@ describe ObjectSpace::AllocationTracer do
       expect(result.length).to be >= 1
       expect(result[[__FILE__, line]]).to eq [1, 0, 0, 0]
     end
+
+    describe 'with different setup' do
+      it 'should work with type' do
+        line = __LINE__ + 3
+        ObjectSpace::AllocationTracer.setup(%i(path line type))
+        result = ObjectSpace::AllocationTracer.trace do
+          a = [Object.new]
+          b = {Object.new => 'foo'}
+        end
+
+        expect(result.length).to be 5
+        expect(result[[__FILE__, line, :T_OBJECT]]).to eq [1, 0, 0, 0]
+        expect(result[[__FILE__, line, :T_ARRAY]]).to eq [1, 0, 0, 0]
+        expect(result[[__FILE__, line + 1, :T_HASH]]).to eq [1, 0, 0, 0]
+        expect(result[[__FILE__, line + 1, :T_OBJECT]]).to eq [1, 0, 0, 0]
+        expect(result[[__FILE__, line + 1, :T_STRING]]).to eq [1, 0, 0, 0]
+      end
+
+      it 'should work with class' do
+        line = __LINE__ + 3
+        ObjectSpace::AllocationTracer.setup(%i(path line class))
+        result = ObjectSpace::AllocationTracer.trace do
+          a = [Object.new]
+          b = {Object.new => 'foo'}
+        end
+
+        expect(result.length).to be 5
+        expect(result[[__FILE__, line, Object]]).to eq [1, 0, 0, 0]
+        expect(result[[__FILE__, line, Array]]).to eq [1, 0, 0, 0]
+        expect(result[[__FILE__, line + 1, Hash]]).to eq [1, 0, 0, 0]
+        expect(result[[__FILE__, line + 1, Object]]).to eq [1, 0, 0, 0]
+        expect(result[[__FILE__, line + 1, String]]).to eq [1, 0, 0, 0]
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: allocation_tracer
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Koichi Sasada