aliyun-oss-sdk 0.0.3 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 48824060a243cb4767d975c02b036ccedf0dba0a
-  data.tar.gz: 0cdbddaf0f33abac43e4c5e5e05346df08773307
+  metadata.gz: 27f9032b8f7891bd84eb08e910d164194a8a72e5
+  data.tar.gz: 26dcaa8f67582786a2f62ea309b49c7a6b565eb4
 SHA512:
-  metadata.gz: a38cd11c82084a0d7f61d0d96b8f4e69dd3cad0e37dc0e724561dd343065da244166e5752221c85c477d181082705ff68245df3750a5d87ed3ca5cbb49564e35
-  data.tar.gz: ddb90c90e27a46a468c4fb7dbdff4683a6bd0f3f3d52626c71369704b227ad5d921e95f716a7cac3e345520b1b6fcb435f681cbec8eee9caa4a26c777359218b
+  metadata.gz: fc87a775fc990b532956c33a7cb1ff54cbb408fe24505b36a45c1859ec92ccabdb1356f120d6a98f1dd76d11c5a9f9a353cf193ce6dbc6053dbad566b3b85006
+  data.tar.gz: 3a461280cb56c0cff89c507b4ca6d21d742832d84a61d01a18ef5e79cdffa263176c625180ab6aa36518665bac6473409c3c503762a6061de96b82bef3a3846a

data/.rubocop.yml

@@ -0,0 +1,17 @@
+# This is the configuration used to check the rubocop source code.
+
+Metrics/LineLength:
+  Max: 100
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Style/AccessorMethodName:
+  Enabled: false

data/Gemfile

@@ -3,3 +3,4 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in ruby-oss-sdk.gemspec
 gemspec
 gem 'coveralls', require: false
+gem 'simplecov', require: false

data/README.md

@@ -1,7 +1,7 @@
 # Aliyun OSS SDK
 
 [![Build Status](https://travis-ci.org/zlx/aliyun-oss-sdk.svg)](https://travis-ci.org/zlx/aliyun-oss-sdk)
-[![Code Climate](https://codeclimate.com/github/zlx/aliyun-oss-sdk.png)](https://codeclimate.com/github/zlx/aliyun-oss-sdk)
+[![Code Climate](https://codeclimate.com/github/zlx/aliyun-oss-sdk/badges/gpa.svg)](https://codeclimate.com/github/zlx/aliyun-oss-sdk)
 [![Coverage Status](https://coveralls.io/repos/zlx/aliyun-oss-sdk/badge.svg?branch=master&service=github)](https://coveralls.io/github/zlx/aliyun-oss-sdk?branch=master)
 
 -----
@@ -26,7 +26,7 @@ And run:
     bundle install  
 
 
-## Usage    
+## Usage
 
 ### Quick Start
 
@@ -111,13 +111,13 @@ With Post Form, we need Post Policy to restrict permissions, here we provide two
 	##### Set the bucket properties  ####
 	
 	# set cors for bucket
-	rule = Aliyun::Oss::Rule::Cors.new({ allowed_methods: ['get'], allowed_origins: ['*'] })
+	rule = Aliyun::Oss::Struct::Cors.new({ allowed_methods: ['get'], allowed_origins: ['*'] })
 	client.bucket_enable_cors([rule])
 	client.bucket_disable_cors	# Disable and remove existing cors
 	
 	# Set lifecycle for bucket
-	rule1 = Aliyun::Oss::Rule::LifeCycle.new({ prefix: 'logs-prod-', days: 7, enable: true })
-	rule2 = Aliyun::Oss::Rule::LifeCycle.new({ prefix: 'logs-dev', date: Time.now + 24*60*60, enable: true })
+	rule1 = Aliyun::Oss::Struct::LifeCycle.new({ prefix: 'logs-prod-', days: 7, enable: true })
+	rule2 = Aliyun::Oss::Struct::LifeCycle.new({ prefix: 'logs-dev', date: Time.now + 24*60*60, enable: true })
 	client.bucket_enable_lifecycle([rule1, rule2])
 	client.bucket_disable_lifecycle  # Disable and remove existing lifecycle
 	
@@ -188,9 +188,9 @@ With Post Form, we need Post Policy to restrict permissions, here we provide two
 	client.bucket_list_parts("sample_multipart.data", "98A6524428734723BE8F81D72B5295EE")  
 	
 	# Complete a Multipart Upload event
-	part1 = Aliyun::Oss::Multipart::Part.new({ number: 1, etag: 'etag1' })
-	part2 = Aliyun::Oss::Multipart::Part.new({ number: 2, etag: 'etag2' })
-	part3 = Aliyun::Oss::Multipart::Part.new({ number: 3, etag: 'etag3' })
+	part1 = Aliyun::Oss::Struct::Part.new({ number: 1, etag: 'etag1' })
+	part2 = Aliyun::Oss::Struct::Part.new({ number: 2, etag: 'etag2' })
+	part3 = Aliyun::Oss::Struct::Part.new({ number: 3, etag: 'etag3' })
 	client.bucket_complete_multipart("Exciting-Ruby.mp4", "98A6524428734723BE8F81D72B5295EE", [part1, part2, part3])
 	
 	# Abort a Multipart Upload event
@@ -215,10 +215,12 @@ Here is thr Ruby Document for this Library, use to find more usage for methods.
 Here are some more guides for help you. Welcome to advice.
 
 + [Installation](./wiki/installation.md)
-+ [Get started](./wiki/get_start.md)
++ [Getting Started](./wiki/get_start.md)
 + [Bucket](./wiki/bucket.md)
-+ [Objects](./wiki/object.md)
++ [Object](./wiki/object.md)
 + [Multipart Upload](./wiki/multipart.md)
++ [CORS](./wiki/cors.md)
++ [LifeCycle](./wiki/lifecycle.md)
 + [Error](./wiki/error.md)
 
 

data/Rakefile

@@ -1,5 +1,6 @@
 require 'bundler/gem_tasks'
 require 'rake/testtask'
+require 'rubocop/rake_task'
 
 Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
@@ -8,3 +9,12 @@ Rake::TestTask.new(:test) do |t|
 end
 
 task default: :test
+
+task :test do
+  Rake::Task['test'].invoke
+  Rake::Task['rubocop'].invoke
+end
+
+RuboCop::RakeTask.new do |task|
+  task.fail_on_error = false
+end

data/aliyun-oss.gemspec

@@ -25,8 +25,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'minitest'
   spec.add_development_dependency 'mocha'
-  #spec.add_development_dependency 'pry-byebug'
+  spec.add_development_dependency 'pry-byebug'
   spec.add_development_dependency 'webmock'
   spec.add_development_dependency 'timecop'
-  #spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'rubocop'
 end

data/lib/aliyun/oss.rb

@@ -1,20 +1,13 @@
 require 'aliyun/oss/version'
+require 'aliyun/oss/client'
+require 'aliyun/oss/struct'
+require 'aliyun/oss/error'
 
 module Aliyun
   module Oss
     autoload :Utils,            'aliyun/oss/utils'
-    autoload :Client,           'aliyun/oss/client'
     autoload :Http,             'aliyun/oss/http'
-    autoload :XmlBuilder,       'aliyun/oss/xml_builder'
     autoload :Authorization,    'aliyun/oss/authorization'
-
-    module Rule
-      autoload :LifeCycle,      'aliyun/oss/rule/lifecycle'
-      autoload :Cors,           'aliyun/oss/rule/cors'
-    end
-
-    module Multipart
-      autoload :Part,           'aliyun/oss/multipart/part'
-    end
+    autoload :XmlGenerator,     'aliyun/oss/xml_generator'
   end
 end

data/lib/aliyun/oss/authorization.rb

@@ -13,7 +13,7 @@ module Aliyun
       # @see {https://docs.aliyun.com/#/pub/oss/api-reference/access-control&signature-url Tempoorary Signature}
       #
       # @param secret_key [String] Secret Key
-      # @param expires [Integer] the number of seconds since January 1, 1970 UTC. used to specified expired time
+      # @param expire_time [Integer] the number of seconds since January 1, 1970 UTC. used to specified expired time
       # @param [Hash] options other options
       # @option options [String] :key the object name
       # @option options [String] :bucket bucket name
@@ -31,7 +31,6 @@ module Aliyun
       #
       # @see {https://docs.aliyun.com/#/pub/oss/api-reference/object&PostObject Post Object}
       #
-      # @param secret_key [String] Secret Key
       # @param policy [Hash] Policy {https://docs.aliyun.com/#/pub/oss/api-reference/object&PostObject#menu7 Detail}
       #
       # @return [String]
@@ -57,6 +56,16 @@ module Aliyun
       #
       # @see {https://docs.aliyun.com/#/pub/oss/api-reference/access-control&signature-header Authorization}
       #
+      # @param access_key [String] Access Key
+      # @param secret_key [String] Secret Key
+      # @param options [Hash] Options
+      # @option options [String] :verb VERB, request method
+      # @option options [String] :date Request Time in formate: '%a, %d %b %Y %H:%M:%S GMT'
+      # @option options [String] :bucket Bucket Name
+      # @option options [String] :key Object Name
+      # @option options [Hash] :query Query key-value pair
+      # @option options [Hash] :headers Headers
+      #
       # @return [String] the authorization string
       def self.get_authorization(access_key, secret_key, options = {})
         content_string = concat_content_string(options[:verb], options[:date], options)
@@ -64,44 +73,66 @@ module Aliyun
         "#{PROVIDER} #{access_key}:#{signature_string.strip}"
       end
 
-      private
-
       def self.concat_content_string(verb, time, options = {})
         headers = options.fetch(:headers, {})
 
-        cononicalized_oss_headers = get_cononicalized_oss_headers(headers)
-        cononicalized_resource = get_cononicalized_resource(*options.values_at(:bucket, :key, :query))
-
-        if cononicalized_oss_headers
-          [
-            verb.upcase,
-            headers['Content-MD5'],
-            headers['Content-Type'],
-            time,
-            cononicalized_oss_headers,
-            cononicalized_resource
-          ].join("\n")
+        conon_headers = get_cononicalized_oss_headers(headers)
+        conon_resource = get_cononicalized_resource(
+          *options.values_at(:bucket, :key, :query)
+        )
+
+        join_values(verb.upcase, time, headers, conon_headers, conon_resource)
+      end
+
+      def self.join_values(verb, time, headers, conon_headers, resource)
+        if conon_headers
+          join_with_conon_headers(verb, time, headers, conon_headers, resource)
         else
-          [
-            verb.upcase,
-            headers['Content-MD5'],
-            headers['Content-Type'],
-            time,
-            cononicalized_resource
-          ].join("\n")
+          join_without_conon_headers(verb, time, headers, resource)
         end
       end
 
+      def self.join_with_conon_headers(verb, time, headers, c_headers, resource)
+        [
+          verb,
+          headers['Content-MD5'],
+          headers['Content-Type'],
+          time,
+          c_headers,
+          resource
+        ].join("\n")
+      end
+
+      def self.join_without_conon_headers(verb, time, headers, resource)
+        [
+          verb,
+          headers['Content-MD5'],
+          headers['Content-Type'],
+          time,
+          resource
+        ].join("\n")
+      end
+
       def self.signature(secret_key, content_string)
         utf8_string = content_string.force_encoding('utf-8')
-        Base64.encode64(OpenSSL::HMAC.digest(OpenSSL::Digest::SHA1.new, secret_key, utf8_string))
+        Base64.encode64(
+          OpenSSL::HMAC.digest(
+            OpenSSL::Digest::SHA1.new,
+            secret_key,
+            utf8_string
+          )
+        )
       end
 
       def self.get_cononicalized_oss_headers(headers)
-        oss_headers = (headers || {}).select { |key, _| key.to_s.downcase.start_with?('x-oss-') }
+        oss_headers = (headers || {}).select do |key, _|
+          key.to_s.downcase.start_with?('x-oss-')
+        end
         return if oss_headers.empty?
 
-        oss_headers.keys.sort.map { |key| "#{key.downcase}:#{oss_headers[key]}" }.join("\n")
+        oss_headers.keys.sort.map do |key|
+          "#{key.downcase}:#{oss_headers[key]}"
+        end.join("\n")
       end
 
       def self.get_cononicalized_resource(bucket, key, query)
@@ -110,7 +141,8 @@ module Aliyun
         cononicalized_resource += key if key
         return cononicalized_resource if query.nil? || query.empty?
 
-        cononicalized_resource + '?' + query.keys.sort.map { |key| "#{key}=#{query[key]}" }.join('&')
+        query_str = query.keys.sort.map { |k| "#{k}=#{query[k]}" }.join('&')
+        cononicalized_resource + '?' + query_str
       end
     end
   end

data/lib/aliyun/oss/client.rb

@@ -1,12 +1,10 @@
-require 'base64'
-require 'openssl'
-require 'digest'
-require 'httparty'
+require 'aliyun/oss/client/clients'
 
 module Aliyun
   module Oss
     class Client
-      attr_reader :access_key, :secret_key, :bucket
+      attr_reader :access_key, :secret_key
+      attr_accessor :bucket
 
       # Initialize a object
       #
@@ -24,6 +22,8 @@ module Aliyun
         @secret_key = secret_key
         @options = options
         @bucket = options[:bucket]
+
+        @services = {}
       end
 
       # List buckets
@@ -72,13 +72,14 @@ module Aliyun
       #   oss-cn-shenzhen,oss-cn-shanghai,oss-us-west-1 ,oss-ap-southeast-1
       # @param acl [String] Specify the bucket's access. (see #bucket_set_acl)
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
       def bucket_create(name, location = 'oss-cn-hangzhou', acl = 'private')
         query = { 'acl' => true }
         headers = { 'x-oss-acl' => acl }
 
-        configuration = { 'CreateBucketConfiguration' => { 'LocationConstraint' => location } }
-        body = Utils.to_xml(configuration)
+        body = XmlGenerator.generate_create_bucket_xml(location)
 
         http.put('/', query: query, headers: headers, body: body, bucket: name, location: location)
       end
@@ -89,6 +90,8 @@ module Aliyun
       #
       # @param name [String] bucket name want to delete
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
       def bucket_delete(name)
         http.delete('/', bucket: name)
@@ -99,6 +102,9 @@ module Aliyun
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/bucket&PutBucketACL Put Bucket Acl
       #
       # @param acl [String] supported value: public-read-write | public-read | private
+      # @raise [RequestError]
+      #
+      # @return [Response]
       def bucket_set_acl(acl)
         query = { 'acl' => true }
         headers = { 'x-oss-acl' => acl }
@@ -111,12 +117,15 @@ module Aliyun
       #
       # @param target_bucket [String] specifies the bucket where you want Aliyun OSS to store server access logs.
       # @param target_prefix [String] this element lets you specify a prefix for the objects that the log files will be stored.
+      #
+      # @raise [RequestError]
+      #
+      # @return [Response]
       def bucket_enable_logging(target_bucket, target_prefix = nil)
         query = { 'logging' => true }
 
-        logging = { 'TargetBucket' => target_bucket }
-        logging.merge!('TargetPrefix' => target_prefix) if target_prefix
-        body = Utils.to_xml('BucketLoggingStatus' => { 'LoggingEnabled' => logging })
+        body = XmlGenerator.generate_enable_logging_xml(target_bucket,
+                                                        target_prefix)
 
         http.put('/', query: query, body: body, bucket: bucket)
       end
@@ -124,6 +133,10 @@ module Aliyun
       # Used to disable access logging.
       #
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/bucket&DeleteBucketLogging Delete Bucket Logging
+      #
+      # @raise [RequestError]
+      #
+      # @return [Response]
       def bucket_disable_logging
         query = { 'logging' => false }
         http.delete('/', query: query, bucket: bucket)
@@ -135,12 +148,14 @@ module Aliyun
       #
       # @param suffix [String] A suffix that is appended to a request that is for a directory on the website endpoint (e.g. if the suffix is index.html and you make a request to samplebucket/images/ the data that is returned will be for the object with the key name images/index.html) The suffix must not be empty and must not include a slash character.
       # @param key [String] The object key name to use when a 4XX class error occurs
+      #
+      # @raise [RequestError]
+      #
+      # @return [Response]
       def bucket_enable_website(suffix, key = nil)
         query = { 'website' => true }
 
-        website_configuration = { 'IndexDocument' => { 'Suffix' => suffix } }
-        website_configuration.merge!('ErrorDocument' => { 'Key' => key }) if key
-        body = Utils.to_xml('WebsiteConfiguration' => website_configuration)
+        body = XmlGenerator.generate_enable_website_xml(suffix, key)
 
         http.put('/', query: query, body: body, bucket: bucket)
       end
@@ -148,6 +163,10 @@ module Aliyun
       # Used to disable website hostted mode.
       #
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/bucket&DeleteBucketWebsite Delete Bucket Website
+      #
+      # @raise [RequestError]
+      #
+      # @return [Response]
       def bucket_disable_website
         query = { 'website' => false }
         http.delete('/', query: query, bucket: bucket)
@@ -160,17 +179,13 @@ module Aliyun
       # @param referers [Array<String>] white list for allowed referer.
       # @param allowed_empty [Boolean] whether allow empty refer.
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
       def bucket_set_referer(referers = [], allowed_empty = false)
         query = { 'referer' => true }
 
-        body = Utils.to_xml('RefererConfiguration' => {
-                              'AllowEmptyReferer' => allowed_empty,
-                              'RefererList' => {
-                                'Referer' => referers
-                              }
-                            }
-                           )
+        body = XmlGenerator.generate_set_referer_xml(referers, allowed_empty)
 
         http.put('/', query: query, body: body, bucket: bucket)
       end
@@ -179,15 +194,25 @@ module Aliyun
       #
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/bucket&PutBucketLifecycle Put Bucket Lifecycle
       #
-      # @param rules [Array<Rule::LifeCycle>] rules for lifecycle
+      # @param rules [Array<Aliyun::Oss::Struct::LifeCycle>] rules for lifecycle
+      #
+      # @raise [RequestError]
+      # @raise [Aliyun::Oss::InvalidLifeCycleRuleError]
+      #   if rule invalid
       #
       # @return [Response]
       def bucket_enable_lifecycle(rules = [])
         query = { 'lifecycle' => true }
 
-        body = Utils.to_xml('LifecycleConfiguration' => {
-                              'Rule' => rules.map(&:to_hash)
-                            })
+        rules = Utils.wrap(rules)
+
+        rules.each do |rule|
+          unless rule.valid?
+            fail Aliyun::Oss::InvalidLifeCycleRuleError, rule.inspect
+          end
+        end
+
+        body = XmlGenerator.generate_lifecycle_rules(rules)
 
         http.put('/', query: query, body: body, bucket: bucket)
       end
@@ -204,15 +229,25 @@ module Aliyun
       #
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/cors&PutBucketcors Put Bucket cors
       #
-      # @param rules [Array<Rule::Cors>] array of rule
+      # @param rules [Array<Aliyun::Oss::Struct::Cors>] array of rule
+      #
+      # @raise [RequestError]
+      # @raise [InvalidCorsRule]
+      #   if rule invalid
       #
       # @return [Response]
       def bucket_enable_cors(rules = [])
         query = { 'cors' => true }
 
-        body = Utils.to_xml('CORSConfiguration' => {
-                              'CORSRule' => rules.map(&:to_hash)
-                            })
+        rules = Utils.wrap(rules)
+
+        rules.each do |rule|
+          unless rule.valid?
+            fail Aliyun::Oss::InvalidCorsRuleError, rule.inspect
+          end
+        end
+
+        body = XmlGenerator.generate_cors_rules(rules)
 
         http.put('/', query: query, body: body, bucket: bucket)
       end
@@ -221,6 +256,8 @@ module Aliyun
       #
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/cors&DeleteBucketcors Delete Bucket cors
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
       def bucket_disable_cors
         query = { 'cors' => false }
@@ -231,21 +268,28 @@ module Aliyun
       #
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/cors&OptionObject OPTIONS Object
       #
+      # @param object_key [String] the object name want to visit.
       # @param origin [String] the requested source domain, denoting cross-domain request.
       # @param request_method [String] the actual request method will be used.
       # @param request_headers [Array<String>] the actual used headers except simple headers will be used.
-      # @param object_name [String] the object name will be visit.
+      #
+      # @raise [RequestError]
       #
       # @return [Response]
-      def bucket_preflight(origin, request_method, request_headers = [], object_name = nil)
-        uri = object_name ? "/#{object_name}" : '/'
+      def bucket_preflight(object_key, origin, request_method, request_headers = [])
+        path = object_key ? "/#{object_key}" : '/'
+
+        headers = {
+          'Origin' => origin,
+          'Access-Control-Request-Method' => request_method
+        }
 
-        headers = { 'Origin' => origin, 'Access-Control-Request-Method' => request_method }
         unless request_headers.empty?
-          headers.merge!('Access-Control-Request-Headers' => request_headers.join(','))
+          value = request_headers.join(',')
+          headers.merge!('Access-Control-Request-Headers' => value)
         end
 
-        http.options(uri, headers: headers, bucket: bucket, key: object_name)
+        http.options(path, headers: headers, bucket: bucket, key: object_key)
       end
 
       # Get ACL for bucket
@@ -272,6 +316,8 @@ module Aliyun
       #
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/bucket&GetBucketLogging Get Bucket Logging
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
       def bucket_get_logging
         query = { 'logging' => true }
@@ -356,7 +402,9 @@ module Aliyun
       # @option options [String] :x-oss-copy-source-if-modified-since If the specified time is earlier than the source object last modification time, normal transfer ans return 200; Otherwise returns 304(not modified)
       # @option options [String] :x-oss-metadata-directive ('COPY') supported value: COPY, REPLACE;
       # @option options [String] :x-oss-server-side-encryption supported value: AES256
-      # @option options [String] :x-oss-object-acl supported value: public-read，private，public-read-write
+      # @option options [String] :x-oss-object-acl supported value: public-read, private, public-read-write
+      #
+      # @raise [RequestError]
       #
       # @return [Response]
       def bucket_copy_object(key, source_bucket, source_key, headers = {})
@@ -377,6 +425,9 @@ module Aliyun
       # @param position [Integer] append to position of object
       # @option headers (see #bucket_create_object)
       #
+      # @raise [RequestError]
+      #
+      # @return [Response]
       def bucket_append_object(key, file, position = 0, headers = {})
         query = { 'append' => true, 'position' => position }
 
@@ -431,8 +482,7 @@ module Aliyun
       def bucket_delete_objects(keys, quiet = false)
         query = { 'delete' => true }
 
-        key_objects = keys.map { |key| { 'Key' => key } }
-        body = Utils.to_xml('Delete' => { 'Object' => key_objects, 'Quiet' => quiet })
+        body = XmlGenerator.generate_delete_objects_xml(keys, quiet)
 
         http.post('/', query: query, body: body, bucket: bucket)
       end
@@ -448,6 +498,8 @@ module Aliyun
       # @option headers [String] :If-Match If the specified ETag match the object ETag, normal transfer and return 200; Otherwise return 412(precondition)
       # @option headers [String] :If-None-Match If the specified ETag not match the object ETag, normal transfer and return 200; Otherwise return 304(Not Modified)
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
       def bucket_get_meta_object(key, headers = {})
         http.head("/#{key}", headers: headers, bucket: bucket, key: key)
@@ -459,6 +511,8 @@ module Aliyun
       #
       # @param key [String] object name
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
       def bucket_get_object_acl(key)
         query = { 'acl' => true }
@@ -472,6 +526,8 @@ module Aliyun
       # @param key [String] object name
       # @param acl [String] access value, supported value: private, public-read, public-read-write
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
       def bucket_set_object_acl(key, acl)
         query = { 'acl' => true }
@@ -507,10 +563,14 @@ module Aliyun
       # @param upload_id [String] the upload ID return by #bucket_init_multipart
       # @param file [File, bin data] the upload data
       #
+      # @raise [RequestError]
+      # @raise [MultipartPartNumberEmptyError]
+      # @raise [MultipartUploadIdEmptyError]
+      #
       # @return [Response]
-      def bucket_multipart_upload(key, number, upload_id, file)
-        fail('number must present!') if number.nil?
-        fail('upload_id must present!') if upload_id.nil? || upload_id.empty?
+      def bucket_multipart_upload(upload_id, key, number, file)
+        fail MultipartPartNumberEmptyError if number.nil?
+        fail MultipartUploadIdEmptyError if upload_id.nil? || upload_id.empty?
 
         query = { 'partNumber' => number.to_s, 'uploadId' => upload_id }
 
@@ -527,26 +587,27 @@ module Aliyun
       # @param options [Hash] options
       # @option options [String] :source_bucket the source bucket name
       # @option options [String] :source_key the source object name
-      # @option options [String] :range the Range bytes, not set means the whole object
+      # @option options [String] :range the Range bytes, not set means the whole object, eg: bytes=100-6291756
       # @option options [String] :x-oss-copy-source-if-match If the specified ETag match the source object ETag, normal transfer and return 200; Otherwise return 412(precondition)
       # @option options [String] :x-oss-copy-source-if-none-match If the specified ETag not match the source object ETag, normal transfer and return 200; Otherwise return 304(Not Modified)
       # @option options [String] :x-oss-copy-source-if-unmodified-since If the specified time is equal to or later than the source object last modification time, normal transfer ans return 200; Otherwise returns 412(precondition)
       # @option options [String] :x-oss-copy-source-if-modified-since If the specified time is earlier than the source object last modification time, normal transfer ans return 200; Otherwise returns 304(not modified)
       #
+      # @raise [RequestError]
+      # @raise [MultipartSourceBucketEmptyError]
+      # @raise [MultipartSourceKeyEmptyError]
+      #
       # @return [Response]
-      def bucket_multipart_copy_upload(key, number, upload_id, options = {})
-        fail('source_bucket must present!') if options[:source_bucket].to_s.empty?
-        fail('source_key must present!') if options[:source_key].to_s.empty?
-
-        query = { 'partNumber' => number, 'uploadId' => upload_id }
+      def bucket_multipart_copy_upload(upload_id, key, number, options = {})
+        source_bucket = options.delete(:source_bucket).to_s
+        source_key = options.delete(:source_key).to_s
+        range = options.delete(:range)
 
-        source_bucket = options.delete(:source_bucket)
-        source_key = options.delete(:source_key)
+        fail MultipartSourceBucketEmptyError if source_bucket.empty?
+        fail MultipartSourceKeyEmptyError if source_key.empty?
 
-        headers = {}
-        headers.merge!('x-oss-copy-source' => "/#{source_bucket}/#{source_key}")
-        headers.merge!('x-oss-copy-source-range' => options.delete(:range)) if options.key?(:range)
-        headers.merge!(options)
+        query = { 'partNumber' => number, 'uploadId' => upload_id }
+        headers = copy_upload_headers(source_bucket, source_key, range, options)
 
         http.put("/#{key}", query: query, headers: headers, bucket: bucket, key: key)
       end
@@ -557,18 +618,20 @@ module Aliyun
       #
       # @param key [String] object name
       # @param upload_id [String] the upload ID return by #bucket_init_multipart
-      # @param parts [Array<Multipart:Part>] parts
+      # @param parts [Array<Aliyun::Oss::Multipart:Part>] parts
+      #
+      # @raise [RequestError]
+      # @raise [MultipartPartsEmptyError]
+      # @raise [MultipartUploadIdEmptyError]
       #
       # @return [Response]
-      def bucket_complete_multipart(key, upload_id, parts = [])
-        fail('parts must present!') if parts.nil? || parts.empty?
-        fail('upload_id must present!') if upload_id.nil?
+      def bucket_complete_multipart(upload_id, key, parts = [])
+        fail MultipartPartsEmptyError if parts.nil? || parts.empty?
+        fail MultipartUploadIdEmptyError if upload_id.nil?
 
         query = { 'uploadId' => upload_id }
 
-        body = Utils.to_xml('CompleteMultipartUpload' => {
-                              'Part' => parts.map(&:to_hash)
-                            })
+        body = XmlGenerator.generate_complete_multipart_xml(parts)
 
         http.post("/#{key}", query: query, body: body, bucket: bucket, key: key)
       end
@@ -583,8 +646,10 @@ module Aliyun
       # @param key [String] the object name
       # @param upload_id [String] the upload ID return by #bucket_init_multipart
       #
+      # @raise [RequestError]
+      #
       # @return [Response]
-      def bucket_abort_multipart(key, upload_id)
+      def bucket_abort_multipart(upload_id, key)
         query = { 'uploadId' => upload_id }
         http.delete("/#{key}", query: query, bucket: bucket, key: key)
       end
@@ -616,14 +681,14 @@ module Aliyun
       # @see https://docs.aliyun.com/#/pub/oss/api-reference/multipart-upload&ListParts List Parts
       #
       # @param key [String] the object name
-      # @param upload_id [String] the upload ID return by #bucket_init_multipart
+      # @param upload_id [Integer] the upload ID return by #bucket_init_multipart
       # @param options [Hash] options
       # @option options [Integer] :max-parts (1000) Limit number of parts, the maxinum should <= 1000
       # @option options [Integer] :part-number-marker Specify the start part, return parts which number large than the specified value
       # @option options [String] :encoding-type Encoding type used for unsupported character in xml 1.0
       #
       # @return [Response]
-      def bucket_list_parts(key, upload_id, options = {})
+      def bucket_list_parts(upload_id, key, options = {})
         accepted_keys = ['max-parts', 'part-number-marker', 'encoding-type']
 
         query = Utils.hash_slice(options, *accepted_keys).merge('uploadId' => upload_id)
@@ -636,6 +701,16 @@ module Aliyun
       def http
         @http = Http.new(access_key, secret_key, @options[:host])
       end
+
+      def copy_upload_headers(source_bucket, source_key, range, options)
+        copy_source = "/#{source_bucket}/#{source_key}"
+
+        headers = {}
+        headers.merge!('x-oss-copy-source' => copy_source)
+        headers.merge!('x-oss-copy-source-range' => range) if range
+        headers.merge!(options)
+        headers
+      end
     end
   end
 end