alexandrite 0.1.3.pre.alpha → 0.1.4.pre.alpha

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 35890f7e1386bc1f6d60ac0d68efd032288f1b4c448e5414c4a6bde38469a262
-  data.tar.gz: 5b29ae9057b620bc9649889b86587a77b1ecaf9eee4549d339293657e44ff95c
+  metadata.gz: 43a1742c1305de531ba2b4c3b7c68b28763fc0c3193a1e2ab74d47c35a44b260
+  data.tar.gz: 9b3e16191969c872fa000ca8e9fc4c44e9c028b141da68f7d7e54cd911abf2c8
 SHA512:
-  metadata.gz: 4655704b09257367b07cb36ffaa6ecfc6bd5fd7991f5066791b48a351dfd39f297a517497595122f6312eff2d98c4999593a999a72d96653a6ded608e92fb39f
-  data.tar.gz: 5d12307befe3fee203ed3e0e5c8fe66cb8fa13e10e7b3586023062ad7be124c96f2fd174755181a20ce9290a334efc3720749dcdc1610cd8f9def5608095771b
+  metadata.gz: d2461c44fc9d3324db7bcf84bc060112094f7a17412b3dcf4c339030b08b1b2c8cd5cee52e70e35aa7cb1339a1c6a8d9300cfe5d36a85f64286acb1cb6943f14
+  data.tar.gz: c2bf54e156474abf8a5424b7e953f8e60e646a2ad56fd4f1e33a42fb69775444df92ab90e81bc3c05b8d486df755f0a02be9467f2a17169847b09c4bd82672d7

data/Gemfile

@@ -6,6 +6,8 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'faraday'
-gem 'logger'
 gem 'faraday-decode_xml'
+gem 'logger'
+gem 'rbs'
+gem 'bump'
 gem 'rubocop'

data/lib/alexandrite/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Alexandrite
-  VERSION = '0.1.3-alpha'
+  VERSION = '0.1.4-alpha'
 end

data/lib/alexandrite.rb

@@ -21,6 +21,8 @@ module Alexandrite
       @result = search_with(key, query)
     end
 
+    # @param [String] key
+    # @param [String] query
     # @return [nil]
     def self.create_from_google(key, query)
       Alexandrite::BookData.create_data(get_volume_info(key, query))
@@ -74,7 +76,7 @@ module Alexandrite
 
   # @param key [String]
   # @param data [Array<String>]
-  # @return [Array<Alexandrite::BookData]
+  # @return [Array<Alexandrite::BookData>]
   def bulk_create(key, data)
     bookshelf = []
     log = Logger.new(STDOUT)

data/lib/alexandrite_book_data.rb

@@ -40,20 +40,37 @@ module Alexandrite
     def self.add_industry_identifiers(volume_info, data)
       return data unless volume_info[:error_message].nil?
 
-      if data[:data_source] == 'OCLC API'
+      assign_isbn(data, volume_info)
+
+      data
+    end
+
+    private
+
+    def assign_isbn(data, volume_info)
+      case data[:data_source]
+      when 'OCLC API'
         data[:isbn10] = volume_info['ISBN_10']
         data[:isbn13] = volume_info['ISBN_13']
-        return data
+      else
+        select_identifiers(data, volume_info)
       end
-      begin
-        volume_info['industryIdentifiers'].each do |identifier|
-          data[:isbn10] = identifier['identifier'] if identifier['type'] == 'ISBN_10'
-          data[:isbn13] = identifier['identifier'] if identifier['type'] == 'ISBN_13'
-        end
-      rescue NoMethodError
         data
+    end
+
+    def select_identifiers(data, volume_info)
+      return data unless volume_info['industryIdentifiers']
+
+      volume_info['industryIdentifiers'].each do |identifier|
+        data[:isbn10] = identifier['identifier'] if isbn10?(identifier)
+        data[:isbn13] = identifier['identifier'] if isbn13?(identifier)
       end
+
       data
     end
+
+    def isbn10?(identifier) = identifier['type'] == 'ISBN_10'
+
+    def isbn13?(identifier) = identifier['type'] == 'ISBN_13'
   end
 end

data/sig/alexandrite/alexandrite.rbs

@@ -0,0 +1,10 @@
+module Alexandrite
+  VERSION: String
+  API: {google: singleton(Google), oclc: singleton(OCLC)}
+  include BookData
+  include ErrorType
+
+  def search_with: (String key, String query, ?api: :google | :oclc) -> (Nokogiri::XML::Document | {error_message: String, results_size: Integer, books: untyped})
+  def create_book: (String key, String query) -> {title: String?, authors: String?, published_date: String?, page_count: String?, description: String?, categories: String?, language: String?, data_source: String, isbn10: String?, isbn13: String?, error_message: String?}
+  def bulk_create: (String key, Array[String] data) -> Array[Hash[Symbol,Object]]
+end

data/sig/alexandrite/book_data.rbs

@@ -0,0 +1,16 @@
+module Alexandrite
+  module BookData
+    def self.create_data: (Hash[:books | :error_message | :results_size | String, String?] volume_info) -> {title: String?, authors: String?, published_date: String?, page_count: String?, description: String?, categories: String?, language: String?, data_source: String, isbn10: String?, isbn13: String?, error_message: String?}
+    def self.add_basic_values: (Hash[:books | :error_message | :results_size | String, String?] volume_info) -> {title: String?, authors: String?, published_date: String?, page_count: String?, description: String?, categories: String?, language: String?}
+    def self.add_origin: (Hash[:books | :error_message | :results_size | String, String?] volume_info) -> String
+    def self.add_industry_identifiers: (Hash[:books | :error_message | :results_size | String, String?] volume_info, {title: String?, authors: String?, published_date: String?, page_count: String?, description: String?, categories: String?, language: String?, data_source: String} data) -> {title: String?, authors: String?, published_date: String?, page_count: String?, description: String?, categories: String?, language: String?, data_source: String, isbn10: String?, isbn13: String?}
+
+    private
+
+    def assign_isbn: (Hash[Symbol,Object] data, Hash[Symbol,Object] volume_info) -> Hash[Symbol,Object]
+    def select_identifiers: (Hash[Symbol,Object] data, Hash[Symbol,Object] volume_info) -> Hash[Symbol,Object]
+    def isbn10?: (Hash[String, String] identifier)-> bool
+    def isbn13?: -> (Hash[String, String] identifier)-> bool
+
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alexandrite
 version: !ruby/object:Gem::Version
-  version: 0.1.3.pre.alpha
+  version: 0.1.4.pre.alpha
 platform: ruby
 authors:
 - J. P. Pérez-Tejada
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-05 00:00:00.000000000 Z
+date: 2023-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -164,6 +164,8 @@ files:
 - lib/helpers/file_handler.rb
 - lib/helpers/format.rb
 - lib/helpers/validation.rb
+- sig/alexandrite/alexandrite.rbs
+- sig/alexandrite/book_data.rbs
 - spec/alexandrite_spec.rb
 - spec/factories/book.rb
 - spec/helpers/format_spec.rb
@@ -189,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.4.6
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Tools for fetching books data from Google and OCLC