alexandria-book-collection-manager 0.7.6 → 0.7.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c194c4c3c57f9f5f3c5168f2e59cbe0f26be22040392ba5cc6640b2fe6bb917
-  data.tar.gz: a76de1e82e89789ffdf419a10fa601d3bdb4b507c58ea76e9ad8b4123627da04
+  metadata.gz: 88a834cc5346bc0704749533797d91e6ff2a04c372e066fe9f91ca239baa63f1
+  data.tar.gz: 4a68efa9e12431f6ea356325b4bcee4a702a7f1f49710860a399657866c158e6
 SHA512:
-  metadata.gz: 367b0d80c25a8ece61d580cedb7806db56f9627c5adb151b63da5655b8495cf988a1e780fa27c88927c02c07b645ff5db452b96896d1720d82df542fb3cd3f1c
-  data.tar.gz: 88570773f1454e1f36c5d0268040f6ab30fd4acb41eb8c90fba9c3bb3488bc980d124705995493f7d7640f7dd9ee7e5355950b594759fd58ffc69a54e1302cbb
+  metadata.gz: 213ed219cd387370ff664b32b108aff3e6655e07579962f436f013616e02e423ef17afb6ed6bc6f036d2c5de863a9b51f8c5d5de5e8f33b9a51a0dff6522da61
+  data.tar.gz: c6440f573914defb43a7a9f451a4cf5e9091275039137c4dabd02d2290c72e87a17d35f62db08f7669d1a66f51ea53e5ef1b1e170cdd3beea237df1d3a1f5dd4

data/.github/workflows/ruby.yml

@@ -0,0 +1,77 @@
+# This workflow will download a prebuilt Ruby version, install dependencies and
+# run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby: [2.5, 2.6, 2.7]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install non-ruby dependencies
+      run: |
+        # Needed for gtk3 gem
+        sudo apt-get install libgtk-3-dev
+        # Needed for gstreamer gem
+        sudo apt-get install libgstreamer1.0-dev
+        # Needed for GooCanvas::Canvas widget
+        sudo apt-get install libgoocanvas-2.0-dev
+        # Needed for zoom gem
+        sudo apt-get install libyaz-dev
+        # Needed for intltool-merge executable
+        sudo apt-get install intltool
+        # Needed for gconftool-2 executable
+        sudo apt-get install gconf2
+        # Needed to provide A11y dbus service to silence warnings
+        sudo apt-get install at-spi2-core
+        # Needed to set up sound player pipeline
+        sudo apt-get install gstreamer1.0-plugins-good
+        # Needed to play sound
+        sudo apt-get install pulseaudio
+        # Provides xvfb-run
+        sudo apt-get install xvfb
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - name: Run unit tests
+      run: xvfb-run bundle exec rake spec:unit
+    - name: Run end-to-end tests in a dbus session
+      run: xvfb-run dbus-run-session bundle exec rake spec:end_to_end
+
+  rubocop:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Install non-ruby dependencies
+      run: |
+        # Needed for gtk3 gem
+        sudo apt-get install libgtk-3-dev
+        # Needed for gstreamer gem
+        sudo apt-get install libgstreamer1.0-dev
+        # Needed for zoom gem
+        sudo apt-get install libyaz-dev
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+        bundler-cache: true
+    - name: Run RuboCop
+      run: bundle exec rubocop -P

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.7.7 / 2020-11-15
+
+* Update Polish translation ([#88] by [Piotr Drąg][piotrdrag])
+* Fix hiding of progress bar of import dialog
+* Fix calendar popups in Smart Library and Book Properties dialogs
+* Fix crashes when activating Export and Import menu items
+
 ## 0.7.6 / 2020-11-01
 
 * Make more strings translatable with help from rubocop-i18n
@@ -100,6 +107,7 @@
 [HappyFacade]: https://github.com/HappyFacade
 
 <!-- issues and pull requests -->
+[#88]: https://github.com/mvz/alexandria-book-collection-manager/pull/88
 [#83]: https://github.com/mvz/alexandria-book-collection-manager/pull/83
 [#64]: https://github.com/mvz/alexandria-book-collection-manager/pull/64
 [#51]: https://github.com/mvz/alexandria-book-collection-manager/pull/51

data/lib/alexandria/export_library.rb

@@ -36,16 +36,19 @@ module Alexandria
     end
 
     def export_as_onix_xml_archive(filename)
-      File.open(File.join(Dir.tmpdir, "onix.xml"), "w") do |io|
+      dir = Dir.mktmpdir
+      File.open(File.join(dir, "onix.xml"), "w") do |io|
         to_onix_document.write(io, 0)
       end
-      copy_covers(File.join(Dir.tmpdir, "images"))
-      Dir.chdir(Dir.tmpdir) do
+      copy_covers(File.join(dir, "images"))
+      Dir.chdir(dir) do
         output = `tar -cjf \"#{filename}\" onix.xml images 2>&1`
         raise output unless $CHILD_STATUS.success?
       end
-      FileUtils.rm_rf(File.join(Dir.tmpdir, "images"))
-      FileUtils.rm(File.join(Dir.tmpdir, "onix.xml"))
+      FileUtils.rm_rf(File.join(dir, "images"))
+      FileUtils.rm(File.join(dir, "onix.xml"))
+    ensure
+      FileUtils.remove_entry dir
     end
 
     def export_as_tellico_xml_archive(filename)

data/lib/alexandria/ui/book_properties_dialog_base.rb

@@ -5,11 +5,13 @@
 # See the file README.md for authorship and licensing information.
 
 require "alexandria/ui/builder_base"
+require "alexandria/ui/calendar_popup"
 require "alexandria/ui/error_dialog"
 
 module Alexandria
   module UI
     class BookPropertiesDialogBase < BuilderBase
+      include CalendarPopup
       include GetText
       extend GetText
       GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
@@ -51,7 +53,7 @@ module Alexandria
                                       editable: 1)
         @treeview_authors.append_column(col)
 
-        setup_calendar_widgets
+        setup_date_widgets
         GLib::Timeout.add(150) do
           @setup_finished = true
 
@@ -63,53 +65,7 @@ module Alexandria
         @book_properties_dialog.show
       end
 
-      def setup_calendar_widgets
-        @popup_displayed = false
-        @calendar_popup = Gtk::Window.new # Gtk::Window::POPUP)
-        # @calendar_popup.modal = true
-        @calendar_popup.decorated = false
-        @calendar_popup.skip_taskbar_hint = true
-        @calendar_popup.skip_pager_hint = true
-        @calendar_popup.events = [:focus_change_mask]
-
-        @calendar_popup.set_transient_for(@book_properties_dialog)
-        @calendar_popup.set_type_hint :dialog
-        @calendar_popup.name = "calendar-popup"
-        @calendar_popup.resizable = false
-        # @calendar_popup.border_width = 4
-        # @calendar_popup.app_paintable = true
-
-        @calendar_popup.signal_connect("focus-out-event") do |_popup, _event|
-          hide_calendar_popup
-          false
-        end
-
-        @calendar = Gtk::Calendar.new
-        @calendar_popup.add(@calendar)
-
-        @calendar.signal_connect("day-selected") do
-          date_arr = @calendar.date
-          year = date_arr[0]
-          month = date_arr[1] # + 1 # gtk : months 0-indexed, Time.gm : 1-index
-          day = date_arr[2]
-          if @calendar_popup_for_entry
-            time = Time.gm(year, month, day)
-            @calendar_popup_for_entry.text = format_date(time)
-          end
-        end
-
-        @calendar.signal_connect("day-selected-double-click") do
-          date_arr = @calendar.date
-          year = date_arr[0]
-          month = date_arr[1] # + 1 # gtk : months 0-indexed, Time.gm : 1-index
-          day = date_arr[2]
-          if @calendar_popup_for_entry
-            time = Time.gm(year, month, day)
-            @calendar_popup_for_entry.text = format_date(time)
-          end
-          hide_calendar_popup
-        end
-
+      def setup_date_widgets
         @redd_date.signal_connect("icon-press") do |entry, primary, _icon|
           case primary.nick
           when "primary"
@@ -130,65 +86,6 @@ module Alexandria
         end
       end
 
-      def clear_date_entry(entry)
-        entry.text = ""
-      end
-
-      def hide_calendar_popup
-        @calendar_popup_for_entry = nil
-
-        @calendar_popup.hide_all
-        @book_properties_dialog.modal = true
-
-        GLib::Timeout.add(150) do
-          # If we set @popup_displayed=false immediately, then a click
-          # event on the primary icon of the Entry simultaneous with
-          # the focus-out-event of the Calendar causes the Calendar to
-          # pop up again milliseconds after being closed.
-          #
-          # This is never what the user intends.
-          #
-          # So we add a small delay before the primary icon's event
-          # handler is told to pop up the calendar in response to
-          # clicks.
-
-          @popup_displayed = false
-          false
-        end
-      end
-
-      def display_calendar_popup(entry)
-        if @popup_displayed
-          hide_calendar_popup
-        else
-          @calendar_popup_for_entry = entry
-          unless entry.text.strip.empty?
-            time = parse_date(entry.text)
-            unless time.nil?
-              @calendar.year = time.year
-              @calendar.month = time.month - 1
-              @calendar.day = time.day
-            end
-          end
-          @book_properties_dialog.modal = false
-          @calendar_popup.move(*get_entry_popup_coords(entry))
-          @calendar_popup.show_all
-          @popup_displayed = true
-        end
-      end
-
-      def get_entry_popup_coords(entry)
-        gdk_win = entry.parent_window
-        x, y = gdk_win.origin
-        alloc = entry.allocation
-        x += alloc.x
-        y += alloc.y
-        y += alloc.height
-        # x = [0, x].max
-        # y = [0, y].max
-        [x, y]
-      end
-
       def widget_names
         [:book_properties_dialog, :button_box, :button_cover,
          :checkbutton_loaned, :checkbutton_own, :checkbutton_redd,

data/lib/alexandria/ui/calendar_popup.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+# This file is part of Alexandria.
+#
+# See the file README.md for authorship and licensing information.
+
+module Alexandria
+  module UI
+    module CalendarPopup
+      def setup_calendar_widgets
+        @calendar_popup = Gtk::Popover.new
+        @calendar_popup.position = :bottom
+
+        @calendar = Gtk::Calendar.new
+        @calendar.show
+        @calendar_popup.add(@calendar)
+
+        @calendar.signal_connect("day-selected") do
+          assign_selected_date
+        end
+
+        @calendar.signal_connect("day-selected-double-click") do
+          assign_selected_date
+          @calendar_popup.hide
+        end
+      end
+
+      def assign_selected_date
+        date_arr = @calendar.date
+        year = date_arr[0]
+        month = date_arr[1] # + 1 # gtk : months 0-indexed, Time.gm : 1-index
+        day = date_arr[2]
+        time = Time.gm(year, month, day)
+        @calendar_popup_for_entry.text = format_date(time)
+      end
+
+      def clear_date_entry(entry)
+        entry.text = ""
+      end
+
+      def display_calendar_popup(entry)
+        setup_calendar_widgets unless defined? @calendar_popup
+
+        @calendar_popup_for_entry = entry
+        unless entry.text.strip.empty?
+          time = parse_date(entry.text)
+          unless time.nil?
+            @calendar.year = time.year
+            @calendar.month = time.month - 1
+            @calendar.day = time.day
+          end
+        end
+        @calendar_popup.set_relative_to(entry)
+        @calendar_popup.popup
+      end
+    end
+  end
+end

data/lib/alexandria/ui/export_dialog.rb

@@ -18,6 +18,8 @@ module Alexandria
       FORMATS = Alexandria::ExportFormat.all
       THEMES = Alexandria::WebTheme.all
 
+      attr_reader :dialog
+
       def initialize(parent, library, sort_order)
         @dialog = Gtk::FileChooserDialog.new(title: _("Export '%s'") % library.name,
                                              parent: parent,
@@ -86,7 +88,7 @@ module Alexandria
       end
 
       def perform
-        while ((response = run) != Gtk::ResponseType::CANCEL) &&
+        while ((response = dialog.run) != Gtk::ResponseType::CANCEL) &&
             (response != Gtk::ResponseType::DELETE_EVENT)
 
           if response == Gtk::ResponseType::HELP
@@ -97,16 +99,17 @@ module Alexandria
                                  THEMES[@theme_combo.active])
             rescue StandardError => ex
               ErrorDialog.new(@dialog, _("Export failed"), ex.message).display
+              break
             end
           end
         end
-        destroy
+        dialog.destroy
       end
 
       private
 
       def on_export(format, theme)
-        filename = self.filename
+        filename = dialog.filename
         if format.ext
           filename += "." + format.ext if File.extname(filename).empty?
           if File.exist?(filename)

data/lib/alexandria/ui/import_dialog.rb

@@ -48,7 +48,7 @@ module Alexandria
         end
 
         dialog.signal_connect("selection_changed") do
-          import_button.sensitive = filename && File.file?(filename)
+          import_button.sensitive = dialog.filename && File.file?(dialog.filename)
         end
 
         # before adding the (hidden) progress bar, we must re-set the
@@ -136,7 +136,7 @@ module Alexandria
                                 "provided is unknown.  Please " \
                                 "retry with another file.")).display
             end
-            pbar.hide
+            @pbar.hide
             self.sensitive = true
           end
         end

data/lib/alexandria/ui/smart_library_properties_dialog_base.rb

@@ -4,12 +4,14 @@
 #
 # See the file README.md for authorship and licensing information.
 
+require "alexandria/ui/calendar_popup"
 require "alexandria/ui/smart_library_rule_box"
 
 module Alexandria
   module UI
     class SmartLibraryPropertiesDialogBase
       include Logging
+      include CalendarPopup
       include GetText
       GetText.bindtextdomain(Alexandria::TEXTDOMAIN, charset: "UTF-8")
 
@@ -49,7 +51,6 @@ module Alexandria
 
         main_box.pack_start(@rules_header_box, expand: false, fill: false)
         main_box << scrollview
-        setup_calendar_widgets
       end
 
       def handle_date_icon_press(widget, primary, _icon)
@@ -221,111 +222,6 @@ module Alexandria
         end
       end
 
-      # COPIED and PASTED from book_properties_dialog_base
-
-      def setup_calendar_widgets
-        @popup_displayed = false
-        @calendar_popup = Gtk::Window.new # Gtk::Window::POPUP)
-        # @calendar_popup.modal = true
-        @calendar_popup.decorated = false
-        @calendar_popup.skip_taskbar_hint = true
-        @calendar_popup.skip_pager_hint = true
-        @calendar_popup.events = [:focus_change_mask]
-
-        @calendar_popup.set_transient_for(@dialog)
-        @calendar_popup.set_type_hint(:dialog)
-        @calendar_popup.name = "calendar-popup"
-        @calendar_popup.resizable = false
-        # @calendar_popup.border_width = 4
-        # @calendar_popup.app_paintable = true
-
-        @calendar_popup.signal_connect("focus-out-event") do |_popup, _event|
-          hide_calendar_popup
-          false
-        end
-
-        @calendar = Gtk::Calendar.new
-        @calendar_popup.add(@calendar)
-
-        @calendar.signal_connect("day-selected") do
-          date_arr = @calendar.date
-          year = date_arr[0]
-          month = date_arr[1] # + 1 # gtk : months 0-indexed, Time.gm : 1-index
-          day = date_arr[2]
-          if @calendar_popup_for_entry
-            time = Time.gm(year, month, day)
-            @calendar_popup_for_entry.text = format_date(time)
-          end
-        end
-
-        @calendar.signal_connect("day-selected-double-click") do
-          date_arr = @calendar.date
-          year = date_arr[0]
-          month = date_arr[1] # + 1 # gtk : months 0-indexed, Time.gm : 1-index
-          day = date_arr[2]
-          if @calendar_popup_for_entry
-            time = Time.gm(year, month, day)
-            @calendar_popup_for_entry.text = format_date(time)
-          end
-          hide_calendar_popup
-        end
-      end
-
-      def hide_calendar_popup
-        @calendar_popup_for_entry = nil
-
-        @calendar_popup.hide_all
-        self.modal = true
-
-        GLib::Timeout.add(150) do
-          # If we set @popup_displayed=false immediately, then a click
-          # event on the primary icon of the Entry simultaneous with
-          # the focus-out-event of the Calendar causes the Calendar to
-          # pop up again milliseconds after being closed.
-          #
-          # This is never what the user intends.
-          #
-          # So we add a small delay before the primary icon's event
-          # handler is told to pop up the calendar in response to
-          # clicks.
-
-          @popup_displayed = false
-          false
-        end
-      end
-
-      def display_calendar_popup(entry)
-        if @popup_displayed
-          hide_calendar_popup
-        else
-          @calendar_popup_for_entry = entry
-          unless entry.text.strip.empty?
-            time = parse_date(entry.text)
-            unless time.nil?
-              @calendar.year = time.year
-              @calendar.month = time.month - 1
-              @calendar.day = time.day
-            end
-          end
-          self.modal = false
-          @calendar_popup.move(*get_entry_popup_coords(entry))
-          @calendar_popup.show_all
-          @popup_displayed = true
-        end
-      end
-
-      def get_entry_popup_coords(entry)
-        gdk_win = entry.parent_window
-        x, y = gdk_win.origin
-        alloc = entry.allocation
-        x += alloc.x
-        y += alloc.y
-        y += alloc.height
-        # x = [0, x].max
-        # y = [0, y].max
-        [x, y]
-      end
-
       def parse_date(datestring)
         # '%m/%d/%Y' for USA and Canada ; or '%Y-%m-%d' for most of Asia
         # http://en.wikipedia.org/wiki/Calendar_date#Middle_endian_forms.2C_starting_with_the_month

data/lib/alexandria/ui/smart_library_rule_box.rb

@@ -27,7 +27,7 @@ module Alexandria
           entry.primary_icon_name = Gtk::Stock::EDIT
 
           entry.primary_icon_activatable = true
-          entry.signal_connect("icon-press") do |widget, primary, _icon|
+          entry.signal_connect("icon-press") do |widget, primary, icon|
             @parent.handle_date_icon_press(widget, primary, icon)
           end
         end

data/lib/alexandria/version.rb

@@ -5,7 +5,7 @@
 # See the file README.md for authorship and licensing information.
 
 module Alexandria
-  VERSION = "0.7.6"
+  VERSION = "0.7.7"
   DATA_VERSION = "0.6.3"
-  DISPLAY_VERSION = "0.7.6"
+  DISPLAY_VERSION = "0.7.7"
 end

data/po/pl.po

@@ -9,7 +9,7 @@ msgstr ""
 "Project-Id-Version: alexandria\n"
 "Report-Msgid-Bugs-To: \n"
 "POT-Creation-Date: 2020-09-13 14:52+0200\n"
-"PO-Revision-Date: 2020-06-28 01:02+0200\n"
+"PO-Revision-Date: 2020-11-01 14:20+0100\n"
 "Last-Translator: Piotr Drąg <piotrdrag@gmail.com>\n"
 "Language-Team: Polish <pl@li.org>\n"
 "Language: pl\n"
@@ -846,7 +846,6 @@ msgid "Invalid ISBN '%s'"
 msgstr "Nieprawidłowy numer ISBN „%s”"
 
 #: ../lib/alexandria/ui/keep_bad_isbn_dialog.rb:18
-#, fuzzy
 msgid ""
 "The book titled '%s' has an invalid ISBN, but still exists in the providers "
 "libraries. Do you want to keep the book but change the ISBN or cancel the "
@@ -990,9 +989,8 @@ msgid "Invalid library name '%s'"
 msgstr "Nieprawidłowa nazwa biblioteki „%s”"
 
 #: ../lib/alexandria/ui/sidepane_manager.rb:55
-#, fuzzy
 msgid "The name provided contains the disallowed character <b>%s</b>"
-msgstr "Podana nazwa zawiera niedozwolony znak <b>%s</b> "
+msgstr "Podana nazwa zawiera niedozwolony znak <b>%s</b>"
 
 #: ../lib/alexandria/ui/sidepane_manager.rb:58
 msgid "Invalid library name"
@@ -1416,9 +1414,3 @@ msgstr "Menedżer domowej biblioteki"
 #: ../alexandria.desktop.in.h:3
 msgid "Manage your book collection"
 msgstr "Zarządzanie domową biblioteką"
-
-#~ msgid "Block is required."
-#~ msgstr "Blokada jest wymagana."
-
-#~ msgid "label"
-#~ msgstr "etykieta"

data/spec/alexandria/ui/export_dialog_spec.rb

@@ -7,9 +7,30 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::ExportDialog do
+  let(:parent) { Gtk::Window.new :toplevel }
+  let(:library) { Alexandria::Library.new "Bar Library" }
+  let(:sort_order) { Alexandria::LibrarySortOrder::Unsorted.new }
+
   it "works" do
-    parent = Gtk::Window.new :toplevel
-    library = instance_double(Alexandria::Library, name: "Bar Library")
-    described_class.new parent, library, :ascending
+    described_class.new parent, library, sort_order
+  end
+
+  describe "#perform" do
+    let(:export_dialog) { described_class.new parent, library, sort_order }
+    let(:chooser) { export_dialog.dialog }
+
+    it "works when response is cancel" do
+      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
+      export_dialog.perform
+    end
+
+    it "works when response is OK" do
+      dir = Dir.mktmpdir
+      allow(chooser).to receive(:run).and_return(Gtk::ResponseType::OK)
+      allow(chooser).to receive(:filename).and_return File.join(dir, "export")
+      export_dialog.perform
+    ensure
+      FileUtils.remove_entry dir
+    end
   end
 end

data/spec/alexandria/ui/import_dialog_spec.rb

@@ -13,6 +13,11 @@ describe Alexandria::UI::ImportDialog do
     described_class.new parent
   end
 
+  it "handles a selection change" do
+    importdialog = described_class.new parent
+    importdialog.dialog.signal_emit "selection_changed"
+  end
+
   describe "#acquire" do
     let(:import_dialog) { described_class.new parent }
     let(:chooser) { import_dialog.dialog }

data/spec/alexandria/ui/smart_library_properties_dialog_spec.rb

@@ -7,18 +7,15 @@
 require_relative "../../spec_helper"
 
 describe Alexandria::UI::SmartLibraryPropertiesDialog do
-  let(:parent) { Gtk::Window.new :toplevel }
-  let(:loader) { Alexandria::LibraryStore.new(TESTDIR) }
-  let(:smart_library) { Alexandria::SmartLibrary.new("Foo", [], :all, loader) }
-
-  it "can be instantiated" do
+  let(:properties_dialog) do
+    parent = Gtk::Window.new :toplevel
+    loader = Alexandria::LibraryStore.new(TESTDIR)
+    smart_library = Alexandria::SmartLibrary.new("Foo", [], :all, loader)
     described_class.new parent, smart_library
   end
+  let(:gtk_dialog) { properties_dialog.dialog }
 
   describe "#acquire" do
-    let(:properties_dialog) { described_class.new parent, smart_library }
-    let(:gtk_dialog) { properties_dialog.dialog }
-
     it "works when response is cancel" do
       allow(gtk_dialog).to receive(:run).and_return(Gtk::ResponseType::CANCEL)
       properties_dialog.acquire
@@ -29,4 +26,24 @@ describe Alexandria::UI::SmartLibraryPropertiesDialog do
       properties_dialog.acquire
     end
   end
+
+  describe "#handle_date_icon_press" do
+    let(:date_entry) do
+      rule_boxes = properties_dialog.handle_add_rule_clicked
+      rule_box = rule_boxes.first
+      rule_box.children[3]
+    end
+
+    before do
+      gtk_dialog.show_all
+    end
+
+    it "pops up the calendar widget" do
+      properties_dialog.handle_date_icon_press(date_entry,
+                                               Gtk::EntryIconPosition::PRIMARY,
+                                               nil)
+      popup = properties_dialog.instance_variable_get(:@calendar_popup)
+      expect(popup).to be_visible
+    end
+  end
 end

data/spec/end_to_end/basic_run_spec.rb

@@ -19,13 +19,6 @@ describe "The Alexandria application" do
     driver.cleanup
   end
 
-  it "starts and can be quit with Ctrl-q" do
-    driver.press_ctrl_q
-
-    status = driver.cleanup
-    expect(status.exitstatus).to eq 0
-  end
-
   it "starts and can be quit with the menu" do
     frame = driver.frame
     menu = frame.find_role :menu_item, /Quit/
@@ -49,7 +42,9 @@ describe "The Alexandria application" do
       table_cell.do_action idx if name == "activate"
     end
 
-    driver.press_ctrl_q
+    frame = driver.frame
+    menu = frame.find_role :menu_item, /Quit/
+    menu.do_action 0
 
     status = driver.cleanup
     expect(status.exitstatus).to eq 0

data/spec/spec_helper.rb

@@ -7,6 +7,7 @@
 require "rspec"
 require "alexandria"
 require "webmock/rspec"
+require "pry"
 
 LIBDIR = File.expand_path("data/libraries", __dir__)
 TESTDIR = File.join(LIBDIR, "test")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alexandria-book-collection-manager
 version: !ruby/object:Gem::Version
-  version: 0.7.6
+  version: 0.7.7
 platform: ruby
 authors:
 - Alexander McCormmach
@@ -28,7 +28,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-01 00:00:00.000000000 Z
+date: 2020-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gettext
@@ -291,13 +291,13 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/dependabot.yml"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".hound.yml"
 - ".reek"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - ".simplecov"
-- ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
 - COPYING
@@ -364,6 +364,7 @@ files:
 - lib/alexandria/ui/book_properties_dialog.rb
 - lib/alexandria/ui/book_properties_dialog_base.rb
 - lib/alexandria/ui/builder_base.rb
+- lib/alexandria/ui/calendar_popup.rb
 - lib/alexandria/ui/callbacks.rb
 - lib/alexandria/ui/columns.rb
 - lib/alexandria/ui/completion_models.rb

data/.travis.yml

@@ -1,45 +0,0 @@
-language: ruby
-
-dist: xenial
-
-services:
-  - xvfb
-
-before_install:
-  - sudo apt-get update
-  # Needed for gtk3 gem
-  - sudo apt-get install libgtk-3-dev
-  # Needed for gstreamer gem
-  - sudo apt-get install libgstreamer1.0-dev
-  # Needed for GooCanvas::Canvas widget
-  - sudo apt-get install libgoocanvas-2.0-dev
-  # Needed for zoom gem
-  - sudo apt-get install libyaz-dev
-  # Needed for intltool-merge executable
-  - sudo apt-get install intltool
-  # Needed for gconftool-2 executable
-  - sudo apt-get install gconf2
-  # Needed to provide A11y dbus service to silence warnings
-  - sudo apt-get install at-spi2-core
-  # Needed to set up sound player pipeline
-  - sudo apt-get install gstreamer1.0-plugins-good
-  # Needed to play sound
-  - sudo apt-get install pulseaudio
-
-cache:
-  bundler: true
-
-script: bundle exec rake
-
-jobs:
-  include:
-    - rvm: 2.5
-    - rvm: 2.6
-    - rvm: 2.7
-    - rvm: 2.7.1
-      name: "RuboCop"
-      script: bundle exec rubocop
-
-branches:
-  only:
-    - master