alephant-sequencer 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7466abcf04d261c43c5530f34afd0175c147a632
-  data.tar.gz: b4d75acc04a87e90a3ea5b4e38710ae71b54a18b
+  metadata.gz: 86b1297e01bdbd2d4c4f81a602b34e895b5ada82
+  data.tar.gz: e492fe5944c17e92b1afbc7ff0f8270558abe51d
 SHA512:
-  metadata.gz: bdac309998678c0f708e1916637b695a668a2640e7d02da705b12b99e8c8a25fd6817bc5e359d7da6ba0b63455f25ef6217db73ffd16d2ac085cb78921810f26
-  data.tar.gz: dc6ea117ba80d4eefb51278b632bc331248f68f482e679321bea31ef2983a6981899c7b4dbfcbe65572ac68ce1313f1001e879dfcf2a1da44703fb1df66c2ba7
+  metadata.gz: 83507711dee28f0b1a8d0abb4a2b5f06927caf541c641d18d4d566d0087320cf10f354e82672de1831c238735a396fe88b8edeae66843a8554de73278877cf6a
+  data.tar.gz: 88468c9d3df88230e5db48fe3f722e89c0bf18a92756555082f4f8179b6181d3a6ec110f4b9063f2051e8eae3ed32922f05d0b9f9d36f53f108896cd9a65c154

data/lib/alephant/sequencer/sequence_table.rb

@@ -8,8 +8,7 @@ require "alephant/support/dynamodb/table"
 module Alephant
   module Sequencer
     class SequenceTable < ::Alephant::Support::DynamoDB::Table
-      include ::Alephant::Logger
-
+      include Logger
       attr_reader :table_name, :client
 
       def initialize(table_name)
@@ -36,7 +35,7 @@ module Alephant
         data.length > 0 ? data[:item]["value"][:n].to_i : 0
       end
 
-      def set_sequence_for(ident, value, last_seen_check = nil)
+      def update_sequence_id(ident, value, last_seen_check = nil)
         begin
 
           current_sequence = last_seen_check.nil? ? sequence_for(ident) : last_seen_check
@@ -67,9 +66,9 @@ module Alephant
             })
           end
 
-          logger.info("SequenceTable#set_sequence_for: #{value} for #{ident} success!")
-        rescue AWS::DynamoDB::Errors::ConditionalCheckFailedException => e
-          logger.warn("SequenceTable#set_sequence_for: (Value to put: #{value}, existing: #{current_sequence}) #{ident} outdated!")
+          logger.info("SequenceTable#update_sequence_id: with new value #{value} for #{ident} success!")
+        rescue AWS::DynamoDB::Errors::ConditionalCheckFailedException
+          logger.warn("SequenceTable#update_sequence_id: (Value to put: #{value}, existing: #{current_sequence}) #{ident} outdated!")
         end
       end
 

data/lib/alephant/sequencer/sequencer.rb

@@ -1,5 +1,4 @@
 require 'jsonpath'
-
 require 'alephant/logger'
 
 module Alephant
@@ -15,6 +14,7 @@ module Alephant
         @exists   = exists?
         @jsonpath = sequence_path
         @ident    = id
+        logger.info("Sequencer#initialize: table: #{sequence_table}, jsonpath: #{sequence_path}, id: #{id}")
       end
 
       def sequential?(msg)
@@ -29,12 +29,12 @@ module Alephant
         last_seen_id = get_last_seen
         sequential = ((last_seen_id || 0) < Sequencer.sequence_id_from(msg, jsonpath))
 
-        block.call(msg) if (sequential || keep_all)
+        block.call if (sequential || keep_all)
 
         if sequential
           set_last_seen(msg, last_seen_id)
         else
-          logger.info("Sequencer#sequence nonsequential message for #{ident}")
+          logger.info("Sequencer#sequence nonsequential message for #{ident} (last_seen_id: #{last_seen_id})")
         end
       end
 
@@ -51,7 +51,7 @@ module Alephant
       def set_last_seen(msg, last_seen_check = nil)
         seen_id = Sequencer.sequence_id_from(msg, jsonpath)
 
-        @sequence_table.set_sequence_for(
+        @sequence_table.update_sequence_id(
           ident, seen_id,
           (exists? ? last_seen_check : nil)
         )

data/lib/alephant/sequencer/version.rb

@@ -1,5 +1,5 @@
 module Alephant
   module Sequencer
-    VERSION = "1.0.0"
+    VERSION = "1.1.0"
   end
 end

data/spec/sequencer_spec.rb

@@ -25,7 +25,7 @@ describe Alephant::Sequencer do
       table.stub(:create)
       table.stub(:sequence_exists)
       table.stub(:sequence_for)
-      table.stub(:set_sequence_for)
+      table.stub(:update_sequence_id)
       table.stub(:truncate!)
       table
     end
@@ -58,10 +58,10 @@ describe Alephant::Sequencer do
 
       let(:a_proc) do
         a_block = double()
-        a_block.should_receive(:called).with(message)
+        a_block.should_receive(:called)
 
-        Proc.new do |msg|
-          a_block.called(msg)
+        Proc.new do
+          a_block.called
         end
       end
 
@@ -69,7 +69,7 @@ describe Alephant::Sequencer do
       let(:stubbed_seen_high) { 3 }
       let(:stubbed_seen_low)  { 1 }
 
-      it "should call the passed block with msg" do
+      it "should call the passed block" do
         subject = Alephant::Sequencer::Sequencer.new(sequence_table, ident, jsonpath)
         subject.validate(message, &a_proc)
       end
@@ -203,12 +203,12 @@ describe Alephant::Sequencer do
           .and_return(last_seen)
       end
 
-      it "calls set_sequence_for(ident, last_seen)" do
+      it "calls update_sequence_id(ident, last_seen)" do
         table = double()
         table.stub(:sequence_exists)
         table.stub(:create)
         table.stub(:sequence_for)
-        table.should_receive(:set_sequence_for)
+        table.should_receive(:update_sequence_id)
           .with(ident, last_seen, nil)
 
         Alephant::Sequencer::Sequencer

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alephant-sequencer
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Robert Kenny