alephant-publisher-request 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 212638793ae63c57e1e7884d4b9734a366e2a87c
-  data.tar.gz: d1150ed44ef1be7842248ebb986c29eca9e85e35
+  metadata.gz: 47fd46ef1bd5568a5d4ea6672a68fef0ebf3b16a
+  data.tar.gz: 8f90c8b8391c9fab241e0f7840af7eb565b08069
 SHA512:
-  metadata.gz: 14e04aac1d08505fdfceb01d1752eb3f19d390400a0770d6ffa77c80fa414708988554afecafe90f9a70cd0aeb8291da100c9c44bb7b394f4ede71b4daa342f8
-  data.tar.gz: 15796375af93d17e6922f02e602819e787ea16d1ae655eab6782eb34dfc9ed6981575d11d8a89557d8ab2db192e9537b7ce2c6fd2ad6501f4a2ce8ecd47e55d8
+  metadata.gz: 274ca023dc2e42790602def922158b8e63d71026c0b67f0b375402200fd83cdaef66a9f981d4d3638ce365719b56dd217d3cac5b97bb4859d1b3d1b0ac3a5870
+  data.tar.gz: 2120ecc5fb640e3019f4a968b21013c2e251ca35653242b932bb12b5f77f5545c69e7157b9a7ea72c2d112e47efb8be77c48f165b74299bf016b52f369b86d87

data/lib/alephant/publisher/request/connection.rb

@@ -0,0 +1,36 @@
+require "alephant/logger"
+
+module Alephant
+  module Publisher
+    module Request
+      class Connection
+        include Logger
+        attr_reader :driver
+
+        def initialize(driver)
+          @driver = driver
+        end
+
+        def get(uri)
+          before   = Time.new
+          response = driver.get(uri)
+          logger.metric(:name => "PublisherRequestDataMapperRequestHTTPTime", :unit => 'Seconds', :value => Time.new - before)
+          raise InvalidApiStatus, response.status unless response.status == 200
+          JSON::parse(response.body, :symbolize_names => true)
+        rescue Faraday::ConnectionFailed
+          logger.metric(:name => "PublisherRequestDataMapperConnectionFailed", :unit => "Count", :value => 1)
+          raise ConnectionFailed
+        rescue JSON::ParserError
+          logger.metric(:name => "PublisherRequestDataMapperInvalidApiResponse", :unit => "Count", :value => 1)
+          raise InvalidApiResponse, "JSON parsing error: #{response.body}"
+        rescue InvalidApiStatus => e
+          logger.metric(:name => "PublisherRequestDataMapperInvalidStatus#{e.status}", :unit => "Count", :value => 1)
+          raise e
+        rescue StandardError => e
+          logger.metric(:name => "PublisherRequestDataMapperApiError", :unit => "Count", :value => 1)
+          raise ApiError, e.message
+        end
+      end
+    end
+  end
+end

data/lib/alephant/publisher/request/data_mapper.rb

@@ -1,12 +1,9 @@
-require 'alephant/logger'
 require 'json'
 
 module Alephant
   module Publisher
     module Request
       class DataMapper
-        include Logger
-
         attr_reader :connection, :context
 
         def initialize(connection, context = {})
@@ -21,23 +18,7 @@ module Alephant
         protected
 
         def get(uri)
-          before = Time.new
-          response = connection.get(uri)
-          logger.metric(:name => "PublisherRequestDataMapperRequestHTTPTime", :unit => 'Seconds', :value => Time.new - before)
-          raise InvalidApiStatus, response.status unless response.status == 200
-          JSON::parse(response.body, :symbolize_names => true)
-        rescue Faraday::ConnectionFailed
-          logger.metric(:name => "PublisherRequestDataMapperConnectionFailed", :unit => "Count", :value => 1)
-          raise ConnectionFailed
-        rescue JSON::ParserError
-          logger.metric(:name => "PublisherRequestDataMapperInvalidApiResponse", :unit => "Count", :value => 1)
-          raise InvalidApiResponse, "JSON parsing error: #{response.body}"
-        rescue InvalidApiStatus => e
-          logger.metric(:name => "PublisherRequestDataMapperInvalidStatus#{e.status}", :unit => "Count", :value => 1)
-          raise e
-        rescue StandardError => e
-          logger.metric(:name => "PublisherRequestDataMapperApiError", :unit => "Count", :value => 1)
-          raise ApiError, e.message
+          connection.get uri
         end
       end
     end

data/lib/alephant/publisher/request/version.rb

@@ -1,7 +1,7 @@
 module Alephant
   module Publisher
     module Request
-      VERSION = "0.1.2"
+      VERSION = "0.2.0"
     end
   end
 end

data/spec/connection_spec.rb

@@ -0,0 +1,47 @@
+require "spec_helper"
+
+describe Alephant::Publisher::Request::Connection do
+  let (:driver) { instance_double(Faraday::Connection, :get => nil) }
+  let (:uri) { "/foo/bar/baz" }
+
+  subject { described_class.new driver }
+
+  describe "#get" do
+    let (:expected_raw_data) do
+      {
+        :some => 'data'
+      }
+    end
+    let (:expected_data) { JSON.generate(expected_raw_data, :symbolize_names => true) }
+    let (:expected_response) { instance_double(Faraday::Response, :body => expected_data, :status => 200) }
+
+    context "with a valid endpoint" do
+      before(:each) do
+        allow(driver).to receive(:get).and_return(expected_response)
+      end
+
+      specify { expect(subject.get(uri)).to eq expected_raw_data }
+    end
+
+    context "invalid hostname" do
+      let (:expected_exception) { Alephant::Publisher::Request::ConnectionFailed }
+      let (:faraday_exception) { Faraday::ConnectionFailed.new(StandardError) }
+
+      before(:each) do
+        allow(driver).to receive(:get).and_raise(faraday_exception)
+      end
+
+      specify { expect { subject.get(uri)}.to raise_error expected_exception }
+    end
+
+    context "invalid status code" do
+      let (:status_code) { 503 }
+      let (:expected_exception) { Alephant::Publisher::Request::InvalidApiStatus }
+      before(:each) do
+        allow(driver).to receive(:get).and_return(OpenStruct.new(:status => status_code))
+      end
+
+      specify { expect { subject.get(uri)}.to raise_error expected_exception }
+    end
+  end
+end

data/spec/integration/rack_server_spec.rb

@@ -5,7 +5,8 @@ describe Alephant::Publisher::Request do
   let (:response) { instance_double(Faraday::Response, :status => 200, :body => nil) }
   let (:base_path) { File.join(File.dirname(__FILE__), '..', 'fixtures', 'components') }
   let (:processor) { Alephant::Publisher::Request::Processor.new(base_path) }
-  let (:connection) { instance_double(Faraday::Connection, :get => response) }
+  let (:driver) { instance_double(Faraday::Connection, :get => response) }
+  let (:connection) { Alephant::Publisher::Request::Connection.new driver }
   let (:data_mapper_factory) { Alephant::Publisher::Request::DataMapperFactory.new(connection, base_path) }
   let (:app) { subject.create(processor, data_mapper_factory, { :debug => true }) }
 

data/spec/spec_helper.rb

@@ -1,11 +1,13 @@
-require 'pry'
+require "pry"
 
-require 'aws-sdk'
-require 'faraday'
-require 'alephant/renderer'
-require 'alephant/publisher/request'
-require 'alephant/publisher/request/error'
-require 'alephant/publisher/request/data_mapper'
-require 'alephant/publisher/request/data_mapper_factory'
+require "json"
+require "aws-sdk"
+require "faraday"
+require "alephant/renderer"
+require "alephant/publisher/request"
+require "alephant/publisher/request/error"
+require "alephant/publisher/request/data_mapper"
+require "alephant/publisher/request/connection"
+require "alephant/publisher/request/data_mapper_factory"
 
-require_relative './fixtures/components/foo/mapper'
+require_relative "./fixtures/components/foo/mapper"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alephant-publisher-request
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Integralist
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-12-17 00:00:00.000000000 Z
+date: 2015-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -251,14 +251,15 @@ files:
 - Rakefile
 - alephant-publisher-request.gemspec
 - lib/alephant/publisher/request.rb
+- lib/alephant/publisher/request/connection.rb
 - lib/alephant/publisher/request/data_mapper.rb
 - lib/alephant/publisher/request/data_mapper_factory.rb
 - lib/alephant/publisher/request/error.rb
 - lib/alephant/publisher/request/processor.rb
 - lib/alephant/publisher/request/processor/base.rb
 - lib/alephant/publisher/request/version.rb
+- spec/connection_spec.rb
 - spec/data_mapper_factory_spec.rb
-- spec/data_mapper_spec.rb
 - spec/fixtures/components/foo/mapper.rb
 - spec/fixtures/components/foo/models/foo.rb
 - spec/fixtures/components/foo/templates/foo.mustache
@@ -294,8 +295,8 @@ signing_key:
 specification_version: 4
 summary: '...'
 test_files:
+- spec/connection_spec.rb
 - spec/data_mapper_factory_spec.rb
-- spec/data_mapper_spec.rb
 - spec/fixtures/components/foo/mapper.rb
 - spec/fixtures/components/foo/models/foo.rb
 - spec/fixtures/components/foo/templates/foo.mustache

data/spec/data_mapper_spec.rb

@@ -1,53 +0,0 @@
-require "spec_helper"
-
-describe FooMapper do
-  let (:connection) { instance_double(Faraday::Connection, :get => nil) }
-  let (:context) do
-    {
-      :foo => :bar
-    }
-  end
-
-  subject { described_class.new(connection, context) }
-
-  describe "#data" do
-    let (:expected_raw_data) do
-      {
-        :some => 'data'
-      }
-    end
-    let (:expected_data) { JSON::generate(expected_raw_data, :symbolize_names => true) }
-    let (:expected_response) { instance_double(Faraday::Response, :body => expected_data, :status => 200) }
-
-    context "with a valid endpoint" do
-      before(:each) do
-        allow(connection).to receive(:get).with("/some/test/endpoint/#{context.values[0]}").and_return(expected_response)
-      end
-
-      specify { expect(subject.data).to eq expected_raw_data }
-    end
-
-    context "invalid hostname" do
-      let (:expected_exception) { Alephant::Publisher::Request::ConnectionFailed }
-      let (:faraday_exception) { Faraday::ConnectionFailed.new(StandardError) }
-
-      before(:each) do
-        allow(connection).to receive(:get).and_raise(faraday_exception)
-      end
-
-      specify { expect { subject.data }.to raise_error expected_exception }
-    end
-
-    context "invalid status code" do
-      let (:status_code) { 503 }
-      let (:expected_exception) { Alephant::Publisher::Request::InvalidApiStatus }
-      before(:each) do
-        allow(connection).to receive(:get).and_return(OpenStruct.new(:status => status_code))
-      end
-
-      specify { expect { subject.data }.to raise_error expected_exception }
-    end
-
-
-  end
-end