alephant-publisher-queue 2.1.4 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 08bdf47b7df3db0f1202c168266202660c485eaa
-  data.tar.gz: fb19ff16c45343e1ca7cf47c8f0ff424c72123a3
+  metadata.gz: e4e4629b6edec4107606c37b56d4c20c041bc1e9
+  data.tar.gz: 9f96470b7492db9645d08a24c4ccf73a7a74bab0
 SHA512:
-  metadata.gz: 792e400244a8b219c9bab5124103794ffd5b0e2d874aed621b2f158bcbe03e17539af1283132fd538de50fdddfea1f767f78af7b2d1c95b3f3abe8ac4d1f8c9f
-  data.tar.gz: f25b7e3d906a302c0e4cdd1157f880076a487dd1297862bcc621f60450db563c11f5bd80bb24b2ab627ddd57d8c2d60cca386ba6cdcef3213f56301d30884d73
+  metadata.gz: 20162a9089a2c093fa7e4636e7abee2927866b405218c0a23cfe013227419131982cd034c75b7e50e67fd378dc837dadff6efff5b374d20fb2c48bf1d2e88e39
+  data.tar.gz: 988aca2dc1c876ecfe9315e44699fd5d69701f7a03bd9b079a031b03d6048962fc9f174fa40cab834379636265003bf86b5636e641a1c6d8c54af4f8c3230967

data/Rakefile

@@ -1,4 +1,4 @@
-$:.unshift File.join(File.dirname(__FILE__), "lib")
+$LOAD_PATH.unshift File.join(File.dirname(__FILE__), "lib")
 
 require "rspec/core/rake_task"
 require "bundler/gem_tasks"

data/alephant-publisher-queue.gemspec

@@ -31,9 +31,9 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency "aws-sdk", "~> 1.0"
   spec.add_runtime_dependency "crimp"
   spec.add_runtime_dependency "alephant-support"
-  spec.add_runtime_dependency "alephant-sequencer", "~> 2"
+  spec.add_runtime_dependency "alephant-sequencer", "~> 3"
   spec.add_runtime_dependency "alephant-cache"
   spec.add_runtime_dependency "alephant-logger", "~> 3.1"
-  spec.add_runtime_dependency "alephant-lookup", "~> 1"
+  spec.add_runtime_dependency "alephant-lookup", "~> 2"
   spec.add_runtime_dependency "alephant-renderer"
 end

data/lib/alephant/publisher/env.rb

@@ -6,7 +6,7 @@ config_file = "config/aws.yaml"
 
 AWS.eager_autoload!
 
-if File.exists? config_file
+if File.exist? config_file
   config = YAML.load(File.read(config_file))
   AWS.config(config)
 end

data/lib/alephant/publisher/queue.rb

@@ -32,7 +32,7 @@ module Alephant
             aws_queue,
             archiver,
             opts.queue[:visibility_timeout] || VISIBILITY_TIMEOUT,
-            opts.queue[:receive_wait_time]  || RECEIVE_WAIT_TIME,
+            opts.queue[:receive_wait_time]  || RECEIVE_WAIT_TIME
           )
         end
 
@@ -58,7 +58,7 @@ module Alephant
         end
 
         def whitelist_key(options, key)
-          options.has_key?(key) && key != :log_validator
+          options.key?(key) && key != :log_validator
         end
 
         def archive_cache

data/lib/alephant/publisher/queue/processor/base.rb

@@ -2,7 +2,7 @@ module Alephant
   module Publisher
     module Queue
       class BaseProcessor
-        def consume(msg)
+        def consume(_msg)
           raise NotImplementedError.new(
             "You must implement the #consume(msg) method"
           )

data/lib/alephant/publisher/queue/sqs_helper/archiver.rb

@@ -46,7 +46,7 @@ module Alephant
                 "event"       => "MessageStored",
                 "messageBody" => msg_body,
                 "method"      => "#{self.class}#store"
-              ) if log_validator.(msg_body)
+              ) if log_validator.call(msg_body)
             end
           end
 

data/lib/alephant/publisher/queue/version.rb

@@ -1,7 +1,7 @@
 module Alephant
   module Publisher
     module Queue
-      VERSION = "2.1.4"
+      VERSION = "2.2.0"
     end
   end
 end

data/lib/alephant/publisher/queue/writer.rb

@@ -97,9 +97,10 @@ module Alephant
         def seq_for(id)
           Sequencer.create(
             config[:sequencer_table_name],
-            seq_key_from(id),
-            config[:sequence_id_path],
-            config[:keep_all_messages] == "true"
+            :id       => seq_key_from(id),
+            :jsonpath => config[:sequence_id_path],
+            :keep_all => config[:keep_all_messages] == "true",
+            :config   => config
           )
         end
 
@@ -130,7 +131,7 @@ module Alephant
         end
 
         def lookup
-          Lookup.create(config[:lookup_table_name])
+          Lookup.create(config[:lookup_table_name], config)
         end
       end
     end

data/spec/archiver_spec.rb

@@ -1,11 +1,11 @@
 require "spec_helper"
 
 describe Alephant::Publisher::Queue::SQSHelper::Archiver do
-  let (:cache)    { instance_double("Alephant::Cache", :put => nil) }
-  let (:queue)    { instance_double("AWS::SQS::Queue", :url => nil) }
-  let (:msg_body) {{ :Message => JSON.generate(msg_uri) }}
-  let (:msg_uri)  {{ :uri => "/content/asset/newsbeat" }}
-  let (:message) do
+  let(:cache)    { instance_double("Alephant::Cache", :put => nil) }
+  let(:queue)    { instance_double("AWS::SQS::Queue", :url => nil) }
+  let(:msg_body) { { :Message => JSON.generate(msg_uri) } }
+  let(:msg_uri)  { { :uri => "/content/asset/newsbeat" } }
+  let(:message) do
     instance_double(
       "AWS::SQS::ReceivedMessage",
       :id    => "id",
@@ -15,17 +15,17 @@ describe Alephant::Publisher::Queue::SQSHelper::Archiver do
     )
   end
 
-  let (:opts) do
+  let(:opts) do
     {
       :log_archive_message => true,
       :async_store         => false
     }
   end
 
-  let (:subject) { described_class.new(cache, opts) }
+  let(:subject) { described_class.new(cache, opts) }
 
   describe "#see" do
-    let (:time_now) { DateTime.parse("Feb 24 1981") }
+    let(:time_now) { DateTime.parse("Feb 24 1981") }
 
     context "calls cache put with the correct params" do
       before(:each) do

data/spec/publisher_spec.rb

@@ -2,11 +2,11 @@ require "spec_helper"
 
 describe Alephant::Publisher::Queue do
   let(:options)       { Alephant::Publisher::Queue::Options.new }
-  let(:queue)         { double("AWS::SQS::Queue", :url => nil ) }
+  let(:queue)         { double("AWS::SQS::Queue", :url => nil) }
   let(:client_double) { double("AWS::SQS", :queues => queue_double) }
-  let(:queue_double)  {
+  let(:queue_double) do
     double("AWS::SQS::QueueCollection", :[] => queue, :url_for => nil)
-  }
+  end
 
   before(:each) do
     expect(AWS::SQS).to receive(:new).and_return(client_double)

data/spec/writer_spec.rb

@@ -9,7 +9,7 @@ describe Alephant::Publisher::Queue::Writer do
       :s3_bucket_id         => :s3_bucket_id,
       :s3_object_path       => :s3_object_path,
       :sequence_id_path     => "$.sequence",
-      :sequencer_table_name => :sequencer_table_name,
+      :sequencer_table_name => "sequencer_table_name",
       :view_path            => :view_path
     }
   end
@@ -23,17 +23,19 @@ describe Alephant::Publisher::Queue::Writer do
         opts[:s3_object_path]
       )
 
-
     allow_any_instance_of(
       Alephant::Sequencer::SequenceTable
-    ).to receive(:create)
-
+    ).to receive_messages(
+      :create          => nil,
+      :sequence_exists => nil
+    )
 
     allow_any_instance_of(Alephant::Sequencer::Sequencer)
       .to receive_messages(
         :sequencer_id_from => nil,
         :set_last_seen     => nil,
-        :get_last_seen     => nil
+        :get_last_seen     => nil,
+        :exists?           => nil
       )
 
     allow_any_instance_of(Alephant::Lookup::LookupTable)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alephant-publisher-queue
 version: !ruby/object:Gem::Version
-  version: 2.1.4
+  version: 2.2.0
 platform: ruby
 authors:
 - BBC News
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-03-15 00:00:00.000000000 Z
+date: 2016-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -197,7 +197,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '3'
   name: alephant-sequencer
   prerelease: false
   type: :runtime
@@ -205,7 +205,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '3'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -239,7 +239,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '2'
   name: alephant-lookup
   prerelease: false
   type: :runtime
@@ -247,7 +247,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '2'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements: