alephant-broker 1.3.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 54b3da006e03b9b1bb3a4697ef59e5472a872481
-  data.tar.gz: b6fb65f722c3cb34f5589327dc1478244d1367fb
+  metadata.gz: 13b219a0a816af81e147be4076441a641d597094
+  data.tar.gz: d1a8e7340e1928c339fded8e0ea1b47cc8cfa3a0
 SHA512:
-  metadata.gz: dc7a8957b4a78a63681e211df68fb18a8bd27c48093a858afab1a394bcc07809666c36f3ac5e711e2726372c306385fb53e1099bc274753a6b7b74e3e562554c
-  data.tar.gz: 6b16b372746c156f6ec2a93c7f906985f88e25e5445df00d4539b1d0567c3408889d2b6f85ab85c99194a820af74c0f187649cb5e4b6341215cb5ae41cd6134a
+  metadata.gz: 3493cad83967ed33668d6fd191e57aa3b58c30628f8ffad8e82e75dc72ef0ec888c7ffd16cca35cbfd015d7b70a6e7b7319323ba4f5db06fd6531a8fa30c99d1
+  data.tar.gz: 2d398103e43e2945664a7d879578eed73b28b2386f340517a84b4aa107a5645c1c80954555608fdd32512b4d7aa060a0b4fb0684aa5c0403df8166f913a49c75

data/alephant-broker.gemspec

@@ -37,4 +37,5 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'alephant-sequencer'
   spec.add_runtime_dependency "dalli-elasticache"
   spec.add_runtime_dependency 'pmap'
+  spec.add_runtime_dependency "faraday"
 end

data/lib/alephant/broker/load_strategy/http.rb

@@ -0,0 +1,68 @@
+require 'alephant/broker/cache'
+require 'alephant/broker/errors/content_not_found'
+require 'faraday'
+
+module Alephant
+  module Broker
+    module LoadStrategy
+      class HTTP
+        class RequestFailed < StandardError; end
+
+        class URL
+          def generate
+            raise NotImplementedError
+          end
+        end
+
+        def initialize(url_generator)
+          @url_generator = url_generator
+        end
+
+        def load(component_meta)
+          cache_object(component_meta)
+        rescue
+          cache.set(component_meta.cache_key, content(component_meta))
+        end
+
+        private
+
+        attr_reader :cache, :url_generator
+
+        def cache
+          @cache ||= Cache::Client.new
+        end
+
+        def cache_object(component_meta)
+          cache.get(component_meta.cache_key) { content component_meta }
+        end
+
+        def content(component_meta)
+          resp = request component_meta
+          {
+            :content => resp.body,
+            :content_type => extract_content_type_from(resp.env.response_headers)
+          }
+        end
+
+        def extract_content_type_from(headers)
+          headers['content-type'].split(';').first
+        end
+
+        def request(component_meta)
+          component_meta.cached = false
+          Faraday.get(url_for component_meta).
+                  tap { |r| raise ContentNotFound unless r.success? }
+        rescue => e
+          raise RequestFailed, e
+        end
+
+        def url_for(component_meta)
+          url_generator.generate(
+            component_meta.id,
+            component_meta.options
+          )
+        end
+      end
+    end
+  end
+end

data/lib/alephant/broker/version.rb

@@ -1,5 +1,5 @@
 module Alephant
   module Broker
-    VERSION = "1.3.1"
+    VERSION = "2.0.0"
   end
 end

data/spec/http_spec.rb

@@ -0,0 +1,87 @@
+require "spec_helper"
+
+describe Alephant::Broker::LoadStrategy::HTTP do
+  subject { described_class.new(url_generator) }
+
+  let(:component_meta) do
+    double('Alephant::Broker::ComponentMeta', cache_key: 'cache_key', id: 'test')
+  end
+  let(:url_generator) { double(generate: "http://foo.bar") }
+  let(:cache) { double('Alephant::Broker::Cache::Client') }
+  let(:body) { '<h1>Batman!</h1>' }
+  let(:content) do
+    {
+      :content => body,
+      :content_type => 'text/html'
+    }
+  end
+
+  before :each do
+    allow(Alephant::Broker::Cache::Client).to receive(:new) { cache }
+  end
+
+  describe "#load" do
+    context "content in cache" do
+      before :each do
+        allow(cache).to receive(:get) { content }
+      end
+
+      it "gets from cache" do
+        expect(subject.load component_meta).to eq content
+      end
+    end
+
+    context "content not in cache" do
+      before :each do
+        allow(cache).to receive(:get).and_yield
+        allow(component_meta).to receive(:'cached=').with(false) { false }
+        allow(component_meta).to receive(:options).and_return Hash.new
+      end
+
+      context "and available over HTTP" do
+        let(:env) { double('env', response_headers: response_headers) }
+        let(:response_headers) { {'content-type' => 'text/html; test'} }
+
+        before :each do
+          allow(Faraday).to receive(:get) do
+            instance_double(
+              'Faraday::Response',
+              body: body,
+              :'success?' => true,
+              env: env)
+          end
+         end
+
+        it "gets from HTTP" do
+         expect(subject.load component_meta).to eq content
+        end
+      end
+
+      context "and HTTP request fails" do
+        before :each do
+          allow(Faraday).to receive(:get).and_raise 
+        end
+
+        specify do
+          expect do
+            subject.load component_meta
+          end.to raise_error Alephant::Broker::LoadStrategy::HTTP::RequestFailed
+        end
+      end
+
+      context "and HTTP request 404s" do
+        before :each do
+          allow(Faraday).to receive(:get) do
+            instance_double('Faraday::Response', body: body, :'success?' => false)
+          end
+        end
+
+        specify do
+          expect do
+            subject.load component_meta
+          end.to raise_error Alephant::Broker::LoadStrategy::HTTP::RequestFailed
+        end
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -4,6 +4,10 @@ require 'pry'
 require 'json'
 require 'alephant/broker'
 require 'alephant/broker/load_strategy/s3'
+require "alephant/broker/load_strategy/http"
+require "alephant/broker/cache"
+require "alephant/broker/errors/content_not_found"
+
 require 'rack/test'
 
 ENV['RACK_ENV'] = 'test'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: alephant-broker
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Steven Jack
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-10-21 00:00:00.000000000 Z
+date: 2014-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -248,6 +248,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  name: faraday
+  prerelease: false
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Brokers requests for alephant components
 email:
 - stevenmajack@gmail.com
@@ -274,6 +288,7 @@ files:
 - lib/alephant/broker/errors/content_not_found.rb
 - lib/alephant/broker/errors/invalid_asset_id.rb
 - lib/alephant/broker/errors/invalid_cache_key.rb
+- lib/alephant/broker/load_strategy/http.rb
 - lib/alephant/broker/load_strategy/s3.rb
 - lib/alephant/broker/request.rb
 - lib/alephant/broker/request/asset.rb
@@ -290,6 +305,7 @@ files:
 - lib/alephant/broker/version.rb
 - spec/fixtures/json/batch.json
 - spec/fixtures/json/batch_compiled.json
+- spec/http_spec.rb
 - spec/integration/spec_helper.rb
 - spec/rack_spec.rb
 - spec/spec_helper.rb
@@ -320,6 +336,7 @@ summary: Brokers requests for alephant components
 test_files:
 - spec/fixtures/json/batch.json
 - spec/fixtures/json/batch_compiled.json
+- spec/http_spec.rb
 - spec/integration/spec_helper.rb
 - spec/rack_spec.rb
 - spec/spec_helper.rb