alchemy_cms 7.2.8 → 7.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0fdef966fae65762629b97f68de454dba401b0343f2556db588e4c9d1fce72b9
-  data.tar.gz: 50457894d1edc86920364f92d283aca506aee9912f8709ad7adc627494852031
+  metadata.gz: ca577f0e46713ddcda567834a14df89269d469c463d40b9ef45a94cb75c51d5c
+  data.tar.gz: 7f2697e309ebf31067618f09c84f6b41811bc3ea3764047e2d9cbb4a69c9e5d3
 SHA512:
-  metadata.gz: 77adc60f06685b4259a1015439f6ab1c8e8772314050bf1de65e38fae047a4dae83bd607c2f95f88abaf4a273ddb245e4b23d4713a8c021c349403554394cf8b
-  data.tar.gz: 4c44fa0cc929f1eaecf86cb3b5d46ed6345627c408b00f5ea22cd037dd2308013118d439edb9815c6f67a5a5830ec279fdaf298f4f83d9bd5d504df82c9ab5b0
+  metadata.gz: f4060445469483578207a2e432bf9b63c4729e47eeb21ea6cc43a1019f677b2e699b531dcf3d56515c8ec599185e5ce2859d87ac12410cc7b600ffee344e1f1a
+  data.tar.gz: 364bd7003f899d43e2f3ee5023f62f8c49be6c572af6c2730f98ca612345e56f5656423ae0b950513c19028734fed908a398a4e5e52cdacfb198c0d7cd0de9cf

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 7.2.9 (2025-03-17)
+
+- [7.2-stable] Fix link dialog for links with url scheme mailto [#3205](https://github.com/AlchemyCMS/alchemy_cms/pull/3205) ([alchemycms-bot](https://github.com/alchemycms-bot))
+- [7.2-stable] CI: Use own script to check changes files [#3201](https://github.com/AlchemyCMS/alchemy_cms/pull/3201) ([tvdeyen](https://github.com/tvdeyen))
+- [7.2-stable] Add rel="noopener noreferrer" to external links [#3184](https://github.com/AlchemyCMS/alchemy_cms/pull/3184) ([alchemycms-bot](https://github.com/alchemycms-bot))
+
 ## 7.2.8 (2025-01-24)
 
 - [7.2-stable] fix attribute sorting across Ruby versions [#3162](https://github.com/AlchemyCMS/alchemy_cms/pull/3162) ([alchemycms-bot](https://github.com/alchemycms-bot))

data/app/components/alchemy/admin/link_dialog/internal_tab.rb

@@ -49,7 +49,8 @@ module Alchemy
         end
 
         def page_attributes
-          locale, urlname, _fragment = uri.path.match(PAGE_URL_PATTERN)&.captures
+          # uri.path might be nil if the protocol is mailto: or a similar scheme that cannot have paths
+          locale, urlname, _fragment = uri.path&.match(PAGE_URL_PATTERN)&.captures
 
           if locale && urlname.present?
             {language_code: locale, urlname: urlname}

data/app/components/alchemy/ingredients/link_view.rb

@@ -1,6 +1,8 @@
 module Alchemy
   module Ingredients
     class LinkView < BaseView
+      include LinkTarget
+
       attr_reader :link_text
 
       # @param ingredient [Alchemy::Ingredient]
@@ -12,7 +14,11 @@ module Alchemy
       end
 
       def call
-        link_to(link_text, value, {target: ingredient.link_target.presence}.merge(html_options)).html_safe
+        target = ingredient.link_target.presence
+        link_to(link_text, value, {
+          target: link_target_value(target),
+          rel: link_rel_value(target)
+        }.merge(html_options)).html_safe
       end
     end
   end

data/app/components/alchemy/ingredients/picture_view.rb

@@ -4,6 +4,8 @@ module Alchemy
   module Ingredients
     # Renders a picture ingredient view
     class PictureView < BaseView
+      include LinkTarget
+
       attr_reader :ingredient,
         :show_caption,
         :disable_link,
@@ -46,10 +48,11 @@ module Alchemy
         output = caption ? img_tag + caption : img_tag
 
         if is_linked?
+          target = ingredient.link_target.presence
           output = link_to(output, url_for(ingredient.link), {
             title: ingredient.link_title.presence,
-            target: (ingredient.link_target == "blank") ? "_blank" : nil,
-            data: {link_target: ingredient.link_target.presence}
+            rel: link_rel_value(target),
+            target: link_target_value(target)
           })
         end
 

data/app/components/alchemy/ingredients/text_view.rb

@@ -1,6 +1,8 @@
 module Alchemy
   module Ingredients
     class TextView < BaseView
+      include LinkTarget
+
       attr_reader :disable_link
 
       delegate :dom_id, :link, :link_title, :link_target,
@@ -21,7 +23,8 @@ module Alchemy
           link_to(value, url_for(link), {
             id: dom_id.presence,
             title: link_title,
-            target: link_target
+            target: link_target_value(link_target),
+            rel: link_rel_value(link_target)
           }.merge(html_options))
         end.html_safe
       end

data/app/components/concerns/alchemy/ingredients/link_target.rb

@@ -0,0 +1,18 @@
+module Alchemy
+  module Ingredients
+    module LinkTarget
+      BLANK_VALUE = "_blank"
+      REL_VALUE = "noopener noreferrer"
+
+      def link_rel_value(target)
+        if link_target_value(target) == BLANK_VALUE
+          REL_VALUE
+        end
+      end
+
+      def link_target_value(target)
+        (target == "blank") ? BLANK_VALUE : target
+      end
+    end
+  end
+end

data/lib/alchemy/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Alchemy
-  VERSION = "7.2.8"
+  VERSION = "7.2.9"
 
   def self.version
     VERSION

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: alchemy_cms
 version: !ruby/object:Gem::Version
-  version: 7.2.8
+  version: 7.2.9
 platform: ruby
 authors:
 - Thomas von Deyen
@@ -12,7 +12,7 @@ authors:
 - Martin Meyerhoff
 bindir: bin
 cert_chain: []
-date: 2025-01-24 00:00:00.000000000 Z
+date: 2025-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionmailer
@@ -806,6 +806,7 @@ files:
 - app/components/alchemy/ingredients/select_view.rb
 - app/components/alchemy/ingredients/text_view.rb
 - app/components/alchemy/ingredients/video_view.rb
+- app/components/concerns/alchemy/ingredients/link_target.rb
 - app/controllers/alchemy/admin/attachments_controller.rb
 - app/controllers/alchemy/admin/base_controller.rb
 - app/controllers/alchemy/admin/clipboard_controller.rb
@@ -1431,7 +1432,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - ImageMagick (libmagick), v6.6 or greater.
-rubygems_version: 3.6.3
+rubygems_version: 3.6.5
 specification_version: 4
 summary: A powerful, userfriendly and flexible CMS for Rails
 test_files: []