alba 3.4.0 → 3.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d1a7b2fac43a1ae40bc0598d6f989fb7b81108d00ca929d31327113590880b2f
-  data.tar.gz: d6bc3c22c9178eeaf8b3b7f3d3d92bc526edd18904fa736c0c25488250f89d02
+  metadata.gz: ad9473eff6bbd8fb5f282d2ad7c9d84ad3f104b0a5e190999bd7788fcec2d8be
+  data.tar.gz: f778882ced7677d043694ba257df58bea4fb09fd108804fd4c0a28b7c722cc20
 SHA512:
-  metadata.gz: da62c8a7d30ab7c4c39032950c9e02cef238b8662f403843351116fb86e3a3010e2780a3b5efe958697fd698e7e703a130a292129f3efad4da253cc9e84570bd
-  data.tar.gz: 94a580ab65397d4f61a8534bfd22999d86bdd9e6cca0ec83b15d03bd2fdbdedc220bbbaf091b20c34e58c7dfe5c7b21c9f046a78b25639dcecf59b71b95199c0
+  metadata.gz: 484f8725e3a71a7d7714f2d19e0c005c11fd995c33e59431bef48f1dac8336360fef3fdd7657f47984bded1753e366a85b4e8bd7101bd0e418c658a508788ccf
+  data.tar.gz: 0e7c53e58d3e9146b775b06d929b37e9860dba366114db7aca21e53628e78f946dd0ac13c7dc2788b0cc7fb10eb7211b9afc0c7ecf7c4bedd892786a07c04ea2

data/.github/workflows/main.yml

@@ -12,9 +12,11 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        ruby: ['3.0', 3.1, 3.2, 3.3, head, jruby, truffleruby]
+        ruby: ['3.0', 3.1, 3.2, 3.3, 3.4, head, jruby, truffleruby]
         gemfile: [all, without_active_support, without_oj]
         exclude:
+          - os: windows-latest
+            ruby: 3.4
           - os: windows-latest
             ruby: jruby
           - os: windows-latest

data/CHANGELOG.md

@@ -6,6 +6,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.5.0] 2025-01-01
+
+### Added
+
+-  `render_serialized_json` now works with `root_key` and `meta` [#398](https://github.com/okuramasafumi/alba/pull/398)
+
+### Improved
+
+- Add transform_keys caching [#402](https://github.com/okuramasafumi/alba/pull/402)
+
 ## [3.4.0] 2024-12-01
 
 ### Added

data/Gemfile

@@ -23,6 +23,16 @@ gem 'simplecov-cobertura', require: false # For test coverage
 # gem 'typeprof', require: false # For language server and typing
 gem 'yard', require: false # For documentation
 
+# FIXME: There is an upstream JRuby 9.4.9.0 issue with `psych` and the latest
+# version of `jar-dependencies`. The issue will be resolved with the release of
+# 9.4.10.0. Then, we can remove this `jar-dependencies` dependency lock.
+#
+# For more information, see: https://github.com/jruby/jruby/issues/8488
+#
+if defined?(JRUBY_VERSION) && Gem::Version.new(JRUBY_VERSION) < Gem::Version.new('9.4.10.0')
+  gem 'jar-dependencies', '< 0.5' # Fix
+end
+
 platforms :ruby do
   gem 'oj', '~> 3.11', require: false # For backend
   gem 'ruby-prof', require: false # For performance profiling

data/README.md

@@ -686,7 +686,7 @@ Alba.serialize(something)
 # => Same as `FooResource.new(something).serialize` when `something` is an instance of `Foo`.
 ```
 
-Although this might be useful sometimes, it's generally recommended to define a class for Resource.
+Although this might be useful sometimes, it's generally recommended to define a class for Resource. Defining a class is often more readable and more maintainable, and inline definitions cannot levarage the benefit of YJIT (it's the slowest with the benchmark YJIT enabled).
 
 #### Inline definition for multiple root keys
 
@@ -1156,7 +1156,7 @@ end
 class UserResource
   include Alba::Resource
 
-  root_key!
+  root_key! # This is required to add inferred root key, otherwise it has no root key
 
   attributes :id
 

data/benchmark/Gemfile

@@ -9,9 +9,11 @@ gem 'alba', path: '../'
 gem 'benchmark-ips'
 gem 'benchmark-memory'
 gem 'blueprinter'
+gem 'csv'
 gem 'fast_serializer_ruby'
 gem 'jbuilder'
 gem 'jserializer'
+gem 'json'
 gem 'multi_json'
 gem 'oj'
 gem 'oj_serializers'

data/benchmark/README.md

@@ -1,6 +1,24 @@
 ## Benchmark for json serializers
 
-This directory contains a few different benchmark scripts. They all use inline Bundler definitions so you can run them by `ruby benchmark/collection.rb` for instance.
+This directory contains a few different benchmark scripts.
+
+## How to run
+
+```
+bundle install
+
+# with `Oj.optimize_rails`
+bundle exec ruby collection.rb
+
+# without `Oj.optimize_rails`
+NO_OJ_OPTIMIZE_RAILS=1 bundle exec ruby collection.rb
+
+# with `Oj.optimize_rails` and YJIT
+YJIT=1 bundle exec ruby collection.rb
+
+# with YJIT and without `Oj.optimize_rails`
+YJIT=1 NO_OJ_OPTIMIZE_RAILS=1 bundle exec ruby collection.rb
+```
 
 ## Result
 
@@ -65,7 +83,7 @@ Comparison:
                  ams:       14.2 i/s - 32.28x  slower
 ```
 
-`benchmark-ips` with `Oj.optimize_rail` and YJIT:
+`benchmark-ips` with `Oj.optimize_rails` and YJIT:
 
 ```
 Comparison:
@@ -82,7 +100,7 @@ Comparison:
                  ams:       20.4 i/s - 33.10x  slower
 ```
 
-`benchmark-ips` with YJIT and without `Oj.optimize_rail`:
+`benchmark-ips` with YJIT and without `Oj.optimize_rails`:
 
 ```
 Comparison:

data/benchmark/collection.rb

@@ -7,6 +7,8 @@ require_relative 'prep'
 
 require "alba"
 
+Alba.inflector = :active_support
+
 class AlbaCommentResource
   include ::Alba::Resource
   attributes :id, :body
@@ -21,6 +23,16 @@ class AlbaPostResource
   many :comments, resource: AlbaCommentResource
 end
 
+class AlbaCommentWithTransformationResource < AlbaCommentResource
+  transform_keys :lower_camel
+end
+
+class AlbaPostWithTransformationResource < AlbaPostResource
+  many :comments, resource: AlbaCommentWithTransformationResource
+
+  transform_keys :lower_camel
+end
+
 # --- ActiveModelSerializer serializers ---
 
 require "active_model_serializers"
@@ -133,7 +145,7 @@ class PostsRepresenter < Representable::Decorator
     property :id
     property :body
     property :commenter_names
-    collection :comments
+    collection :comments, decorator: CommentRepresenter
   end
 
   def commenter_names
@@ -205,6 +217,7 @@ posts = Post.all.includes(:comments, :commenters)
 # --- Store the serializers in procs ---
 
 alba = Proc.new { AlbaPostResource.new(posts).serialize }
+alba_with_transformation = Proc.new { AlbaPostWithTransformationResource.new(posts).serialize }
 alba_inline = Proc.new do
   Alba.serialize(posts) do
     attributes :id, :body
@@ -222,7 +235,7 @@ fast_serializer = Proc.new { FastSerializerPostResource.new(posts).to_json }
 jserializer = Proc.new { JserializerPostSerializer.new(posts, is_collection: true).to_json }
 panko = proc { Panko::ArraySerializer.new(posts, each_serializer: PankoPostSerializer).to_json }
 rails = Proc.new do
-  ActiveSupport::JSON.encode(posts.map{ |post| post.serializable_hash(include: :comments) })
+  posts.to_json(include: {comments: {only: [:id, :body]}}, methods: [:commenter_names])
 end
 representable = Proc.new { PostsRepresenter.new(posts).to_json }
 simple_ams = Proc.new { SimpleAMS::Renderer::Collection.new(posts, serializer: SimpleAMSPostSerializer).to_json }
@@ -254,6 +267,7 @@ end
 
 benchmark_body = lambda do |x|
   x.report(:alba, &alba)
+  x.report(:alba_with_transformation, &alba_with_transformation)
   x.report(:alba_inline, &alba_inline)
   x.report(:ams, &ams)
   x.report(:blueprinter, &blueprinter)
@@ -273,3 +287,11 @@ Benchmark.ips(&benchmark_body)
 
 require 'benchmark/memory'
 Benchmark.memory(&benchmark_body)
+
+# --- Show gem versions ---
+
+puts "Gem versions:"
+gems = %w[alba active_model_serializers blueprinter fast_serializer jserializer panko_serializer representable simple_ams turbostreamer]
+Bundler.load.specs.each do |spec|
+  puts "#{spec.name}: #{spec.version}" if gems.include?(spec.name)
+end

data/lib/alba/railtie.rb

@@ -7,13 +7,14 @@ module Alba
       Alba.inflector = :active_support
 
       ActiveSupport.on_load(:action_controller) do
-        define_method(:serialize) do |obj, with: nil, &block|
-          with.nil? ? Alba.resource_with(obj, &block) : with.new(obj)
+        define_method(:serialize) do |obj, with: nil, root_key: nil, meta: {}, &block|
+          resource = with.nil? ? Alba.resource_with(obj, &block) : with.new(obj)
+          resource.to_json(root_key: root_key, meta: meta)
         end
 
-        define_method(:render_serialized_json) do |obj, with: nil, &block|
+        define_method(:render_serialized_json) do |obj, with: nil, root_key: nil, meta: {}, &block|
           json = with.nil? ? Alba.resource_with(obj, &block) : with.new(obj)
-          render json: json
+          render json: json.to_json(root_key: root_key, meta: meta)
         end
       end
     end

data/lib/alba/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Alba
-  VERSION = '3.4.0'
+  VERSION = '3.5.0'
 end

data/lib/alba.rb

@@ -117,6 +117,7 @@ module Alba
     #   When it's a Class or a Module, it should have some methods, see {Alba::DefaultInflector}
     def inflector=(inflector)
       @inflector = inflector_from(inflector)
+      reset_transform_keys
     end
 
     # @param block [Block] resource body
@@ -144,11 +145,13 @@ module Alba
 
     # Configure Alba to symbolize keys
     def symbolize_keys!
+      reset_transform_keys unless @symbolize_keys
       @symbolize_keys = true
     end
 
     # Configure Alba to stringify (not symbolize) keys
     def stringify_keys!
+      reset_transform_keys if @symbolize_keys
       @symbolize_keys = false
     end
 
@@ -168,19 +171,22 @@ module Alba
     # @param key [String] a target key
     # @param transform_type [Symbol] a transform type, either one of `camel`, `lower_camel`, `dash` or `snake`
     # @return [String]
-    def transform_key(key, transform_type:)
+    def transform_key(key, transform_type:) # rubocop:disable Metrics/MethodLength
       raise Alba::Error, 'Inflector is nil. You must set inflector before transforming keys.' unless inflector
 
-      key = key.to_s
+      @_transformed_keys[transform_type][key] ||= begin
+        key = key.to_s
 
-      k = case transform_type
-          when :camel then inflector.camelize(key)
-          when :lower_camel then inflector.camelize_lower(key)
-          when :dash then inflector.dasherize(key)
-          when :snake then inflector.underscore(key)
-          else raise Alba::Error, "Unknown transform type: #{transform_type}"
-          end
-      regularize_key(k)
+        k = case transform_type
+            when :camel then inflector.camelize(key)
+            when :lower_camel then inflector.camelize_lower(key)
+            when :dash then inflector.dasherize(key)
+            when :snake then inflector.underscore(key)
+            else raise Alba::Error, "Unknown transform type: #{transform_type}"
+            end
+
+        regularize_key(k)
+      end
     end
 
     # Register types, used for both builtin and custom types
@@ -208,6 +214,7 @@ module Alba
       @_on_error = :raise
       @_on_nil = nil
       @types = {}
+      reset_transform_keys
       register_default_types
     end
 
@@ -302,6 +309,10 @@ module Alba
       inflector
     end
 
+    def reset_transform_keys
+      @_transformed_keys = Hash.new { |h, k| h[k] = {} }
+    end
+
     def register_default_types # rubocop:disable Metrics/AbcSize
       [String, :String].each do |t|
         register_type(t, check: ->(obj) { obj.is_a?(String) }, converter: lambda(&:to_s))
@@ -318,3 +329,7 @@ module Alba
 
   reset!
 end
+
+# Monkey patch for TruffleRuby
+# Delete this after 24.1.2 is released
+File::SHARE_DELETE = 0 if defined?(Truffle)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: alba
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.5.0
 platform: ruby
 authors:
 - OKURA Masafumi
 bindir: exe
 cert_chain: []
-date: 2024-12-01 00:00:00.000000000 Z
+date: 2025-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ostruct