al_comments 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48a78c929e423ff284d9ddb31ad8c7ee322f50394452c42bdabe0bb543b92c02
-  data.tar.gz: 7d5ff7dd4a7ea88fe64d782b6228398c23aafd1ad4bea83f484e961f0663e910
+  metadata.gz: b21be4d1edaba6ece5ead7b8a4a367d44f8931ba71e789923d5420a3edc88958
+  data.tar.gz: 378e2a1016b2e1775665ab3ff6ade1bf21fd4cc9c37ba24d31efcba5f7b56ae1
 SHA512:
-  metadata.gz: 7cef6fcfdf238069a461a198a2deddb9610238b4fed2671f458a9214a07444e106549ec26864d955bd7c9e35efd8134bceb2c341aeac31e9619c3097a1e24c93
-  data.tar.gz: 6d2f0e1b0207ebef63884c4ad23f30975eff9b45a304073fc1504f8152033d28335e716e0d52e41492e73419c26b4e27283a52b9d862dd3a0a8131e8e1d73afd
+  metadata.gz: 458b7d6f979287163ccdc1ee7a59be3d8989aace5cf526bb6826809e4a0fbacba2e9255f8796d4045eb703dc9a7982e4454109b30f377171b93da38b2def58d1
+  data.tar.gz: 3eb9b4fc9c64fc6414d5411635503a37ee8fff72edcc8d9e26498f4eb5959874f5d435fc450fcbabb9b7503cda215e772f579aef559af6a678d94c959a8948a8

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.1.2 - 2026-02-07
+- Aligned giscus activation behavior with al-folio main branch expectations:
+  - Removed fallback from `site.repository` / `site.github.repository_nwo` to avoid partially configured giscus injection.
+  - Requires `repo`, `repo_id`, `category`, and `category_id` before loading giscus client script.
+  - Shows theme-side warning with missing required keys when configuration is incomplete.
+- Expanded tests for incomplete giscus config handling.
+
 ## 0.1.1 - 2026-02-07
 - Improved config compatibility for comment rendering:
   - Supports both string and symbol keys for nested config values.

data/lib/al_comments.rb

@@ -81,20 +81,42 @@ module AlComments
       nested.is_a?(Hash) ? nested : {}
     end
 
-    def resolve_giscus_repo(site, giscus)
+    def resolve_giscus_repo(_site, giscus)
       repo = fetch_key(giscus, 'repo', 'repository', 'repo_name')
-      return repo.to_s unless value_blank?(repo)
+      return '' if value_blank?(repo)
 
-      repository = fetch_key(site.config, 'repository')
-      return repository.to_s unless value_blank?(repository)
+      repo.to_s
+    end
+
+    def missing_giscus_fields(giscus, repo)
+      required = {
+        'repo' => repo,
+        'repo_id' => fetch_key(giscus, 'repo_id'),
+        'category' => fetch_key(giscus, 'category'),
+        'category_id' => fetch_key(giscus, 'category_id')
+      }
 
-      github = fetch_key(site.config, 'github')
-      if github.is_a?(Hash)
-        repository_nwo = fetch_key(github, 'repository_nwo')
-        return repository_nwo.to_s unless value_blank?(repository_nwo)
+      required.each_with_object([]) do |(name, value), missing|
+        missing << name if value_blank?(value)
       end
+    end
+
+    def giscus_warning_html(style, spacer, missing_fields)
+      details = if missing_fields.empty?
+                  ''
+                else
+                  "<p>Missing required keys: <code>#{missing_fields.join(', ')}</code>.</p>"
+                end
+
+      warning = <<~HTML
+        <blockquote class="block-danger">
+          <h5>giscus comments misconfigured</h5>
+          <p>Please follow instructions at <a href="http://giscus.app">http://giscus.app</a> and update your giscus configuration.</p>
+          #{details}
+        </blockquote>
+      HTML
 
-      ''
+      %(<div id="giscus_thread"#{style}>#{spacer}\n#{warning}</div>)
     end
 
     def disqus_html(site, page, disqus_shortname)
@@ -127,15 +149,10 @@ module AlComments
       max_width = fetch_key(site.config, 'max_width')
       style = post_layout?(page) ? " style=\"max-width: #{max_width}; margin: 0 auto;\"" : ''
       spacer = post_layout?(page) ? "\n  <br>" : ''
+      missing_fields = missing_giscus_fields(giscus, repo)
 
-      if repo.to_s.strip.empty?
-        warning = <<~HTML
-          <blockquote class="block-danger">
-            <h5>giscus comments misconfigured</h5>
-            <p>Please follow instructions at <a href="http://giscus.app">http://giscus.app</a> and update your giscus configuration.</p>
-          </blockquote>
-        HTML
-        return %(<div id="giscus_thread"#{style}>#{spacer}\n#{warning}</div>)
+      unless missing_fields.empty?
+        return giscus_warning_html(style, spacer, missing_fields)
       end
 
       <<~HTML

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: al_comments
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - al-org