airspace 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68fd92350f1c6274af7a30a46918f1b9037ba9d1b0e63b1a88c284a4715f432d
-  data.tar.gz: 8b89696d66ec946c6ee807f86cacd4cdf370057b74f9a06b6cdae1bfbfa2448b
+  metadata.gz: 81e321a98d086d49ec21f49d48ce9f8b724a70ccd0b9ea6e3df106736b549b0c
+  data.tar.gz: d33b59a0dda864fe42d8a52ab64b1983ea4b1bade39826acdfe2957ed11bf7db
 SHA512:
-  metadata.gz: 7603141412de37754499c6b148ba58c3c80ce4434d9b58f7d8d4a6e4d36de07827810cff6317281f4ab90af180d3464bf377202c4755ec62c4e330855f702fa3
-  data.tar.gz: d0c7cb11e532003bf867fddddc36759bdadd0fd583430b4a1cdbb12e2c2da510c4263fceb824546b1ed33e37cb6a2f9bb74c626616e9f1864c479f09c4279ace
+  metadata.gz: d96e783bd3dc5d828d763c123d1a8bb2abafe7c92fd0651567a0f4c47bc61b0a3026630e093322209af1e19be8e5cc7d7b008dc417e46d49d553566c7fcc114d
+  data.tar.gz: f0f7bca65485dc3f7550ef554c6660fafc672f311782026291389ffdaafab3be5ec119b47b37f2930d71a9d37ba8a33dfedfa36aec77146c7a9237f583a5adb7

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 1.0.1 (February 22, 2019)
+
+**Critical Bug Fix**
+
+* Ensure Reader#page and Reader#pages work when there is a page_count of 0
+* Ensure Reader#page works when number is out of bounds (out of bounds is defined as: ```number <= 0``` or ```number > page_count``` )
+
 # 1.0.0 (February 21, 2019)
 
 Initial Release.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    airspace (1.0.0)
+    airspace (1.0.1)
       redis (>= 3.3.0)
 
 GEM

data/lib/airspace/reader.rb

@@ -66,12 +66,16 @@ module Airspace
     end
 
     def pages
+      return [] unless page_count.positive?
+
       store.chunks(key, chunk_count).map do |chunk|
         chunk.map { |r| serializer.deserialize_row(r) }
       end
     end
 
     def page(number)
+      return [] unless within_bounds?(number)
+
       page_index  = number - 1
       location    = chunker.locate(page_index)
       chunk       = store.chunk(key, location.chunk_index)
@@ -85,6 +89,10 @@ module Airspace
 
     private
 
+    def within_bounds?(number)
+      page_count.positive? && number.positive? && number <= page_count
+    end
+
     def store
       ::Airspace::Store.new(client)
     end

data/lib/airspace/version.rb

@@ -8,5 +8,5 @@
 #
 
 module Airspace
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/spec/airspace/reader_spec.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+#
+# Copyright (c) 2019-present, Blue Marble Payroll, LLC
+#
+# This source code is licensed under the MIT license found in the
+# LICENSE file in the root directory of this source tree.
+#
+
+require './spec/spec_helper'
+
+describe ::Airspace::Reader do
+  let(:client) { Redis.new }
+
+  let(:id) { 'reader-test-set' }
+
+  let(:options) { { prefix: TEST_PREFIX } }
+
+  let(:reader) { ::Airspace.get(client, id, options: options) }
+
+  subject { reader }
+
+  context 'with no pages' do
+    before(:each) do
+      ::Airspace.set(client, id: id, options: options)
+    end
+
+    describe '#page' do
+      it 'should return empty array when page_count is 0' do
+        expect(subject.page(1)).to eq([])
+      end
+
+      it 'should return empty array when number <= 0' do
+        expect(subject.page(-1)).to eq([])
+      end
+    end
+
+    describe '#pages' do
+      it 'should return empty array when page_count is 0' do
+        expect(subject.pages).to eq([])
+      end
+    end
+  end
+
+  context 'with pages' do
+    let(:pages) do
+      [
+        [
+          { 'id' => 1, 'name' => 'Matt' }
+        ]
+      ]
+    end
+
+    before(:each) do
+      ::Airspace.set(client, id: id, options: options, pages: pages)
+    end
+
+    describe '#page' do
+      it 'should return array of rows when number <= page_count' do
+        expect(subject.page(1)).to eq(pages[0])
+      end
+
+      it 'should return empty array when number > page_count' do
+        expect(subject.page(2)).to eq([])
+      end
+
+      it 'should return empty array when number <= 0' do
+        expect(subject.page(-1)).to eq([])
+      end
+    end
+
+    describe '#page' do
+      it 'should return array of pages when page_count > 0' do
+        expect(subject.pages).to eq(pages)
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airspace
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Matthew Ruggio
@@ -158,6 +158,7 @@ files:
 - lib/airspace/version.rb
 - spec/airspace/airspace_spec.rb
 - spec/airspace/chunker_spec.rb
+- spec/airspace/reader_spec.rb
 - spec/airspace/store_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/bluemarblepayroll/airspace
@@ -186,5 +187,6 @@ summary: Redis Dataset Store
 test_files:
 - spec/airspace/airspace_spec.rb
 - spec/airspace/chunker_spec.rb
+- spec/airspace/reader_spec.rb
 - spec/airspace/store_spec.rb
 - spec/spec_helper.rb