airbrake_tools 0.0.7 → 0.0.8

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    airbrake_tools (0.0.7)
+    airbrake_tools (0.0.8)
       airbrake-api (>= 4.2.2)
 
 GEM

data/lib/airbrake_tools/version.rb

@@ -1,3 +1,3 @@
 module AirbrakeTools
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/lib/airbrake_tools.rb

@@ -91,9 +91,10 @@ module AirbrakeTools
     def add_notices_to_pages(errors)
       Parallel.map(errors, :in_threads => 10) do |error|
         begin
-          notices = AirbrakeAPI.notices(error.id, :pages => 1, :raw => true).compact
+          pages = 1
+          notices = AirbrakeAPI.notices(error.id, :pages => pages, :raw => true).compact
           print "."
-          [error, notices, frequency(notices)]
+          [error, notices, frequency(notices, pages * AirbrakeAPI::Client::PER_PAGE)]
         rescue Faraday::Error::ParsingError
           $stderr.puts "Ignoring #{hot_summary(error)}, got 500 from http://#{AirbrakeAPI.account}.airbrake.io/errors/#{error.id}"
         end
@@ -119,10 +120,14 @@ module AirbrakeTools
     end
 
     # we only have a limited sample size, so we do not know how many errors occurred in total
-    def frequency(notices)
+    def frequency(notices, expected_notices)
       return 0 if notices.empty?
-      range = Time.now.to_f - notices.map{ |n| n.created_at.to_f }.min
-      errors_per_second = notices.size / range
+      range = if notices.size < expected_notices
+        60 * 60 # we got less notices then we wanted -> very few errors -> low frequency
+      else
+        Time.now - notices.map{ |n| n.created_at }.min
+      end
+      errors_per_second = notices.size / range.to_f
       (errors_per_second * 60 * 60).round(2) # errors_per_hour
     end
 

data/spec/airbrake_tools_spec.rb

@@ -93,16 +93,21 @@ describe "airbrake-tools" do
 
   describe ".frequency" do
     it "calculates for 0" do
-      AirbrakeTools.send(:frequency, []).should == 0
+      AirbrakeTools.send(:frequency, [], 0).should == 0
+      AirbrakeTools.send(:frequency, [], 1).should == 0
     end
 
     it "calculates for 1" do
-      AirbrakeTools.send(:frequency, [stub(:created_at => Time.now - (60*60))]).should == 1
+      AirbrakeTools.send(:frequency, [stub(:created_at => Time.now - (60*60))], 1).should == 1
     end
 
     it "calculates for n" do
       # 3 per minute => 180/hour
-      AirbrakeTools.send(:frequency, [stub(:created_at => Time.now-60), stub(:created_at => Time.now-40), stub(:created_at => Time.now-20)]).should == 180
+      AirbrakeTools.send(:frequency, [stub(:created_at => Time.now-60), stub(:created_at => Time.now-40), stub(:created_at => Time.now-20)], 3).should == 180
+    end
+
+    it "calculates low if notices are smaller then expected notices" do
+      AirbrakeTools.send(:frequency, [stub(:created_at => Time.now)], 10).should == 1
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airbrake_tools
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-15 00:00:00.000000000 Z
+date: 2013-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake-api