airbrake 8.3.0 → 8.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d66c9a0d425a9603e3834b3031a900af0ca6508
-  data.tar.gz: 1a7faaaa2dcc1eec9d08768c895e28320b0f6bef
+  metadata.gz: 82116cbc8eec2d17547206dc0f644ac974b2df10
+  data.tar.gz: a17a8339ced1ac6d9f89aa87cb60a438b5264c58
 SHA512:
-  metadata.gz: 860d464f6c7afabacb5771584fdcdcad41d20f15be0ed970324830c5667ca1ee9544e2c02399858bfabe45e8e4719928b85b62ddb20c72cba4bbdb1feab64fc5
-  data.tar.gz: 8f0b20da65fe963ab10d9b3da7c760a44184c025a33c4160d1e780013938ee606bc83b4c7dece98828e02289806738b987d469ab214d545c1ecc08ed48da58cb
+  metadata.gz: 4329f1e59fedbc6769f4f4491b12484b63f50538ff53db3d7f72d693f96f041baaf7ecb576579c9c47e0eff17cb6f4852ca728e08547fa3895205fa9a415003a
+  data.tar.gz: bff45ecb23e4fbb8076dd69a10b5be16a3e6659258d4cc92bb41c923d274a5c9ddcd4ed68d09228c64c031aeecfd5cd05e3b8367e83e32296a51bb794e3682f6

data/lib/airbrake/rails.rb

@@ -9,6 +9,11 @@ module Airbrake
         require 'airbrake/rails/action_controller_notify_subscriber'
         require 'airbrake/rails/action_controller_performance_breakdown_subscriber'
 
+        ActiveSupport::Notifications.subscribe(
+          'process_action.action_controller',
+          Airbrake::Rails::ActionControllerPerformanceBreakdownSubscriber.new
+        )
+
         require 'airbrake/rails/active_record_subscriber' if defined?(ActiveRecord)
 
         # Since Rails 3.2 the ActionDispatch::DebugExceptions middleware is

data/lib/airbrake/rails/action_controller_performance_breakdown_subscriber.rb

@@ -15,8 +15,8 @@ module Airbrake
             route: route,
             response_type: payload[:format],
             groups: {
-              db: payload[:db_runtime],
-              view: payload[:view_runtime]
+              db: payload[:db_runtime].to_i,
+              view: payload[:view_runtime].to_i
             },
             start_time: event.time
           )
@@ -25,8 +25,3 @@ module Airbrake
     end
   end
 end
-
-ActiveSupport::Notifications.subscribe(
-  'process_action.action_controller',
-  Airbrake::Rails::ActionControllerPerformanceBreakdownSubscriber.new
-)

data/lib/airbrake/version.rb

@@ -1,5 +1,5 @@
 # We use Semantic Versioning v2.0.0
 # More information: http://semver.org/
 module Airbrake
-  AIRBRAKE_VERSION = '8.3.0'.freeze
+  AIRBRAKE_VERSION = '8.3.1'.freeze
 end

data/spec/unit/rails/action_controller_performance_breakdown_subscriber_spec.rb

@@ -0,0 +1,87 @@
+require 'airbrake/rails/action_controller_performance_breakdown_subscriber'
+
+RSpec.describe Airbrake::Rails::ActionControllerPerformanceBreakdownSubscriber do
+  after { Airbrake::Rack::RequestStore[:routes] = nil }
+
+  context "when routes are not set in the request store" do
+    before { Airbrake::Rack::RequestStore[:routes] = nil }
+
+    it "doesn't send performance breakdown info" do
+      expect(Airbrake).not_to receive(:notify_performance_breakdown)
+      subject.call([])
+    end
+  end
+
+  context "when there are no routes in the request store" do
+    before { Airbrake::Rack::RequestStore[:routes] = [] }
+
+    it "doesn't send performance breakdown info" do
+      expect(Airbrake).not_to receive(:notify_performance_breakdown)
+      subject.call([])
+    end
+  end
+
+  context "when there's a route in the request store" do
+    let(:event) do
+      OpenStruct.new(
+        payload: {
+          format: :html,
+          view_runtime: 1.0,
+          db_runtime: 1.0
+        }
+      )
+    end
+
+    before do
+      Airbrake::Rack::RequestStore[:routes] = [['/test-route', 'GET']]
+
+      event_dbl = double
+      expect(event_dbl).to receive(:new).and_return(event)
+      stub_const('ActiveSupport::Notifications::Event', event_dbl)
+    end
+
+    it "sends performance info to Airbrake" do
+      expect(Airbrake).to receive(:notify_performance_breakdown).with(
+        hash_including(
+          route: '/test-route',
+          method: 'GET',
+          response_type: :html,
+          groups: { db: 1.0, view: 1.0 }
+        )
+      )
+      subject.call([])
+    end
+
+    context "and when view_runtime is nil" do
+      before { event.payload[:view_runtime] = nil }
+
+      it "sets the view group runtime to 0" do
+        expect(Airbrake).to receive(:notify_performance_breakdown).with(
+          hash_including(
+            route: '/test-route',
+            method: 'GET',
+            response_type: :html,
+            groups: { db: 1.0, view: 0 }
+          )
+        )
+        subject.call([])
+      end
+    end
+
+    context "and when db_runtime is nil" do
+      before { event.payload[:db_runtime] = nil }
+
+      it "sets the view group runtime to 0" do
+        expect(Airbrake).to receive(:notify_performance_breakdown).with(
+          hash_including(
+            route: '/test-route',
+            method: 'GET',
+            response_type: :html,
+            groups: { db: 0, view: 1.0 }
+          )
+        )
+        subject.call([])
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airbrake
 version: !ruby/object:Gem::Version
-  version: 8.3.0
+  version: 8.3.1
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
@@ -319,6 +319,7 @@ files:
 - spec/unit/rack/user_filter_spec.rb
 - spec/unit/rack/user_spec.rb
 - spec/unit/rails/action_cable/notify_callback_spec.rb
+- spec/unit/rails/action_controller_performance_breakdown_subscriber_spec.rb
 - spec/unit/rake/tasks_spec.rb
 - spec/unit/shoryuken_spec.rb
 - spec/unit/sidekiq/retryable_jobs_filter_spec.rb
@@ -367,6 +368,7 @@ test_files:
 - spec/unit/rack/user_filter_spec.rb
 - spec/unit/rack/user_spec.rb
 - spec/unit/rack/route_filter_spec.rb
+- spec/unit/rails/action_controller_performance_breakdown_subscriber_spec.rb
 - spec/unit/rails/action_cable/notify_callback_spec.rb
 - spec/integration/sinatra/sinatra_spec.rb
 - spec/integration/rack/rack_spec.rb