airbrake 4.3.2 → 4.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a9cbcc7af3d4f64af905ebac59cf09f65d8479d8
-  data.tar.gz: 854302ffe9b41145615d10bf6ee677b916efd239
+  metadata.gz: 44a934004ed694e6b4c9b0c210e026646106e436
+  data.tar.gz: e3f294e32503a5dad98e440069f3a61a0311f0d4
 SHA512:
-  metadata.gz: 0145fe2c505bdc19edb661c7c8fcb350f3cd229f472ed0eba4152dc9f98fccd31db1637e6c4c0c76b818706f7e648aa72a0d0b7889f3de2a7c90bd8ad696cb0b
-  data.tar.gz: 4f516bbcf921d6065c7e2f608246538b427486625bd7ed6c81e70c042317fc0e819762bc0b64c507303858f8ff37c112d2d0cecffb5bda5fa1e276b89531a084
+  metadata.gz: c3bbe64f8da080d243f96e25ffa94fa8bff057b610f3cd39fa95a659e8ca251af01483c8cd0332fdb27af4de5aacdd2bde484ae33d8c1257d414c5c00610882d
+  data.tar.gz: 855f6eee69fdf83c3bc0368b3725961ecb990bfb988843fbcb9c24a3c8b6cb15d788cc1b634bc4e8041e05983adc0686c79feb73da3a6899e259c34fb2ca3ba5

data/CHANGELOG

@@ -1,3 +1,17 @@
+Version 4.3.3 - 2015-10-20 19:33:27 -0500
+===============================================================================
+
+Daniel Loy (1):
+      don't break `clean_params` when processing nested array (as seen in action_dispatch.cookies from cgi-data)
+
+Joe Van Dyk (1):
+      Add way to ignore all the exceptions
+
+Kyrylo Silin (2):
+      Merge pull request #432 from loybert/fix/dont-break-when-filtering-arrays-of-arrays
+      Merge pull request #433 from Tanga/ignore_exceptions
+
+
 Version 4.3.2 - 2015-10-16 21:24:49 -0500
 ===============================================================================
 
@@ -1642,5 +1656,6 @@ Nick Quaranto (3):
 
 
 
+
 
 

data/lib/airbrake.rb

@@ -172,9 +172,11 @@ module Airbrake
     end
 
     def build_notice_for(exception, opts = {})
+      exception_classes = [exception.class.to_s]
       exception = unwrap_exception(exception)
       opts = opts.merge(:exception => exception) if exception.is_a?(Exception)
       opts = opts.merge(exception.to_hash) if exception.respond_to?(:to_hash)
+      opts = opts.merge(exception_classes: exception_classes)
       Notice.new(configuration.merge(opts))
     end
 

data/lib/airbrake/notice.rb

@@ -94,6 +94,9 @@ module Airbrake
     # Instance that's used for cleaning out data that should be filtered out, should respond to #clean
     attr_accessor :cleaner
 
+    # An array of the exception classes for this error (including wrapped ones)
+    attr_reader :exception_classes
+
     public
 
     def initialize(args)
@@ -102,7 +105,6 @@ module Airbrake
       @api_key          = args[:api_key]
       @project_root     = args[:project_root]
       @url              = args[:url] || rack_env(:url)
-
       @notifier_name    = args[:notifier_name]
       @notifier_version = args[:notifier_version]
       @notifier_url     = args[:notifier_url]
@@ -131,6 +133,14 @@ module Airbrake
       @hostname        = local_hostname
       @user            = args[:user] || {}
 
+      @exception_classes= Array(args[:exception_classes])
+      if @exception
+        @exception_classes << @exception.class
+      end
+      if @error_class
+        @exception_classes << @error_class
+      end
+
 
       also_use_rack_params_filters
       find_session_data
@@ -251,8 +261,13 @@ module Airbrake
 
     # Determines if this notice should be ignored
     def ignore?
-      ignored_class_names.include?(error_class) ||
-        ignore_by_filters.any? {|filter| filter.call(self) }
+      exception_classes.each do |klass|
+        if ignored_class_names.include?(klass)
+          return true
+        end
+      end
+
+      ignore_by_filters.any? {|filter| filter.call(self) }
     end
 
     # Allows properties to be accessed using a hash-like syntax

data/lib/airbrake/utils/params_cleaner.rb

@@ -98,7 +98,7 @@ module Airbrake
 
         def filter(hash)
           hash.each do |key, value|
-            if filter_key?(key)
+            if hash.is_a?(Hash) && filter_key?(key)
               hash[key] = "[FILTERED]"
             elsif value.respond_to?(:to_hash)
               filter(hash[key])

data/lib/airbrake/version.rb

@@ -1,3 +1,3 @@
 module Airbrake
-  VERSION = "4.3.2".freeze
+  VERSION = "4.3.3".freeze
 end

data/test/notice_test.rb

@@ -366,6 +366,13 @@ class NoticeTest < Test::Unit::TestCase
     assert !notice.ignore?
   end
 
+  should "ignore an wrapped exception matching ignore filters" do
+    notice = build_notice(error_class: "NotIgnored",
+                          exception_classes: ["Ignored", "NotIgnored"],
+                          ignore: ["Ignored"])
+    assert notice.ignore?
+  end
+
   should "ignore an exception with a matching error class" do
     notice = build_notice(:error_class => 'ArgumentError',
                           :ignore      => [ArgumentError])

data/test/params_cleaner_test.rb

@@ -190,4 +190,15 @@ class ParamsCleanerTest < Test::Unit::TestCase
     assert_match(/\A#<(Temp)?[Ff]ile:0x.+>\z/, clean_params.parameters[:files][0])
     assert_match(/\A#<IO:0x.+>\z/, clean_params.parameters[:files][1])
   end
+
+  should "not break on filtering multi-dimensional array as possible in action_dispatch.cookies" do
+    original = { 'cgi_cookies_to_filter' => [['any_cookie_key', 'some_cookie_value'], ['secret', 'some_secret_value']] }
+    clean_params = clean(:params_filters => [:secret],
+                         :params_whitelist_filters => [:secret],
+                         :parameters => original)
+    assert_nothing_raised do
+      clean_params.send(:parameters)
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake
 version: !ruby/object:Gem::Version
-  version: 4.3.2
+  version: 4.3.3
 platform: ruby
 authors:
 - Airbrake
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-17 00:00:00.000000000 Z
+date: 2015-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder