airbrake 3.1.16 → 3.1.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3798079c271cc435d260126593812bce5241b775
-  data.tar.gz: 353de11bf6b78ce210e1163edf899687ecef0db8
+  metadata.gz: dfc2885576a30927690a4535d69e4ca351010c80
+  data.tar.gz: d46ef484b70f08951c33fff46079c8a08317c2be
 SHA512:
-  metadata.gz: 81be18beb2bc90e89260cc06a5f9295bddf54c7c717fea75d9731ed13d6883f8d93a01671fcfc38bd48f5d4244f2bbf1833e92de34e7492f74e884e7104beb49
-  data.tar.gz: 64e0c784c018f7e285b0b2bbbd8a2dae954ca97e0db04c8a1279d5ae01116ec34ddc72c0548de09def0da51339db94985b294710aa8ef4fa4aa06e08182a2c1f
+  metadata.gz: 2194af5fb0d2c3610728f6ddcacc260aa366d6b30e4311c452ff8f54815f43b71aa05c632bef75d3ff447c40a2d45399393d40a4b21c09d30234db6ad3423def
+  data.tar.gz: 736d7e758269212bbdbb0440c1aa8d436489f16de8813aa8b3778efad5ad0dbe9be69494514e9b18b20d1c07fa2a149af58630f24b22efb5ce229db3ad6d053d

data/CHANGELOG

@@ -1,3 +1,85 @@
+Version 3.1.17 - 2014-05-20 21:00:25 -0700
+===============================================================================
+
+Alex Tomlins (1):
+      Only send notices if configured with api_key
+
+Ali Faiz (22):
+      Add tasks specific for using appraisal to test different versions
+      Ensure that integration tests can use the same helpers as unit tests
+      Fix errors causing features to fail
+      Add sqlite3 for Rails 3.2 & 4.0 appraisal gems
+      Fix integrations with Rails 3.0 by locking sucker_punch to v1.0.2.
+      Update README.md
+      Merge pull request #285 from airbrake/adjust-ci-integration
+      Merge pull request #281 from jhawthorn/fix_actioncontroller_metal
+      Merge pull request #268 from alphagov/disable_unless_configured
+      Merge pull request #287 from itolmach/master
+      Add apikey to certain cucumber tests for changes for configured
+      Merge pull request #288 from airbrake/fix-apikey-related-tests
+      Merge pull request #277 from polleverywhere/rails3_filter_parameters
+      Merge pull request #262 from roqua/mv-regex-filters
+      Fix filtering checks in cucumber tests by checking for 'key=' instead of blind check
+      Make separate step for the cucumber test that checks for filtered keys
+      Merge pull request #289 from airbrake/fix-regex-filtering
+      Write verbose output when configuration prevents sending notices to Airbrake.
+      Merge pull request #294 from Nitrodist/ensure-rake-integration
+      Merge pull request #295 from airbrake/add-context-when-notice-not-sent
+      Merge pull request #293 from Nitrodist/use-minitest-4
+      Use tag date instead of trying to sort on tag name
+
+Ivan Tolmachev (3):
+      added airbrakeman notifier ruby illustration
+      illustration added, take 2
+      Added Airbrakeman Notifier Illustration
+
+John Hawthorn (1):
+      fix middleware for AC::Metal on rails 3.2
+
+Version 3.1.16 - 2014-03-11 13:34:51 -0700
+===============================================================================
+
+Joseph Silvashy (5):
+      Merge pull request #267 from nberger/fix-typo-in-rails3-tasks
+      Update license for Rackspace
+      Merge pull request #255 from viperdezigns/capistrano3
+      Bump to 3.1.14
+      Bump to 3.1.16
+
+Mark Campbell (2):
+      Add minitest 4.x as an explicit dependency
+      Ensure rake integration is enabled when rescue_rake_exceptions is true
+
+Marten Veldthuis (3):
+      Add support for regexp filters
+      Refactor cgi_data filtering to use `filter_key?`
+      Add a default rack env filter for variables matching "secret" or "password".
+
+Mike Foley (2):
+      Add backwards compatibility for filter_parameters in Rails3
+      Add tests, minor refactor for Rails 3 functionality
+
+Nicolas Berger (1):
+      Fix typo: Rack -> Rake
+
+Richard Pernikoff (3):
+      execute instead of run
+      get full revision hash and send correct repo url
+      execute the rake task within the release_path instead of running cd release_path.
+
+ViperDezigns (1):
+      Merge pull request #2 from tunespeak/capistrano3
+
+spodlecki (7):
+      adding capistrano 3
+      attempting err fixes
+      release_path
+      making repo name a env var
+      adding airbrake escape user method
+      logger.info doesn't exist, seems Cap uses info() now
+      execute instead of run
+
+
 Version 3.1.15 - 2014-01-03 14:37:38 +0100
 ===============================================================================
 
@@ -1275,5 +1357,6 @@ Nick Quaranto (3):
 
 
 
+
 
 

data/README.md

@@ -1,16 +1,20 @@
 Airbrake
 ========
 
-[![Circle CI](https://circleci.com/gh/airbrake/airbrake/tree/master.png?circle_token=66cb9cfc6d20f550a2dbde522f5f0f9f81bd653b)](https://circleci.com/gh/airbrake/airbrake)
+[![Circle CI](https://circleci.com/gh/airbrake/airbrake/tree/master.png?circle-token=66cb9cfc6d20f550a2dbde522f5f0f9f81bd653b)](https://circleci.com/gh/airbrake/airbrake)
 [![Code Climate](https://codeclimate.com/github/airbrake/airbrake.png)](https://codeclimate.com/github/airbrake/airbrake)
 [![Coverage Status](https://coveralls.io/repos/airbrake/airbrake/badge.png?branch=master)](https://coveralls.io/r/airbrake/airbrake?branch=master)
 [![Dependency Status](https://gemnasium.com/airbrake/airbrake.png)](https://gemnasium.com/airbrake/airbrake)
 
+<img src="http://f.cl.ly/items/3Q163w1r2K1J1b030k0g/ruby%2009.19.32.jpg" width=800px>
+
 This is the notifier gem for integrating apps with [Airbrake](http://airbrake.io).
 
 When an uncaught exception occurs, Airbrake will POST the relevant data
 to the Airbrake server specified in your environment.
 
+<img scr="http://f.cl.ly/items/142j0Z2u0R1Y2L0L3D26/ruby.jpg" width=800px;>
+
 Help
 ----
 

data/Rakefile

@@ -1,5 +1,5 @@
 require 'rubygems'
-require "bundler/setup"
+require 'bundler/setup'
 require 'appraisal'
 require 'rake'
 require 'rake/testtask'
@@ -15,7 +15,11 @@ require './lib/airbrake/version'
 
 Coveralls::RakeTask.new
 
-task :default => ["test:unit", "test:integration"]
+appraisal_environments = %w(rails-4.0 rails-3.2 rails-3.1 rails-3.0 rake sinatra rack)
+task default: %w( test:unit coveralls:push) +
+  appraisal_environments.map {|ae| "test:integration:#{ae.gsub(/[\-\.]/, '_')}"} +
+  appraisal_environments.map {|ae| "test:cucumber:#{ae.gsub(/[\-\.]/, '_')}"}
+
 
 namespace :test do
   Rake::TestTask.new(:unit) do |t|
@@ -24,13 +28,24 @@ namespace :test do
     t.verbose = true
   end
 
-  desc "Integration tests for all versions of Rails."
-  task :integration do
-    system 'INTEGRATION=true rake appraisal:rails-3.2 integration_test'\
-    '&& INTEGRATION=true rake appraisal:rails-3.1 integration_test'\
-    '&& INTEGRATION=true rake appraisal:rails-3.0 integration_test'\
-    '&& rake coveralls:push'\
-    '&& INTEGRATION=true rake appraisal cucumber'
+  desc "Integration tests Rake, Sinatra, Rack and for all versions of Rails"
+  namespace :integration do
+    appraisal_environments.each do |appraisal_env|
+      task appraisal_env.gsub(/[\-\.]/, '_').to_sym do
+        ENV['INTEGRATION'] = 'true'
+        system "appraisal #{appraisal_env} rake integration_test" or exit!(1)
+      end
+    end
+  end
+
+  desc "Cucumber tests Rake, Sinatra, Rack and for all versions of Rails"
+  namespace :cucumber do
+    appraisal_environments.each do |appraisal_env|
+      task appraisal_env.gsub(/[\-\.]/, '_').to_sym do
+        ENV['INTEGRATION'] = 'true'
+        system "appraisal #{appraisal_env} rake cucumber" or exit!(1)
+      end
+    end
   end
 end
 
@@ -88,7 +103,7 @@ EOF
 Version #{version} - #{Time.now}
 ===============================================================================
 
-#{`git log $(git tag | grep -v rc | sort --version-sort | tail -1)..HEAD | git shortlog`}
+#{`git log $(git for-each-ref --sort=taggerdate --format '%(tag)' refs/tags | tail -1)..HEAD | git shortlog`}
 #{old}
 EOF
     end

data/airbrake.gemspec

@@ -28,11 +28,12 @@ Gem::Specification.new do |s|
   s.add_development_dependency("appraisal")
   s.add_development_dependency("rspec-rails")
   s.add_development_dependency("girl_friday")
-  s.add_development_dependency("sucker_punch")
+  s.add_development_dependency("sucker_punch",   "1.0.2")
   s.add_development_dependency("shoulda-matchers")
   s.add_development_dependency("shoulda-context")
   s.add_development_dependency("pry")
   s.add_development_dependency("coveralls")
+  s.add_development_dependency("minitest", ["~> 4.0"])
 
   s.authors = ["Airbrake"]
   s.email   = %q{support@airbrake.io}

data/features/metal.feature

@@ -4,6 +4,7 @@ Feature: Rescue errors in Rails middleware
     And I cd to "rails_root"
     And I configure the notifier to use the following configuration lines:
     """
+      config.api_key = "myapikey"
       config.logger = Logger.new STDOUT
     """
     And I configure the Airbrake shim

data/features/rails.feature

@@ -134,6 +134,7 @@ Feature: Install the Gem in a Rails application
     And I run `rails generate airbrake -k myapikey -t`
     When I configure the notifier to use the following configuration lines:
       """
+      config.api_key = "myapikey"
       config.logger = Logger.new STDOUT
       """
     And I configure the application to filter parameter "secret"

data/features/step_definitions/rails_application_steps.rb

@@ -255,9 +255,9 @@ end
 
 Then /^the Airbrake notification should not contain any of the sensitive Rack variables$/ do
   sensitive_rack_data_regex = FILTERED_RACK_VARS.map do |var|
-    Regexp.quote(var)
+    var.instance_of?(Regexp) ? var : Regexp.quote(var)
   end.join("|")
-  step %{the last notice sent should not contain "#{sensitive_rack_data_regex}"}
+  step %{the last notice sent should not contain keys with "#{sensitive_rack_data_regex}"}
 end
 
 Then /^the last notice sent should contain "([^\"]*)"$/ do |data|
@@ -270,6 +270,11 @@ Then /^the last notice sent should not contain "([^\"]*)"$/ do |data|
   last_notice.should_not match(%r{#{data}})
 end
 
+Then /^the last notice sent should not contain keys with "([^\"]*)"$/ do |data|
+  last_notice = File.read(LAST_NOTICE)
+  last_notice.should_not match(%r{key\=\"(#{data})\"})
+end
+
 Then /^the Airbrake notification should contain the framework information$/ do
   step %{the last notice sent should contain "Rails: #{ENV["RAILS_VERSION"]}"}
 end

data/features/support/env.rb

@@ -30,8 +30,10 @@ end
 def reload_rack_filters
   original_filters = File.read(ORIGINAL_RACK_FILTERS)
 
+  Dir.mkdir(TEMP_DIR) unless Dir.exist?(TEMP_DIR)
+
   File.write(File.join(TEMP_DIR, "rack_filters.rb"), 
-             original_filters.lines[1..-2].join("\n"))
+             original_filters.lines.to_a[1..-2].join("\n"))
 
   require File.join(TEMP_DIR, "rack_filters.rb")
 end

data/features/support/rails.rb

@@ -123,33 +123,32 @@ module RailsHelpers
   end
 
   def perform_request(uri, environment = 'production')
-      request_script = <<-SCRIPT
-        require File.expand_path('../config/environment', __FILE__)
-
-        env      = Rack::MockRequest.env_for(#{uri.inspect})
-        response = RailsRoot::Application.call(env)
-
-
-        response = response.last if response.last.is_a?(ActionDispatch::Response)
-
-        if response.is_a?(Array)
-          puts "Status: " + response.first.to_s
-          puts "Headers: " + response.second.to_s
-          if response.last.respond_to?(:each)
-            # making it work even with Rack::BodyProxy
-            body = ""
-            response.last.each do |chunk|
-              body << chunk
-            end
-            response.pop
-            response << body
-          end
-          puts "Body: " + response.last.to_s
-        else
-          puts response.body
-        end
-      SCRIPT
-      File.open(File.join(rails_root, 'request.rb'), 'w') { |file| file.write(request_script) }
+    request_script = <<-SCRIPT
+require File.expand_path('../config/environment', __FILE__)
+
+env      = Rack::MockRequest.env_for(#{uri.inspect})
+response = RailsRoot::Application.call(env)
+
+response = response.last if response.last.is_a?(ActionDispatch::Response)
+
+if response.is_a?(Array)
+  puts "Status: " + response.first.to_s
+  puts "Headers: " + response.second.to_s
+  if response.last.respond_to?(:each)
+    # making it work even with Rack::BodyProxy
+    body = ""
+    response.last.each do |chunk|
+      body << chunk
+    end
+    response.pop
+    response << body
+  end
+  puts "Body: " + response.last.to_s
+else
+  puts response.body
+end
+    SCRIPT
+    File.open(File.join(rails_root, 'request.rb'), 'w') { |file| file.write(request_script) }
   end
 
 end

data/features/user_informer.feature

@@ -22,6 +22,7 @@ Feature: Inform the user of the airbrake notice that was just created
   Scenario: Rescue an exception in a controller with a custom error string
     When I configure the notifier to use the following configuration lines:
     """
+    config.api_key = "myapikey"
     config.user_information = 'Error #{{ error_id }}'
     """
     And I run `rails generate airbrake -k myapikey`

data/lib/airbrake.rb

@@ -61,6 +61,12 @@ module Airbrake
       write_verbose_log("Notice details: \n#{notice}")
     end
 
+    def report_notice_not_sent_for_configuration
+      write_verbose_log("Notice was not sent due to configuration: \
+        \n  Environment Monitored? #{configuration.public?} \
+        \n  API key set? #{configuration.configured?}")
+    end
+
     # Returns the Ruby version, Rails version, and current Rails environment
     def environment_info
       info = "[Ruby: #{RUBY_VERSION}]"
@@ -147,13 +153,15 @@ module Airbrake
     private
 
     def send_notice(notice)
-      if configuration.public?
+      if configuration.configured? && configuration.public?
         if configuration.async?
           configuration.async.call(notice)
           nil # make sure we never set env["airbrake.error_id"] for async notices
         else
           sender.send_to_airbrake(notice)
         end
+      else
+        report_notice_not_sent_for_configuration
       end
     end
 

data/lib/airbrake/configuration.rb

@@ -256,6 +256,12 @@ module Airbrake
       to_hash.merge(hash)
     end
 
+    # Determines if the notifier will send notices.
+    # @return [Boolean] Returns +true+ if an api string exists, +false+ otherwise.
+    def configured?
+      !api_key.nil? && !api_key.empty?
+    end
+
     # Determines if the notifier will send notices.
     # @return [Boolean] Returns +false+ if in a development environment, +true+ otherwise.
     def public?
@@ -298,6 +304,13 @@ module Airbrake
         use_default_or_this
     end
 
+    def rescue_rake_exceptions=(val)
+      if val && !defined?(Airbrake::RakeHandler)
+        raise LoadError, "you must require 'airbrake/rake_handler' to rescue from rake exceptions"
+      end
+      @rescue_rake_exceptions = val
+    end
+
     def js_api_key
       @js_api_key || self.api_key
     end

data/lib/airbrake/rails/controller_methods.rb

@@ -42,15 +42,22 @@ module Airbrake
       def airbrake_filter_if_filtering(hash)
         return hash if ! hash.is_a?(Hash)
 
-
         if respond_to?(:filter_parameters) # Rails 2
           filter_parameters(hash)
-        # elsif defined?(ActionDispatch::Http::ParameterFilter) # Rails 3
-        #   ActionDispatch::Http::ParameterFilter.new(::Rails.application.config.filter_parameters).filter(hash)
+        elsif rails3?
+          filter_rails3_parameters(hash)
         else
           hash
         end
+      end
+
+      def rails3?
+        defined?(::Rails.version) && ::Rails.version =~ /\A3/
+      end
 
+      def filter_rails3_parameters(hash)
+        ActionDispatch::Http::ParameterFilter.new(
+          ::Rails.application.config.filter_parameters).filter(hash)
       end
 
       def airbrake_session_data

data/lib/airbrake/rails/middleware.rb

@@ -25,12 +25,13 @@ module Airbrake
 
       private
 
-      def after_airbrake_handler(env, exception)
-        if defined? env["action_controller.instance"].
-          rescue_action_in_public_without_airbrake
+      def controller(env)
+        env["action_controller.instance"]
+      end
 
-          env["action_controller.instance"].
-            rescue_action_in_public_without_airbrake(exception)
+      def after_airbrake_handler(env, exception)
+        if controller(env).respond_to?(:rescue_action_in_public_without_airbrake)
+          controller(env).rescue_action_in_public_without_airbrake(exception)
         end
       end
 
@@ -43,8 +44,11 @@ module Airbrake
       end
 
       def request_data(env)
-        env["action_controller.instance"].try(:airbrake_request_data) ||
+        if controller(env).respond_to?(:airbrake_request_data)
+          controller(env).airbrake_request_data
+        else
           {:rack_env => env}
+        end
       end
 
       def ignored_user_agent?(env)

data/lib/airbrake/utils/params_cleaner.rb

@@ -55,21 +55,28 @@ module Airbrake
 
         def clean_rack_request_data
           if @cgi_data
-            Airbrake::FILTERED_RACK_VARS.each do |var|
-              @cgi_data.delete var
+            @cgi_data.keys.each do |key|
+              if filter_key?(key, Airbrake::FILTERED_RACK_VARS)
+                @cgi_data.delete key
+              end
             end
           end
         end
 
-        def filter_key?(key)
-          @filters.any? do |filter|
-            key.to_s.eql?(filter.to_s)
+        def filter_key?(key, filters)
+          filters.any? do |filter|
+            case filter
+            when Regexp
+              filter.match(key)
+            else
+              key.to_s.eql?(filter.to_s)
+            end
           end
         end
 
         def filter(hash)
           hash.each do |key, value|
-            if filter_key?(key)
+            if filter_key?(key, @filters)
               hash[key] = "[FILTERED]"
             elsif value.respond_to?(:to_hash)
               filter(hash[key])

data/lib/airbrake/utils/rack_filters.rb

@@ -35,5 +35,10 @@ module Airbrake
       rack.input
   )
 
-  FILTERED_RACK_VARS = SENSITIVE_RACK_VARS + RACK_VARS_CONTAINING_INSTANCES
+  SENSITIVE_ENV_VARS = [
+      /secret/i,
+      /password/i
+  ]
+
+  FILTERED_RACK_VARS = SENSITIVE_RACK_VARS + SENSITIVE_ENV_VARS + RACK_VARS_CONTAINING_INSTANCES
 end

data/lib/airbrake/version.rb

@@ -1,3 +1,3 @@
 module Airbrake
-  VERSION = "3.1.16"
+  VERSION = "3.1.17".freeze
 end

data/resources/notice.xml

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?><notice version="2.4"><api-key>myapikey</api-key><notifier><name>Airbrake Notifier</name><version>3.1.16</version><url>https://github.com/airbrake/airbrake</url></notifier><error><class>AirbrakeTestingException</class><message>AirbrakeTestingException: 
+Testing airbrake via "rake airbrake:test". If you can see this, it works.</message><backtrace><line number="377" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/callbacks.rb" method="_run__860778729963979009__process_action__callbacks"/><line number="80" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/callbacks.rb" method="run_callbacks"/><line number="17" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/abstract_controller/callbacks.rb" method="process_action"/><line number="29" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_controller/metal/rescue.rb" method="process_action"/><line number="31" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_controller/metal/instrumentation.rb" method="block in process_action"/><line number="159" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/notifications.rb" method="block in instrument"/><line number="20" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/notifications/instrumenter.rb" method="instrument"/><line number="159" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/notifications.rb" method="instrument"/><line number="30" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_controller/metal/instrumentation.rb" method="process_action"/><line number="250" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_controller/metal/params_wrapper.rb" method="process_action"/><line number="136" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/abstract_controller/base.rb" method="process"/><line number="44" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/abstract_controller/rendering.rb" method="process"/><line number="195" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_controller/metal.rb" method="dispatch"/><line number="13" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_controller/metal/rack_delegation.rb" method="dispatch"/><line number="231" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_controller/metal.rb" method="block in action"/><line number="80" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/routing/route_set.rb" method="call"/><line number="80" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/routing/route_set.rb" method="dispatch"/><line number="48" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/routing/route_set.rb" method="call"/><line number="71" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/journey/router.rb" method="block in call"/><line number="59" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/journey/router.rb" method="each"/><line number="59" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/journey/router.rb" method="call"/><line number="674" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/routing/route_set.rb" method="call"/><line number="23" file="[GEM_ROOT]/gems/rack-1.5.2/lib/rack/etag.rb" method="call"/><line number="25" file="[GEM_ROOT]/gems/rack-1.5.2/lib/rack/conditionalget.rb" method="call"/><line number="11" file="[GEM_ROOT]/gems/rack-1.5.2/lib/rack/head.rb" method="call"/><line number="27" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/middleware/params_parser.rb" method="call"/><line number="241" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/middleware/flash.rb" method="call"/><line number="225" file="[GEM_ROOT]/gems/rack-1.5.2/lib/rack/session/abstract/id.rb" method="context"/><line number="220" file="[GEM_ROOT]/gems/rack-1.5.2/lib/rack/session/abstract/id.rb" method="call"/><line number="486" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/middleware/cookies.rb" method="call"/><line number="29" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/middleware/callbacks.rb" method="block in call"/><line number="373" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/callbacks.rb" method="_run__4065767142482523156__call__callbacks"/><line number="80" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/callbacks.rb" method="run_callbacks"/><line number="27" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/middleware/callbacks.rb" method="call"/><line number="76" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/middleware/remote_ip.rb" method="call"/><line number="38" file="[GEM_ROOT]/gems/railties-4.0.4/lib/rails/rack/logger.rb" method="call_app"/><line number="20" file="[GEM_ROOT]/gems/railties-4.0.4/lib/rails/rack/logger.rb" method="block in call"/><line number="68" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/tagged_logging.rb" method="block in tagged"/><line number="26" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/tagged_logging.rb" method="tagged"/><line number="68" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/tagged_logging.rb" method="tagged"/><line number="20" file="[GEM_ROOT]/gems/railties-4.0.4/lib/rails/rack/logger.rb" method="call"/><line number="21" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/middleware/request_id.rb" method="call"/><line number="21" file="[GEM_ROOT]/gems/rack-1.5.2/lib/rack/methodoverride.rb" method="call"/><line number="17" file="[GEM_ROOT]/gems/rack-1.5.2/lib/rack/runtime.rb" method="call"/><line number="83" file="[GEM_ROOT]/gems/activesupport-4.0.4/lib/active_support/cache/strategy/local_cache.rb" method="call"/><line number="64" file="[GEM_ROOT]/gems/actionpack-4.0.4/lib/action_dispatch/middleware/static.rb" method="call"/><line number="112" file="[GEM_ROOT]/gems/rack-1.5.2/lib/rack/sendfile.rb" method="call"/><line number="511" file="[GEM_ROOT]/gems/railties-4.0.4/lib/rails/engine.rb" method="call"/><line number="97" file="[GEM_ROOT]/gems/railties-4.0.4/lib/rails/application.rb" method="call"/><line number="240" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/task.rb" method="call"/><line number="240" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/task.rb" method="block in execute"/><line number="235" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/task.rb" method="each"/><line number="235" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/task.rb" method="execute"/><line number="179" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/task.rb" method="block in invoke_with_call_chain"/><line number="211" file="/Users/alifaiz/.rvm/rubies/ruby-2.0.0-p353/lib/ruby/2.0.0/monitor.rb" method="mon_synchronize"/><line number="172" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/task.rb" method="invoke_with_call_chain"/><line number="165" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/task.rb" method="invoke"/><line number="150" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="invoke_task"/><line number="106" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="block (2 levels) in top_level"/><line number="106" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="each"/><line number="106" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="block in top_level"/><line number="115" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="run_with_threads"/><line number="100" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="top_level"/><line number="78" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="block in run"/><line number="176" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="standard_exception_handling"/><line number="75" file="[GEM_ROOT]/gems/rake-10.2.2/lib/rake/application.rb" method="run"/><line number="33" file="[GEM_ROOT]/gems/rake-10.2.2/bin/rake" method="&lt;top (required)&gt;"/><line number="23" file="[GEM_ROOT]/bin/rake" method="load"/><line number="23" file="[GEM_ROOT]/bin/rake" method="&lt;main&gt;"/><line number="15" file="[GEM_ROOT]/bin/ruby_executable_hooks" method="eval"/><line number="15" file="[GEM_ROOT]/bin/ruby_executable_hooks" method="&lt;main&gt;"/></backtrace></error><request><url>http://www.example.com/verify</url><component>application</component><action>verify</action><params><var key="action">verify</var><var key="controller">application</var></params><cgi-data><var key="rack.version">["1", "2"]</var><var key="rack.multithread">true</var><var key="rack.multiprocess">true</var><var key="rack.run_once">false</var><var key="REQUEST_METHOD">GET</var><var key="SERVER_NAME">www.example.com</var><var key="SERVER_PORT">80</var><var key="QUERY_STRING"></var><var key="PATH_INFO">/verify</var><var key="rack.url_scheme">http</var><var key="HTTPS">off</var><var key="SCRIPT_NAME"></var><var key="CONTENT_LENGTH">0</var><var key="ORIGINAL_FULLPATH">/verify</var><var key="ORIGINAL_SCRIPT_NAME"></var><var key="action_dispatch.parameter_filter">["password"]</var><var key="action_dispatch.redirect_filter">[]</var><var key="action_dispatch.show_exceptions">false</var><var key="action_dispatch.show_detailed_exceptions">true</var><var key="ROUTES_2160658760_SCRIPT_NAME"></var><var key="action_dispatch.request_id">5d547c87-a383-4a63-9c0c-cfcdd16ff368</var><var key="action_dispatch.remote_ip"></var><var key="action_dispatch.request.path_parameters"><var key="action">verify</var><var key="controller">application</var></var><var key="action_dispatch.request.content_type"></var><var key="action_dispatch.request.request_parameters"></var><var key="rack.request.query_string"></var><var key="rack.request.query_hash"></var><var key="action_dispatch.request.query_parameters"></var><var key="action_dispatch.request.parameters"><var key="action">verify</var><var key="controller">application</var></var><var key="action_dispatch.request.formats">["text/html"]</var></cgi-data></request><server-environment><project-root>/Users/alifaiz/Work/Exceptional/airbrake-gem/tmp/rails_root</project-root><environment-name>test</environment-name><hostname>ali-mb.local</hostname></server-environment><framework>Rails: 4.0.4</framework></notice>

data/test/configuration_test.rb

@@ -40,6 +40,11 @@ class ConfigurationTest < Test::Unit::TestCase
     assert config.async.respond_to?(:call)
   end
 
+  should "raise error for rake integration if rake handler isn't loaded" do
+    config = Airbrake::Configuration.new
+    assert_raises(LoadError) { config.rescue_rake_exceptions = true }
+  end
+
   should "set provided-callable for async {}" do
     config = Airbrake::Configuration.new
     config.async {|notice| :ok}
@@ -183,6 +188,27 @@ class ConfigurationTest < Test::Unit::TestCase
     assert_same_elements %w(development test cucumber), config.development_environments
   end
 
+  context "configured?" do
+    setup do
+      @config = Airbrake::Configuration.new
+    end
+
+    should "be true if given an api_key" do
+      @config.api_key = "1234"
+      assert @config.configured?
+    end
+
+    should "be false with a nil api_key" do
+      @config.api_key = nil
+      assert !@config.configured?
+    end
+
+    should "be false with a blank api_key" do
+      @config.api_key = ''
+      assert !@config.configured?
+    end
+  end
+
   should "be public in a public environment" do
     config = Airbrake::Configuration.new
     config.development_environments = %w(development)

data/test/controller_methods_test.rb

@@ -54,5 +54,24 @@ class ControllerMethodsTest < Test::Unit::TestCase
       assert_equal no_session, {:session => 'no session found'}
     end
   end
-end
 
+  context "Rails 3" do
+    setup do
+      @controller = TestController.new
+      ::Rails = Object.new
+      ::Rails.stubs(:version).returns("3.2.17")
+    end
+    should "respond to rails3? with true" do
+      assert @controller.send(:rails3?)
+    end
+    should "call filter_rails3_parameters" do
+      hash = {:a => "b"}
+      filtered_hash = {:c => "d"}
+
+      @controller.expects(:filter_rails3_parameters).with(hash).
+        returns(filtered_hash)
+      assert_equal filtered_hash,
+        @controller.send(:airbrake_filter_if_filtering, hash)
+    end
+  end
+end

data/test/helper.rb

@@ -88,7 +88,7 @@ module TestMethods
   end
 end
 
-class Test::Unit::TestCase
+module TestHelpers
   def stub_sender
     stub('sender', :send_to_airbrake => nil)
   end
@@ -183,6 +183,10 @@ class Test::Unit::TestCase
   end
 end
 
+class Test::Unit::TestCase
+  include ::TestHelpers
+end
+
 module DefinesConstants
   def setup
     @defined_constants = []

data/test/integration/catcher_test.rb

@@ -131,6 +131,7 @@ end
 class ActionControllerCatcherTest < ActionDispatch::IntegrationTest
 
   include DefinesConstants
+  include TestHelpers
 
   def setup
     super
@@ -269,6 +270,13 @@ class ActionControllerCatcherTest < ActionDispatch::IntegrationTest
     assert_caught_and_not_sent
   end
 
+  def test_not_deliver_notices_from_exceptions_with_no_api_key
+    Airbrake.configuration.api_key = nil
+    @app = AirbrakeTestController.action(:boom)
+    get '/'
+    assert_caught_and_not_sent
+  end
+
   def test_not_deliver_notices_from_actions_that_dont_raise
     @app = AirbrakeTestController.action(:hello)
     get '/'

data/test/notifier_test.rb

@@ -187,7 +187,7 @@ class NotifierTest < Test::Unit::TestCase
     config_opts = { 'one' => 'two', 'three' => 'four' }
     stub_notice!
     stub_sender!
-    Airbrake.configuration = stub('config', :merge => config_opts, :public? => true,:async? => nil)
+    Airbrake.configuration = stub('config', :merge => config_opts, :configured? => true, :public? => true,:async? => nil)
 
     Airbrake.notify(exception)
 

data/test/params_cleaner_test.rb

@@ -64,6 +64,17 @@ class ParamsCleanerTest < Test::Unit::TestCase
     assert_equal({"abc" => "123"}, clean_params.cgi_data)
   end
 
+  should "remove secrets from cgi_data" do
+    original = {
+      "aws_secret_key"   => "secret",
+      "service_password" => "password",
+      "abc" => "123"
+    }
+
+    clean_params = clean(:cgi_data => original)
+    assert_equal({"abc" => "123"}, clean_params.cgi_data)
+  end
+
   should "filter parameters" do
     assert_filters_hash(:parameters)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake
 version: !ruby/object:Gem::Version
-  version: 3.1.16
+  version: 3.1.17
 platform: ruby
 authors:
 - Airbrake
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-11 00:00:00.000000000 Z
+date: 2014-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -210,16 +210,16 @@ dependencies:
   name: sucker_punch
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.0.2
 - !ruby/object:Gem::Dependency
   name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
@@ -276,6 +276,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '4.0'
 description: 
 email: support@airbrake.io
 executables:
@@ -283,12 +297,42 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG
+- Gemfile
+- Guardfile
+- INSTALL
+- LICENSE
+- README.md
+- README_FOR_HEROKU_ADDON.md
+- Rakefile
+- TESTED_AGAINST
+- airbrake.gemspec
+- bin/airbrake
+- features/metal.feature
+- features/rack.feature
+- features/rails.feature
+- features/rails_with_js_notifier.feature
+- features/rake.feature
+- features/sinatra.feature
+- features/step_definitions/file_steps.rb
+- features/step_definitions/rack_steps.rb
+- features/step_definitions/rails_application_steps.rb
+- features/step_definitions/rake_steps.rb
+- features/support/airbrake_shim.rb.template
+- features/support/aruba.rb
+- features/support/env.rb
+- features/support/matchers.rb
+- features/support/rails.rb
+- features/support/rake/Rakefile
+- features/user_informer.feature
 - generators/airbrake/airbrake_generator.rb
 - generators/airbrake/lib/insert_commands.rb
 - generators/airbrake/lib/rake_commands.rb
 - generators/airbrake/templates/airbrake_tasks.rake
 - generators/airbrake/templates/capistrano_hook.rb
 - generators/airbrake/templates/initializer.rb
+- install.rb
+- lib/airbrake.rb
 - lib/airbrake/backtrace.rb
 - lib/airbrake/capistrano.rb
 - lib/airbrake/capistrano3.rb
@@ -303,12 +347,12 @@ files:
 - lib/airbrake/jobs/send_job.rb
 - lib/airbrake/notice.rb
 - lib/airbrake/rack.rb
+- lib/airbrake/rails.rb
 - lib/airbrake/rails/action_controller_catcher.rb
 - lib/airbrake/rails/controller_methods.rb
 - lib/airbrake/rails/error_lookup.rb
 - lib/airbrake/rails/javascript_notifier.rb
 - lib/airbrake/rails/middleware.rb
-- lib/airbrake/rails.rb
 - lib/airbrake/rails3_tasks.rb
 - lib/airbrake/railtie.rb
 - lib/airbrake/rake_handler.rb
@@ -316,43 +360,32 @@ files:
 - lib/airbrake/sender.rb
 - lib/airbrake/shared_tasks.rb
 - lib/airbrake/sinatra.rb
-- lib/airbrake/tasks/airbrake.cap
 - lib/airbrake/tasks.rb
+- lib/airbrake/tasks/airbrake.cap
 - lib/airbrake/user_informer.rb
 - lib/airbrake/utils/params_cleaner.rb
 - lib/airbrake/utils/rack_filters.rb
 - lib/airbrake/version.rb
-- lib/airbrake.rb
 - lib/airbrake_tasks.rb
 - lib/rails/generators/airbrake/airbrake_generator.rb
 - lib/templates/javascript_notifier_configuration
 - lib/templates/javascript_notifier_loader
 - lib/templates/rescue.erb
 - rails/init.rb
+- resources/README.md
 - resources/airbrake_3_0.json
 - resources/ca-bundle.crt
-- resources/README.md
+- resources/notice.xml
 - script/integration_test.rb
-- airbrake.gemspec
-- CHANGELOG
-- Gemfile
-- Guardfile
-- INSTALL
-- LICENSE
-- Rakefile
-- README_FOR_HEROKU_ADDON.md
-- README.md
-- TESTED_AGAINST
-- install.rb
 - test/airbrake_tasks_test.rb
 - test/backtrace_test.rb
 - test/capistrano_test.rb
 - test/configuration_test.rb
 - test/controller_methods_test.rb
 - test/helper.rb
+- test/integration.rb
 - test/integration/catcher_test.rb
 - test/integration/javascript_notifier_test.rb
-- test/integration.rb
 - test/logger_test.rb
 - test/notice_test.rb
 - test/notifier_test.rb
@@ -364,24 +397,6 @@ files:
 - test/sender_test.rb
 - test/support/response_shim.xml
 - test/user_informer_test.rb
-- features/metal.feature
-- features/rack.feature
-- features/rails.feature
-- features/rails_with_js_notifier.feature
-- features/rake.feature
-- features/sinatra.feature
-- features/step_definitions/file_steps.rb
-- features/step_definitions/rack_steps.rb
-- features/step_definitions/rails_application_steps.rb
-- features/step_definitions/rake_steps.rb
-- features/support/airbrake_shim.rb.template
-- features/support/aruba.rb
-- features/support/env.rb
-- features/support/matchers.rb
-- features/support/rails.rb
-- features/support/rake/Rakefile
-- features/user_informer.feature
-- bin/airbrake
 homepage: http://www.airbrake.io
 licenses: []
 metadata: {}
@@ -401,7 +416,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Send your application errors to our hosted service and reclaim your inbox.
@@ -443,4 +458,3 @@ test_files:
 - features/support/rails.rb
 - features/support/rake/Rakefile
 - features/user_informer.feature
-has_rdoc: