airbrake-statsd 0.1.0 → 0.2.0

data/lib/airbrake-statsd.rb

@@ -32,7 +32,7 @@ module Airbrake
 
       def increment
         return unless configured?
-        client.increment('exceptions')
+        client.increment(config.bucket)
       end
 
     end # << self

data/lib/airbrake-statsd/configuration.rb

@@ -14,6 +14,11 @@ module Airbrake
       end
       attr_writer :port
 
+      def bucket
+        @bucket ||= 'exceptions'
+      end
+      attr_writer :bucket
+
     end # Configuration
   end # Statsd
 end # Airbrake

data/lib/airbrake-statsd/version.rb

@@ -1,5 +1,5 @@
 module Airbrake
   module Statsd
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

data/spec/unit/airbrake-statsd/configuration_spec.rb

@@ -37,6 +37,17 @@ module Airbrake
         end
       end
 
+      describe '`bucket` option' do
+        it 'defaults to "exceptions"' do
+          subject.bucket.should == 'exceptions'
+        end
+
+        it 'can be set' do
+          subject.bucket = 'errors'
+          subject.bucket.should == 'errors'
+        end
+      end
+
     end
   end
 end

data/spec/unit/airbrake-statsd_spec.rb

@@ -6,11 +6,26 @@ module Airbrake
     subject { Statsd }
 
     before do
-      subject.instance_variable_set('@configured', nil)
-      subject.instance_variable_set('@config', nil)
-      subject.instance_variable_set('@client', nil)
+      ['@configured', '@config', '@client'].each do |var_name|
+        subject.instance_variable_set(var_name, nil)
+      end
     end
 
+    describe '#configure' do
+      it 'sets @configured to true' do
+        subject.instance_variable_get('@configured').should_not be_true
+        subject.configure
+        subject.instance_variable_get('@configured').should be_true
+      end
+
+      context 'when block is passed' do
+        it 'passes #config to block' do
+          block = Proc.new { |conf| conf.should be_a(Statsd::Configuration) }
+          subject.configure(&block)
+        end
+      end # block passed
+    end # configure
+
     describe '#configured?' do
       context 'when #configure has been called' do
         it 'returns true' do
@@ -30,7 +45,7 @@ module Airbrake
       it 'creates new Configuration instance if not set' do
         subject.config.should be_a(Statsd::Configuration)
       end
-    end
+    end # config
 
     describe '#client' do
       it 'creates a new ::Statsd client instance if not set' do
@@ -49,23 +64,36 @@ module Airbrake
           ::Statsd.any_instance.should_receive(:namespace=).with('test').once
           subject.client
         end
-      end
-    end
+      end # namespace is set
+    end # client
 
     describe '#increment' do
       context 'when #configure has been called' do
         before { subject.configure }
 
-        it 'calls #increment on #client instance' do
-          subject.client.should_receive(:increment).once
+        it 'calls #increment on #client' do
+          subject.client.should_receive(:increment).with('exceptions').once
           subject.increment
         end
 
-        it 'default bucket name used is "exceptions"' do
-          subject.client.should_receive(:increment).with('exceptions').once
+        context 'when bucket option has been customized' do
+          before do
+            subject.configure { |config| config.bucket = 'errors' }
+          end
+
+          it 'calls #increment on #client with custom bucket' do
+            subject.client.should_receive(:increment).with('errors').once
+            subject.increment
+          end
+        end # bucket option customized
+      end # configure called
+
+      context 'when #configure has not been called' do
+        it 'does not call #increment on #client' do
+          subject.client.should_not_receive(:increment)
           subject.increment
         end
-      end # configure called
+      end # configure not called
     end # increment
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-statsd
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70264029721400 !ruby/object:Gem::Requirement
+  requirement: &70244425362220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70264029721400
+  version_requirements: *70244425362220
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70264029719960 !ruby/object:Gem::Requirement
+  requirement: &70244425360740 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70264029719960
+  version_requirements: *70244425360740
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70264029719260 !ruby/object:Gem::Requirement
+  requirement: &70244425359980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70264029719260
+  version_requirements: *70244425359980
 - !ruby/object:Gem::Dependency
   name: airbrake
-  requirement: &70264029718620 !ruby/object:Gem::Requirement
+  requirement: &70244425359340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70264029718620
+  version_requirements: *70244425359340
 - !ruby/object:Gem::Dependency
   name: statsd-ruby
-  requirement: &70264029717780 !ruby/object:Gem::Requirement
+  requirement: &70244425358600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70264029717780
+  version_requirements: *70244425358600
 description: Increment an exception counter in StatsD whenever the Airbrake gem reports
   and exception.
 email:
@@ -102,7 +102,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2958165307938427188
+      hash: -2772850285584878905
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -111,7 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2958165307938427188
+      hash: -2772850285584878905
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.11