airbrake-ruby 2.5.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae9f7049d793e87a0318eb83c39ab56842dfffc0
-  data.tar.gz: 85e78326a5fca5307ba496f9c3cbe0acb584fc51
+  metadata.gz: c824b0d3f9372ab651d5e308df76080b2000f519
+  data.tar.gz: 2fc17c502f0bd474db41d00697a12bcdfeb0ac6e
 SHA512:
-  metadata.gz: 42090f81e92e38d63cf555fe0c989d34ea02c6ff9d78453756e08f3523274d644f169f05315d81eb896d3393a9b7a4bbd005d482dfe9d59ea664554f75a30c73
-  data.tar.gz: e5680cae91bf311eda5ec420a0946675b94f9d8eef01d8dd47002902bdf11d3fa971abed4e01f9728493f643329f15933cfd6dc6398c1bd4e7a87b20b0af8559
+  metadata.gz: 191e18fafeddbfe6501f5acdf17cd5ec9fd759e41e78b2c3637625b87024561d2ab9599292c420607051b0043079f88490d8470f6caebe6e5e431640a5bdcf43
+  data.tar.gz: 1d16bdffa0fd2c37184b2e95be230b6816e3e9b5d0c2f01b09c9867d70e8d0551f73b9001de35eb0529a0104b7d59b1c86a6fa8236bc7d742bad2101e9844899

data/lib/airbrake-ruby/config.rb

@@ -118,7 +118,7 @@ module Airbrake
       @endpoint ||=
         begin
           self.host = ('https://' << host) if host !~ %r{\Ahttps?://}
-          api = "api/v3/projects/#{project_id}/notices?key=#{project_key}"
+          api = "api/v3/projects/#{project_id}/notices"
           URI.join(host, api)
         end
     end

data/lib/airbrake-ruby/filters/keys_filter.rb

@@ -131,6 +131,7 @@ module Airbrake
 
       def filter_context_key(notice, key)
         return unless notice[:context][key]
+        return if notice[:context][key] == FILTERED
         return filter_hash(notice[:context][key]) unless should_filter?(key)
 
         notice[:context][key] = FILTERED

data/lib/airbrake-ruby/sync_sender.rb

@@ -66,6 +66,7 @@ module Airbrake
       Net::HTTP::Post.new(uri.request_uri).tap do |req|
         req.body = notice.to_json
 
+        req['Authorization'] = "Bearer #{@config.project_key}"
         req['Content-Type'] = CONTENT_TYPE
         req['User-Agent'] =
           "#{Airbrake::Notice::NOTIFIER[:name]}/#{Airbrake::AIRBRAKE_RUBY_VERSION}" \

data/lib/airbrake-ruby/version.rb

@@ -4,5 +4,5 @@
 module Airbrake
   ##
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '2.5.0'.freeze
+  AIRBRAKE_RUBY_VERSION = '2.5.1'.freeze
 end

data/spec/airbrake_spec.rb

@@ -1,9 +1,7 @@
 require 'spec_helper'
 
 RSpec.describe Airbrake do
-  let(:endpoint) do
-    'https://airbrake.io/api/v3/projects/113743/notices?key=fd04e13d806a90f96614ad8e529b2822'
-  end
+  let(:endpoint) { 'https://airbrake.io/api/v3/projects/113743/notices' }
 
   let!(:notifier) do
     described_class.configure do |c|

data/spec/config_spec.rb

@@ -241,7 +241,7 @@ RSpec.describe Airbrake::Config do
         it "sets the endpoint with the slug" do
           config.host = 'https://localhost/bingo/'
           expect(config.endpoint.to_s).
-            to eq('https://localhost/bingo/api/v3/projects/1/notices?key=2')
+            to eq('https://localhost/bingo/api/v3/projects/1/notices')
         end
       end
 
@@ -249,7 +249,7 @@ RSpec.describe Airbrake::Config do
         it "sets the endpoint without the slug" do
           config.host = 'https://localhost/bingo'
           expect(config.endpoint.to_s).
-            to eq('https://localhost/api/v3/projects/1/notices?key=2')
+            to eq('https://localhost/api/v3/projects/1/notices')
         end
       end
     end

data/spec/notifier_spec.rb

@@ -8,10 +8,7 @@ RSpec.describe Airbrake::Notifier do
   let(:project_id) { 105138 }
   let(:project_key) { 'fd04e13d806a90f96614ad8e529b2822' }
   let(:localhost) { 'http://localhost:8080' }
-
-  let(:endpoint) do
-    "https://airbrake.io/api/v3/projects/#{project_id}/notices?key=#{project_key}"
-  end
+  let(:endpoint) { "https://airbrake.io/api/v3/projects/#{project_id}/notices" }
 
   let(:airbrake_params) do
     { project_id: project_id,

data/spec/notifier_spec/options_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Airbrake::Notifier do
   let(:localhost) { 'http://localhost:8080' }
 
   let(:endpoint) do
-    "https://airbrake.io/api/v3/projects/#{project_id}/notices?key=#{project_key}"
+    "https://airbrake.io/api/v3/projects/#{project_id}/notices"
   end
 
   let(:airbrake_params) do
@@ -39,7 +39,7 @@ RSpec.describe Airbrake::Notifier do
           end
         end
 
-        path = '/api/v3/projects/105138/notices?key=fd04e13d806a90f96614ad8e529b2822'
+        path = '/api/v3/projects/105138/notices'
 
         context "given a full host" do
           include_examples('endpoint', localhost = 'http://localhost:8080',
@@ -150,7 +150,7 @@ RSpec.describe Airbrake::Notifier do
 
         # rubocop:disable Metrics/LineLength
         expect(proxied_request.request_line).
-          to eq("POST http://localhost:#{proxy.config[:Port]}/api/v3/projects/105138/notices?key=fd04e13d806a90f96614ad8e529b2822 HTTP/1.1\r\n")
+          to eq("POST http://localhost:#{proxy.config[:Port]}/api/v3/projects/105138/notices HTTP/1.1\r\n")
         # rubocop:enable Metrics/LineLength
       end
     end
@@ -226,5 +226,25 @@ RSpec.describe Airbrake::Notifier do
         include_examples 'sent notice', environment: :development
       end
     end
+
+    describe ":blacklist_keys" do
+      # Fixes https://github.com/airbrake/airbrake-ruby/issues/276
+      context "when specified along with :whitelist_keys" do
+        context "and when context payload is present" do
+          it "sends a notice" do
+            params = {
+              blacklist_keys: %i[password password_confirmation],
+              whitelist_keys: [:email, /user/i, 'account_id']
+            }
+            airbrake = described_class.new(airbrake_params.merge(params))
+            notice = airbrake.build_notice(ex)
+            notice[:context][:headers] = 'banana'
+            airbrake.notify_sync(notice)
+
+            expect(a_request(:post, endpoint)).to have_been_made
+          end
+        end
+      end
+    end
   end
 end

data/spec/sync_sender_spec.rb

@@ -14,7 +14,15 @@ RSpec.describe Airbrake::SyncSender do
   describe "#send" do
     let(:promise) { Airbrake::Promise.new }
     let(:stdout) { StringIO.new }
-    let(:config) { Airbrake::Config.new(logger: Logger.new(stdout)) }
+
+    let(:config) do
+      Airbrake::Config.new(
+        project_id: 1,
+        project_key: 'banana',
+        logger: Logger.new(stdout)
+      )
+    end
+
     let(:sender) { described_class.new(config) }
     let(:notice) { Airbrake::Notice.new(config, AirbrakeTestError.new) }
 
@@ -27,6 +35,21 @@ RSpec.describe Airbrake::SyncSender do
       expect(stdout.string).to match(/ERROR -- : .+ HTTP error: foo/)
     end
 
+    it "passes project key as a token in the Authorization header" do
+      stub_request(:post, 'https://airbrake.io/api/v3/projects/1/notices').
+        to_return(body: '{}')
+      sender.send(notice, promise)
+
+      expect(
+        a_request(:post, 'https://airbrake.io/api/v3/projects/1/notices').with(
+          headers: {
+            'Authorization' => 'Bearer banana',
+            'Content-Type' => 'application/json'
+          }
+        )
+      ).to have_been_made.once
+    end
+
     context "when request body is nil" do
       it "doesn't send a notice" do
         expect_any_instance_of(Airbrake::Truncator).
@@ -50,7 +73,7 @@ RSpec.describe Airbrake::SyncSender do
     end
 
     context "when IP is rate limited" do
-      let(:endpoint) { %r{https://airbrake.io/api/v3/projects/notices} }
+      let(:endpoint) { %r{https://airbrake.io/api/v3/projects/1/notices} }
 
       before do
         stub_request(:post, endpoint).to_return(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-20 00:00:00.000000000 Z
+date: 2017-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec