airbrake-ruby 2.2.2 → 2.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d64cdba9f23541f20ba15bc0d7e4428cdec2f18b
-  data.tar.gz: 6adece1384ee220679a705b3343850bd2401473e
+  metadata.gz: 03b38987d8ca77dcd6c8302246192bd1a9184854
+  data.tar.gz: 93f4e52998430af6c6bcce0bca5e1b6dae3202ae
 SHA512:
-  metadata.gz: 91de811f9e41f506ac429361f692c795f1622452b63b500770ad3910178c5fdf0e0685c37c9a035c014a653a212fadb1bdf692011bd37d17b17a6ba0ec541790
-  data.tar.gz: 93f7598aca53fc4d2d672b357bc43727ebb937624a97e55835c1dfe35134f120e9812a734e0c33f3add558ada30201c0ce0fbada1247da2c1f425be82155ec06
+  metadata.gz: 9f2ae08f59cb532ca0313d7d16eebab0ea9e54c5796048c57fc6418d2c7b18d37744450651f4743d4147b7288aba6f25ae0d8db88d0135104a50d35444d59be1
+  data.tar.gz: 0a327f231fea3629de145c84570c17f48a5f0e9c37050ed0a3f53ab8cea9d59d83c17c03066c4e025051d6f0870b9b0e5591345e1d76f554a42744b0a55949b0

data/lib/airbrake-ruby/filters/keys_filter.rb

@@ -70,7 +70,7 @@ module Airbrake
 
       def filter_hash(hash)
         hash.each_key do |key|
-          if should_filter?(key)
+          if should_filter?(key.to_s)
             hash[key] = FILTERED
           elsif hash[key].is_a?(Hash)
             filter_hash(hash[key])

data/lib/airbrake-ruby/version.rb

@@ -4,5 +4,5 @@
 module Airbrake
   ##
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '2.2.2'.freeze
+  AIRBRAKE_RUBY_VERSION = '2.2.3'.freeze
 end

data/spec/filters/keys_blacklist_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+RSpec.describe Airbrake::Filters::KeysBlacklist do
+  subject do
+    described_class.new(Logger.new('/dev/null'), patterns)
+  end
+
+  describe "#call" do
+    let(:notice) do
+      Airbrake::Notice.new(Airbrake::Config.new, AirbrakeTestError.new)
+    end
+
+    context "when a pattern is a regexp and when a key is a hash" do
+      let(:patterns) { [/bango/] }
+
+      it "doesn't fail" do
+        notice[:params] = { bingo: { {} => 'unfiltered' } }
+        expect { subject.call(notice) }.not_to raise_error
+      end
+    end
+  end
+end

data/spec/filters/thread_filter_spec.rb

@@ -1,23 +1,30 @@
 require 'spec_helper'
 
 RSpec.describe Airbrake::Filters::ThreadFilter do
-  subject { described_class.new }
+  let(:notice) do
+    Airbrake::Notice.new(Airbrake::Config.new, AirbrakeTestError.new)
+  end
+
+  def new_thread
+    Thread.new do
+      th = Thread.current
 
-  let(:notice) { Airbrake::Notice.new(Airbrake::Config.new, AirbrakeTestError.new) }
-  let(:th) { Thread.current }
+      # Ensure a thread always has some variable to make sure the
+      # :fiber_variables Hash is always present.
+      th[:random_var] = 42
+      yield(th)
+    end.join
+  end
 
   shared_examples "fiber variable ignore" do |key|
     it "ignores the :#{key} fiber variable" do
-      th[key] = :bingo
-      subject.call(notice)
-      th[key] = nil
+      new_thread do |th|
+        th[key] = :bingo
+        subject.call(notice)
+      end
 
       fiber_variables = notice[:params][:thread][:fiber_variables]
-      if RUBY_ENGINE == 'jruby'
-        expect(fiber_variables).to be_nil
-      else
-        expect(fiber_variables[key]).to be_nil
-      end
+      expect(fiber_variables[key]).to be_nil
     end
   end
 
@@ -26,27 +33,28 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
   end
 
   it "appends thread variables" do
-    Thread.new do
+    new_thread do |th|
       th.thread_variable_set(:bingo, :bango)
       subject.call(notice)
-      th.thread_variable_set(:bingo, nil)
-    end.join
+    end
 
     expect(notice[:params][:thread][:thread_variables][:bingo]).to eq(:bango)
   end
 
   it "appends fiber variables" do
-    th[:bingo] = :bango
-    subject.call(notice)
-    th[:bingo] = nil
+    new_thread do |th|
+      th[:bingo] = :bango
+      subject.call(notice)
+    end
 
     expect(notice[:params][:thread][:fiber_variables][:bingo]).to eq(:bango)
   end
 
   it "appends name", skip: !Thread.current.respond_to?(:name) do
-    th.name = 'bingo'
-    subject.call(notice)
-    th.name = nil
+    new_thread do |th|
+      th.name = 'bingo'
+      subject.call(notice)
+    end
 
     expect(notice[:params][:thread][:name]).to eq('bingo')
   end
@@ -83,19 +91,19 @@ RSpec.describe Airbrake::Filters::ThreadFilter do
     end
 
     it "doesn't append the IO object to thread variables" do
-      Thread.new do
+      new_thread do |th|
         th.thread_variable_set(:io, io_obj)
         subject.call(notice)
-        th.thread_variable_set(:io, nil)
-      end.join
+      end
 
       expect(notice[:params][:thread][:thread_variables]).to be_nil
     end
 
     it "doesn't append the IO object to thread variables" do
-      th[:io] = io_obj
-      subject.call(notice)
-      th[:io] = nil
+      new_thread do |th|
+        th[:io] = io_obj
+        subject.call(notice)
+      end
 
       expect(notice[:params][:thread][:fiber_variables][:io]).to be_nil
     end

data/spec/promise_spec.rb

@@ -1,8 +1,6 @@
 require 'spec_helper'
 
 RSpec.describe Airbrake::Promise do
-  subject { described_class.new }
-
   describe ".then" do
     let(:resolved_with) { [] }
     let(:rejected_with) { [] }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.2.3
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-05 00:00:00.000000000 Z
+date: 2017-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -137,6 +137,7 @@ files:
 - spec/config/validator_spec.rb
 - spec/config_spec.rb
 - spec/filter_chain_spec.rb
+- spec/filters/keys_blacklist_spec.rb
 - spec/filters/thread_filter_spec.rb
 - spec/nested_exception_spec.rb
 - spec/notice_spec.rb
@@ -179,6 +180,7 @@ test_files:
 - spec/config/validator_spec.rb
 - spec/config_spec.rb
 - spec/filter_chain_spec.rb
+- spec/filters/keys_blacklist_spec.rb
 - spec/filters/thread_filter_spec.rb
 - spec/nested_exception_spec.rb
 - spec/notice_spec.rb