airbrake-ruby 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4447483250d34ac608ceac9356647902e55a8c58
-  data.tar.gz: 550d498d5f8f36b5cff9a4f02a45e813646c2833
+  metadata.gz: bbc56120094dd5ebca9b489ba613aca53d696da3
+  data.tar.gz: d0f207390f282a459a2a80f13223b7c61de5be09
 SHA512:
-  metadata.gz: 4913a170dcebd29645730f83bba8135a251b07f77f57933eefcaa596b22ad44db84599dbe444ea8bd6fcee57407351f4e1caab8c9d71b292506aa8a89242894e
-  data.tar.gz: d471bba8e00eb16117d6eb8a8842becff961f69d7e3fedfe878fa94939c2aad5919bf9ed5393c91e875995b07de2c4c3c4ae72839b1c600ac4a97f021d651176
+  metadata.gz: a42ae86774fa693ac7678e6e4a9bc0e6014992f4d1c8ba91b08f615b40fbd36cdbaf8bae42163d7bbb574c3f25292c92fc10e3707c13b42a35706a01ca2de682
+  data.tar.gz: 4eb63a597c488410fe44972ab6077b11e7d296788e431fda2e956b5fee9f2f58133d0e172f32667d5d1a56aac7b1478d288d5315541c0f0be37e0c87720f9a23

data/lib/airbrake-ruby.rb

@@ -15,12 +15,12 @@ require 'airbrake-ruby/response'
 require 'airbrake-ruby/nested_exception'
 require 'airbrake-ruby/notice'
 require 'airbrake-ruby/backtrace'
-require 'airbrake-ruby/filter_chain'
 require 'airbrake-ruby/payload_truncator'
 require 'airbrake-ruby/filters'
 require 'airbrake-ruby/filters/keys_filter'
 require 'airbrake-ruby/filters/keys_whitelist'
 require 'airbrake-ruby/filters/keys_blacklist'
+require 'airbrake-ruby/filter_chain'
 require 'airbrake-ruby/notifier'
 
 ##

data/lib/airbrake-ruby/filter_chain.rb

@@ -25,6 +25,15 @@ module Airbrake
       end
     end
 
+    ##
+    # Filters to be executed last. By this time all permutations on a notice
+    # should be done, so the final step is to blacklist/whitelist keys.
+    # @return [Array<Class>]
+    KEYS_FILTERS = [
+      Airbrake::Filters::KeysBlacklist,
+      Airbrake::Filters::KeysWhitelist
+    ].freeze
+
     ##
     # Skip over SystemExit exceptions, because they're just noise.
     # @return [Proc]
@@ -38,6 +47,7 @@ module Airbrake
     # @param [Airbrake::Config] config
     def initialize(config)
       @filters = []
+      @keys_filters = []
 
       [SYSTEM_EXIT_FILTER, GEM_ROOT_FILTER].each do |filter|
         add_filter(filter)
@@ -51,6 +61,7 @@ module Airbrake
     # Adds a filter to the filter chain.
     # @param [#call] filter The filter object (proc, class, module, etc)
     def add_filter(filter)
+      return @keys_filters << filter if KEYS_FILTERS.include?(filter.class)
       @filters << filter
     end
 
@@ -61,7 +72,7 @@ module Airbrake
     # @param [Airbrake::Notice] notice The notice to be filtered
     # @return [void]
     def refine(notice)
-      @filters.each do |filter|
+      (@filters + @keys_filters).each do |filter|
         break if notice.ignored?
         filter.call(notice)
       end

data/lib/airbrake-ruby/version.rb

@@ -4,5 +4,5 @@
 module Airbrake
   ##
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '1.7.0'.freeze
+  AIRBRAKE_RUBY_VERSION = '1.7.1'.freeze
 end

data/spec/filter_chain_spec.rb

@@ -39,6 +39,21 @@ RSpec.describe Airbrake::FilterChain do
 
         expect(nums).to eq([0, 1, 2])
       end
+
+      it "executes keys filters last" do
+        notice[:params] = { bingo: 'bango' }
+        blacklist = Airbrake::Filters::KeysBlacklist.new(config.logger, :bingo)
+        @chain.add_filter(blacklist)
+
+        @chain.add_filter(
+          proc do |notice|
+            expect(notice[:params][:bingo]).to eq('bango')
+          end
+        )
+
+        @chain.refine(notice)
+        expect(notice[:params][:bingo]).to eq('[Filtered]')
+      end
     end
 
     describe "default backtrace filters" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-20 00:00:00.000000000 Z
+date: 2017-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec