airbrake-ruby 1.2.4 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3dca16a0676d8aa679ffb3980107107697027b4e
-  data.tar.gz: bfb64410f23a9f6f37047bc9baad6147c25f874e
+  metadata.gz: dec071c8c6dc94827a5094f345a3e04f6e14d403
+  data.tar.gz: f70b0927dcb8a948890cbe1f08f440dbffa832ea
 SHA512:
-  metadata.gz: 0adab3693e3ea82b617927c3efddc5d85ded45be062d849c27e4090c06a5099647449e182c8a945c5e055fc79d2a609b42d08d77a28d989f94b94feaec55ae97
-  data.tar.gz: 3034cfdedfb4320732413e948736dfe6982323859ef109bbcec4044047bb10cce88421a862c67156939c713b7a42ec839581f9c5d64120f853e74d82dd35c60d
+  metadata.gz: 23da1628abcb6f3db15af6988c346f102ebda373ee6ac30212981680cd76014de7c15cdf4e877e81ef7f6fbd7e7996f5c07501cf1472c4c9b9cb8f9e4be22a6d
+  data.tar.gz: 5df62237f843c6521677c6e8f5ceb98547ef76d8931334fb6e611ca489dcb7337cb03044cad51d76375a4339ab426b750a5dd63e2d6addeda80c3f7cb1e0dc31

data/lib/airbrake-ruby.rb

@@ -98,7 +98,7 @@ module Airbrake
     def configure(notifier = :default)
       yield config = Airbrake::Config.new
 
-      if @notifiers.key?(notifier)
+      if configured?(notifier)
         raise Airbrake::Error,
               "the '#{notifier}' notifier was already configured"
       else
@@ -266,6 +266,7 @@ module Airbrake
     # @option deploy_params [Symbol] :repository
     # @option deploy_params [Symbol] :revision
     # @option deploy_params [Symbol] :version
+    # @return [void]
     # @since v5.0.0
     # @api private
     def create_deploy(deploy_params, notifier = :default)
@@ -275,20 +276,15 @@ module Airbrake
     private
 
     ##
-    # Calls +method+ on +notifier+ with provided +args+.
-    #
-    # @raise [Airbrake::Error] if none of the notifiers exist
+    # Calls +method+ on +notifier+ with provided +args+. If +notifier+ is not
+    # configured, returns nil.
     def call_notifier(notifier, method, *args, &block)
-      if @notifiers.key?(notifier)
-        @notifiers[notifier].__send__(method, *args, &block)
-      else
-        # If we raise SystemExit, the Ruby process can gracefully quit without
-        # the unwanted Airbrake::Error.
-        raise args.first if args.first.class == SystemExit
+      return unless configured?(notifier)
+      @notifiers[notifier].__send__(method, *args, &block)
+    end
 
-        raise Airbrake::Error,
-              "the '#{notifier}' notifier isn't configured"
-      end
+    def configured?(notifier)
+      @notifiers.key?(notifier)
     end
   end
 end

data/lib/airbrake-ruby/async_sender.rb

@@ -114,7 +114,8 @@ module Airbrake
         "#{LOG_LABEL} AsyncSender has reached its capacity of "                   \
         "#{@unsent.max} and the following notice will not be delivered "          \
         "Error: #{notice[:errors][0][:type]} - #{notice[:errors][0][:message]}\n" \
-        "Backtrace: \n" + backtrace.join("\n"))
+        "Backtrace: \n" + backtrace.join("\n")
+      )
       nil
     end
   end

data/lib/airbrake-ruby/notice.rb

@@ -140,7 +140,8 @@ module Airbrake
     private
 
     def context(params)
-      { version: @config.app_version,
+      ctx = {
+        version: @config.app_version,
         # We ensure that root_directory is always a String, so it can always be
         # converted to JSON in a predictable manner (when it's a Pathname and in
         # Rails environment, it converts to unexpected JSON).
@@ -153,7 +154,9 @@ module Airbrake
 
         # Make sure we always send hostname.
         hostname: HOSTNAME
-      }.merge(CONTEXT).delete_if { |_key, val| val.nil? || val.empty? }
+      }
+
+      ctx.merge(CONTEXT).delete_if { |_key, val| val.nil? || val.empty? }
     end
 
     def raise_if_ignored

data/lib/airbrake-ruby/version.rb

@@ -3,5 +3,5 @@
 module Airbrake
   ##
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '1.2.4'.freeze
+  AIRBRAKE_RUBY_VERSION = '1.3.0'.freeze
 end

data/spec/airbrake_spec.rb

@@ -20,18 +20,15 @@ RSpec.describe Airbrake do
     described_class.instance_variable_set(:@notifiers, {})
   end
 
-  shared_examples 'error handling' do |method|
-    it "raises error if there is no notifier when using #{method}" do
+  shared_examples 'non-configured notifier handling' do |method|
+    it "returns nil if there is no configured notifier when using #{method}" do
       described_class.instance_variable_set(:@notifiers, {})
-
-      expect { described_class.__send__(method, 'bingo') }.
-        to raise_error(Airbrake::Error,
-                       "the 'default' notifier isn't configured")
+      expect(described_class.__send__(method, 'bingo')).to be_nil
     end
   end
 
   describe ".notify" do
-    include_examples 'error handling', :notify
+    include_examples 'non-configured notifier handling', :notify
 
     it "sends exceptions asynchronously" do
       described_class.notify('bingo')
@@ -41,7 +38,7 @@ RSpec.describe Airbrake do
   end
 
   describe ".notify_sync" do
-    include_examples 'error handling', :notify_sync
+    include_examples 'non-configured notifier handling', :notify_sync
 
     it "sends exceptions synchronously" do
       expect(described_class.notify_sync('bingo')).to be_a(Hash)
@@ -97,14 +94,16 @@ RSpec.describe Airbrake do
         include_examples(
           'backtrace building',
           'converts it to a RuntimeException and builds a fake backtrace',
-          'bingo')
+          'bingo'
+        )
       end
 
       context "given an Exception with missing backtrace" do
         include_examples(
           'backtrace building',
           'builds a backtrace for it and sends the notice',
-          RuntimeError.new('bingo'))
+          RuntimeError.new('bingo')
+        )
       end
     end
 
@@ -162,7 +161,7 @@ RSpec.describe Airbrake do
   end
 
   describe ".add_filter" do
-    include_examples 'error handling', :add_filter
+    include_examples 'non-configured notifier handling', :add_filter
 
     it "adds filters with help of blocks" do
       filter_chain = notifier.instance_variable_get(:@filter_chain)
@@ -178,14 +177,14 @@ RSpec.describe Airbrake do
   end
 
   describe ".whitelist_keys" do
-    include_examples 'error handling', :whitelist_keys
+    include_examples 'non-configured notifier handling', :whitelist_keys
   end
 
   describe ".blacklist_keys" do
-    include_examples 'error handling', :blacklist_keys
+    include_examples 'non-configured notifier handling', :blacklist_keys
   end
 
   describe ".build_notice" do
-    include_examples 'error handling', :build_notice
+    include_examples 'non-configured notifier handling', :build_notice
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.3.0
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2016-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec