airbrake-ruby 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7584737ab96d10454a892c2a5962f71efa1f344b
-  data.tar.gz: 0b0b806ab0434e86f0ad797854679e53480997d7
+  metadata.gz: 3dca16a0676d8aa679ffb3980107107697027b4e
+  data.tar.gz: bfb64410f23a9f6f37047bc9baad6147c25f874e
 SHA512:
-  metadata.gz: 5a1891009204e5d5dbca417495d270eabab1340a7059f106430a1c50c5de0f41647f864defd0ce9642fa06d9b4e0425aa81c908925c024e860f45148e7773832
-  data.tar.gz: 39bae0e2ac392cb11ea1d55b3a8ae2dd7d513fba0dcd6e7908af4bcc8c962360d7a76a8ce9fe4c3d2d9c1dc5de87c69cf34bbdd4d541a943df96b1a7719de0a4
+  metadata.gz: 0adab3693e3ea82b617927c3efddc5d85ded45be062d849c27e4090c06a5099647449e182c8a945c5e055fc79d2a609b42d08d77a28d989f94b94feaec55ae97
+  data.tar.gz: 3034cfdedfb4320732413e948736dfe6982323859ef109bbcec4044047bb10cce88421a862c67156939c713b7a42ec839581f9c5d64120f853e74d82dd35c60d

data/lib/airbrake-ruby/payload_truncator.rb

@@ -91,7 +91,7 @@ module Airbrake
     end
 
     def truncate_string(str)
-      replace_invalid_characters!(str)
+      str = replace_invalid_characters!(str)
       return str if str.length <= @max_size
       str.slice(0, @max_size) + '[Truncated]'.freeze
     end
@@ -106,14 +106,16 @@ module Airbrake
     # For modern Rubies we use UTF-16 as a safe alternative.
     #
     # @param [String] str The string to replace characters
-    # @return [void]
-    # @note This method mutates +str+ for speed
+    # @return [String] a UTF-8 encoded string
+    # @note This method mutates +str+ unless it's frozen,
+    #   in which case it creates a duplicate
     # @see https://github.com/flori/json/commit/3e158410e81f94dbbc3da6b7b35f4f64983aa4e3
     def replace_invalid_characters!(str)
       encoding = str.encoding
       utf8_string = (encoding == Encoding::UTF_8 || encoding == Encoding::ASCII)
       return str if utf8_string && str.valid_encoding?
 
+      str = str.dup if str.frozen?
       str.encode!(TEMP_ENCODING, ENCODING_OPTIONS) if utf8_string
       str.encode!('utf-8', ENCODING_OPTIONS)
     end

data/lib/airbrake-ruby/version.rb

@@ -3,5 +3,5 @@
 module Airbrake
   ##
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '1.2.3'.freeze
+  AIRBRAKE_RUBY_VERSION = '1.2.4'.freeze
 end

data/spec/payload_truncator_spec.rb

@@ -445,6 +445,17 @@ RSpec.describe Airbrake::PayloadTruncator do
 
           expect(params[:unicode]).to match(/[�\?]{4}/)
         end
+
+        it "doesn't fail when string is frozen" do
+          encoded = Base64.encode64("\xD3\xE6\xBC\x9D\xBA").encode!('ASCII-8BIT')
+          bad_string = Base64.decode64(encoded).freeze
+
+          params = { unicode: bad_string }
+
+          @truncator.truncate_object(params)
+
+          expect(params[:unicode]).to match(/[�\?]{4}/)
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-22 00:00:00.000000000 Z
+date: 2016-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec