airbrake-ruby 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca403eaf9b4aeb5fb5ca045087642ad1401e738c
-  data.tar.gz: 34696a178cd229b8af3c2c9a5f99bef94e2b72d5
+  metadata.gz: 7584737ab96d10454a892c2a5962f71efa1f344b
+  data.tar.gz: 0b0b806ab0434e86f0ad797854679e53480997d7
 SHA512:
-  metadata.gz: 2e52ed3bda29d983c09d8998a084f5c3a1c937f37872e624bc4769936552bad215394ced32cbf6d04ff5083c882db3fd5b5b6dc5c7601ecae29f4371830dc4fd
-  data.tar.gz: 90dc365fc8000e40192a959aeea5bec8693451c75e79925640b62186d78bebd92467887983f5b6ca70ba05b4e465222552ba36e788c4e6fc0623ee9e12ab3bf0
+  metadata.gz: 5a1891009204e5d5dbca417495d270eabab1340a7059f106430a1c50c5de0f41647f864defd0ce9642fa06d9b4e0425aa81c908925c024e860f45148e7773832
+  data.tar.gz: 39bae0e2ac392cb11ea1d55b3a8ae2dd7d513fba0dcd6e7908af4bcc8c962360d7a76a8ce9fe4c3d2d9c1dc5de87c69cf34bbdd4d541a943df96b1a7719de0a4

data/lib/airbrake-ruby/filters/keys_filter.rb

@@ -37,10 +37,7 @@ module Airbrake
         end
 
         return unless notice[:context][:url]
-        url = URI(notice[:context][:url])
-        return if url.nil? || url.query.nil?
-
-        notice[:context][:url] = filter_url_params(url)
+        filter_url(notice)
       end
 
       ##
@@ -74,6 +71,17 @@ module Airbrake
 
         url.to_s
       end
+
+      def filter_url(notice)
+        begin
+          url = URI(notice[:context][:url])
+        rescue URI::InvalidURIError
+          return
+        end
+
+        return unless url.query
+        notice[:context][:url] = filter_url_params(url)
+      end
     end
   end
 end

data/lib/airbrake-ruby/version.rb

@@ -3,5 +3,5 @@
 module Airbrake
   ##
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '1.2.2'.freeze
+  AIRBRAKE_RUBY_VERSION = '1.2.3'.freeze
 end

data/spec/notifier_spec.rb

@@ -685,6 +685,44 @@ RSpec.describe Airbrake::Notifier do
           with(body: expected_body)
         ).to have_been_made.once
       end
+
+      context "given a non-standard URL" do
+        it "leaves the URL unfiltered" do
+          @airbrake.whitelist_keys(%w(bish))
+
+          notice = @airbrake.build_notice(ex)
+          notice[:context][:url] =
+            'http://localhost:3000/cra]]]sh?foo=bar&baz=bongo&bish=bash'
+
+          @airbrake.notify_sync(notice)
+
+          # rubocop:disable Metrics/LineLength
+          expected_body =
+            %r("context":{.*"url":"http://localhost:3000/cra\]\]\]sh\?foo=bar&baz=bongo&bish=bash".*})
+          # rubocop:enable Metrics/LineLength
+
+          expect(
+            a_request(:post, endpoint).
+            with(body: expected_body)
+          ).to have_been_made.once
+        end
+      end
+
+      context "given a URL without a query" do
+        it "skips params filtering and leaves the URL untouched" do
+          @airbrake.whitelist_keys(%w(bish))
+
+          notice = @airbrake.build_notice(ex)
+          notice[:context][:url] = 'http://localhost:3000/crash'
+
+          @airbrake.notify_sync(notice)
+
+          expect(
+            a_request(:post, endpoint).
+            with(body: %r("context":{.*"url":"http://localhost:3000/crash".*}))
+          ).to have_been_made.once
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-05 00:00:00.000000000 Z
+date: 2016-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec