airbrake-ruby 1.0.0.rc.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 92ce605f767bda511e878bfb2f3c693251573d79
-  data.tar.gz: 996a67010b00cd651a22921befd7c1d353d1eff2
+  metadata.gz: 0e0b8a983d9bbd1f4b07e94bbc77e7ecc7da3149
+  data.tar.gz: 28e61e26cf914c6d688601fcd775291deddd5c9f
 SHA512:
-  metadata.gz: cef747483b2c451ee12df8221bf49da0cb8faf8ccf279929be286d2070f5c6993fefdf3e82b487ba2909599f40d4baacd94db39d2e95dc8b0caeb0ea93a5cc3c
-  data.tar.gz: 4b43779c5de8e1998760906e9816478ac71c697161d9054068b277e33bc5d831779b0b60638f3a389cb9e96482aebfa826b1083e08d64214b10d0a42854174a4
+  metadata.gz: 24386e09635bee179b11bb836e6440034947675d1ea509029105a28d1d8c507a5185f10949d11b58123c119530a8c7e5a4f55ebc8054a1475e2754eb4053fa8f
+  data.tar.gz: ffa255cceab9397485b1ca313259179768129909ae0b50ee5b9dee831fabed3ea3b954c438c9d64d315219302be0878b8192497894e29f5be08588e300bf28f3

data/lib/airbrake-ruby/backtrace.rb

@@ -14,7 +14,7 @@ module Airbrake
     ##
     # @return [Regexp] the pattern that matches standard Ruby stack frames,
     #   such as ./spec/notice_spec.rb:43:in `block (3 levels) in <top (required)>'
-    STACKFRAME_REGEXP = %r{\A
+    RUBY_STACKFRAME_REGEXP = %r{\A
       (?<file>.+)       # Matches './spec/notice_spec.rb'
       :
       (?<line>\d+)      # Matches '43'
@@ -34,6 +34,16 @@ module Airbrake
       \)
     \z/x
 
+    ##
+    # @return [Regexp] the template that tries to assume what a generic stack
+    #   frame might look like, when exception's backtrace is set manually.
+    GENERIC_STACKFRAME_REGEXP = %r{\A
+      (?<file>.+)   # Matches '/foo/bar/baz.ext'
+      :
+      (?<line>\d+)  # Matches '43'
+      (?<function>) # No-op
+    \z}x
+
     ##
     # Parses an exception's backtrace.
     #
@@ -44,11 +54,11 @@ module Airbrake
       regexp = if java_exception?(exception)
                  JAVA_STACKFRAME_REGEXP
                else
-                 STACKFRAME_REGEXP
+                 RUBY_STACKFRAME_REGEXP
                end
 
       (exception.backtrace || []).map do |stackframe|
-        stack_frame(regexp.match(stackframe))
+        stack_frame(match_frame(regexp, stackframe))
       end
     end
 
@@ -71,5 +81,15 @@ module Airbrake
           function: match[:function] }
       end
     end
+
+    def self.match_frame(regexp, stackframe)
+      match = regexp.match(stackframe)
+      return match if match
+
+      match = GENERIC_STACKFRAME_REGEXP.match(stackframe)
+      return match if match
+
+      raise Airbrake::Error, "can't parse '#{stackframe}'"
+    end
   end
 end

data/lib/airbrake-ruby/notice.rb

@@ -15,7 +15,7 @@ module Airbrake
     #   Context tab in the dashboard
     CONTEXT = {
       os: RUBY_PLATFORM,
-      language: RUBY_VERSION,
+      language: "#{RUBY_ENGINE}/#{RUBY_VERSION}".freeze,
       notifier: NOTIFIER
     }.freeze
 

data/lib/airbrake-ruby/version.rb

@@ -3,5 +3,5 @@
 module Airbrake
   ##
   # @return [String] the library version
-  AIRBRAKE_RUBY_VERSION = '1.0.0.rc.1'.freeze
+  AIRBRAKE_RUBY_VERSION = '1.0.0'.freeze
 end

data/spec/backtrace_spec.rb

@@ -73,5 +73,40 @@ RSpec.describe Airbrake::Backtrace do
           to eq(backtrace_array)
       end
     end
+
+    context "generic backtrace" do
+      # rubocop:disable Metrics/LineLength
+      let(:generic_bt) do
+        ["/home/bingo/bango/assets/stylesheets/error_pages.scss:139:in `animation'",
+         "/home/bingo/bango/assets/stylesheets/error_pages.scss:139",
+         "/home/bingo/.gem/ruby/2.2.2/gems/sass-3.4.20/lib/sass/tree/visitors/perform.rb:349:in `block in visit_mixin'"]
+      end
+      # rubocop:enable Metrics/LineLength
+
+      let(:ex) { AirbrakeTestError.new.tap { |e| e.set_backtrace(generic_bt) } }
+
+      let(:parsed_backtrace) do
+        # rubocop:disable Metrics/LineLength, Style/HashSyntax, Style/SpaceInsideHashLiteralBraces, Style/SpaceAroundOperators
+        [{:file=>"/home/bingo/bango/assets/stylesheets/error_pages.scss", :line=>139, :function=>"animation"},
+         {:file=>"/home/bingo/bango/assets/stylesheets/error_pages.scss", :line=>139, :function=>""},
+         {:file=>"/home/bingo/.gem/ruby/2.2.2/gems/sass-3.4.20/lib/sass/tree/visitors/perform.rb", :line=>349, :function=>"block in visit_mixin"}]
+        # rubocop:enable Metrics/LineLength, Style/HashSyntax, Style/SpaceInsideHashLiteralBraces, Style/SpaceAroundOperators
+      end
+
+      it "returns a properly formatted array of hashes" do
+        expect(described_class.parse(ex)).to eq(parsed_backtrace)
+      end
+    end
+
+    context "unknown backtrace" do
+      let(:unknown_bt) { ['a b c 1 23 321 .rb'] }
+
+      let(:ex) { AirbrakeTestError.new.tap { |e| e.set_backtrace(unknown_bt) } }
+
+      it "raises error" do
+        expect { described_class.parse(ex) }.
+          to raise_error(Airbrake::Error, /can't parse/)
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbrake-ruby
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Airbrake Technologies, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-11 00:00:00.000000000 Z
+date: 2015-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -135,9 +135,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5