airbadger 0.0.4 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c5d1f63130dcbd9664e66c98ebd2881c3f8093d8
-  data.tar.gz: 4563077ce8f0b11f7ff3e2cb2031a0e7c3e3bc15
+  metadata.gz: 1de42cf567b6d7ddab5665c3c13f751bd2f6b832
+  data.tar.gz: 3311757fd84cb7805f33f1cab39a7ad464b4e5b3
 SHA512:
-  metadata.gz: f104a615416232818187a6f391ef89939ad5eec0cb62ad36bdd4e5cf8d3bb5bd98ec06135e1665e3b88d01172b468980898bce10d4b8c8a7a7e3d637ef567973
-  data.tar.gz: b089057607c5bb3655d2ad350b9d673253bd4697cf77fb454cefd73a4f8a79b665f1cf34138371cee34a7ed1a67603e16854554596775d4b311a2dff9405e900
+  metadata.gz: 1c1e021b6a988b19b89279e9e01402cfd0ad59a4f6b8e9b874553c21aef91b5ebca8dd780514f3e0fbe715edea07afdc486e5ccf792d00799e2604ef77590d2e
+  data.tar.gz: 9ac06114fab252695124859d4b2252e149beed93b05209e8f08e704cc7eb56353b83f3ad13ae874751dc57cd171ec47f4a6e2a3969e1bd2cf98244aca23aa88a

data/lib/airbadger.rb

@@ -1,30 +1,14 @@
 require 'airbadger/version'
 
-require 'airbadger/warning_suppression'
-require 'airbadger/airbrake_loader'
-require 'airbadger/configuration'
+require 'airbadger/proxying_error_collector'
 
-module Airbadger
-  def self.configure(&block)
-    configuration.instance_eval(&block)
-    configuration.setup_proxy!
-  end
-
-  def self.method_missing(method_name, *args, &block)
-    if PROXIED_METHODS.include? method_name
-      configuration.loaded_endpoints.each do |endpoint|
-        endpoint.send(method_name, *args, &block)
-      end
-      return nil
-    end
-    super
-  end
-
-  private
+require 'airbrake'
+require 'honeybadger'
 
-  PROXIED_METHODS = [:notify, :notify_or_ignore]
+module Airbadger
+  ERROR_COLLECTORS = [Airbrake, Honeybadger]
 
-  def self.configuration
-    @configuration ||= Configuration.new
+  ERROR_COLLECTORS.each do |error_collector|
+    error_collector.extend(ProxyingErrorCollector)
   end
 end

data/lib/airbadger/proxying_error_collector.rb

@@ -0,0 +1,18 @@
+module Airbadger::ProxyingErrorCollector
+  PROXY_METHODS = [:notify, :notify_or_ignore]
+
+  def self.extend_object(error_collector)
+    class << error_collector
+      Airbadger::ProxyingErrorCollector::PROXY_METHODS.each do |method_name|
+        define_method "#{method_name}_with_proxy" do |*args|
+          Airbadger::ERROR_COLLECTORS.each do |proxied_collector|
+            proxied_collector.send("#{method_name}_without_proxy", *args)
+          end
+        end
+
+        alias_method "#{method_name}_without_proxy", method_name
+        alias_method method_name, "#{method_name}_with_proxy"
+      end
+    end
+  end
+end

data/lib/airbadger/version.rb

@@ -1,3 +1,3 @@
 module Airbadger
-  VERSION = '0.0.4'
+  VERSION = '0.1.0'
 end

data/spec/airbadger_spec.rb

@@ -1,63 +1,26 @@
 require 'spec_helper'
 
-describe Airbadger do
-  ['#notify', '#notify_or_ignore'].each do |proxied_method|
-    describe proxied_method do
-      it 'proxies calls to all configured modules' do
-        proxied_method.sub!('#', '')
-
-        Airbadger.configure do
-          endpoint :raygun do |config|
-            config.test_mode = true
-          end
-          endpoint :errbit do |config|
+[Airbrake, Honeybadger].each do |error_api|
+  describe error_api do
+    ['#notify', '#notify_or_ignore'].each do |proxied_method|
+      describe proxied_method do
+        before :all do
+          Airbrake.configure do |config|
             config.test_mode = true
           end
         end
 
-        error = Exception.new('Some serious shit went down')
+        it 'proxies calls to Airbrake and Honeybadger' do
+          proxied_method.sub!('#', '')
 
-        Raygun.should_receive(proxied_method).with(error)
-        Errbit.should_receive(proxied_method).with(error)
-
-        Airbadger.send(proxied_method, error)
-      end
-    end
-  end
+          error = Exception.new('Some serious shit went down')
 
-  it 'proxies calls to Airbrake to all loaded modules' do
-    Airbadger.configure do
-      endpoint :raygun do |config|
-        config.test_mode = true
-      end
-      endpoint :airbrake do |config|
-        config.test_mode = true
-      end
-    end
+          Airbrake.should_receive("#{proxied_method}_without_proxy").with(error)
+          Honeybadger.should_receive("#{proxied_method}_without_proxy").with(error)
 
-    error = Exception.new('Some serious shit went down')
-
-    Raygun.should_receive(:notify).with(error)
-    AirbrakeProxied.should_receive(:notify).with(error)
-
-    Airbrake.notify(error)
-  end
-
-  it 'proxies calls to Honeybadger' do
-    Airbadger.configure do 
-      endpoint :raygun do |config|
-        config.test_mode = true
-      end
-      endpoint :honeybadger do |config|
-        config.ignore_only = []
+          error_api.send(proxied_method, error)
+        end
       end
     end
-
-    error = Exception.new('Some serious shit went down')
-
-    Raygun.should_receive(:notify).with(error)
-    Honeybadger.should_receive(:notify).with(error)
-
-    Airbadger.notify(error)
   end
 end

data/spec/spec_helper.rb

@@ -13,28 +13,10 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'airbadger'
 
-EXAMPLE_SERVICE_NAMES = [
-  'Airbrake',
-  'AirbrakeProxied',
-  'BasicAirbrake',
-  'Errbit',
-  'Raygun'
-]
-
 RSpec.configure do |config|
   # Run specs in random order to surface order dependencies. If you find an
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
   config.order = 'random'
-
-  config.before :each do
-    EXAMPLE_SERVICE_NAMES.each do |service_name|
-      Object.send(:remove_const, service_name) if Object.const_defined?(service_name)
-    end
-  end
-
-  config.before :each do
-    Airbadger.instance_variable_set('@configuration', nil)
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: airbadger
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.1.0
 platform: ruby
 authors:
 - Josh Jordan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-07 00:00:00.000000000 Z
+date: 2013-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake
@@ -112,15 +112,10 @@ files:
 - Rakefile
 - airbadger.gemspec
 - lib/airbadger.rb
-- lib/airbadger/airbrake_loader.rb
-- lib/airbadger/configuration.rb
+- lib/airbadger/proxying_error_collector.rb
 - lib/airbadger/version.rb
-- lib/airbadger/warning_suppression.rb
 - spec/airbadger_spec.rb
-- spec/airbrake_loader_spec.rb
-- spec/configuration_spec.rb
 - spec/spec_helper.rb
-- spec/warning_suppression_spec.rb
 homepage: http://github.com/joshjordan/airbadger
 licenses:
 - MIT
@@ -147,7 +142,4 @@ specification_version: 4
 summary: Reports errors to multiple Airbrake-compatible endpoints
 test_files:
 - spec/airbadger_spec.rb
-- spec/airbrake_loader_spec.rb
-- spec/configuration_spec.rb
 - spec/spec_helper.rb
-- spec/warning_suppression_spec.rb

data/lib/airbadger/airbrake_loader.rb

@@ -1,52 +0,0 @@
-class Airbadger::AirbrakeLoader
-  def self.load_as(airbrake_alias)
-    new(airbrake_alias).load_aliased
-  end
-
-  def load_aliased
-    without_recording_loaded_features do
-      load_airbrake!
-      load_airbrake_rails! if defined?(::Rails)
-    end
-    aliased_module.tap do
-      preserve_namespaced_calls!
-      remove_airbrake_from_global_namespace!
-    end
-  end
-
-  private
-
-  attr_reader :endpoint_alias
-
-  def initialize(endpoint_alias)
-    @endpoint_alias = endpoint_alias.sub(/^Airbrake$/, 'AirbrakeProxied')
-  end
-
-  def load_airbrake!
-    require 'airbrake'
-  end
-
-  def load_airbrake_rails!
-    require 'airbrake/rails/controller_methods'
-    require 'airbrake/rails/javascript_notifier'
-  end
-
-  def aliased_module
-    @aliased_module ||= Object.const_set(endpoint_alias, Airbrake)
-  end
-
-  def preserve_namespaced_calls!
-    aliased_module.const_set('Airbrake', aliased_module)
-  end
-
-  def remove_airbrake_from_global_namespace!
-    Object.send(:remove_const, 'Airbrake')
-  end
-
-  def without_recording_loaded_features
-    feature_count = $LOADED_FEATURES.count
-    yield
-  ensure
-    $LOADED_FEATURES.pop while feature_count < $LOADED_FEATURES.count
-  end
-end

data/lib/airbadger/configuration.rb

@@ -1,35 +0,0 @@
-class Airbadger::Configuration
-  include Airbadger::WarningSuppression
-
-  def endpoint(service_name, &block)
-    load_endpoint(service_name).configure(&block)
-  end
-
-  def setup_proxy!
-    Object.const_set('Airbrake', Airbadger)
-  end
-
-  def loaded_endpoints
-    @loaded_modules ||= []
-  end
-
-  private
-
-  ENDPOINT_LOADERS = Hash.new(::Airbadger::AirbrakeLoader.method(:load_as)).merge({
-    'Honeybadger' => Proc.new do
-      require 'honeybadger'
-      Honeybadger
-    end
-  })
-
-  def load_endpoint(service_name)
-    service_name = ghetto_classify(service_name)
-    without_warnings do
-      ENDPOINT_LOADERS[service_name].call(service_name)
-    end.tap(&loaded_endpoints.method(:push))
-  end
-
-  def ghetto_classify(snake_cased)
-    snake_cased.to_s.split('_').collect{ |str| str[0] = str[0].upcase; str }.join
-  end
-end

data/lib/airbadger/warning_suppression.rb

@@ -1,9 +0,0 @@
-module Airbadger::WarningSuppression
-  def without_warnings
-    #TODO: a better approach would be to log this to an Airbadger logger
-    old_verbose, $VERBOSE = $VERBOSE, nil
-    yield
-  ensure
-    $VERBOSE = old_verbose
-  end
-end

data/spec/airbrake_loader_spec.rb

@@ -1,49 +0,0 @@
-require 'spec_helper'
-
-describe Airbadger::AirbrakeLoader do
-  include Airbadger::WarningSuppression
-
-  describe '.load_as' do
-    it 'loads a new Airbrake singleton with the given name' do
-      without_warnings do
-        described_class.load_as('Errbit')
-        described_class.load_as('Raygun')
-      end
-
-      Errbit.should respond_to :notify
-      Raygun.should respond_to :notify
-      Errbit.should_not eq Raygun
-    end
-
-    it 'produces endpoints singletons capable of receiving error data' do
-      without_warnings do
-        described_class.load_as('Errbit')
-      end
-      Errbit.configure do |config|
-        config.test_mode = true
-      end
-
-      now = DateTime.now.to_s
-      Errbit.notify(Exception.new(now))
-
-      Errbit.sender.last_notice.should include(now)
-    end
-
-    it 'eager-loads Rails extensions when Rails is running' do
-      Rails = Module.new
-      without_warnings { described_class.load_as('Errbit') }
-
-      defined?(Errbit::Rails::ControllerMethods).should be_true
-      defined?(Errbit::Rails::JavascriptNotifier).should be_true
-
-      Object.send(:remove_const, 'Rails')
-    end
-
-    it 'does not load Rails extensions when Rails is not running' do
-      without_warnings { described_class.load_as('Errbit') }
-
-      defined?(Errbit::Rails::ControllerMethods).should be_false
-      defined?(Errbit::Rails::JavascriptNotifier).should be_false
-    end
-  end
-end

data/spec/configuration_spec.rb

@@ -1,46 +0,0 @@
-require 'spec_helper'
-
-describe Airbadger::Configuration do
-  describe '#endpoint' do
-    it 'proxies the configuration block to a named Airbrake singleton' do
-      subject.endpoint :BasicAirbrake do |config|
-        config.test_mode = true
-      end
-
-      subject.endpoint :Errbit do |config|
-        config.test_mode = true
-        config.host = 'errbit.example.com'
-      end
-
-      BasicAirbrake.configuration.host.should eq 'api.airbrake.io'
-      Errbit.configuration.host.should eq 'errbit.example.com'
-    end
-
-    it 'accepts snake-cased service names and produces constants with proper class names' do
-      subject.endpoint :basic_airbrake do |config|
-        config.test_mode = true
-      end
-
-      defined?(BasicAirbrake).should be_true
-    end
-
-    it 'rewrites the name "Airbrake" to "AirbrakeProxied" to avoid collisions' do
-      subject.endpoint :airbrake do |config|
-        config.test_mode = true
-      end
-
-      defined?(Airbrake).should be_false
-      defined?(AirbrakeProxied).should be_true
-    end
-
-    it 'supports Honeybadger configuration from the Honeybadger gem rather than the Airbrake gem' do
-      Airbadger::AirbrakeLoader.should_receive(:load_as).never
-
-      subject.endpoint :honeybadger do |config|
-        config.ignore_only = []
-      end
-
-      defined?(Honeybadger).should be_true
-    end
-  end
-end

data/spec/warning_suppression_spec.rb

@@ -1,39 +0,0 @@
-require 'spec_helper'
-
-describe Airbadger::WarningSuppression do
-  include Airbadger::WarningSuppression
-
-  describe '#without_warnings' do
-    before :each do
-      @old_version = Airbadger::VERSION
-    end
-
-    let! :error_stream do
-      $stderr = StringIO.new
-    end
-    
-    it 'executes the block and does not emit warnings into the stderr stream' do
-      without_warnings do
-        Airbadger::VERSION = 42
-      end
-
-      Airbadger::VERSION.should eq 42
-      error_stream.string.should be_empty
-    end
-
-    it 'resumes emitting warnings into the stderr stream after the block' do
-      without_warnings do
-        Airbadger::VERSION = 42
-      end
-
-      Airbadger::VERSION = 43
-
-      error_stream.string.should_not be_empty
-    end
-
-    after :each do
-      Airbadger::VERSION = @old_version
-      $stderr = STDERR
-    end
-  end
-end