air18n 0.4.5 → 0.4.6

data/lib/air18n/metrics.rb

@@ -2,10 +2,59 @@ module Air18n
   module Metrics
     TARGET_PRIORITY_PHRASE_TRANSLATION_PERCENT = 98
 
+    def self.time_to_first_translation
+      # First we get all phrases created in the last 28 days and one of their
+      # translations (leaving out verifications).
+      #
+      # Then we look at the difference between the phrase's created_at and the
+      # phrase translation's created_at and return the average per language
+
+      search_scope = Air18n::Phrase.still_used
+      search_scope = search_scope.select(
+        '`phrases`.`id`, `phrases`.`key`, `phrases`.`created_at`, ' +
+        '`phrase_translations`.`locale` AS latest_translation_locale, ' +
+        '`phrase_translations`.`user_id` AS latest_translation_user_id, ' +
+        '`phrase_translations`.`created_at` AS latest_translation_created_at'
+      )
+      search_scope = search_scope.where('`phrases`.`created_at` >= ?', 28.days.ago)
+      search_scope = search_scope.pull_in_all_historic_phrase_translations
+      search_scope = search_scope.where('`phrase_translations`.`is_verification` = ?', false)
+      search_scope = search_scope.group('`phrases`.`id`, `phrase_translations`.`phrase_id`, `latest_translation_locale`')
+
+      phrases_and_translations = search_scope.all
+
+      progress = {}
+
+      locale_to_translations = phrases_and_translations.group_by do |phrase_and_translation|
+        phrase_and_translation.latest_translation_locale
+      end
+      locale_to_translations.each do |locale, phrases_and_translations_for_locale|
+        if locale.present?
+          locale = locale.to_sym
+          progress[locale] ||= {}
+          elapsed_times = []
+          phrases_and_translations_for_locale.each do |phrase_and_translation|
+            phrase_created_at = phrase_and_translation.created_at
+            translated_at = phrase_and_translation.latest_translation_created_at
+            if translated_at.is_a?(String)
+              translated_at = Time.parse(translated_at)
+            end
+            seconds_passed = (translated_at - phrase_created_at).to_i
+
+            elapsed_times << seconds_passed
+          end
+
+          progress[locale][:average_seconds_to_first_translation] = (elapsed_times.inject(:+).to_f / elapsed_times.size).round
+        end
+      end
+
+      progress
+    end
+
     def self.translation_progress(page_ids)
       search_scope = Air18n::Phrase.still_used
       search_scope = search_scope.select(
-        '`phrases`.`id`, `phrases`.`key`, ' +
+        '`phrases`.`id`, `phrases`.`key`, `phrases`.`created_at`, ' +
         '`phrase_translations`.`locale` AS latest_translation_locale, ' +
         '`phrase_translations`.`user_id` AS latest_translation_user_id, ' +
         '`phrase_translations`.`created_at` AS latest_translation_created_at, ' +
@@ -39,13 +88,19 @@ module Air18n
       priority_keys = phrases_and_translations.map { |phrase_and_translation| phrase_and_translation.key }.uniq
       number_of_priority_phrases = priority_keys.size
       number_of_priority_words = priority_keys.map { |k| word_counts[k] }.sum
-      locale_to_translations = phrases_and_translations.group_by { |phrase_and_translation| phrase_and_translation.latest_translation_locale }
+      locale_to_translations = phrases_and_translations.group_by do |phrase_and_translation|
+        phrase_and_translation.latest_translation_locale
+      end
       locale_to_translations.each do |locale, phrases_and_translations_for_locale|
         if locale.present?
           locale = locale.to_sym
           progress[locale] ||= {}
-          phrases_with_translations_for_locale = phrases_and_translations_for_locale.find_all { |phrase_and_translation| phrase_and_translation.latest_translation_user_id }
-          phrases_with_verifications_for_locale = phrases_with_translations_for_locale.find_all { |phrase_and_translation| true_value?(phrase_and_translation.latest_translation_is_verification) }
+          phrases_with_translations_for_locale = phrases_and_translations_for_locale.find_all do |phrase_and_translation|
+            phrase_and_translation.latest_translation_user_id
+          end
+          phrases_with_verifications_for_locale = phrases_with_translations_for_locale.find_all do |phrase_and_translation|
+            true_value?(phrase_and_translation.latest_translation_is_verification)
+          end
 
           words_with_translations_for_locale = phrases_with_translations_for_locale.map { |p| word_counts[p.key] }.sum
           words_with_verifications_for_locale = phrases_with_verifications_for_locale.map { |p| word_counts[p.key] }.sum
@@ -83,12 +138,19 @@ module Air18n
           progress[locale][:phrases_remaining_to_verify] = progress[locale][:phrases] - progress[locale][:phrases_verified]
           progress[locale][:words_remaining_to_verify] = progress[locale][:words] - progress[locale][:words_verified]
 
-          progress[locale][:translators] = phrases_with_translations_for_locale.inject(Set.new) do |carry, value|
-            if since?(value.latest_translation_created_at, 28.days.ago)
-              carry.add(value.latest_translation_user_id)
+          progress[locale][:translators] =
+            phrases_with_translations_for_locale.inject(Set.new) do |carry, value|
+              if since?(value.latest_translation_created_at, 28.days.ago)
+                carry.add(value.latest_translation_user_id)
+              end
+              carry
+            end
+          progress[locale][:number_of_nonautomatic_translators] =
+            if progress[locale][:translators].include?(0)
+              progress[locale][:translators].size - 1
+            else
+              progress[locale][:translators].size
             end
-            carry
-          end
         end
       end
 
@@ -156,7 +218,6 @@ module Air18n
         :words_translated_last_week => words_translated_last_week,
         :words_verified_last_month => words_verified_last_month,
         :words_verified_last_week => words_verified_last_week,
-        :words_verified_last_week => words_verified_last_week,
         :daily_average => daily_average,
         :number_of_later_modified_phrases_last_month => number_of_later_modified_phrases_last_month,
         :later_modified_percent => later_modified_percent
@@ -173,6 +234,13 @@ module Air18n
           info[:translator_progress][user_id] = translator_progress(locale, user_id)
         end
       end
+
+      t = time_to_first_translation()
+      t.each do |locale, info|
+        p[locale].merge!(info)
+      end
+
+      p
     end
 
     # Returns scope for searching for most recent PhraseTranslations of a

data/lib/air18n/phrase.rb

@@ -125,6 +125,10 @@ module Air18n
       "LEFT OUTER JOIN phrase_translations ON phrase_translations.phrase_id = phrases.id AND phrase_translations.is_latest = #{connection.quoted_true} AND phrase_translations.is_stale = #{connection.quoted_false}"
     ) }
 
+    scope :pull_in_all_historic_phrase_translations, lambda { joins(
+      "LEFT OUTER JOIN phrase_translations ON phrase_translations.phrase_id = phrases.id"
+    ) }
+
     # The still_used scope is wrapped in a lambda expression to
     # I18n.still_used_phrase_ids is reevaluated each time.
     # This makes dynamic updating possible and testing easier.

data/lib/air18n/version.rb

@@ -1,3 +1,3 @@
 module Air18n
-  VERSION = "0.4.5"
+  VERSION = "0.4.6"
 end

data/spec/lib/air18n/metrics_spec.rb

@@ -17,13 +17,17 @@ describe Air18n::Metrics do
 
     @translator1_ko_id = 15
 
-    @phrase1 = FactoryGirl.create(:phrase, :value => 'one two three four five six seven eight nine')
-    @phrase2 = FactoryGirl.create(:phrase)
-    @phrase3 = FactoryGirl.create(:phrase)
-    @phrase4 = FactoryGirl.create(:phrase)
-    @phrase5 = FactoryGirl.create(:phrase)
-    @phrase6 = FactoryGirl.create(:phrase)
-    @phrase7 = FactoryGirl.create(:phrase)
+    without_timestamping_of Air18n::Phrase do
+      @phrase1 = FactoryGirl.create(:phrase,
+                                    :value => 'one two three four five six seven eight nine',
+                                    :created_at => 3.days.ago)
+      @phrase2 = FactoryGirl.create(:phrase, :created_at => 1.year.ago)
+      @phrase3 = FactoryGirl.create(:phrase, :created_at => 1.year.ago)
+      @phrase4 = FactoryGirl.create(:phrase, :created_at => 1.year.ago)
+      @phrase5 = FactoryGirl.create(:phrase, :created_at => 1.year.ago)
+      @phrase6 = FactoryGirl.create(:phrase, :created_at => 1.year.ago)
+      @phrase7 = FactoryGirl.create(:phrase, :created_at => 1.year.ago)
+    end
 
     # info#press is a manually-prioritized page.
     @phrase3_screenshot1 = FactoryGirl.create(
@@ -197,7 +201,9 @@ describe Air18n::Metrics do
         :words_remaining_to_verify => 12,
 
         # translator2_fr doesn't appear because he hasn't last touched any phrase.
-        :translators => Set.new([@translator1_fr_id, @translator4_fr_id]) })
+        :translators => Set.new([@translator1_fr_id, @translator4_fr_id]),
+        :number_of_nonautomatic_translators => 2,
+      })
 
       ppp[:it].should include({
         :phrases => 5,
@@ -210,7 +216,8 @@ describe Air18n::Metrics do
         :words_translated_percent => 43,
         :phrases_progress => :bad,
         :phrases_remaining_to_translate => 4,
-        :words_remaining_to_translate => 12 })
+        :words_remaining_to_translate => 12,
+      })
       ppp[:ko].should include({
         :phrases => 5,
         :words => 21,
@@ -223,7 +230,8 @@ describe Air18n::Metrics do
         :phrases_progress => :bad,
         :phrases_remaining_to_translate => 4,
         :words_remaining_to_translate => 18,
-        :translators => Set.new([@translator1_ko_id]) })
+        :translators => Set.new([@translator1_ko_id]),
+      })
     end
   end
 
@@ -259,11 +267,21 @@ describe Air18n::Metrics do
     end
   end
 
+  context "#time_to_first_translation" do
+    it "should measure time to first translation" do
+      s = Air18n::Metrics.time_to_first_translation
+      s.size.should == 2
+      s[:it][:average_seconds_to_first_translation].should == 280800
+      s[:fr][:average_seconds_to_first_translation].should == 277200
+    end
+  end
+
   context "#metrics_suite" do
     it "should work" do
       s = Air18n::Metrics.metrics_suite
       s[:fr][:words_translated].should == 18
       s[:fr][:translator_progress].size.should == 2
+      s[:fr][:average_seconds_to_first_translation].should > 0
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: air18n
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.4.6
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-27 00:00:00.000000000 Z
+date: 2013-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n