air18n 0.1.11 → 0.1.12

data/lib/air18n/phrase.rb

@@ -1,9 +1,11 @@
 module Air18n
   class Phrase < ActiveRecord::Base
     has_many :phrase_translations, :dependent=>:delete_all
+    has_many :phrase_revisions, :foreign_key => 'key', :primary_key => 'key', :dependent=>:delete_all
     has_many :phrase_screenshots, :foreign_key => 'phrase_key', :primary_key => 'key', :dependent=>:delete_all
 
     after_update :mark_translations_stale
+    after_update :record_phrase_revision
 
     validates_uniqueness_of :key
 
@@ -18,6 +20,17 @@ module Air18n
       end
     end
 
+    def record_phrase_revision
+      value_hash = compute_value_hash
+      LoggingHelper.info "record phrase revision"
+      PhraseRevision.find_or_create_by_key_and_value_hash_and_value(key, value_hash, value)
+    end
+
+    def compute_value_hash
+      Digest::MD5.new.update(value).to_s
+    end
+
+    # TODO(jkb) retire this method, it is very old and ugly.
     def self.by_key lookup
       if !@by_key then
         @by_key = {}
@@ -88,5 +101,9 @@ module Air18n
     def is_rich_text?
       !!(self.value && Phrase.is_rich?(self.value))
     end
+
+    def revisions_in_order
+      phrase_revisions.order('phrase_revisions.created_at ASC')
+    end
   end
 end

data/lib/air18n/phrase_revision.rb

@@ -0,0 +1,9 @@
+module Air18n
+  class PhraseRevision < ActiveRecord::Base
+    belongs_to :phrase
+
+    def self.value_from_hash(phrase_key, hash)
+      find_by_key_and_value_hash(phrase_key, hash).value
+    end
+  end
+end

data/lib/air18n/phrase_translation.rb

@@ -37,7 +37,7 @@ module Air18n
     # Sets the source_word_count and source_hash fields.
     def set_source_hash
       self.source_word_count = PhraseTranslation.segment(phrase.value).size
-      self.source_hash = Digest::MD5.new.update(phrase.value).to_s
+      self.source_hash = phrase.compute_value_hash
     end
 
     # Provides a complete set of latest translations for specified locales, in nested hash format.

data/lib/air18n/reflection.rb

@@ -1,4 +1,5 @@
 require 'air18n/phrase'
+require 'air18n/phrase_revision'
 require 'air18n/phrase_screenshot'
 require 'air18n/phrase_translation'
 require 'air18n/screenshot'

data/lib/air18n/version.rb

@@ -1,3 +1,3 @@
 module Air18n
-  VERSION = "0.1.11"
+  VERSION = "0.1.12"
 end

data/lib/generators/air18n/migration/templates/active_record/migration.rb

@@ -1,5 +1,15 @@
 class Air18nMigration < ActiveRecord::Migration
   def self.up
+    create_table "phrase_revisions", :force => true do |t|
+      t.string   "key"
+      t.text     "value"
+      t.string   "value_hash"
+      t.datetime "created_at"
+      t.datetime "updated_at"
+    end
+
+    add_index "phrase_revisions", ["key", "value_hash"], :name => "index_phrase_revisions_on_key_and_value_hash"
+
     create_table "phrase_screenshots", :force => true do |t|
       t.string   "screenshot_url"
       t.datetime "created_at"

data/spec/lib/air18n/phrase_spec.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Air18n::Phrase do
+  context 'revisions' do
+    it "should keep track of its revisions" do
+      phrase = FactoryGirl.create(:phrase, :key => 'revisions key')
+      phrase.value = "new value"
+      phrase.save!
+      phrase.phrase_revisions.size.should == 1
+      phrase.phrase_revisions.first.value_hash.should == "14979451a8c46ae1691eb3aedab3359d"
+
+      phrase.value = "second value"
+      phrase.save!
+      revisions = phrase.revisions_in_order
+      revisions.map(&:value_hash).should == ["14979451a8c46ae1691eb3aedab3359d", "5d10ab09a3cd6e0227c2c79fd8e525b7"]
+
+      phrase.value = "new value"
+      phrase.save!
+      revisions = phrase.revisions_in_order
+      revisions.map(&:value_hash).should == ["14979451a8c46ae1691eb3aedab3359d", "5d10ab09a3cd6e0227c2c79fd8e525b7"]
+      Air18n::PhraseRevision.value_from_hash('revisions key', "14979451a8c46ae1691eb3aedab3359d").should == "new value"
+      Air18n::PhraseRevision.value_from_hash('revisions key', "5d10ab09a3cd6e0227c2c79fd8e525b7").should == "second value"
+    end
+  end
+end

data/spec/lib/air18n/phrase_translation_spec.rb

@@ -26,9 +26,10 @@ describe Air18n::PhraseTranslation do
 
   context 'source hash' do
     it "PhraseTranslation Should get unset when a new translation is made" do
-      original_translation = FactoryGirl.create(:phrase_translation)
-      original_translation.source_word_count.should == 3
-      original_translation.source_hash.should == "e2c1628507c9d0dfd6469a9196370b84"
+      phrase = FactoryGirl.create(:phrase, :key => 'source hash phrase key', :value => 'source hash phrase value')
+      original_translation = FactoryGirl.create(:phrase_translation, :phrase => phrase)
+      original_translation.source_word_count.should == 4
+      original_translation.source_hash.should == "b60188f9fd5c5b5e63a412501bd464a2"
     end
   end
 

data/spec/spec_helper.rb

@@ -24,6 +24,8 @@ require "active_record"
 db_name = ENV['DB'] || 'sqlite3'
 database_yml = File.expand_path('../database.yml', __FILE__)
 
+ActiveRecord::Base.logger = Logger.new(File.join(File.dirname(__FILE__), "debug.log"))
+
 if File.exists?(database_yml)
   active_record_configuration = YAML.load_file(database_yml)
 
@@ -33,7 +35,6 @@ if File.exists?(database_yml)
   ActiveRecord::Base.establish_connection(db_name)
   ActiveRecord::Base.connection
 
-  ActiveRecord::Base.logger = Logger.new(File.join(File.dirname(__FILE__), "debug.log"))
   ActiveRecord::Base.default_timezone = :utc
 
   ActiveRecord::Base.silence do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: air18n
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 0.1.12
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-18 00:00:00.000000000 Z
+date: 2012-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -153,6 +153,7 @@ files:
 - lib/air18n/logging_helper.rb
 - lib/air18n/mock_priority.rb
 - lib/air18n/phrase.rb
+- lib/air18n/phrase_revision.rb
 - lib/air18n/phrase_screenshot.rb
 - lib/air18n/phrase_translation.rb
 - lib/air18n/prim_and_proper.rb
@@ -173,6 +174,7 @@ files:
 - spec/factories.rb
 - spec/lib/air18n/air18n_spec.rb
 - spec/lib/air18n/backend_spec.rb
+- spec/lib/air18n/phrase_spec.rb
 - spec/lib/air18n/phrase_translation_spec.rb
 - spec/lib/air18n/prim_and_proper_spec.rb
 - spec/lib/air18n/pseudo_locales_spec.rb
@@ -207,6 +209,7 @@ test_files:
 - spec/factories.rb
 - spec/lib/air18n/air18n_spec.rb
 - spec/lib/air18n/backend_spec.rb
+- spec/lib/air18n/phrase_spec.rb
 - spec/lib/air18n/phrase_translation_spec.rb
 - spec/lib/air18n/prim_and_proper_spec.rb
 - spec/lib/air18n/pseudo_locales_spec.rb